From 4d4a6356e8e1a6ac0b177cb6bd398148030cb320 Mon Sep 17 00:00:00 2001 From: "darin@chromium.org" <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Tue, 5 May 2009 06:11:00 +0000 Subject: Re-do r15244: Fix crash in ~TestWebViewDelegate caused by shell_ being null. Moved the RevokeDragDrop call to the TestShell destructor instead. Eliminate webkit/glue/webhistoryitem* in favor of adding a NavigateBackForwardSoon method WebViewDelegate. This moves all of the hacky details of how we intercept "history.{back, forward,go}" into the webkit layer. My eventual plan is to teach WebCore how to make this not hacky. BUG=11423 R=mpcomplete Review URL: http://codereview.chromium.org/108004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15278 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/glue/webhistoryitem.h | 39 --------------------------------------- 1 file changed, 39 deletions(-) delete mode 100644 webkit/glue/webhistoryitem.h (limited to 'webkit/glue/webhistoryitem.h') diff --git a/webkit/glue/webhistoryitem.h b/webkit/glue/webhistoryitem.h deleted file mode 100644 index 6757211..0000000 --- a/webkit/glue/webhistoryitem.h +++ /dev/null @@ -1,39 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef WEBKIT_GLUE_WEBHISTORYITEM_H_ -#define WEBKIT_GLUE_WEBHISTORYITEM_H_ - -#include "webkit/glue/weburlrequest.h" // for WebRequest::ExtraData - -class GURL; - -class WebHistoryItem : public base::RefCounted<WebHistoryItem> { - public: - // Create a new history item. - static WebHistoryItem* Create(const GURL& url, - const std::wstring& title, - const std::string& history_state, - WebRequest::ExtraData* extra_data); - - WebHistoryItem() { } - virtual ~WebHistoryItem() { } - - // Returns the URL. - virtual const GURL& GetURL() const = 0; - - // Returns the title. - virtual const std::wstring& GetTitle() const = 0; - - // Returns the string representation of the history state for this entry. - virtual const std::string& GetHistoryState() const = 0; - - // Returns any ExtraData associated with this history entry. - virtual WebRequest::ExtraData* GetExtraData() const = 0; - - private: - DISALLOW_EVIL_CONSTRUCTORS(WebHistoryItem); -}; - -#endif // #ifndef WEBKIT_GLUE_WEBHISTORYITEM_H_ -- cgit v1.1