From 1647ac8f2c5de0809eb4e78f1902fba19dbb7c53 Mon Sep 17 00:00:00 2001 From: "brettw@chromium.org" Date: Sun, 27 Feb 2011 20:33:02 +0000 Subject: Don't use crashed plugins when instantiating new ones. Before, when a plugin crashed and was still referenced by a plugin in the same renderer, it would try to re-use the crashed one, which obviously doesn't work very well. This change removes crashed plugins from the renderer's list. TEST=Manual: instantiate two tabs sharing the same renderer using a plugin, kill the plugin, then reload one of the tabs. BUG=none Review URL: http://codereview.chromium.org/6594036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76194 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/plugins/ppapi/plugin_delegate.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'webkit/plugins/ppapi/plugin_delegate.h') diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h index 72d5c9b..3aead21 100644 --- a/webkit/plugins/ppapi/plugin_delegate.h +++ b/webkit/plugins/ppapi/plugin_delegate.h @@ -85,10 +85,12 @@ class PluginDelegate { // have PluginDelegates). class ModuleLifetime { public: - // Notification that the given plugin object has been deleted. This is - // called from the module's destructor, so you should not dereference the - // given pointer. - virtual void PluginModuleDestroyed(PluginModule* destroyed_module) = 0; + // Notification that the given plugin object is no longer usable. It either + // indicates the module was deleted, or that it has crashed. + // + // This can be called from the module's destructor, so you should not + // dereference the given pointer. + virtual void PluginModuleDead(PluginModule* dead_module) = 0; }; // This class is implemented by the PluginDelegate implementation and is -- cgit v1.1