From 5c84b70992f1510c1fb5b15932c7e21e43e95574 Mon Sep 17 00:00:00 2001 From: "ojan@chromium.org" Date: Thu, 15 Oct 2009 23:10:08 +0000 Subject: Fix removing of entries in the JSON that pass all runs and have a max (floored) run time below MIN_TIME (1 second). In the last patch I tested that tests with all passes and run time above MIN_TIME didn't get stripped. Now I've confirmed both directions work. The problem is that the "key" argument to max is a python 2.5 feature that was failing silently because it considered it as an optional second argument. Review URL: http://codereview.chromium.org/271110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29205 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/tools/layout_tests/layout_package/json_results_generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'webkit/tools/layout_tests/layout_package') diff --git a/webkit/tools/layout_tests/layout_package/json_results_generator.py b/webkit/tools/layout_tests/layout_package/json_results_generator.py index 5cd0c95..e88957f 100644 --- a/webkit/tools/layout_tests/layout_package/json_results_generator.py +++ b/webkit/tools/layout_tests/layout_package/json_results_generator.py @@ -414,7 +414,7 @@ class JSONResultsGenerator: is_all_pass = self._IsResultsAllOfType(test[self.RESULTS], self.PASS_RESULT) is_all_no_data = self._IsResultsAllOfType(test[self.RESULTS], self.NO_DATA_RESULT) - max_time = max(test[self.TIMES], lambda x, y : cmp(x[1], y[1])) + max_time = max([time[1] for time in test[self.TIMES]]) # Remove all passes/no-data from the results to reduce noise and filesize. # If a test passes every run, but takes > MIN_TIME to run, don't throw away -- cgit v1.1