From 219d310caa54c41347ae5cf923aec8b768e0638f Mon Sep 17 00:00:00 2001 From: "mbelshe@google.com" Date: Fri, 6 Mar 2009 17:25:56 +0000 Subject: Rename "ReadOnly" attribute to "v8ReadOnly". Although this attribute is fairly self-describing, it is difficult to look at IDL and know what is V8 specific. Since this is something that we added, having it marked as such greatly helps when reviewing. Also rename: v8OnInstance -> V8OnInstance v8DisallowShadowing -> V8DisallowShadowing v8DoNotCheckSignature -> V8DoNotCheckSignature Review URL: http://codereview.chromium.org/39263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11123 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/port/bindings/scripts/CodeGeneratorV8.pm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'webkit') diff --git a/webkit/port/bindings/scripts/CodeGeneratorV8.pm b/webkit/port/bindings/scripts/CodeGeneratorV8.pm index fcaf6bd..8701a1f 100644 --- a/webkit/port/bindings/scripts/CodeGeneratorV8.pm +++ b/webkit/port/bindings/scripts/CodeGeneratorV8.pm @@ -372,7 +372,7 @@ sub GenerateDomainSafeFunctionGetter my $funcName = $function->signature->name; my $signature = "v8::Signature::New(" . $className . "::GetRawTemplate())"; - if ($function->signature->extendedAttributes->{"v8DoNotCheckSignature"}) { + if ($function->signature->extendedAttributes->{"V8DoNotCheckSignature"}) { $signature = "v8::Local()"; } @@ -511,7 +511,7 @@ END END } - } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"v8DisallowShadowing"}) { + } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"V8DisallowShadowing"}) { # perform lookup first push(@implContentDecls, < holder = V8Proxy::LookupDOMWrapper(V8ClassIndex::$classIndex, info.This()); @@ -901,7 +901,7 @@ sub GenerateBatchedAttributeData $accessControl .= "|v8::ALL_CAN_WRITE"; } } - if ($attrExt->{"v8DisallowShadowing"}) { + if ($attrExt->{"V8DisallowShadowing"}) { $accessControl .= "|v8::PROHIBITS_OVERWRITING"; } $accessControl = "static_cast(" . $accessControl . ")"; @@ -928,7 +928,7 @@ sub GenerateBatchedAttributeData if ($attrExt->{"DontEnum"}) { $propAttr .= "|v8::DontEnum"; } - if ($attrExt->{"v8DisallowShadowing"}) { + if ($attrExt->{"V8DisallowShadowing"}) { $propAttr .= "|v8::DontDelete"; } @@ -1146,7 +1146,7 @@ sub GenerateImplementation my @normal; if ($interfaceName eq "DOMWindow") { foreach my $attribute (@$attributes) { - if ($attribute->signature->extendedAttributes->{"v8DisallowShadowing"}) { + if ($attribute->signature->extendedAttributes->{"V8DisallowShadowing"}) { push(@disallows_shadowing, $attribute); } else { push(@normal, $attribute); @@ -1237,14 +1237,14 @@ END if ($attrExt->{"DontEnum"}) { $property_attributes .= "|v8::DontEnum"; } - if ($attrExt->{"ReadOnly"}) { + if ($attrExt->{"V8ReadOnly"}) { $property_attributes .= "|v8::ReadOnly"; } my $commentInfo = "Function '$name' (ExtAttr: '" . join(' ', keys(%{$attrExt})) . "')"; my $template = "proto"; - if ($attrExt->{"v8OnInstance"}) { + if ($attrExt->{"V8OnInstance"}) { $template = "instance"; } @@ -1280,7 +1280,7 @@ END } my $signature = "default_signature"; - if ($attrExt->{"v8DoNotCheckSignature"}){ + if ($attrExt->{"V8DoNotCheckSignature"}){ $signature = "v8::Local()"; } -- cgit v1.1