From bd635c097dfc689674d6b21c006850a7b07f23f4 Mon Sep 17 00:00:00 2001 From: "mbelshe@chromium.org" Date: Tue, 25 May 2010 20:21:16 +0000 Subject: Enable warning 4389 as an error on windows builds. This will make windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/default_plugin/plugin_database_handler.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'webkit') diff --git a/webkit/default_plugin/plugin_database_handler.cc b/webkit/default_plugin/plugin_database_handler.cc index d35fdb1..3aeff63 100644 --- a/webkit/default_plugin/plugin_database_handler.cc +++ b/webkit/default_plugin/plugin_database_handler.cc @@ -144,13 +144,13 @@ int32 PluginDatabaseHandler::Write(NPStream* stream, int32 offset, } } - unsigned long bytes_written = 0; + DWORD bytes_written = 0; if (0 == lstrcmpiA(stream->url, plugin_finder_url_.c_str())) { DCHECK(plugin_downloads_file_ != INVALID_HANDLE_VALUE); WriteFile(plugin_downloads_file_, buffer, buffer_length, &bytes_written, NULL); - DCHECK(buffer_length == bytes_written); + DCHECK_EQ(buffer_length, static_cast(bytes_written)); } return bytes_written; } -- cgit v1.1