From cd7ef4f027ae36e80e368f967d1b98e1a3e3bde8 Mon Sep 17 00:00:00 2001 From: "tc@google.com" Date: Wed, 3 Dec 2008 00:28:01 +0000 Subject: Merge the windows and linux test lists. We have the test script look for the test lists in the platform specific dir. If it doesn't find it, it falls back to the file in layout_tests/test_lists. Mac still has its own test list. Review URL: http://codereview.chromium.org/12886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6257 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/tools/layout_tests/run_webkit_tests.py | 8 + .../test_lists/linux/tests_fixable.txt | 1507 -------------------- .../test_lists/linux/tests_ignored.txt | 186 --- .../layout_tests/test_lists/tests_fixable.txt | 1506 +++++++++++++++++++ .../layout_tests/test_lists/tests_ignored.txt | 186 +++ .../layout_tests/test_lists/win/tests_fixable.txt | 1174 --------------- .../layout_tests/test_lists/win/tests_ignored.txt | 186 --- 7 files changed, 1700 insertions(+), 3053 deletions(-) delete mode 100644 webkit/tools/layout_tests/test_lists/linux/tests_fixable.txt delete mode 100644 webkit/tools/layout_tests/test_lists/linux/tests_ignored.txt create mode 100644 webkit/tools/layout_tests/test_lists/tests_fixable.txt create mode 100644 webkit/tools/layout_tests/test_lists/tests_ignored.txt delete mode 100644 webkit/tools/layout_tests/test_lists/win/tests_fixable.txt delete mode 100644 webkit/tools/layout_tests/test_lists/win/tests_ignored.txt (limited to 'webkit') diff --git a/webkit/tools/layout_tests/run_webkit_tests.py b/webkit/tools/layout_tests/run_webkit_tests.py index 28f4020..83c6d3c 100755 --- a/webkit/tools/layout_tests/run_webkit_tests.py +++ b/webkit/tools/layout_tests/run_webkit_tests.py @@ -129,9 +129,17 @@ class TestRunner: # to sort it. So we save it to add back to the list later. saved_test_files = self._test_files + # We first check the platform specific sub directory for the test lists. + # If the platform specific sub dir doesn't exist, we fall back to the + # TEST_FILE_DIR directory. Once we're all using the same test list, we + # can remove this fallback. file_dir = os.path.join(os.path.dirname(sys.argv[0]), TEST_FILE_DIR) file_dir = os.path.join(file_dir, path_utils.TestListPlatformDir()) file_dir = path_utils.GetAbsolutePath(file_dir) + if not os.path.exists(os.path.join(file_dir, + test_expectations.TestExpectations.FIXABLE)): + file_dir = os.path.join(os.path.dirname(sys.argv[0]), TEST_FILE_DIR) + file_dir = path_utils.GetAbsolutePath(file_dir) is_debug_mode = self._options.target == 'Debug' expectations = test_expectations.TestExpectations(self._test_files, diff --git a/webkit/tools/layout_tests/test_lists/linux/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/linux/tests_fixable.txt deleted file mode 100644 index e261725..0000000 --- a/webkit/tools/layout_tests/test_lists/linux/tests_fixable.txt +++ /dev/null @@ -1,1507 +0,0 @@ -// These tests are expected to fail until we get around to fixing -// them. - -// Bug 1124548: Copying with no selection is sometimes supposed to work -// Also skipped by Apple on Windows (rdar://problem/5015941) -LayoutTests/editing/execCommand/copy-without-selection.html = FAIL - -// onload race condition due to poorly designed test. -// Works fine when run stand-alone. Not needed for Beta. -// Also skipped by Apple on Windows, due to intermittent failure -// (rdar://5313536) -LayoutTests/fast/dom/frame-loading-via-document-write.html = FAIL - -// Bug 877986. -// WebKit's CSS counters are somewhat broken, thus expected results are failures -// Our high-precision timers make these tests flakey. -// We could fork these tests, but we'll just unfork them as soon as -// our high-precision timers are public. -LayoutTests/css2.1/t1204-increment-00-c-o.html = FAIL -LayoutTests/css2.1/t1204-increment-01-c-o.html = FAIL -LayoutTests/css2.1/t1204-increment-02-c-o.html = FAIL -LayoutTests/css2.1/t1204-reset-00-c-o.html = FAIL -LayoutTests/css2.1/t1204-reset-01-c-o.html = FAIL - -// This are failing for different reasons under our new lighttpd configuration -// TODO(deanm): Address all of these via lighttpd if possible, otherwise fork. -// Maybe flaky and need to be forked? Bug 1234761. - -// Difference in caching headers -LayoutTests/http/tests/xmlhttprequest/cache-override.html = FAIL -// LightTPD doesn't accept unknown HTTP methods -LayoutTests/http/tests/xmlhttprequest/methods-lower-case.html = TIMEOUT -LayoutTests/http/tests/xmlhttprequest/methods-async.html = TIMEOUT -// LightTPD doesn't accept unknown HTTP methods and passes CGIs a Content-Type -// even when a request didn't send the header. -LayoutTests/http/tests/xmlhttprequest/methods.html = FAIL -// http://crbug.com/2975 : Need to support upload progress notifications in -// the resource bridge. -LayoutTests/http/tests/xmlhttprequest/upload-onload-event.html = FAIL -LayoutTests/http/tests/xmlhttprequest/upload-onprogress-event.html = FAIL -LayoutTests/http/tests/xmlhttprequest/upload-progress-events.html = FAIL - -// ----------------------------------------------------------------- -// TEXT -// ----------------------------------------------------------------- - -// This class of test fails because of size differences in text runs. -// Mostly this is because of international text rendering differences. - -// Bug 1316221: fail now that we use the same font code path in test_shell -// as in Chrome -LayoutTests/css2.1/t1202-counter-04-b.html = FAIL -LayoutTests/css2.1/t1202-counters-04-b.html = FAIL - -// Bug 1124513: the max length is being applied correctly, but the over- and -// under-lines aren't placed properly over the "x". -// The under-lines are a cosmetic error which is not necessary to fix for Beta. (eseidel) -LayoutTests/fast/forms/input-text-maxlength.html = FAIL -LayoutTests/fast/forms/input-text-paste-maxlength.html = FAIL - -// Font differences, requiring overriden metrics, not a real bug, not fixing for Beta -LayoutTests/fast/text/international/bidi-AN-after-L.html = FAIL - -// Bug: 1145880 -// Parethesis missing, metrics wrong. -LayoutTests/fast/text/international/bidi-neutral-run.html = FAIL - -// Bug: 628529: complex text effects -// This is a real bug, but not one we're fixing for Beta. -LayoutTests/fast/text/stroking-decorations.html = FAIL -LayoutTests/fast/text/stroking.html = FAIL - -// Bug: 1124522 -// Incrorect results, in incorrect international font metrics. -// Fixing these overrides does not help us to Beta, deffering -LayoutTests/fast/text/atsui-multiple-renderers.html = FAIL -LayoutTests/fast/text/atsui-pointtooffset-calls-cg.html = FAIL - -// Bug: 1143381 -// This test checks that we hack around a bug in helvetica. We fail to. -LayoutTests/fast/text/wide-zero-width-space.html = FAIL - -// Font-size differences in international text cause the wrong character -// to be under the (x,y) click location used by the test. See bug 850411 -// on faking international font sizes like we do for Latin fonts. -LayoutTests/fast/text/atsui-rtl-override-selection.html = FAIL - -// Bug: 1124542 -// More missing international text overides, not needed for Beta. -// Capitalization results match Safari, even if "not fully correct" -LayoutTests/fast/text/capitalize-boundaries.html = FAIL - -// Bug: 1145887 -// Different button line-heights, our behavior looks wrong. -LayoutTests/fast/forms/control-restrict-line-height.html = FAIL -LayoutTests/fast/replaced/table-percent-height.html = FAIL - -// Bug 992930: Unable to load file:/// URLs from data: URLs. -LayoutTests/fast/events/standalone-image-drag-to-editable.html = FAIL - -// Bug 1187672. Two font faces should be identical but aren't. Punting SVG. -LayoutTests/svg/custom/font-face-simple.svg = FAIL - -// ----------------------------------------------------------------- -// URL -// ----------------------------------------------------------------- - -// http://b/1089231: Form submission (GET) on non-standard url does not append a query. -// Defering these tests as the expected behavior is wonky, and shouldn't affect -// existing apps one way or another. - -// Implicit expectation in this test is that you can "set query" on a data URL, -// and it should replace the first "?" substring. This makes absolutely no sense. -LayoutTests/fast/events/stopPropagation-submit.html = FAIL - -// Expected results has a terminal "?", since "set query" on about:blank is allowed. -// This is strange since query should have no meaning in non-standard urls -LayoutTests/http/tests/navigation/onload-navigation-iframe-timeout.html = FAIL -LayoutTests/http/tests/navigation/onload-navigation-iframe.html = FAIL - -// ----------------------------------------------------------------- -// PENDING TESTS (forked to pending/, need to be sent upstream) -// ----------------------------------------------------------------- - -// Bug 972450: These tests don't work with fast timers due to setTimeout -// races. Pending versions have these fixed. -LayoutTests/fast/repaint/bugzilla-6473.html = FAIL - -// Bug 982608: test had a wrong result for one condition -LayoutTests/plugins/destroy-stream-twice.html = FAIL TIMEOUT - -// Bug 1143337. Forked to pending/http/tests/security/. -LayoutTests/http/tests/security/cross-frame-access-child-explicit-domain.html = FAIL -LayoutTests/http/tests/security/cross-frame-access-parent-explicit-domain.html = FAIL -LayoutTests/http/tests/security/cross-frame-access-protocol-explicit-domain.html = FAIL -LayoutTests/http/tests/security/cross-frame-access-protocol.html = FAIL - -// Bug 1064038. Image with border="1" drawn without the border. -LayoutTests/fast/forms/image-border.html = FAIL - -// Bug 1055396. Vertical scrollbar created when there is no overflow. -LayoutTests/fast/forms/textarea-scrollbar-height.html = FAIL - -// ----------------------------------------------------------------- -// Other -// ----------------------------------------------------------------- - -// Bug 865472, this should just need proper pixel test rebaselining. -// Also skipped by Apple on Windows (rdar://5723191). -LayoutTests/http/tests/navigation/javascriptlink-frames.html = FAIL - -// Bug: 1143492 -// Window status should always return a string object -// WebKit does this to match IE, FF also fails this test. -LayoutTests/fast/dom/assign-to-window-status.html = FAIL - -// Bug 905894 -// Getting parseerror (probably wrong svn:eol-style) -// Will be fixed by upstream merge -LayoutTests/fast/xsl/xslt-enc16.xml = FAIL -LayoutTests/fast/xsl/xslt-enc16to16.xml = FAIL - -// Bug: 742182, 845388 -// Mac Safari under certain circumstances automatically places -// a caret in editable document even when none was requested programatically. -// We don't intend to copy this feature (at least not for Beta). -LayoutTests/editing/selection/designmode-no-caret.html = FAIL - -// Bug: 742182, 845388, 960092 -// Platform-specific: simulates command-{arrow} input to modify selection -// Our Event-Sender isn't robust enough to support this. -// Not required for Beta. This may also be related to known home/end issues -// which are intended to be fixed for Beta. -LayoutTests/editing/selection/move-begin-end.html = FAIL - -// Bug 845400 -// The end result looks right, but the event messages differ. -LayoutTests/editing/pasteboard/paste-xml.xhtml = FAIL - -// Bug 849441 -// Directionality of mixed-direction text in selected choice should -// match that in the option lists. +// Low priority, unclear if test expectations are correct (see bug) +LayoutTests/fast/forms/select-writing-direction-natural.html = FAIL +LayoutTests/fast/text/international/bidi-menulist.html = FAIL + +// Bug 850875 +// requires support for layoutTestController.encodeHostName() +LayoutTests/fast/encoding/idn-security.html = FAIL + +// Bug 852346 +// These layout tests to see if link colors change after visiting a page. They +// does this by using layoutTestController.keepWebHistory() to turn on a +// temporary web history. layoutTestController.keepWebHistory() is not +// implemented in test shell. +// This is a test tool problem, not a Chrome problem. +LayoutTests/fast/history/clicked-link-is-visited.html = FAIL +LayoutTests/fast/history/subframe-is-visited.html = FAIL + +// Bug 1027226 +// Bug 945322: test shell should dump text when +// layoutTestController.notifyDone() is called +LayoutTests/editing/selection/drag-in-iframe.html = FAIL + +// Bug 849056 +// We don't support NPN_Enumerate, but don't know of any plugin +// which depends on that functionality. So we ignore this for beta. +LayoutTests/plugins/netscape-enumerate.html = FAIL + +// This tests the screen's pixel depth, which we don't set on the buildbots +// so it depends on the users settings. Making this a broken test for us. +// The test must be fixed to not depend on user settings and rebaselined. post-beta. +LayoutTests/fast/dom/Window/window-screen-properties.html = PASS FAIL + +// Bug: 849060 +// Plugin creation is delayed until after first layout, so +// setwindow isn't being called. +LayoutTests/plugins/netscape-plugin-setwindow-size.html = FAIL + +LayoutTests/http/tests/security/cross-frame-access-put.html = FAIL + +// Bug 982602 +// We don't support support window.resizeTo (nor is it planned for Beta) +LayoutTests/fast/dom/Window/window-resize-and-move-arguments.html = FAIL + +// Test expects that when focus is in an iframe and page-up is hit, the parent +// document is also scrolled +// IE and FF also "fail" this test. +LayoutTests/fast/frames/iframe-scroll-page-up-down.html = FAIL + +// Bug 1082426 +// document.write() pf plain text does not always flush +// This is a known WebKit bug, https://bugs.webkit.org/show_bug.cgi?id=8961 +LayoutTests/editing/execCommand/delete-no-scroll.html = FAIL + +// Bug: 879449 +// TODO(joshia): Need some changes to the test shell in order to support +// Java applet related unit tests. So disable the following for now. +// These tests should be fixed immediately after the Java applets work is done. +LayoutTests/fast/replaced/applet-disabled-positioned.html = FAIL +LayoutTests/fast/replaced/applet-rendering-java-disabled.html = FAIL + +// Bug 1198880 +LayoutTests/svg/custom/svgsvgelement-ctm.xhtml = FAIL + +// Bug 1204878 +LayoutTests/http/tests/navigation/post-goback1.html = FAIL + +// Bug 1135948: Fails because we cannot call plugins as functions. +LayoutTests/plugins/bindings-test.html = FAIL + +// Bug 871718: These tests load data: URLs into frames and sets queries on then. +// This is totally broken. This layout test should be rewitten so that the +// subframes are not data URLs (probably we want files in the resources dir.). +LayoutTests/fast/encoding/char-encoding.html = FAIL +LayoutTests/fast/encoding/char-decoding.html = FAIL + +// Bug 1130795: since we don't have Aqua-themed controls, don't ignore the +// box-shadow properties of controls that request Aqua theming. But since Aqua +// controls are rare on the web, defer this fix. +LayoutTests/fast/forms/box-shadow-override.html = FAIL + +// These tests are not valid: the so-called expected results are not known to +// be correct. See bug 849072. +// TODO(ojan): They are *our* tests. +// It seems silly to skip our own tests when we can change/delete them. +// I'm marking them as deferred for now, but we should do something with them. +SKIP : chrome/http/mime = PASS + +// Bug: 916857: These tests fail because of