From ce7dabcdd3528252e5a991f287cdcb2b3853b422 Mon Sep 17 00:00:00 2001 From: "chase@chromium.org" Date: Wed, 1 Sep 2010 18:37:54 +0000 Subject: Revert 58153 - Introduce a flag to bypass the cache when retrieving current memory usage. We need the most fresh value when giving an estimate to current working set, for example, after major GC in V8 happened. Review URL: http://codereview.chromium.org/3285003 TBR=antonm@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58206 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/glue/webkitclient_impl.cc | 5 ++--- webkit/glue/webkitclient_impl.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) (limited to 'webkit') diff --git a/webkit/glue/webkitclient_impl.cc b/webkit/glue/webkitclient_impl.cc index 5bfd43a5..70be0f3 100644 --- a/webkit/glue/webkitclient_impl.cc +++ b/webkit/glue/webkitclient_impl.cc @@ -424,11 +424,10 @@ static size_t memoryUsageMBGeneric() { } #endif -size_t WebKitClientImpl::memoryUsageMB(bool no_cache) { +size_t WebKitClientImpl::memoryUsageMB() { size_t current_mem_usage = 0; MemoryUsageCache* mem_usage_cache_singleton = MemoryUsageCache::Get(); - if (!no_cache - && mem_usage_cache_singleton->IsCachedValueValid(¤t_mem_usage)) + if (mem_usage_cache_singleton->IsCachedValueValid(¤t_mem_usage)) return current_mem_usage; current_mem_usage = diff --git a/webkit/glue/webkitclient_impl.h b/webkit/glue/webkitclient_impl.h index 2d446f4..8c0cfa3 100644 --- a/webkit/glue/webkitclient_impl.h +++ b/webkit/glue/webkitclient_impl.h @@ -34,7 +34,7 @@ class WebKitClientImpl : public WebKit::WebKitClient { virtual WebKit::WebString signedPublicKeyAndChallengeString( unsigned key_size_index, const WebKit::WebString& challenge, const WebKit::WebURL& url); - virtual size_t memoryUsageMB(bool no_cache = false); + virtual size_t memoryUsageMB(); virtual WebKit::WebURLLoader* createURLLoader(); virtual WebKit::WebSocketStreamHandle* createSocketStreamHandle(); virtual WebKit::WebString userAgent(const WebKit::WebURL& url); -- cgit v1.1