From de016ebcdfde1345a9463af1e50b7645f6909ffc Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Wed, 20 May 2009 04:14:21 +0000 Subject: Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was created for has long been closed. This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least). Review URL: http://codereview.chromium.org/115553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16462 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/glue/plugins/webplugin_delegate_impl.cc | 5 ----- webkit/tools/test_shell/webwidget_host_win.cc | 4 ---- 2 files changed, 9 deletions(-) (limited to 'webkit') diff --git a/webkit/glue/plugins/webplugin_delegate_impl.cc b/webkit/glue/plugins/webplugin_delegate_impl.cc index 2addf7f..2c41851 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl.cc +++ b/webkit/glue/plugins/webplugin_delegate_impl.cc @@ -13,7 +13,6 @@ #include "base/message_loop.h" #include "base/stats_counters.h" #include "base/string_util.h" -#include "base/win_util.h" #include "webkit/default_plugin/plugin_impl.h" #include "webkit/glue/glue_util.h" #include "webkit/glue/webplugin.h" @@ -205,7 +204,6 @@ WebPluginDelegateImpl::WebPluginDelegateImpl( WebPluginDelegateImpl::~WebPluginDelegateImpl() { if (::IsWindow(dummy_window_for_activation_)) { ::DestroyWindow(dummy_window_for_activation_); - TRACK_HWND_DESTRUCTION(dummy_window_for_activation_); } DestroyInstance(); @@ -460,7 +458,6 @@ bool WebPluginDelegateImpl::WindowedCreatePlugin() { 0, GetModuleHandle(NULL), 0); - TRACK_HWND_CREATION(windowed_handle_); if (windowed_handle_ == 0) return false; @@ -522,7 +519,6 @@ void WebPluginDelegateImpl::WindowedDestroyWindow() { plugin_->WillDestroyWindow(windowed_handle_); DestroyWindow(windowed_handle_); - TRACK_HWND_DESTRUCTION(windowed_handle_); windowed_handle_ = 0; } } @@ -675,7 +671,6 @@ bool WebPluginDelegateImpl::CreateDummyWindowForActivation() { 0, GetModuleHandle(NULL), 0); - TRACK_HWND_CREATION(dummy_window_for_activation_); if (dummy_window_for_activation_ == 0) return false; diff --git a/webkit/tools/test_shell/webwidget_host_win.cc b/webkit/tools/test_shell/webwidget_host_win.cc index 9deca4c..44fd523 100644 --- a/webkit/tools/test_shell/webwidget_host_win.cc +++ b/webkit/tools/test_shell/webwidget_host_win.cc @@ -50,7 +50,6 @@ WebWidgetHost* WebWidgetHost::Create(HWND parent_view, kWindowClassName, kWindowClassName, WS_POPUP, 0, 0, 0, 0, parent_view, NULL, GetModuleHandle(NULL), NULL); - TRACK_HWND_CREATION(host->view_); win_util::SetWindowUserData(host->view_, host); host->webwidget_ = WebWidget::Create(delegate); @@ -71,9 +70,6 @@ LRESULT CALLBACK WebWidgetHost::WndProc(HWND hwnd, UINT message, WPARAM wparam, case WM_DESTROY: delete host; break; - case WM_NCDESTROY: - TRACK_HWND_DESTRUCTION(hwnd); - break; case WM_PAINT: { RECT rect; -- cgit v1.1