From f2ebbf06167ad4ff8cb23109b3652c8c4b7ff5f7 Mon Sep 17 00:00:00 2001 From: "rsleevi@chromium.org" Date: Fri, 6 Apr 2012 03:14:30 +0000 Subject: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/9997007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131088 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/dom_storage/dom_storage_task_runner.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'webkit') diff --git a/webkit/dom_storage/dom_storage_task_runner.h b/webkit/dom_storage/dom_storage_task_runner.h index c7b5fd5..8cb0e79 100644 --- a/webkit/dom_storage/dom_storage_task_runner.h +++ b/webkit/dom_storage/dom_storage_task_runner.h @@ -55,6 +55,9 @@ class DomStorageTaskRunner : public base::TaskRunner { const tracked_objects::Location& from_here, const base::Closure& task, int64 delay_ms) OVERRIDE; + + protected: + virtual ~DomStorageTaskRunner() {} }; // A derived class used in chromium that utilizes a SequenceWorkerPool @@ -78,8 +81,10 @@ class DomStorageWorkerPoolTaskRunner : public DomStorageTaskRunner { SequenceID sequence_id, const base::Closure& task) OVERRIDE; - private: + protected: virtual ~DomStorageWorkerPoolTaskRunner(); + + private: const scoped_refptr message_loop_; const scoped_refptr sequenced_worker_pool_; base::SequencedWorkerPool::SequenceToken primary_sequence_token_; @@ -105,8 +110,10 @@ class MockDomStorageTaskRunner : public DomStorageTaskRunner { SequenceID sequence_id, const base::Closure& task) OVERRIDE; - private: + protected: virtual ~MockDomStorageTaskRunner(); + + private: const scoped_refptr message_loop_; }; -- cgit v1.1