From 56fb0ec2da13e47e65d1ef8e07dee1a9a37fde70 Mon Sep 17 00:00:00 2001 From: ananta Date: Tue, 12 May 2015 18:51:21 -0700 Subject: Send a Blur notification to the renderer if we receive a mouse exit for a window outside a popup. Blink maintains state for popups whether they are hidden shown etc. So when a popup is shown and an action causes the popup to be hidden then blink changes the state to hidden. If an action causes the popup to be closed on the browser without notifying blink that the popup is going away due to focus being lost on the parent view, then blink assumes that the popup is still visible. As a result clicking again on a select box would just hide the popup as blink thinks the popup is visible. This bug is only triggered in corner cases like ASH where you have one root window parenting everything else. On regular desktop environments clicking outside the browser window while the popup is open would cause activation changes to occur which would ensure that the Blur notification goes through to the browser. The other change is a simple fix in delegate_execute which caused it to crash in debug mode on a multi dll build. Crash occurred because we were looking for version information in base.dll while launching the crash server. BUG=482937 Review URL: https://codereview.chromium.org/1136143005 Cr-Commit-Position: refs/heads/master@{#329563} --- win8/delegate_execute/crash_server_init.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'win8') diff --git a/win8/delegate_execute/crash_server_init.cc b/win8/delegate_execute/crash_server_init.cc index 1272652..859874d 100644 --- a/win8/delegate_execute/crash_server_init.cc +++ b/win8/delegate_execute/crash_server_init.cc @@ -47,7 +47,7 @@ bool IsRunningSystemInstall() { google_breakpad::CustomClientInfo* GetCustomInfo() { scoped_ptr version_info( - FileVersionInfo::CreateFileVersionInfoForCurrentModule()); + FileVersionInfo::CreateFileVersionInfoForModule(NULL)); static google_breakpad::CustomInfoEntry ver_entry( L"ver", version_info->file_version().c_str()); -- cgit v1.1