From c62bb4ac21755405ec6b8eb9379b2b551478df26 Mon Sep 17 00:00:00 2001 From: gab Date: Wed, 2 Sep 2015 07:44:10 -0700 Subject: Make GetCommandExecuteImplClsid return the CLSID as a string directly. BUG=Unjustified single out-param. Review URL: https://codereview.chromium.org/1321143002 Cr-Commit-Position: refs/heads/master@{#346915} --- win8/delegate_execute/delegate_execute.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'win8') diff --git a/win8/delegate_execute/delegate_execute.cc b/win8/delegate_execute/delegate_execute.cc index a41fb5b..01e1fd4 100644 --- a/win8/delegate_execute/delegate_execute.cc +++ b/win8/delegate_execute/delegate_execute.cc @@ -46,10 +46,10 @@ class DelegateExecuteModule HRESULT PreMessageLoop(int nShowCmd) { HRESULT hr = S_OK; - base::string16 clsid_string; GUID clsid; BrowserDistribution* dist = BrowserDistribution::GetDistribution(); - if (!dist->GetCommandExecuteImplClsid(&clsid_string)) + const base::string16 clsid_string = dist->GetCommandExecuteImplClsid(); + if (clsid_string.empty()) return E_FAIL; hr = ::CLSIDFromString(clsid_string.c_str(), &clsid); if (FAILED(hr)) -- cgit v1.1