From e26e6d0a79391734160024bba2955353760c5020 Mon Sep 17 00:00:00 2001 From: brettw Date: Mon, 28 Dec 2015 22:51:47 -0800 Subject: Use .rc strings in fewer places for installer util. The resource strings are needed only for the setup app and unit tests. Previously they were also linked into Chrome. This clarifies the usage and renames the targets to force you to pick (previously the naming encouraged you to link to the strings, which is probably not correct for most cases. Review URL: https://codereview.chromium.org/1545803002 Cr-Commit-Position: refs/heads/master@{#367057} --- win8/delegate_execute/BUILD.gn | 2 +- win8/metro_driver/BUILD.gn | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'win8') diff --git a/win8/delegate_execute/BUILD.gn b/win8/delegate_execute/BUILD.gn index d21d73c..8309dc6 100644 --- a/win8/delegate_execute/BUILD.gn +++ b/win8/delegate_execute/BUILD.gn @@ -44,7 +44,7 @@ source_set("lib") { "//base", "//breakpad:breakpad_handler", "//chrome/common:constants", - "//chrome/installer/util:with_no_strings_some_things_wont_work", + "//chrome/installer/util:with_no_strings", "//ui/base", "//ui/gfx", "//ui/gfx/geometry", diff --git a/win8/metro_driver/BUILD.gn b/win8/metro_driver/BUILD.gn index 2cf2dd9..68c9a90 100644 --- a/win8/metro_driver/BUILD.gn +++ b/win8/metro_driver/BUILD.gn @@ -23,7 +23,7 @@ shared_library("metro_driver") { ":version_resources", "//base", "//chrome/common:constants", - "//chrome/installer/util:with_no_strings_some_things_wont_work", + "//chrome/installer/util:with_no_strings", "//crypto", "//ipc", "//sandbox", @@ -122,7 +122,7 @@ test("metro_driver_unittests") { deps = [ ":metro_driver", "//base", - "//chrome/installer/util", + "//chrome/installer/util:with_rc_strings", "//testing/gtest", ] } -- cgit v1.1