// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include #include "base/values.h" #include "base/scoped_ptr.h" #include "testing/gtest/include/gtest/gtest.h" class ValuesTest: public testing::Test { }; TEST(ValuesTest, Basic) { // Test basic dictionary getting/setting DictionaryValue settings; std::wstring homepage = L"http://google.com"; ASSERT_FALSE( settings.GetString(L"global.homepage", &homepage)); ASSERT_EQ(std::wstring(L"http://google.com"), homepage); ASSERT_FALSE(settings.Get(L"global", NULL)); settings.Set(L"global", Value::CreateBooleanValue(true)); ASSERT_TRUE(settings.Get(L"global", NULL)); settings.SetString(L"global.homepage", L"http://scurvy.com"); ASSERT_TRUE(settings.Get(L"global", NULL)); homepage = L"http://google.com"; ASSERT_TRUE(settings.GetString(L"global.homepage", &homepage)); ASSERT_EQ(std::wstring(L"http://scurvy.com"), homepage); // Test storing a dictionary in a list. ListValue* toolbar_bookmarks; ASSERT_FALSE( settings.GetList(L"global.toolbar.bookmarks", &toolbar_bookmarks)); toolbar_bookmarks = new ListValue; settings.Set(L"global.toolbar.bookmarks", toolbar_bookmarks); ASSERT_TRUE( settings.GetList(L"global.toolbar.bookmarks", &toolbar_bookmarks)); DictionaryValue* new_bookmark = new DictionaryValue; new_bookmark->SetString(L"name", L"Froogle"); new_bookmark->SetString(L"url", L"http://froogle.com"); toolbar_bookmarks->Append(new_bookmark); ListValue* bookmark_list; ASSERT_TRUE(settings.GetList(L"global.toolbar.bookmarks", &bookmark_list)); DictionaryValue* bookmark; ASSERT_EQ(1U, bookmark_list->GetSize()); ASSERT_TRUE(bookmark_list->GetDictionary(0, &bookmark)); std::wstring bookmark_name = L"Unnamed"; ASSERT_TRUE(bookmark->GetString(L"name", &bookmark_name)); ASSERT_EQ(std::wstring(L"Froogle"), bookmark_name); std::wstring bookmark_url; ASSERT_TRUE(bookmark->GetString(L"url", &bookmark_url)); ASSERT_EQ(std::wstring(L"http://froogle.com"), bookmark_url); } TEST(ValuesTest, List) { scoped_ptr mixed_list(new ListValue()); mixed_list->Set(0, Value::CreateBooleanValue(true)); mixed_list->Set(1, Value::CreateIntegerValue(42)); mixed_list->Set(2, Value::CreateRealValue(88.8)); mixed_list->Set(3, Value::CreateStringValue("foo")); ASSERT_EQ(4u, mixed_list->GetSize()); Value *value = NULL; bool bool_value = false; int int_value = 0; double double_value = 0.0; std::string string_value; ASSERT_FALSE(mixed_list->Get(4, &value)); ASSERT_FALSE(mixed_list->GetInteger(0, &int_value)); ASSERT_EQ(0, int_value); ASSERT_FALSE(mixed_list->GetReal(1, &double_value)); ASSERT_EQ(0.0, double_value); ASSERT_FALSE(mixed_list->GetString(2, &string_value)); ASSERT_EQ("", string_value); ASSERT_FALSE(mixed_list->GetBoolean(3, &bool_value)); ASSERT_EQ(false, bool_value); ASSERT_TRUE(mixed_list->GetBoolean(0, &bool_value)); ASSERT_EQ(true, bool_value); ASSERT_TRUE(mixed_list->GetInteger(1, &int_value)); ASSERT_EQ(42, int_value); ASSERT_TRUE(mixed_list->GetReal(2, &double_value)); ASSERT_EQ(88.8, double_value); ASSERT_TRUE(mixed_list->GetString(3, &string_value)); ASSERT_EQ("foo", string_value); } TEST(ValuesTest, BinaryValue) { char* buffer = NULL; // Passing a null buffer pointer doesn't yield a BinaryValue scoped_ptr binary(BinaryValue::Create(buffer, 0)); ASSERT_FALSE(binary.get()); // If you want to represent an empty binary value, use a zero-length buffer. buffer = new char[1]; ASSERT_TRUE(buffer); binary.reset(BinaryValue::Create(buffer, 0)); ASSERT_TRUE(binary.get()); ASSERT_TRUE(binary->GetBuffer()); ASSERT_EQ(buffer, binary->GetBuffer()); ASSERT_EQ(0U, binary->GetSize()); // Test the common case of a non-empty buffer buffer = new char[15]; binary.reset(BinaryValue::Create(buffer, 15)); ASSERT_TRUE(binary.get()); ASSERT_TRUE(binary->GetBuffer()); ASSERT_EQ(buffer, binary->GetBuffer()); ASSERT_EQ(15U, binary->GetSize()); char stack_buffer[42]; memset(stack_buffer, '!', 42); binary.reset(BinaryValue::CreateWithCopiedBuffer(stack_buffer, 42)); ASSERT_TRUE(binary.get()); ASSERT_TRUE(binary->GetBuffer()); ASSERT_NE(stack_buffer, binary->GetBuffer()); ASSERT_EQ(42U, binary->GetSize()); ASSERT_EQ(0, memcmp(stack_buffer, binary->GetBuffer(), binary->GetSize())); } TEST(ValuesTest, StringValue) { // Test overloaded CreateStringValue. scoped_ptr narrow_value(Value::CreateStringValue("narrow")); ASSERT_TRUE(narrow_value.get()); ASSERT_TRUE(narrow_value->IsType(Value::TYPE_STRING)); scoped_ptr wide_value(Value::CreateStringValue(L"wide")); ASSERT_TRUE(wide_value.get()); ASSERT_TRUE(wide_value->IsType(Value::TYPE_STRING)); // Test overloaded GetString. std::string narrow = "http://google.com"; std::wstring wide = L"http://google.com"; ASSERT_TRUE(narrow_value->GetAsString(&narrow)); ASSERT_TRUE(narrow_value->GetAsString(&wide)); ASSERT_EQ(std::string("narrow"), narrow); ASSERT_EQ(std::wstring(L"narrow"), wide); ASSERT_TRUE(wide_value->GetAsString(&narrow)); ASSERT_TRUE(wide_value->GetAsString(&wide)); ASSERT_EQ(std::string("wide"), narrow); ASSERT_EQ(std::wstring(L"wide"), wide); } // This is a Value object that allows us to tell if it's been // properly deleted by modifying the value of external flag on destruction. class DeletionTestValue : public Value { public: DeletionTestValue(bool* deletion_flag) : Value(TYPE_NULL) { Init(deletion_flag); // Separate function so that we can use ASSERT_* } void Init(bool* deletion_flag) { ASSERT_TRUE(deletion_flag); deletion_flag_ = deletion_flag; *deletion_flag_ = false; } ~DeletionTestValue() { *deletion_flag_ = true; } private: bool* deletion_flag_; }; TEST(ValuesTest, ListDeletion) { bool deletion_flag = true; { ListValue list; list.Append(new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); } EXPECT_TRUE(deletion_flag); { ListValue list; list.Append(new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); list.Clear(); EXPECT_TRUE(deletion_flag); } { ListValue list; list.Append(new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); EXPECT_TRUE(list.Set(0, Value::CreateNullValue())); EXPECT_TRUE(deletion_flag); } } TEST(ValuesTest, ListRemoval) { bool deletion_flag = true; Value* removed_item = NULL; { ListValue list; list.Append(new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); EXPECT_EQ(1U, list.GetSize()); EXPECT_FALSE(list.Remove(std::numeric_limits::max(), &removed_item)); EXPECT_FALSE(list.Remove(1, &removed_item)); EXPECT_TRUE(list.Remove(0, &removed_item)); ASSERT_TRUE(removed_item); EXPECT_EQ(0U, list.GetSize()); } EXPECT_FALSE(deletion_flag); delete removed_item; removed_item = NULL; EXPECT_TRUE(deletion_flag); { ListValue list; list.Append(new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); EXPECT_TRUE(list.Remove(0, NULL)); EXPECT_TRUE(deletion_flag); EXPECT_EQ(0U, list.GetSize()); } { ListValue list; DeletionTestValue* value = new DeletionTestValue(&deletion_flag); list.Append(value); EXPECT_FALSE(deletion_flag); EXPECT_EQ(0, list.Remove(*value)); EXPECT_TRUE(deletion_flag); EXPECT_EQ(0U, list.GetSize()); } } TEST(ValuesTest, DictionaryDeletion) { std::wstring key = L"test"; bool deletion_flag = true; { DictionaryValue dict; dict.Set(key, new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); } EXPECT_TRUE(deletion_flag); { DictionaryValue dict; dict.Set(key, new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); dict.Clear(); EXPECT_TRUE(deletion_flag); } { DictionaryValue dict; dict.Set(key, new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); dict.Set(key, Value::CreateNullValue()); EXPECT_TRUE(deletion_flag); } } TEST(ValuesTest, DictionaryRemoval) { std::wstring key = L"test"; bool deletion_flag = true; Value* removed_item = NULL; { DictionaryValue dict; dict.Set(key, new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); EXPECT_TRUE(dict.HasKey(key)); EXPECT_FALSE(dict.Remove(L"absent key", &removed_item)); EXPECT_TRUE(dict.Remove(key, &removed_item)); EXPECT_FALSE(dict.HasKey(key)); ASSERT_TRUE(removed_item); } EXPECT_FALSE(deletion_flag); delete removed_item; removed_item = NULL; EXPECT_TRUE(deletion_flag); { DictionaryValue dict; dict.Set(key, new DeletionTestValue(&deletion_flag)); EXPECT_FALSE(deletion_flag); EXPECT_TRUE(dict.HasKey(key)); EXPECT_TRUE(dict.Remove(key, NULL)); EXPECT_TRUE(deletion_flag); EXPECT_FALSE(dict.HasKey(key)); } } TEST(ValuesTest, DictionaryWithoutPathExpansion) { DictionaryValue dict; dict.Set(L"this.is.expanded", Value::CreateNullValue()); dict.SetWithoutPathExpansion(L"this.isnt.expanded", Value::CreateNullValue()); EXPECT_FALSE(dict.HasKey(L"this.is.expanded")); EXPECT_TRUE(dict.HasKey(L"this")); Value* value1; EXPECT_TRUE(dict.Get(L"this", &value1)); DictionaryValue* value2; ASSERT_TRUE(dict.GetDictionaryWithoutPathExpansion(L"this", &value2)); EXPECT_EQ(value1, value2); EXPECT_EQ(1U, value2->size()); EXPECT_TRUE(dict.HasKey(L"this.isnt.expanded")); Value* value3; EXPECT_FALSE(dict.Get(L"this.isnt.expanded", &value3)); Value* value4; ASSERT_TRUE(dict.GetWithoutPathExpansion(L"this.isnt.expanded", &value4)); EXPECT_EQ(Value::TYPE_NULL, value4->GetType()); } TEST(ValuesTest, DeepCopy) { DictionaryValue original_dict; Value* original_null = Value::CreateNullValue(); original_dict.Set(L"null", original_null); Value* original_bool = Value::CreateBooleanValue(true); original_dict.Set(L"bool", original_bool); Value* original_int = Value::CreateIntegerValue(42); original_dict.Set(L"int", original_int); Value* original_real = Value::CreateRealValue(3.14); original_dict.Set(L"real", original_real); Value* original_string = Value::CreateStringValue("hello"); original_dict.Set(L"string", original_string); Value* original_wstring = Value::CreateStringValue(L"peek-a-boo"); original_dict.Set(L"wstring", original_wstring); char* original_buffer = new char[42]; memset(original_buffer, '!', 42); BinaryValue* original_binary = Value::CreateBinaryValue(original_buffer, 42); original_dict.Set(L"binary", original_binary); ListValue* original_list = new ListValue(); Value* original_list_element_0 = Value::CreateIntegerValue(0); original_list->Append(original_list_element_0); Value* original_list_element_1 = Value::CreateIntegerValue(1); original_list->Append(original_list_element_1); original_dict.Set(L"list", original_list); scoped_ptr copy_dict( static_cast(original_dict.DeepCopy())); ASSERT_TRUE(copy_dict.get()); ASSERT_NE(copy_dict.get(), &original_dict); Value* copy_null = NULL; ASSERT_TRUE(copy_dict->Get(L"null", ©_null)); ASSERT_TRUE(copy_null); ASSERT_NE(copy_null, original_null); ASSERT_TRUE(copy_null->IsType(Value::TYPE_NULL)); Value* copy_bool = NULL; ASSERT_TRUE(copy_dict->Get(L"bool", ©_bool)); ASSERT_TRUE(copy_bool); ASSERT_NE(copy_bool, original_bool); ASSERT_TRUE(copy_bool->IsType(Value::TYPE_BOOLEAN)); bool copy_bool_value = false; ASSERT_TRUE(copy_bool->GetAsBoolean(©_bool_value)); ASSERT_TRUE(copy_bool_value); Value* copy_int = NULL; ASSERT_TRUE(copy_dict->Get(L"int", ©_int)); ASSERT_TRUE(copy_int); ASSERT_NE(copy_int, original_int); ASSERT_TRUE(copy_int->IsType(Value::TYPE_INTEGER)); int copy_int_value = 0; ASSERT_TRUE(copy_int->GetAsInteger(©_int_value)); ASSERT_EQ(42, copy_int_value); Value* copy_real = NULL; ASSERT_TRUE(copy_dict->Get(L"real", ©_real)); ASSERT_TRUE(copy_real); ASSERT_NE(copy_real, original_real); ASSERT_TRUE(copy_real->IsType(Value::TYPE_REAL)); double copy_real_value = 0; ASSERT_TRUE(copy_real->GetAsReal(©_real_value)); ASSERT_EQ(3.14, copy_real_value); Value* copy_string = NULL; ASSERT_TRUE(copy_dict->Get(L"string", ©_string)); ASSERT_TRUE(copy_string); ASSERT_NE(copy_string, original_string); ASSERT_TRUE(copy_string->IsType(Value::TYPE_STRING)); std::string copy_string_value; std::wstring copy_wstring_value; ASSERT_TRUE(copy_string->GetAsString(©_string_value)); ASSERT_TRUE(copy_string->GetAsString(©_wstring_value)); ASSERT_EQ(std::string("hello"), copy_string_value); ASSERT_EQ(std::wstring(L"hello"), copy_wstring_value); Value* copy_wstring = NULL; ASSERT_TRUE(copy_dict->Get(L"wstring", ©_wstring)); ASSERT_TRUE(copy_wstring); ASSERT_NE(copy_wstring, original_wstring); ASSERT_TRUE(copy_wstring->IsType(Value::TYPE_STRING)); ASSERT_TRUE(copy_wstring->GetAsString(©_string_value)); ASSERT_TRUE(copy_wstring->GetAsString(©_wstring_value)); ASSERT_EQ(std::string("peek-a-boo"), copy_string_value); ASSERT_EQ(std::wstring(L"peek-a-boo"), copy_wstring_value); Value* copy_binary = NULL; ASSERT_TRUE(copy_dict->Get(L"binary", ©_binary)); ASSERT_TRUE(copy_binary); ASSERT_NE(copy_binary, original_binary); ASSERT_TRUE(copy_binary->IsType(Value::TYPE_BINARY)); ASSERT_NE(original_binary->GetBuffer(), static_cast(copy_binary)->GetBuffer()); ASSERT_EQ(original_binary->GetSize(), static_cast(copy_binary)->GetSize()); ASSERT_EQ(0, memcmp(original_binary->GetBuffer(), static_cast(copy_binary)->GetBuffer(), original_binary->GetSize())); Value* copy_value = NULL; ASSERT_TRUE(copy_dict->Get(L"list", ©_value)); ASSERT_TRUE(copy_value); ASSERT_NE(copy_value, original_list); ASSERT_TRUE(copy_value->IsType(Value::TYPE_LIST)); ListValue* copy_list = static_cast(copy_value); ASSERT_EQ(2U, copy_list->GetSize()); Value* copy_list_element_0; ASSERT_TRUE(copy_list->Get(0, ©_list_element_0)); ASSERT_TRUE(copy_list_element_0); ASSERT_NE(copy_list_element_0, original_list_element_0); int copy_list_element_0_value; ASSERT_TRUE(copy_list_element_0->GetAsInteger(©_list_element_0_value)); ASSERT_EQ(0, copy_list_element_0_value); Value* copy_list_element_1; ASSERT_TRUE(copy_list->Get(1, ©_list_element_1)); ASSERT_TRUE(copy_list_element_1); ASSERT_NE(copy_list_element_1, original_list_element_1); int copy_list_element_1_value; ASSERT_TRUE(copy_list_element_1->GetAsInteger(©_list_element_1_value)); ASSERT_EQ(1, copy_list_element_1_value); } TEST(ValuesTest, Equals) { Value* null1 = Value::CreateNullValue(); Value* null2 = Value::CreateNullValue(); EXPECT_NE(null1, null2); EXPECT_TRUE(null1->Equals(null2)); Value* boolean = Value::CreateBooleanValue(false); EXPECT_FALSE(null1->Equals(boolean)); delete null1; delete null2; delete boolean; DictionaryValue dv; dv.SetBoolean(L"a", false); dv.SetInteger(L"b", 2); dv.SetReal(L"c", 2.5); dv.SetString(L"d1", "string"); dv.SetString(L"d2", L"string"); dv.Set(L"e", Value::CreateNullValue()); DictionaryValue* copy = static_cast(dv.DeepCopy()); EXPECT_TRUE(dv.Equals(copy)); ListValue* list = new ListValue; list->Append(Value::CreateNullValue()); list->Append(new DictionaryValue); dv.Set(L"f", list); EXPECT_FALSE(dv.Equals(copy)); copy->Set(L"f", list->DeepCopy()); EXPECT_TRUE(dv.Equals(copy)); list->Append(Value::CreateBooleanValue(true)); EXPECT_FALSE(dv.Equals(copy)); delete copy; } TEST(ValuesTest, RemoveEmptyChildren) { scoped_ptr root(new DictionaryValue); // Remove empty lists and dictionaries. root->Set(L"empty_dict", new DictionaryValue); root->Set(L"empty_list", new ListValue); root->SetWithoutPathExpansion(L"a.b.c.d.e", new DictionaryValue); root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_TRUE(root->empty()); // Make sure we don't prune too much. root->SetBoolean(L"bool", true); root->Set(L"empty_dict", new DictionaryValue); root->SetString(L"empty_string", ""); root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_EQ(2U, root->size()); // Should do nothing. root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_EQ(2U, root->size()); // Nested test cases. These should all reduce back to the bool and string // set above. { root->Set(L"a.b.c.d.e", new DictionaryValue); root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_EQ(2U, root->size()); } { DictionaryValue* inner = new DictionaryValue; root->Set(L"dict_with_emtpy_children", inner); inner->Set(L"empty_dict", new DictionaryValue); inner->Set(L"empty_list", new ListValue); root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_EQ(2U, root->size()); } { ListValue* inner = new ListValue; root->Set(L"list_with_empty_children", inner); inner->Append(new DictionaryValue); inner->Append(new ListValue); root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_EQ(2U, root->size()); } // Nested with siblings. { ListValue* inner = new ListValue; root->Set(L"list_with_empty_children", inner); inner->Append(new DictionaryValue); inner->Append(new ListValue); DictionaryValue* inner2 = new DictionaryValue; root->Set(L"dict_with_empty_children", inner2); inner2->Set(L"empty_dict", new DictionaryValue); inner2->Set(L"empty_list", new ListValue); root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_EQ(2U, root->size()); } // Make sure nested values don't get pruned. { ListValue* inner = new ListValue; root->Set(L"list_with_empty_children", inner); ListValue* inner2 = new ListValue; inner->Append(new DictionaryValue); inner->Append(inner2); inner2->Append(Value::CreateStringValue("hello")); root.reset(root->DeepCopyWithoutEmptyChildren()); EXPECT_EQ(3U, root->size()); EXPECT_TRUE(root->GetList(L"list_with_empty_children", &inner)); EXPECT_EQ(1U, inner->GetSize()); // Dictionary was pruned. EXPECT_TRUE(inner->GetList(0, &inner2)); EXPECT_EQ(1U, inner2->GetSize()); } }