// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "components/content_settings/core/browser/content_settings_pref_provider.h" #include "base/auto_reset.h" #include "base/command_line.h" #include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" #include "base/test/simple_test_clock.h" #include "base/threading/platform_thread.h" #include "base/values.h" #include "chrome/browser/content_settings/content_settings_mock_observer.h" #include "chrome/browser/prefs/browser_prefs.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/testing_profile.h" #include "components/content_settings/core/browser/content_settings_pref.h" #include "components/content_settings/core/browser/content_settings_registry.h" #include "components/content_settings/core/browser/content_settings_rule.h" #include "components/content_settings/core/browser/website_settings_info.h" #include "components/content_settings/core/browser/website_settings_registry.h" #include "components/content_settings/core/common/content_settings_pattern.h" #include "components/content_settings/core/test/content_settings_test_utils.h" #include "components/pref_registry/pref_registry_syncable.h" #include "components/prefs/default_pref_store.h" #include "components/prefs/overlay_user_pref_store.h" #include "components/prefs/pref_change_registrar.h" #include "components/prefs/pref_service.h" #include "components/prefs/scoped_user_pref_update.h" #include "components/prefs/testing_pref_store.h" #include "components/syncable_prefs/pref_service_mock_factory.h" #include "components/syncable_prefs/pref_service_syncable.h" #include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" #include "url/gurl.h" using ::testing::_; namespace content_settings { class DeadlockCheckerThread : public base::PlatformThread::Delegate { public: explicit DeadlockCheckerThread(const ContentSettingsPref* pref) : pref_(pref) {} void ThreadMain() override { EXPECT_TRUE(pref_->TryLockForTesting()); } private: const ContentSettingsPref* pref_; DISALLOW_COPY_AND_ASSIGN(DeadlockCheckerThread); }; // A helper for observing an preference changes and testing whether // |PrefProvider| holds a lock when the preferences change. class DeadlockCheckerObserver { public: // |DeadlockCheckerObserver| doesn't take the ownership of |prefs| or // |provider|. DeadlockCheckerObserver(PrefService* prefs, PrefProvider* provider) : provider_(provider), notification_received_(false) { pref_change_registrar_.Init(prefs); for (const auto& pair : provider_->content_settings_prefs_) { const ContentSettingsPref* pref = pair.second.get(); pref_change_registrar_.Add( pref->pref_name_, base::Bind( &DeadlockCheckerObserver::OnContentSettingsPatternPairsChanged, base::Unretained(this), base::Unretained(pref))); } } virtual ~DeadlockCheckerObserver() {} bool notification_received() const { return notification_received_; } private: void OnContentSettingsPatternPairsChanged(const ContentSettingsPref* pref) { // Check whether |provider_| holds its lock. For this, we need a // separate thread. DeadlockCheckerThread thread(pref); base::PlatformThreadHandle handle; ASSERT_TRUE(base::PlatformThread::Create(0, &thread, &handle)); base::PlatformThread::Join(handle); notification_received_ = true; } PrefProvider* provider_; PrefChangeRegistrar pref_change_registrar_; bool notification_received_; DISALLOW_COPY_AND_ASSIGN(DeadlockCheckerObserver); }; class PrefProviderTest : public testing::Test { public: PrefProviderTest() { // Ensure all content settings are initialized. ContentSettingsRegistry::GetInstance(); } private: content::TestBrowserThreadBundle thread_bundle_; }; TEST_F(PrefProviderTest, Observer) { TestingProfile profile; PrefProvider pref_content_settings_provider(profile.GetPrefs(), false); ContentSettingsPattern pattern = ContentSettingsPattern::FromString("[*.]example.com"); MockObserver mock_observer; EXPECT_CALL(mock_observer, OnContentSettingChanged(pattern, ContentSettingsPattern::Wildcard(), CONTENT_SETTINGS_TYPE_IMAGES, "")); pref_content_settings_provider.AddObserver(&mock_observer); pref_content_settings_provider.SetWebsiteSetting( pattern, ContentSettingsPattern::Wildcard(), CONTENT_SETTINGS_TYPE_IMAGES, std::string(), new base::FundamentalValue(CONTENT_SETTING_ALLOW)); pref_content_settings_provider.ShutdownOnUIThread(); } // Test for regression in which the PrefProvider modified the user pref store // of the OTR unintentionally: http://crbug.com/74466. TEST_F(PrefProviderTest, Incognito) { PersistentPrefStore* user_prefs = new TestingPrefStore(); OverlayUserPrefStore* otr_user_prefs = new OverlayUserPrefStore(user_prefs); syncable_prefs::PrefServiceMockFactory factory; factory.set_user_prefs(make_scoped_refptr(user_prefs)); scoped_refptr registry( new user_prefs::PrefRegistrySyncable); syncable_prefs::PrefServiceSyncable* regular_prefs = factory.CreateSyncable(registry.get()).release(); chrome::RegisterUserProfilePrefs(registry.get()); syncable_prefs::PrefServiceMockFactory otr_factory; otr_factory.set_user_prefs(make_scoped_refptr(otr_user_prefs)); scoped_refptr otr_registry( new user_prefs::PrefRegistrySyncable); syncable_prefs::PrefServiceSyncable* otr_prefs = otr_factory.CreateSyncable(otr_registry.get()).release(); chrome::RegisterUserProfilePrefs(otr_registry.get()); TestingProfile::Builder profile_builder; profile_builder.SetPrefService(make_scoped_ptr(regular_prefs)); scoped_ptr profile = profile_builder.Build(); TestingProfile::Builder otr_profile_builder; otr_profile_builder.SetPrefService(make_scoped_ptr(otr_prefs)); otr_profile_builder.BuildIncognito(profile.get()); PrefProvider pref_content_settings_provider(regular_prefs, false); PrefProvider pref_content_settings_provider_incognito(otr_prefs, true); ContentSettingsPattern pattern = ContentSettingsPattern::FromString("[*.]example.com"); pref_content_settings_provider.SetWebsiteSetting( pattern, pattern, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), new base::FundamentalValue(CONTENT_SETTING_ALLOW)); GURL host("http://example.com/"); // The value should of course be visible in the regular PrefProvider. EXPECT_EQ(CONTENT_SETTING_ALLOW, TestUtils::GetContentSetting(&pref_content_settings_provider, host, host, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); // And also in the OTR version. EXPECT_EQ(CONTENT_SETTING_ALLOW, TestUtils::GetContentSetting( &pref_content_settings_provider_incognito, host, host, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); const WebsiteSettingsInfo* info = WebsiteSettingsRegistry::GetInstance()->Get(CONTENT_SETTINGS_TYPE_IMAGES); // But the value should not be overridden in the OTR user prefs accidentally. EXPECT_FALSE(otr_user_prefs->IsSetInOverlay(info->pref_name())); pref_content_settings_provider.ShutdownOnUIThread(); pref_content_settings_provider_incognito.ShutdownOnUIThread(); } TEST_F(PrefProviderTest, GetContentSettingsValue) { TestingProfile testing_profile; PrefProvider provider(testing_profile.GetPrefs(), false); GURL primary_url("http://example.com/"); ContentSettingsPattern primary_pattern = ContentSettingsPattern::FromString("[*.]example.com"); EXPECT_EQ(CONTENT_SETTING_DEFAULT, TestUtils::GetContentSetting(&provider, primary_url, primary_url, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); EXPECT_EQ(NULL, TestUtils::GetContentSettingValue( &provider, primary_url, primary_url, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); provider.SetWebsiteSetting(primary_pattern, primary_pattern, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), new base::FundamentalValue(CONTENT_SETTING_BLOCK)); EXPECT_EQ(CONTENT_SETTING_BLOCK, TestUtils::GetContentSetting(&provider, primary_url, primary_url, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); scoped_ptr value_ptr(TestUtils::GetContentSettingValue( &provider, primary_url, primary_url, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); int int_value = -1; value_ptr->GetAsInteger(&int_value); EXPECT_EQ(CONTENT_SETTING_BLOCK, IntToContentSetting(int_value)); provider.SetWebsiteSetting(primary_pattern, primary_pattern, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), NULL); EXPECT_EQ(NULL, TestUtils::GetContentSettingValue( &provider, primary_url, primary_url, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); provider.ShutdownOnUIThread(); } TEST_F(PrefProviderTest, Patterns) { TestingProfile testing_profile; PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(), false); GURL host1("http://example.com/"); GURL host2("http://www.example.com/"); GURL host3("http://example.org/"); GURL host4("file:///tmp/test.html"); ContentSettingsPattern pattern1 = ContentSettingsPattern::FromString("[*.]example.com"); ContentSettingsPattern pattern2 = ContentSettingsPattern::FromString("example.org"); ContentSettingsPattern pattern3 = ContentSettingsPattern::FromString("file:///tmp/test.html"); EXPECT_EQ(CONTENT_SETTING_DEFAULT, TestUtils::GetContentSetting(&pref_content_settings_provider, host1, host1, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); pref_content_settings_provider.SetWebsiteSetting( pattern1, pattern1, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), new base::FundamentalValue(CONTENT_SETTING_BLOCK)); EXPECT_EQ(CONTENT_SETTING_BLOCK, TestUtils::GetContentSetting(&pref_content_settings_provider, host1, host1, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); EXPECT_EQ(CONTENT_SETTING_BLOCK, TestUtils::GetContentSetting(&pref_content_settings_provider, host2, host2, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); EXPECT_EQ(CONTENT_SETTING_DEFAULT, TestUtils::GetContentSetting(&pref_content_settings_provider, host3, host3, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); pref_content_settings_provider.SetWebsiteSetting( pattern2, pattern2, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), new base::FundamentalValue(CONTENT_SETTING_BLOCK)); EXPECT_EQ(CONTENT_SETTING_BLOCK, TestUtils::GetContentSetting(&pref_content_settings_provider, host3, host3, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); EXPECT_EQ(CONTENT_SETTING_DEFAULT, TestUtils::GetContentSetting(&pref_content_settings_provider, host4, host4, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); pref_content_settings_provider.SetWebsiteSetting( pattern3, pattern3, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), new base::FundamentalValue(CONTENT_SETTING_BLOCK)); EXPECT_EQ(CONTENT_SETTING_BLOCK, TestUtils::GetContentSetting(&pref_content_settings_provider, host4, host4, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); pref_content_settings_provider.ShutdownOnUIThread(); } TEST_F(PrefProviderTest, ResourceIdentifier) { TestingProfile testing_profile; PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(), false); GURL host("http://example.com/"); ContentSettingsPattern pattern = ContentSettingsPattern::FromString("[*.]example.com"); std::string resource1("someplugin"); std::string resource2("otherplugin"); EXPECT_EQ(CONTENT_SETTING_DEFAULT, TestUtils::GetContentSetting(&pref_content_settings_provider, host, host, CONTENT_SETTINGS_TYPE_PLUGINS, resource1, false)); pref_content_settings_provider.SetWebsiteSetting( pattern, pattern, CONTENT_SETTINGS_TYPE_PLUGINS, resource1, new base::FundamentalValue(CONTENT_SETTING_BLOCK)); EXPECT_EQ(CONTENT_SETTING_BLOCK, TestUtils::GetContentSetting(&pref_content_settings_provider, host, host, CONTENT_SETTINGS_TYPE_PLUGINS, resource1, false)); EXPECT_EQ(CONTENT_SETTING_DEFAULT, TestUtils::GetContentSetting(&pref_content_settings_provider, host, host, CONTENT_SETTINGS_TYPE_PLUGINS, resource2, false)); pref_content_settings_provider.ShutdownOnUIThread(); } // http://crosbug.com/17760 TEST_F(PrefProviderTest, Deadlock) { syncable_prefs::TestingPrefServiceSyncable prefs; PrefProvider::RegisterProfilePrefs(prefs.registry()); // Chain of events: a preference changes, |PrefProvider| notices it, and reads // and writes the preference. When the preference is written, a notification // is sent, and this used to happen when |PrefProvider| was still holding its // lock. const WebsiteSettingsInfo* info = WebsiteSettingsRegistry::GetInstance()->Get(CONTENT_SETTINGS_TYPE_IMAGES); PrefProvider provider(&prefs, false); DeadlockCheckerObserver observer(&prefs, &provider); { DictionaryPrefUpdate update(&prefs, info->pref_name()); base::DictionaryValue* mutable_settings = update.Get(); mutable_settings->SetWithoutPathExpansion("www.example.com,*", new base::DictionaryValue()); } EXPECT_TRUE(observer.notification_received()); provider.ShutdownOnUIThread(); } TEST_F(PrefProviderTest, LastUsage) { TestingProfile testing_profile; PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(), false); base::SimpleTestClock* test_clock = new base::SimpleTestClock; test_clock->SetNow(base::Time::Now()); pref_content_settings_provider.SetClockForTesting( scoped_ptr(test_clock)); GURL host("http://example.com/"); ContentSettingsPattern pattern = ContentSettingsPattern::FromString("[*.]example.com"); base::Time no_usage = pref_content_settings_provider.GetLastUsage( pattern, pattern, CONTENT_SETTINGS_TYPE_GEOLOCATION); EXPECT_EQ(no_usage.ToDoubleT(), 0); pref_content_settings_provider.UpdateLastUsage( pattern, pattern, CONTENT_SETTINGS_TYPE_GEOLOCATION); base::Time first = pref_content_settings_provider.GetLastUsage( pattern, pattern, CONTENT_SETTINGS_TYPE_GEOLOCATION); test_clock->Advance(base::TimeDelta::FromSeconds(10)); pref_content_settings_provider.UpdateLastUsage( pattern, pattern, CONTENT_SETTINGS_TYPE_GEOLOCATION); base::Time second = pref_content_settings_provider.GetLastUsage( pattern, pattern, CONTENT_SETTINGS_TYPE_GEOLOCATION); base::TimeDelta delta = second - first; EXPECT_EQ(delta.InSeconds(), 10); pref_content_settings_provider.ShutdownOnUIThread(); } TEST_F(PrefProviderTest, IncognitoInheritsValueMap) { syncable_prefs::TestingPrefServiceSyncable prefs; PrefProvider::RegisterProfilePrefs(prefs.registry()); ContentSettingsPattern pattern_1 = ContentSettingsPattern::FromString("google.com"); ContentSettingsPattern pattern_2 = ContentSettingsPattern::FromString("www.google.com"); ContentSettingsPattern wildcard = ContentSettingsPattern::FromString("*"); scoped_ptr value( new base::FundamentalValue(CONTENT_SETTING_ALLOW)); // Create a normal provider and set a setting. PrefProvider normal_provider(&prefs, false); normal_provider.SetWebsiteSetting(pattern_1, wildcard, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), value->DeepCopy()); // Non-OTR provider, Non-OTR iterator has one setting (pattern 1). { scoped_ptr it(normal_provider.GetRuleIterator( CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); EXPECT_TRUE(it->HasNext()); EXPECT_EQ(pattern_1, it->Next().primary_pattern); EXPECT_FALSE(it->HasNext()); } // Non-OTR provider, OTR iterator has no settings. { scoped_ptr it(normal_provider.GetRuleIterator( CONTENT_SETTINGS_TYPE_IMAGES, std::string(), true)); EXPECT_FALSE(it->HasNext()); } // Create an incognito provider and set a setting. PrefProvider incognito_provider(&prefs, true); incognito_provider.SetWebsiteSetting(pattern_2, wildcard, CONTENT_SETTINGS_TYPE_IMAGES, std::string(), value->DeepCopy()); // OTR provider, non-OTR iterator has one setting (pattern 1). { scoped_ptr it(incognito_provider.GetRuleIterator( CONTENT_SETTINGS_TYPE_IMAGES, std::string(), false)); EXPECT_TRUE(it->HasNext()); EXPECT_EQ(pattern_1, it->Next().primary_pattern); EXPECT_FALSE(it->HasNext()); } // OTR provider, OTR iterator has one setting (pattern 2). { scoped_ptr it(incognito_provider.GetRuleIterator( CONTENT_SETTINGS_TYPE_IMAGES, std::string(), true)); EXPECT_TRUE(it->HasNext()); EXPECT_EQ(pattern_2, it->Next().primary_pattern); EXPECT_FALSE(it->HasNext()); } incognito_provider.ShutdownOnUIThread(); normal_provider.ShutdownOnUIThread(); } TEST_F(PrefProviderTest, ClearAllContentSettingsRules) { syncable_prefs::TestingPrefServiceSyncable prefs; PrefProvider::RegisterProfilePrefs(prefs.registry()); ContentSettingsPattern pattern = ContentSettingsPattern::FromString("google.com"); ContentSettingsPattern wildcard = ContentSettingsPattern::FromString("*"); scoped_ptr value( new base::FundamentalValue(CONTENT_SETTING_ALLOW)); ResourceIdentifier res_id("abcde"); PrefProvider provider(&prefs, false); // Non-empty pattern, syncable, empty resource identifier. provider.SetWebsiteSetting(pattern, wildcard, CONTENT_SETTINGS_TYPE_IMAGES, ResourceIdentifier(), value->DeepCopy()); // Non-empty pattern, non-syncable, empty resource identifier. provider.SetWebsiteSetting(pattern, wildcard, CONTENT_SETTINGS_TYPE_GEOLOCATION, ResourceIdentifier(), value->DeepCopy()); // Non-empty pattern, plugins, non-empty resource identifier. provider.SetWebsiteSetting(pattern, wildcard, CONTENT_SETTINGS_TYPE_PLUGINS, res_id, value->DeepCopy()); // Empty pattern, plugins, non-empty resource identifier. provider.SetWebsiteSetting(wildcard, wildcard, CONTENT_SETTINGS_TYPE_PLUGINS, res_id, value->DeepCopy()); // Non-empty pattern, syncable, empty resource identifier. provider.SetWebsiteSetting(pattern, wildcard, CONTENT_SETTINGS_TYPE_COOKIES, ResourceIdentifier(), value->DeepCopy()); // Non-empty pattern, non-syncable, empty resource identifier. provider.SetWebsiteSetting(pattern, wildcard, CONTENT_SETTINGS_TYPE_NOTIFICATIONS, ResourceIdentifier(), value->DeepCopy()); provider.ClearAllContentSettingsRules(CONTENT_SETTINGS_TYPE_IMAGES); provider.ClearAllContentSettingsRules(CONTENT_SETTINGS_TYPE_GEOLOCATION); provider.ClearAllContentSettingsRules(CONTENT_SETTINGS_TYPE_PLUGINS); WebsiteSettingsRegistry* registry = WebsiteSettingsRegistry::GetInstance(); // Test that the preferences for images, geolocation and plugins are empty. const char* empty_prefs[] = { registry->Get(CONTENT_SETTINGS_TYPE_IMAGES)->pref_name().c_str(), registry->Get(CONTENT_SETTINGS_TYPE_GEOLOCATION)->pref_name().c_str(), registry->Get(CONTENT_SETTINGS_TYPE_PLUGINS)->pref_name().c_str(), }; for (const char* pref : empty_prefs) { DictionaryPrefUpdate update(&prefs, pref); const base::DictionaryValue* dictionary = update.Get(); EXPECT_TRUE(dictionary->empty()); } // Test that the preferences for cookies and notifications are not empty. const char* nonempty_prefs[] = { registry->Get(CONTENT_SETTINGS_TYPE_COOKIES)->pref_name().c_str(), registry->Get(CONTENT_SETTINGS_TYPE_NOTIFICATIONS)->pref_name().c_str(), }; for (const char* pref : nonempty_prefs) { DictionaryPrefUpdate update(&prefs, pref); const base::DictionaryValue* dictionary = update.Get(); EXPECT_EQ(1u, dictionary->size()); } provider.ShutdownOnUIThread(); } } // namespace content_settings