// Copyright 2015 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "chrome/browser/manifest/manifest_icon_selector.h" #include #include #include "base/macros.h" #include "base/strings/utf_string_conversions.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/gfx/screen.h" #include "ui/gfx/test/test_screen.h" class ManifestIconSelectorTest : public testing::Test { protected: ManifestIconSelectorTest() { test_screen_.display()->set_id(0x1337); test_screen_.display()->set_bounds(gfx::Rect(0, 0, 2560, 1440)); gfx::Screen::SetScreenInstance(&test_screen_); } ~ManifestIconSelectorTest() override { gfx::Screen::SetScreenInstance(nullptr); } GURL FindBestMatchingIconWithMinimum( const std::vector& icons, int minimum_icon_size_in_dp) { return ManifestIconSelector::FindBestMatchingIcon( icons, GetPreferredIconSizeInDp(), minimum_icon_size_in_dp); } GURL FindBestMatchingIcon(const std::vector& icons) { return FindBestMatchingIconWithMinimum(icons, 0); } void SetDisplayDeviceScaleFactor(float device_scale_factor) { test_screen_.display()->set_device_scale_factor(device_scale_factor); } int GetPreferredIconSizeInDp() { return preferred_icon_size_; } void SetPreferredIconSizeInDp(int new_size) { preferred_icon_size_ = new_size; } static content::Manifest::Icon CreateIcon( const std::string& url, const std::string& type, double density, const std::vector sizes) { content::Manifest::Icon icon; icon.src = GURL(url); if (!type.empty()) icon.type = base::NullableString16(base::UTF8ToUTF16(type), false); icon.density = density; icon.sizes = sizes; return icon; } private: gfx::test::TestScreen test_screen_; int preferred_icon_size_ = 48; DISALLOW_COPY_AND_ASSIGN(ManifestIconSelectorTest); }; TEST_F(ManifestIconSelectorTest, NoIcons) { // No icons should return the empty URL. std::vector icons; GURL url = FindBestMatchingIcon(icons); EXPECT_TRUE(url.is_empty()); } TEST_F(ManifestIconSelectorTest, NoSizes) { // Icon with no sizes are ignored. std::vector icons; icons.push_back( CreateIcon("http://foo.com/icon.png", "", 1.0, std::vector())); GURL url = FindBestMatchingIcon(icons); EXPECT_TRUE(url.is_empty()); } TEST_F(ManifestIconSelectorTest, MIMETypeFiltering) { // Icons with type specified to a MIME type that isn't a valid image MIME type // are ignored. std::vector sizes; sizes.push_back(gfx::Size(1024, 1024)); std::vector icons; icons.push_back( CreateIcon("http://foo.com/icon.png", "image/foo_bar", 1.0, sizes)); icons.push_back(CreateIcon("http://foo.com/icon.png", "image/", 1.0, sizes)); icons.push_back(CreateIcon("http://foo.com/icon.png", "image/", 1.0, sizes)); icons.push_back( CreateIcon("http://foo.com/icon.png", "video/mp4", 1.0, sizes)); GURL url = FindBestMatchingIcon(icons); EXPECT_TRUE(url.is_empty()); icons.clear(); icons.push_back( CreateIcon("http://foo.com/icon.png", "image/png", 1.0, sizes)); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); icons.clear(); icons.push_back( CreateIcon("http://foo.com/icon.png", "image/gif", 1.0, sizes)); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); icons.clear(); icons.push_back( CreateIcon("http://foo.com/icon.png", "image/jpeg", 1.0, sizes)); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } TEST_F(ManifestIconSelectorTest, PreferredSizeOfCurrentDensityIsUsedFirst) { // This test has three icons each are marked with sizes set to the preferred // icon size for the associated density. std::vector sizes_1; sizes_1.push_back(gfx::Size(GetPreferredIconSizeInDp(), GetPreferredIconSizeInDp())); std::vector sizes_2; sizes_2.push_back(gfx::Size(GetPreferredIconSizeInDp() * 2, GetPreferredIconSizeInDp() * 2)); std::vector sizes_3; sizes_3.push_back(gfx::Size(GetPreferredIconSizeInDp() * 3, GetPreferredIconSizeInDp() * 3)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x1.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon_x2.png", "", 2.0, sizes_2)); icons.push_back(CreateIcon("http://foo.com/icon_x3.png", "", 3.0, sizes_3)); SetDisplayDeviceScaleFactor(1.0f); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); SetDisplayDeviceScaleFactor(2.0f); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x2.png", url.spec()); SetDisplayDeviceScaleFactor(3.0f); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x3.png", url.spec()); } TEST_F(ManifestIconSelectorTest, PreferredSizeOfDefaultDensityIsUsedSecond) { // This test has three icons. The first one is of density zero and is marked // with three sizes which are the preferred icon size for density 1, 2 and 3. // The icon for density 2 and 3 have a size set to 1024x1024. // Regardless of the device scale factor, the icon of density 1 is going to be // used because it matches the preferred size. std::vector sizes_1; sizes_1.push_back(gfx::Size(GetPreferredIconSizeInDp(), GetPreferredIconSizeInDp())); sizes_1.push_back(gfx::Size(GetPreferredIconSizeInDp() * 2, GetPreferredIconSizeInDp() * 2)); sizes_1.push_back(gfx::Size(GetPreferredIconSizeInDp() * 3, GetPreferredIconSizeInDp() * 3)); std::vector sizes_2; sizes_2.push_back(gfx::Size(1024, 1024)); std::vector sizes_3; sizes_3.push_back(gfx::Size(1024, 1024)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x1.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon_x2.png", "", 2.0, sizes_2)); icons.push_back(CreateIcon("http://foo.com/icon_x3.png", "", 3.0, sizes_3)); SetDisplayDeviceScaleFactor(1.0f); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); SetDisplayDeviceScaleFactor(2.0f); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); SetDisplayDeviceScaleFactor(3.0f); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); } TEST_F(ManifestIconSelectorTest, DeviceDensityFirst) { // If there is no perfect icon but an icon of the current device density is // present, it will be picked. // This test has three icons each are marked with sizes set to the preferred // icon size for the associated density. std::vector sizes; sizes.push_back(gfx::Size(1024, 1024)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x1.png", "", 1.0, sizes)); icons.push_back(CreateIcon("http://foo.com/icon_x2.png", "", 2.0, sizes)); icons.push_back(CreateIcon("http://foo.com/icon_x3.png", "", 3.0, sizes)); SetDisplayDeviceScaleFactor(1.0f); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); SetDisplayDeviceScaleFactor(2.0f); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x2.png", url.spec()); SetDisplayDeviceScaleFactor(3.0f); url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x3.png", url.spec()); } TEST_F(ManifestIconSelectorTest, DeviceDensityFallback) { // If there is no perfect icon but and no icon of the current display density, // an icon of density 1.0 will be used. std::vector sizes; sizes.push_back(gfx::Size(1024, 1024)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x1.png", "", 1.0, sizes)); icons.push_back(CreateIcon("http://foo.com/icon_x2.png", "", 2.0, sizes)); SetDisplayDeviceScaleFactor(3.0f); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); } TEST_F(ManifestIconSelectorTest, DeviceDensityMatchRejectsTooSmall) { // If we have to resort to density matching to find icons, then an icon of // the correct size has not been found. Make sure that the minimum passed // is enforced. std::vector sizes_1_2; std::vector sizes_3; sizes_1_2.push_back(gfx::Size(47, 47)); sizes_3.push_back(gfx::Size(95, 95)); // Set to a value which will not affect the calculations. SetPreferredIconSizeInDp(1024); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x1.png", "", 1.0, sizes_1_2)); icons.push_back(CreateIcon("http://foo.com/icon_x2.png", "", 2.0, sizes_1_2)); icons.push_back(CreateIcon("http://foo.com/icon_x3.png", "", 3.0, sizes_3)); // Nothing matches here because the minimum is 48. SetDisplayDeviceScaleFactor(1.0f); GURL url = FindBestMatchingIconWithMinimum(icons, 48); EXPECT_TRUE(url.is_empty()); // Nothing matches here because the minimum is 48 again. SetDisplayDeviceScaleFactor(2.0f); url = FindBestMatchingIconWithMinimum(icons, 48); EXPECT_TRUE(url.is_empty()); // Nothing matches here as the minimum is 96. SetDisplayDeviceScaleFactor(3.0f); url = FindBestMatchingIconWithMinimum(icons, 96); EXPECT_TRUE(url.is_empty()); } TEST_F(ManifestIconSelectorTest, IdealVeryCloseToMinimumMatches) { std::vector sizes; sizes.push_back(gfx::Size(2, 2)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x1.png", "", 1.0, sizes)); SetDisplayDeviceScaleFactor(1.0f); GURL url = FindBestMatchingIconWithMinimum(icons, 1); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); } TEST_F(ManifestIconSelectorTest, SizeVeryCloseToMinimumMatches) { std::vector sizes; sizes.push_back(gfx::Size(2, 2)); SetPreferredIconSizeInDp(200); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x1.png", "", 1.0, sizes)); SetDisplayDeviceScaleFactor(1.0f); GURL url = FindBestMatchingIconWithMinimum(icons, 1); EXPECT_EQ("http://foo.com/icon_x1.png", url.spec()); } TEST_F(ManifestIconSelectorTest, DoNotUseOtherDensities) { // If there are only icons of densities that are not the current display // density or the default density, they are ignored. std::vector sizes; sizes.push_back(gfx::Size(1024, 1024)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_x2.png", "", 2.0, sizes)); SetDisplayDeviceScaleFactor(3.0f); GURL url = FindBestMatchingIcon(icons); EXPECT_TRUE(url.is_empty()); } TEST_F(ManifestIconSelectorTest, NotSquareIconsAreIgnored) { std::vector sizes; sizes.push_back(gfx::Size(1024, 1023)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes)); GURL url = FindBestMatchingIcon(icons); EXPECT_TRUE(url.is_empty()); } TEST_F(ManifestIconSelectorTest, ClosestIconToPreferred) { // This test verifies ManifestIconSelector::FindBestMatchingIcon by passing // different icon sizes and checking which one is picked. // The Device Scale Factor is 1.0 and the preferred icon size is returned by // GetPreferredIconSizeInDp(). int very_small = GetPreferredIconSizeInDp() / 4; int small_size = GetPreferredIconSizeInDp() / 2; int bit_small = GetPreferredIconSizeInDp() - 1; int bit_big = GetPreferredIconSizeInDp() + 1; int big = GetPreferredIconSizeInDp() * 2; int very_big = GetPreferredIconSizeInDp() * 4; // (very_small, bit_small) => bit_small { std::vector sizes_1; sizes_1.push_back(gfx::Size(very_small, very_small)); std::vector sizes_2; sizes_2.push_back(gfx::Size(bit_small, bit_small)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_2)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } // (very_small, bit_small, smaller) => bit_small { std::vector sizes_1; sizes_1.push_back(gfx::Size(very_small, very_small)); std::vector sizes_2; sizes_2.push_back(gfx::Size(bit_small, bit_small)); std::vector sizes_3; sizes_3.push_back(gfx::Size(small_size, small_size)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_2)); icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_3)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } // (very_big, big) => big { std::vector sizes_1; sizes_1.push_back(gfx::Size(very_big, very_big)); std::vector sizes_2; sizes_2.push_back(gfx::Size(big, big)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_2)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } // (very_big, big, bit_big) => bit_big { std::vector sizes_1; sizes_1.push_back(gfx::Size(very_big, very_big)); std::vector sizes_2; sizes_2.push_back(gfx::Size(big, big)); std::vector sizes_3; sizes_3.push_back(gfx::Size(bit_big, bit_big)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_2)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_3)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } // (bit_small, very_big) => very_big { std::vector sizes_1; sizes_1.push_back(gfx::Size(bit_small, bit_small)); std::vector sizes_2; sizes_2.push_back(gfx::Size(very_big, very_big)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_2)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } // (bit_small, bit_big) => bit_big { std::vector sizes_1; sizes_1.push_back(gfx::Size(bit_small, bit_small)); std::vector sizes_2; sizes_2.push_back(gfx::Size(bit_big, bit_big)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_2)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } } TEST_F(ManifestIconSelectorTest, UseAnyIfNoPreferredSize) { // 'any' (ie. gfx::Size(0,0)) should be used if there is no icon of a // preferred size. An icon with the current device scale factor is preferred // over one with the default density. // 'any' with preferred size => preferred size { std::vector sizes_1; sizes_1.push_back(gfx::Size(GetPreferredIconSizeInDp(), GetPreferredIconSizeInDp())); std::vector sizes_2; sizes_2.push_back(gfx::Size(0, 0)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_2)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } // 'any' with nearly preferred size => any { std::vector sizes_1; sizes_1.push_back(gfx::Size(GetPreferredIconSizeInDp() + 1, GetPreferredIconSizeInDp() + 1)); std::vector sizes_2; sizes_2.push_back(gfx::Size(0, 0)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes_1)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 1.0, sizes_2)); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } // 'any' on default density and current density => current density. { std::vector sizes; sizes.push_back(gfx::Size(0, 0)); std::vector icons; icons.push_back(CreateIcon("http://foo.com/icon_no.png", "", 1.0, sizes)); icons.push_back(CreateIcon("http://foo.com/icon.png", "", 3.0, sizes)); SetDisplayDeviceScaleFactor(3.0f); GURL url = FindBestMatchingIcon(icons); EXPECT_EQ("http://foo.com/icon.png", url.spec()); } }