// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "chrome/browser/ui/toolbar/wrench_menu_model.h" #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/defaults.h" #include "chrome/browser/prefs/browser_prefs.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/global_error/global_error.h" #include "chrome/browser/ui/global_error/global_error_service.h" #include "chrome/browser/ui/global_error/global_error_service_factory.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/upgrade_detector.h" #include "chrome/test/base/browser_with_test_window_test.h" #include "chrome/test/base/menu_model_test.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_io_thread_state.h" #include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "testing/gtest/include/gtest/gtest.h" namespace { // Error class has a menu item. class MenuError : public GlobalError { public: explicit MenuError(int command_id) : command_id_(command_id), execute_count_(0) { } int execute_count() { return execute_count_; } bool HasMenuItem() override { return true; } int MenuItemCommandID() override { return command_id_; } base::string16 MenuItemLabel() override { return base::string16(); } void ExecuteMenuItem(Browser* browser) override { execute_count_++; } bool HasBubbleView() override { return false; } bool HasShownBubbleView() override { return false; } void ShowBubbleView(Browser* browser) override { ADD_FAILURE(); } GlobalErrorBubbleViewBase* GetBubbleView() override { return NULL; } private: int command_id_; int execute_count_; DISALLOW_COPY_AND_ASSIGN(MenuError); }; } // namespace class WrenchMenuModelTest : public BrowserWithTestWindowTest, public ui::AcceleratorProvider { public: // Don't handle accelerators. bool GetAcceleratorForCommandId(int command_id, ui::Accelerator* accelerator) override { return false; } protected: void SetUp() override { prefs_.reset(new TestingPrefServiceSimple()); chrome::RegisterLocalState(prefs_->registry()); TestingBrowserProcess::GetGlobal()->SetLocalState(prefs_.get()); testing_io_thread_state_.reset(new chrome::TestingIOThreadState()); BrowserWithTestWindowTest::SetUp(); } void TearDown() override { BrowserWithTestWindowTest::TearDown(); testing_io_thread_state_.reset(); TestingBrowserProcess::GetGlobal()->SetLocalState(NULL); DestroyBrowserAndProfile(); } private: scoped_ptr prefs_; scoped_ptr testing_io_thread_state_; }; // Copies parts of MenuModelTest::Delegate and combines them with the // WrenchMenuModel since WrenchMenuModel is now a SimpleMenuModel::Delegate and // not derived from SimpleMenuModel. class TestWrenchMenuModel : public WrenchMenuModel { public: TestWrenchMenuModel(ui::AcceleratorProvider* provider, Browser* browser) : WrenchMenuModel(provider, browser), execute_count_(0), checked_count_(0), enable_count_(0) { } // Testing overrides to ui::SimpleMenuModel::Delegate: bool IsCommandIdChecked(int command_id) const override { bool val = WrenchMenuModel::IsCommandIdChecked(command_id); if (val) checked_count_++; return val; } bool IsCommandIdEnabled(int command_id) const override { ++enable_count_; return true; } void ExecuteCommand(int command_id, int event_flags) override { ++execute_count_; } int execute_count_; mutable int checked_count_; mutable int enable_count_; }; TEST_F(WrenchMenuModelTest, Basics) { TestWrenchMenuModel model(this, browser()); int itemCount = model.GetItemCount(); // Verify it has items. The number varies by platform, so we don't check // the exact number. EXPECT_GT(itemCount, 10); UpgradeDetector* detector = UpgradeDetector::GetInstance(); detector->NotifyUpgradeRecommended(); EXPECT_TRUE(detector->notify_upgrade()); EXPECT_EQ(browser_defaults::kShowUpgradeMenuItem, model.IsCommandIdVisible(IDC_UPGRADE_DIALOG)); // Execute a couple of the items and make sure it gets back to our delegate. // We can't use CountEnabledExecutable() here because the encoding menu's // delegate is internal, it doesn't use the one we pass in. // Note: The new menu has a spacing separator at the first slot. model.ActivatedAt(1); EXPECT_TRUE(model.IsEnabledAt(1)); // Make sure to use the index that is not separator in all configurations. model.ActivatedAt(itemCount - 1); EXPECT_TRUE(model.IsEnabledAt(itemCount - 1)); EXPECT_EQ(model.execute_count_, 2); EXPECT_EQ(model.enable_count_, 2); model.execute_count_ = 0; model.enable_count_ = 0; // Choose something from the bookmark submenu and make sure it makes it back // to the delegate as well. int bookmarksModelIndex = -1; for (int i = 0; i < itemCount; ++i) { if (model.GetTypeAt(i) == ui::MenuModel::TYPE_SUBMENU) { // The bookmarks submenu comes after the Tabs and Downloads items. bookmarksModelIndex = i + 2; break; } } EXPECT_GT(bookmarksModelIndex, -1); ui::MenuModel* bookmarksModel = model.GetSubmenuModelAt(bookmarksModelIndex); EXPECT_TRUE(bookmarksModel); // The bookmarks model may be empty until we tell it we're going to show it. bookmarksModel->MenuWillShow(); EXPECT_GT(bookmarksModel->GetItemCount(), 1); // Bookmark manager item. bookmarksModel->ActivatedAt(4); EXPECT_TRUE(bookmarksModel->IsEnabledAt(4)); EXPECT_EQ(model.execute_count_, 1); EXPECT_EQ(model.enable_count_, 1); } // Tests global error menu items in the wrench menu. TEST_F(WrenchMenuModelTest, GlobalError) { // Make sure services required for tests are initialized. GlobalErrorService* service = GlobalErrorServiceFactory::GetForProfile(browser()->profile()); ProfileOAuth2TokenServiceFactory::GetForProfile(browser()->profile()); const int command1 = 1234567; // AddGlobalError takes ownership of error1. MenuError* error1 = new MenuError(command1); service->AddGlobalError(error1); const int command2 = 1234568; // AddGlobalError takes ownership of error2. MenuError* error2 = new MenuError(command2); service->AddGlobalError(error2); WrenchMenuModel model(this, browser()); int index1 = model.GetIndexOfCommandId(command1); EXPECT_GT(index1, -1); int index2 = model.GetIndexOfCommandId(command2); EXPECT_GT(index2, -1); EXPECT_TRUE(model.IsEnabledAt(index1)); EXPECT_EQ(0, error1->execute_count()); model.ActivatedAt(index1); EXPECT_EQ(1, error1->execute_count()); EXPECT_TRUE(model.IsEnabledAt(index2)); EXPECT_EQ(0, error2->execute_count()); model.ActivatedAt(index2); EXPECT_EQ(1, error1->execute_count()); } class EncodingMenuModelTest : public BrowserWithTestWindowTest, public MenuModelTest { }; TEST_F(EncodingMenuModelTest, IsCommandIdCheckedWithNoTabs) { EncodingMenuModel model(browser()); ASSERT_EQ(NULL, browser()->tab_strip_model()->GetActiveWebContents()); EXPECT_FALSE(model.IsCommandIdChecked(IDC_ENCODING_WINDOWS1252)); }