// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "base/bind.h" #include "base/callback.h" #include "base/compiler_specific.h" #include "base/memory/weak_ptr.h" #include "base/message_loop.h" #include "base/test/test_timeouts.h" #include "sync/engine/backoff_delay_provider.h" #include "sync/engine/sync_scheduler_impl.h" #include "sync/engine/syncer.h" #include "sync/internal_api/public/base/model_type_invalidation_map_test_util.h" #include "sync/sessions/test_util.h" #include "sync/test/callback_counter.h" #include "sync/test/engine/fake_model_worker.h" #include "sync/test/engine/mock_connection_manager.h" #include "sync/test/engine/test_directory_setter_upper.h" #include "sync/test/fake_extensions_activity_monitor.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" using base::TimeDelta; using base::TimeTicks; using testing::_; using testing::AtLeast; using testing::DoAll; using testing::Eq; using testing::Invoke; using testing::Mock; using testing::Not; using testing::Return; using testing::WithArg; namespace syncer { using sessions::SyncSession; using sessions::SyncSessionContext; using sessions::SyncSessionSnapshot; using sync_pb::GetUpdatesCallerInfo; class MockSyncer : public Syncer { public: MOCK_METHOD3(SyncShare, bool(sessions::SyncSession*, SyncerStep, SyncerStep)); }; // Used when tests want to record syncing activity to examine later. struct SyncShareRecords { std::vector times; std::vector snapshots; }; void QuitLoopNow() { // We use QuitNow() instead of Quit() as the latter may get stalled // indefinitely in the presence of repeated timers with low delays // and a slow test (e.g., ThrottlingDoesThrottle [which has a poll // delay of 5ms] run under TSAN on the trybots). base::MessageLoop::current()->QuitNow(); } void RunLoop() { base::MessageLoop::current()->Run(); } void PumpLoop() { // Do it this way instead of RunAllPending to pump loop exactly once // (necessary in the presence of timers; see comment in // QuitLoopNow). base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(&QuitLoopNow)); RunLoop(); } void PumpLoopFor(base::TimeDelta time) { // Allow the loop to run for the specified amount of time. base::MessageLoop::current()->PostDelayedTask( FROM_HERE, base::Bind(&QuitLoopNow), time); RunLoop(); } ModelSafeRoutingInfo TypesToRoutingInfo(ModelTypeSet types) { ModelSafeRoutingInfo routes; for (ModelTypeSet::Iterator iter = types.First(); iter.Good(); iter.Inc()) { routes[iter.Get()] = GROUP_PASSIVE; } return routes; } // Compare a ModelTypeSet to a ModelTypeInvalidationMap, ignoring // state values. testing::AssertionResult ModelTypeSetMatchesInvalidationMap( ModelTypeSet lhs, const ModelTypeInvalidationMap& rhs) { ModelTypeSet rhs_set = ModelTypeInvalidationMapToSet(rhs); if (!rhs_set.Equals(rhs_set)) { return testing::AssertionFailure() << "ModelTypeSet: " << ModelTypeSetToString(lhs) << " does not match ModelTypeInvalidationMap: " << ModelTypeSetToString(rhs_set); } else { return testing::AssertionSuccess(); } } // Convenient to use in tests wishing to analyze SyncShare calls over time. static const size_t kMinNumSamples = 5; class SyncSchedulerTest : public testing::Test { public: SyncSchedulerTest() : weak_ptr_factory_(this), syncer_(NULL), delay_(NULL) {} class MockDelayProvider : public BackoffDelayProvider { public: MockDelayProvider() : BackoffDelayProvider( TimeDelta::FromSeconds(kInitialBackoffRetrySeconds), TimeDelta::FromSeconds(kInitialBackoffImmediateRetrySeconds)) { } MOCK_METHOD1(GetDelay, TimeDelta(const TimeDelta&)); }; virtual void SetUp() { dir_maker_.SetUp(); syncer_ = new MockSyncer(); delay_ = NULL; routing_info_[BOOKMARKS] = GROUP_UI; routing_info_[AUTOFILL] = GROUP_DB; routing_info_[THEMES] = GROUP_UI; routing_info_[NIGORI] = GROUP_PASSIVE; workers_.clear(); workers_.push_back(make_scoped_refptr(new FakeModelWorker(GROUP_UI))); workers_.push_back(make_scoped_refptr(new FakeModelWorker(GROUP_DB))); workers_.push_back(make_scoped_refptr(new FakeModelWorker(GROUP_PASSIVE))); std::vector workers; for (std::vector >::iterator it = workers_.begin(); it != workers_.end(); ++it) { workers.push_back(it->get()); } connection_.reset(new MockConnectionManager(directory())); connection_->SetServerReachable(); context_.reset(new SyncSessionContext( connection_.get(), directory(), workers, &extensions_activity_monitor_, std::vector(), NULL, NULL, true, // enable keystore encryption "fake_invalidator_client_id")); context_->set_routing_info(routing_info_); context_->set_notifications_enabled(true); context_->set_account_name("Test"); scheduler_.reset( new SyncSchedulerImpl("TestSyncScheduler", BackoffDelayProvider::FromDefaults(), context(), syncer_)); } SyncSchedulerImpl* scheduler() { return scheduler_.get(); } const ModelSafeRoutingInfo& routing_info() { return routing_info_; } MockSyncer* syncer() { return syncer_; } MockDelayProvider* delay() { return delay_; } MockConnectionManager* connection() { return connection_.get(); } TimeDelta zero() { return TimeDelta::FromSeconds(0); } TimeDelta timeout() { return TestTimeouts::action_timeout(); } virtual void TearDown() { PumpLoop(); scheduler_.reset(); PumpLoop(); dir_maker_.TearDown(); } void AnalyzePollRun(const SyncShareRecords& records, size_t min_num_samples, const TimeTicks& optimal_start, const TimeDelta& poll_interval) { const std::vector& data(records.times); EXPECT_GE(data.size(), min_num_samples); for (size_t i = 0; i < data.size(); i++) { SCOPED_TRACE(testing::Message() << "SyncShare # (" << i << ")"); TimeTicks optimal_next_sync = optimal_start + poll_interval * i; EXPECT_GE(data[i], optimal_next_sync); EXPECT_EQ(GetUpdatesCallerInfo::PERIODIC, records.snapshots[i].source().updates_source); } } void DoQuitLoopNow() { QuitLoopNow(); } void StartSyncScheduler(SyncScheduler::Mode mode) { scheduler()->Start(mode); } // This stops the scheduler synchronously. void StopSyncScheduler() { scheduler()->RequestStop(base::Bind(&SyncSchedulerTest::DoQuitLoopNow, weak_ptr_factory_.GetWeakPtr())); RunLoop(); } bool RunAndGetBackoff() { ModelTypeSet nudge_types(BOOKMARKS); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge(zero(), nudge_types, FROM_HERE); RunLoop(); return scheduler()->IsBackingOff(); } void UseMockDelayProvider() { delay_ = new MockDelayProvider(); scheduler_->delay_provider_.reset(delay_); } SyncSessionContext* context() { return context_.get(); } ModelTypeSet GetThrottledTypes() { return scheduler_->nudge_tracker_.GetThrottledTypes(); } private: syncable::Directory* directory() { return dir_maker_.directory(); } base::WeakPtrFactory weak_ptr_factory_; base::MessageLoop message_loop_; TestDirectorySetterUpper dir_maker_; scoped_ptr connection_; scoped_ptr context_; scoped_ptr scheduler_; MockSyncer* syncer_; MockDelayProvider* delay_; std::vector > workers_; FakeExtensionsActivityMonitor extensions_activity_monitor_; ModelSafeRoutingInfo routing_info_; }; void RecordSyncShareImpl(SyncSession* s, SyncShareRecords* record) { record->times.push_back(TimeTicks::Now()); record->snapshots.push_back(s->TakeSnapshot()); } ACTION_P(RecordSyncShare, record) { RecordSyncShareImpl(arg0, record); if (base::MessageLoop::current()->is_running()) QuitLoopNow(); return true; } ACTION_P2(RecordSyncShareMultiple, record, quit_after) { RecordSyncShareImpl(arg0, record); EXPECT_LE(record->times.size(), quit_after); if (record->times.size() >= quit_after && base::MessageLoop::current()->is_running()) { QuitLoopNow(); } return true; } ACTION(AddFailureAndQuitLoopNow) { ADD_FAILURE(); QuitLoopNow(); return true; } ACTION(QuitLoopNowAction) { QuitLoopNow(); return true; } // Test nudge scheduling. TEST_F(SyncSchedulerTest, Nudge) { SyncShareRecords records; ModelTypeSet model_types(BOOKMARKS); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))) .RetiresOnSaturation(); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge(zero(), model_types, FROM_HERE); RunLoop(); ASSERT_EQ(1U, records.snapshots.size()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( model_types, records.snapshots[0].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, records.snapshots[0].source().updates_source); Mock::VerifyAndClearExpectations(syncer()); // Make sure a second, later, nudge is unaffected by first (no coalescing). SyncShareRecords records2; model_types.Remove(BOOKMARKS); model_types.Put(AUTOFILL); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records2)))); scheduler()->ScheduleLocalNudge(zero(), model_types, FROM_HERE); RunLoop(); ASSERT_EQ(1U, records2.snapshots.size()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( model_types, records2.snapshots[0].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, records2.snapshots[0].source().updates_source); } // Make sure a regular config command is scheduled fine in the absence of any // errors. TEST_F(SyncSchedulerTest, Config) { SyncShareRecords records; const ModelTypeSet model_types(BOOKMARKS); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, model_types, TypesToRoutingInfo(model_types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); ASSERT_TRUE(scheduler()->ScheduleConfiguration(params)); ASSERT_EQ(1, counter.times_called()); ASSERT_EQ(1U, records.snapshots.size()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( model_types, records.snapshots[0].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::RECONFIGURATION, records.snapshots[0].source().updates_source); } // Simulate a failure and make sure the config request is retried. TEST_F(SyncSchedulerTest, ConfigWithBackingOff) { UseMockDelayProvider(); EXPECT_CALL(*delay(), GetDelay(_)) .WillRepeatedly(Return(TimeDelta::FromMilliseconds(1))); SyncShareRecords records; const ModelTypeSet model_types(BOOKMARKS); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), WithArg<0>(RecordSyncShare(&records)))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); ASSERT_EQ(0U, records.snapshots.size()); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, model_types, TypesToRoutingInfo(model_types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); ASSERT_FALSE(scheduler()->ScheduleConfiguration(params)); ASSERT_EQ(0, counter.times_called()); ASSERT_EQ(1U, records.snapshots.size()); RunLoop(); ASSERT_EQ(2U, records.snapshots.size()); ASSERT_EQ(1, counter.times_called()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( model_types, records.snapshots[1].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::RECONFIGURATION, records.snapshots[1].source().updates_source); } // Issue a nudge when the config has failed. Make sure both the config and // nudge are executed. TEST_F(SyncSchedulerTest, NudgeWithConfigWithBackingOff) { const ModelTypeSet model_types(BOOKMARKS); UseMockDelayProvider(); EXPECT_CALL(*delay(), GetDelay(_)) .WillRepeatedly(Return(TimeDelta::FromMilliseconds(50))); SyncShareRecords records; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), WithArg<0>(RecordSyncShare(&records)))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), WithArg<0>(RecordSyncShare(&records)))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); ASSERT_EQ(0U, records.snapshots.size()); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, model_types, TypesToRoutingInfo(model_types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); ASSERT_FALSE(scheduler()->ScheduleConfiguration(params)); ASSERT_EQ(0, counter.times_called()); ASSERT_EQ(1U, records.snapshots.size()); scheduler()->ScheduleLocalNudge(zero(), model_types, FROM_HERE); RunLoop(); // Note that we're not RunLoop()ing for the NUDGE we just scheduled, but // for the first retry attempt from the config job (after // waiting ~+/- 50ms). ASSERT_EQ(2U, records.snapshots.size()); ASSERT_EQ(0, counter.times_called()); EXPECT_EQ(GetUpdatesCallerInfo::RECONFIGURATION, records.snapshots[1].source().updates_source); RunLoop(); // This is the 3rd attempt, which we've set up to SimulateSuccess. ASSERT_EQ(3U, records.snapshots.size()); ASSERT_EQ(1, counter.times_called()); // Now change the mode so nudge can execute. StartSyncScheduler(SyncScheduler::NORMAL_MODE); ASSERT_EQ(4U, records.snapshots.size()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( model_types, records.snapshots[2].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::RECONFIGURATION, records.snapshots[2].source().updates_source); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( model_types, records.snapshots[3].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, records.snapshots[3].source().updates_source); } // Test that nudges are coalesced. TEST_F(SyncSchedulerTest, NudgeCoalescing) { StartSyncScheduler(SyncScheduler::NORMAL_MODE); SyncShareRecords r; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&r)))); const ModelTypeSet types1(BOOKMARKS), types2(AUTOFILL), types3(THEMES); TimeDelta delay = zero(); TimeTicks optimal_time = TimeTicks::Now() + delay; scheduler()->ScheduleLocalNudge(delay, types1, FROM_HERE); scheduler()->ScheduleLocalNudge(zero(), types2, FROM_HERE); RunLoop(); ASSERT_EQ(1U, r.snapshots.size()); EXPECT_GE(r.times[0], optimal_time); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( Union(types1, types2), r.snapshots[0].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, r.snapshots[0].source().updates_source); Mock::VerifyAndClearExpectations(syncer()); SyncShareRecords r2; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&r2)))); scheduler()->ScheduleLocalNudge(zero(), types3, FROM_HERE); RunLoop(); ASSERT_EQ(1U, r2.snapshots.size()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( types3, r2.snapshots[0].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, r2.snapshots[0].source().updates_source); } // Test that nudges are coalesced. TEST_F(SyncSchedulerTest, NudgeCoalescingWithDifferentTimings) { StartSyncScheduler(SyncScheduler::NORMAL_MODE); SyncShareRecords r; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&r)))); ModelTypeSet types1(BOOKMARKS), types2(AUTOFILL), types3; // Create a huge time delay. TimeDelta delay = TimeDelta::FromDays(1); scheduler()->ScheduleLocalNudge(delay, types1, FROM_HERE); scheduler()->ScheduleLocalNudge(zero(), types2, FROM_HERE); TimeTicks min_time = TimeTicks::Now(); TimeTicks max_time = TimeTicks::Now() + delay; RunLoop(); // Make sure the sync has happened. ASSERT_EQ(1U, r.snapshots.size()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( Union(types1, types2), r.snapshots[0].source().types)); // Make sure the sync happened at the right time. EXPECT_GE(r.times[0], min_time); EXPECT_LE(r.times[0], max_time); } // Test nudge scheduling. TEST_F(SyncSchedulerTest, NudgeWithStates) { StartSyncScheduler(SyncScheduler::NORMAL_MODE); SyncShareRecords records; const ModelTypeSet types(BOOKMARKS); ModelTypeInvalidationMap invalidation_map = ModelTypeSetToInvalidationMap(types, "test"); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))) .RetiresOnSaturation(); scheduler()->ScheduleInvalidationNudge(zero(), invalidation_map, FROM_HERE); RunLoop(); ASSERT_EQ(1U, records.snapshots.size()); EXPECT_THAT(invalidation_map, Eq(records.snapshots[0].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::NOTIFICATION, records.snapshots[0].source().updates_source); Mock::VerifyAndClearExpectations(syncer()); // Make sure a second, later, nudge is unaffected by first (no coalescing). SyncShareRecords records2; invalidation_map.erase(BOOKMARKS); invalidation_map[AUTOFILL].payload = "test2"; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records2)))); scheduler()->ScheduleInvalidationNudge(zero(), invalidation_map, FROM_HERE); RunLoop(); ASSERT_EQ(1U, records2.snapshots.size()); EXPECT_THAT(invalidation_map, Eq(records2.snapshots[0].source().types)); EXPECT_EQ(GetUpdatesCallerInfo::NOTIFICATION, records2.snapshots[0].source().updates_source); } // Test that polling works as expected. TEST_F(SyncSchedulerTest, Polling) { SyncShareRecords records; TimeDelta poll_interval(TimeDelta::FromMilliseconds(30)); EXPECT_CALL(*syncer(), SyncShare(_,_,_)).Times(AtLeast(kMinNumSamples)) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShareMultiple(&records, kMinNumSamples)))); scheduler()->OnReceivedLongPollIntervalUpdate(poll_interval); TimeTicks optimal_start = TimeTicks::Now() + poll_interval; StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run again to wait for polling. RunLoop(); StopSyncScheduler(); AnalyzePollRun(records, kMinNumSamples, optimal_start, poll_interval); } // Test that the short poll interval is used. TEST_F(SyncSchedulerTest, PollNotificationsDisabled) { SyncShareRecords records; TimeDelta poll_interval(TimeDelta::FromMilliseconds(30)); EXPECT_CALL(*syncer(), SyncShare(_,_,_)).Times(AtLeast(kMinNumSamples)) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShareMultiple(&records, kMinNumSamples)))); scheduler()->OnReceivedShortPollIntervalUpdate(poll_interval); scheduler()->SetNotificationsEnabled(false); TimeTicks optimal_start = TimeTicks::Now() + poll_interval; StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run again to wait for polling. RunLoop(); StopSyncScheduler(); AnalyzePollRun(records, kMinNumSamples, optimal_start, poll_interval); } // Test that polling intervals are updated when needed. TEST_F(SyncSchedulerTest, PollIntervalUpdate) { SyncShareRecords records; TimeDelta poll1(TimeDelta::FromMilliseconds(120)); TimeDelta poll2(TimeDelta::FromMilliseconds(30)); scheduler()->OnReceivedLongPollIntervalUpdate(poll1); EXPECT_CALL(*syncer(), SyncShare(_,_,_)).Times(AtLeast(kMinNumSamples)) .WillOnce(DoAll( WithArg<0>( sessions::test_util::SimulatePollIntervalUpdate(poll2)), Return(true))) .WillRepeatedly( DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>( RecordSyncShareMultiple(&records, kMinNumSamples)))); TimeTicks optimal_start = TimeTicks::Now() + poll1 + poll2; StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run again to wait for polling. RunLoop(); StopSyncScheduler(); AnalyzePollRun(records, kMinNumSamples, optimal_start, poll2); } // Test that the sessions commit delay is updated when needed. TEST_F(SyncSchedulerTest, SessionsCommitDelay) { SyncShareRecords records; TimeDelta delay1(TimeDelta::FromMilliseconds(120)); TimeDelta delay2(TimeDelta::FromMilliseconds(30)); scheduler()->OnReceivedSessionsCommitDelay(delay1); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce( DoAll( WithArg<0>( sessions::test_util::SimulateSessionsCommitDelayUpdate( delay2)), Invoke(sessions::test_util::SimulateSuccess), QuitLoopNowAction())); EXPECT_EQ(delay1, scheduler()->GetSessionsCommitDelay()); StartSyncScheduler(SyncScheduler::NORMAL_MODE); EXPECT_EQ(delay1, scheduler()->GetSessionsCommitDelay()); const ModelTypeSet model_types(BOOKMARKS); scheduler()->ScheduleLocalNudge(zero(), model_types, FROM_HERE); RunLoop(); EXPECT_EQ(delay2, scheduler()->GetSessionsCommitDelay()); StopSyncScheduler(); } // Test that no syncing occurs when throttled. TEST_F(SyncSchedulerTest, ThrottlingDoesThrottle) { const ModelTypeSet types(BOOKMARKS); TimeDelta poll(TimeDelta::FromMilliseconds(5)); TimeDelta throttle(TimeDelta::FromMinutes(10)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( WithArg<0>(sessions::test_util::SimulateThrottled(throttle)), Return(true))) .WillRepeatedly(AddFailureAndQuitLoopNow()); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge( TimeDelta::FromMicroseconds(1), types, FROM_HERE); PumpLoop(); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, types, TypesToRoutingInfo(types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); ASSERT_FALSE(scheduler()->ScheduleConfiguration(params)); ASSERT_EQ(0, counter.times_called()); } TEST_F(SyncSchedulerTest, ThrottlingExpiresFromPoll) { SyncShareRecords records; TimeDelta poll(TimeDelta::FromMilliseconds(15)); TimeDelta throttle1(TimeDelta::FromMilliseconds(150)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); ::testing::InSequence seq; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( WithArg<0>(sessions::test_util::SimulateThrottled(throttle1)), Return(true))) .RetiresOnSaturation(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShareMultiple(&records, kMinNumSamples)))); TimeTicks optimal_start = TimeTicks::Now() + poll + throttle1; StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run again to wait for polling. RunLoop(); StopSyncScheduler(); AnalyzePollRun(records, kMinNumSamples, optimal_start, poll); } TEST_F(SyncSchedulerTest, ThrottlingExpiresFromNudge) { SyncShareRecords records; TimeDelta poll(TimeDelta::FromDays(1)); TimeDelta throttle1(TimeDelta::FromMilliseconds(150)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); ::testing::InSequence seq; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( WithArg<0>(sessions::test_util::SimulateThrottled(throttle1)), Return(true))) .RetiresOnSaturation(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), QuitLoopNowAction())); const ModelTypeSet types(BOOKMARKS); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge(zero(), types, FROM_HERE); PumpLoop(); EXPECT_TRUE(scheduler()->IsCurrentlyThrottled()); RunLoop(); EXPECT_FALSE(scheduler()->IsCurrentlyThrottled()); StopSyncScheduler(); } TEST_F(SyncSchedulerTest, ThrottlingExpiresFromConfigure) { SyncShareRecords records; TimeDelta poll(TimeDelta::FromDays(1)); TimeDelta throttle1(TimeDelta::FromMilliseconds(150)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); ::testing::InSequence seq; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( WithArg<0>(sessions::test_util::SimulateThrottled(throttle1)), Return(true))) .RetiresOnSaturation(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), QuitLoopNowAction())); const ModelTypeSet types(BOOKMARKS); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, types, TypesToRoutingInfo(types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); EXPECT_FALSE(scheduler()->ScheduleConfiguration(params)); EXPECT_EQ(0, counter.times_called()); EXPECT_TRUE(scheduler()->IsCurrentlyThrottled()); RunLoop(); EXPECT_FALSE(scheduler()->IsCurrentlyThrottled()); StopSyncScheduler(); } TEST_F(SyncSchedulerTest, TypeThrottlingBlocksNudge) { UseMockDelayProvider(); EXPECT_CALL(*delay(), GetDelay(_)) .WillRepeatedly(Return(zero())); TimeDelta poll(TimeDelta::FromDays(1)); TimeDelta throttle1(TimeDelta::FromSeconds(60)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); const ModelTypeSet types(BOOKMARKS); ::testing::InSequence seq; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( WithArg<0>( sessions::test_util::SimulateTypesThrottled(types, throttle1)), Return(true))) .RetiresOnSaturation(); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge(zero(), types, FROM_HERE); PumpLoop(); EXPECT_TRUE(GetThrottledTypes().HasAll(types)); // This won't cause a sync cycle because the types are throttled. scheduler()->ScheduleLocalNudge(zero(), types, FROM_HERE); PumpLoop(); StopSyncScheduler(); } TEST_F(SyncSchedulerTest, TypeThrottlingDoesBlockOtherSources) { UseMockDelayProvider(); EXPECT_CALL(*delay(), GetDelay(_)) .WillRepeatedly(Return(zero())); SyncShareRecords records; TimeDelta poll(TimeDelta::FromDays(1)); TimeDelta throttle1(TimeDelta::FromSeconds(60)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); const ModelTypeSet throttled_types(BOOKMARKS); const ModelTypeSet unthrottled_types(PREFERENCES); ::testing::InSequence seq; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( WithArg<0>( sessions::test_util::SimulateTypesThrottled( throttled_types, throttle1)), Return(true))) .RetiresOnSaturation(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge(zero(), throttled_types, FROM_HERE); PumpLoop(); EXPECT_EQ(0U, records.snapshots.size()); EXPECT_TRUE(GetThrottledTypes().HasAll(throttled_types)); // Ignore invalidations for throttled types. ModelTypeInvalidationMap invalidation_map = ModelTypeSetToInvalidationMap(throttled_types, "test"); scheduler()->ScheduleInvalidationNudge(zero(), invalidation_map, FROM_HERE); PumpLoop(); EXPECT_EQ(0U, records.snapshots.size()); // Ignore refresh requests for throttled types. scheduler()->ScheduleLocalRefreshRequest(zero(), throttled_types, FROM_HERE); PumpLoop(); EXPECT_EQ(0U, records.snapshots.size()); // Local nudges for non-throttled types will trigger a sync. scheduler()->ScheduleLocalNudge(zero(), unthrottled_types, FROM_HERE); RunLoop(); EXPECT_EQ(1U, records.snapshots.size()); StopSyncScheduler(); } // Test nudges / polls don't run in config mode and config tasks do. TEST_F(SyncSchedulerTest, ConfigurationMode) { TimeDelta poll(TimeDelta::FromMilliseconds(15)); SyncShareRecords records; scheduler()->OnReceivedLongPollIntervalUpdate(poll); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records)))) .RetiresOnSaturation(); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); const ModelTypeSet nudge_types(AUTOFILL); scheduler()->ScheduleLocalNudge(zero(), nudge_types, FROM_HERE); scheduler()->ScheduleLocalNudge(zero(), nudge_types, FROM_HERE); const ModelTypeSet config_types(BOOKMARKS); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, config_types, TypesToRoutingInfo(config_types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); ASSERT_TRUE(scheduler()->ScheduleConfiguration(params)); ASSERT_EQ(1, counter.times_called()); ASSERT_EQ(1U, records.snapshots.size()); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( config_types, records.snapshots[0].source().types)); // Switch to NORMAL_MODE to ensure NUDGES were properly saved and run. // SyncSchedulerWhiteboxTest also provides coverage for this, but much // more targeted ('whitebox' style). scheduler()->OnReceivedLongPollIntervalUpdate(TimeDelta::FromDays(1)); SyncShareRecords records2; EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), WithArg<0>(RecordSyncShare(&records2)))); // TODO(tim): Figure out how to remove this dangerous need to reset // routing info between mode switches. context()->set_routing_info(routing_info()); StartSyncScheduler(SyncScheduler::NORMAL_MODE); ASSERT_EQ(1U, records2.snapshots.size()); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, records2.snapshots[0].source().updates_source); EXPECT_TRUE(ModelTypeSetMatchesInvalidationMap( nudge_types, records2.snapshots[0].source().types)); PumpLoop(); } class BackoffTriggersSyncSchedulerTest : public SyncSchedulerTest { virtual void SetUp() { SyncSchedulerTest::SetUp(); UseMockDelayProvider(); EXPECT_CALL(*delay(), GetDelay(_)) .WillRepeatedly(Return(TimeDelta::FromMilliseconds(1))); } virtual void TearDown() { StopSyncScheduler(); SyncSchedulerTest::TearDown(); } }; // Have the sycner fail during commit. Expect that the scheduler enters // backoff. TEST_F(BackoffTriggersSyncSchedulerTest, FailCommitOnce) { EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), QuitLoopNowAction())); EXPECT_TRUE(RunAndGetBackoff()); } // Have the syncer fail during download updates and succeed on the first // retry. Expect that this clears the backoff state. TEST_F(BackoffTriggersSyncSchedulerTest, FailDownloadOnceThenSucceed) { EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( Invoke(sessions::test_util::SimulateDownloadUpdatesFailed), Return(true))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), QuitLoopNowAction())); EXPECT_FALSE(RunAndGetBackoff()); } // Have the syncer fail during commit and succeed on the first retry. Expect // that this clears the backoff state. TEST_F(BackoffTriggersSyncSchedulerTest, FailCommitOnceThenSucceed) { EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( Invoke(sessions::test_util::SimulateCommitFailed), Return(true))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), QuitLoopNowAction())); EXPECT_FALSE(RunAndGetBackoff()); } // Have the syncer fail to download updates and fail again on the retry. // Expect this will leave the scheduler in backoff. TEST_F(BackoffTriggersSyncSchedulerTest, FailDownloadTwice) { EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( Invoke(sessions::test_util::SimulateDownloadUpdatesFailed), Return(true))) .WillRepeatedly(DoAll( Invoke(sessions::test_util::SimulateDownloadUpdatesFailed), QuitLoopNowAction())); EXPECT_TRUE(RunAndGetBackoff()); } // Have the syncer fail to get the encryption key yet succeed in downloading // updates. Expect this will leave the scheduler in backoff. TEST_F(BackoffTriggersSyncSchedulerTest, FailGetEncryptionKey) { EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll( Invoke(sessions::test_util::SimulateGetEncryptionKeyFailed), Return(true))) .WillRepeatedly(DoAll( Invoke(sessions::test_util::SimulateGetEncryptionKeyFailed), QuitLoopNowAction())); EXPECT_TRUE(RunAndGetBackoff()); } // Test that no polls or extraneous nudges occur when in backoff. TEST_F(SyncSchedulerTest, BackoffDropsJobs) { SyncShareRecords r; TimeDelta poll(TimeDelta::FromMilliseconds(5)); const ModelTypeSet types(BOOKMARKS); scheduler()->OnReceivedLongPollIntervalUpdate(poll); UseMockDelayProvider(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), RecordSyncShareMultiple(&r, 1U))); EXPECT_CALL(*delay(), GetDelay(_)). WillRepeatedly(Return(TimeDelta::FromDays(1))); StartSyncScheduler(SyncScheduler::NORMAL_MODE); // This nudge should fail and put us into backoff. Thanks to our mock // GetDelay() setup above, this will be a long backoff. scheduler()->ScheduleLocalNudge(zero(), types, FROM_HERE); RunLoop(); Mock::VerifyAndClearExpectations(syncer()); ASSERT_EQ(1U, r.snapshots.size()); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, r.snapshots[0].source().updates_source); // Wait a while (10x poll interval) so a few poll jobs will be attempted. PumpLoopFor(poll * 10); // Try (and fail) to schedule a nudge. scheduler()->ScheduleLocalNudge( base::TimeDelta::FromMilliseconds(1), types, FROM_HERE); Mock::VerifyAndClearExpectations(syncer()); Mock::VerifyAndClearExpectations(delay()); ASSERT_EQ(1U, r.snapshots.size()); EXPECT_CALL(*delay(), GetDelay(_)).Times(0); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, types, TypesToRoutingInfo(types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); ASSERT_FALSE(scheduler()->ScheduleConfiguration(params)); ASSERT_EQ(0, counter.times_called()); } // Test that backoff is shaping traffic properly with consecutive errors. TEST_F(SyncSchedulerTest, BackoffElevation) { SyncShareRecords r; UseMockDelayProvider(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)).Times(kMinNumSamples) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), RecordSyncShareMultiple(&r, kMinNumSamples))); const TimeDelta first = TimeDelta::FromSeconds(kInitialBackoffRetrySeconds); const TimeDelta second = TimeDelta::FromMilliseconds(2); const TimeDelta third = TimeDelta::FromMilliseconds(3); const TimeDelta fourth = TimeDelta::FromMilliseconds(4); const TimeDelta fifth = TimeDelta::FromMilliseconds(5); const TimeDelta sixth = TimeDelta::FromDays(1); EXPECT_CALL(*delay(), GetDelay(first)).WillOnce(Return(second)) .RetiresOnSaturation(); EXPECT_CALL(*delay(), GetDelay(second)).WillOnce(Return(third)) .RetiresOnSaturation(); EXPECT_CALL(*delay(), GetDelay(third)).WillOnce(Return(fourth)) .RetiresOnSaturation(); EXPECT_CALL(*delay(), GetDelay(fourth)).WillOnce(Return(fifth)) .RetiresOnSaturation(); EXPECT_CALL(*delay(), GetDelay(fifth)).WillOnce(Return(sixth)); StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run again with a nudge. scheduler()->ScheduleLocalNudge(zero(), ModelTypeSet(BOOKMARKS), FROM_HERE); RunLoop(); ASSERT_EQ(kMinNumSamples, r.snapshots.size()); EXPECT_GE(r.times[1] - r.times[0], second); EXPECT_GE(r.times[2] - r.times[1], third); EXPECT_GE(r.times[3] - r.times[2], fourth); EXPECT_GE(r.times[4] - r.times[3], fifth); } // Test that things go back to normal once a retry makes forward progress. TEST_F(SyncSchedulerTest, BackoffRelief) { SyncShareRecords r; const TimeDelta poll(TimeDelta::FromMilliseconds(10)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); UseMockDelayProvider(); const TimeDelta backoff = TimeDelta::FromMilliseconds(5); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), RecordSyncShareMultiple(&r, kMinNumSamples))) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateSuccess), RecordSyncShareMultiple(&r, kMinNumSamples))); EXPECT_CALL(*delay(), GetDelay(_)).WillOnce(Return(backoff)); // Optimal start for the post-backoff poll party. TimeTicks optimal_start = TimeTicks::Now(); StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run again to wait for polling. scheduler()->ScheduleLocalNudge(zero(), ModelTypeSet(BOOKMARKS), FROM_HERE); RunLoop(); StopSyncScheduler(); EXPECT_EQ(kMinNumSamples, r.times.size()); // The first nudge ran as soon as possible. It failed. TimeTicks optimal_job_time = optimal_start; EXPECT_GE(r.times[0], optimal_job_time); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, r.snapshots[0].source().updates_source); // It was followed by a successful retry nudge shortly afterward. optimal_job_time = optimal_job_time + backoff; EXPECT_GE(r.times[1], optimal_job_time); EXPECT_EQ(GetUpdatesCallerInfo::LOCAL, r.snapshots[1].source().updates_source); // After that, we went back to polling. for (size_t i = 2; i < r.snapshots.size(); i++) { optimal_job_time = optimal_job_time + poll; SCOPED_TRACE(testing::Message() << "SyncShare # (" << i << ")"); EXPECT_GE(r.times[i], optimal_job_time); EXPECT_EQ(GetUpdatesCallerInfo::PERIODIC, r.snapshots[i].source().updates_source); } } // Test that poll failures are ignored. They should have no effect on // subsequent poll attempts, nor should they trigger a backoff/retry. TEST_F(SyncSchedulerTest, TransientPollFailure) { SyncShareRecords r; const TimeDelta poll_interval(TimeDelta::FromMilliseconds(1)); scheduler()->OnReceivedLongPollIntervalUpdate(poll_interval); UseMockDelayProvider(); // Will cause test failure if backoff is initiated. EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateCommitFailed), RecordSyncShare(&r))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), RecordSyncShare(&r))); StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run the unsucessful poll. The failed poll should not trigger backoff. RunLoop(); EXPECT_FALSE(scheduler()->IsBackingOff()); // Run the successful poll. RunLoop(); EXPECT_FALSE(scheduler()->IsBackingOff()); } // Test that appropriate syncer steps are requested for each job type. TEST_F(SyncSchedulerTest, SyncerSteps) { // Nudges. EXPECT_CALL(*syncer(), SyncShare(_, SYNCER_BEGIN, SYNCER_END)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), Return(true))); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge(zero(), ModelTypeSet(BOOKMARKS), FROM_HERE); PumpLoop(); // Pump again to run job. PumpLoop(); StopSyncScheduler(); Mock::VerifyAndClearExpectations(syncer()); // Configuration. EXPECT_CALL(*syncer(), SyncShare(_, DOWNLOAD_UPDATES, APPLY_UPDATES)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), Return(true))); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); ModelTypeSet model_types(BOOKMARKS); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, model_types, TypesToRoutingInfo(model_types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); ASSERT_TRUE(scheduler()->ScheduleConfiguration(params)); ASSERT_EQ(1, counter.times_called()); // Runs directly so no need to pump the loop. StopSyncScheduler(); Mock::VerifyAndClearExpectations(syncer()); StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Poll. EXPECT_CALL(*syncer(), SyncShare(_, DOWNLOAD_UPDATES, APPLY_UPDATES)) .Times(AtLeast(1)) .WillRepeatedly(DoAll(Invoke(sessions::test_util::SimulateSuccess), QuitLoopNowAction())); const TimeDelta poll(TimeDelta::FromMilliseconds(10)); scheduler()->OnReceivedLongPollIntervalUpdate(poll); StartSyncScheduler(SyncScheduler::NORMAL_MODE); // Run again to wait for polling. RunLoop(); StopSyncScheduler(); Mock::VerifyAndClearExpectations(syncer()); } // Test that starting the syncer thread without a valid connection doesn't // break things when a connection is detected. TEST_F(SyncSchedulerTest, StartWhenNotConnected) { connection()->SetServerNotReachable(); connection()->UpdateConnectionStatus(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateConnectionFailure), Return(true))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), Return(true))); StartSyncScheduler(SyncScheduler::NORMAL_MODE); scheduler()->ScheduleLocalNudge(zero(), ModelTypeSet(BOOKMARKS), FROM_HERE); // Should save the nudge for until after the server is reachable. base::MessageLoop::current()->RunUntilIdle(); scheduler()->OnConnectionStatusChange(); connection()->SetServerReachable(); connection()->UpdateConnectionStatus(); base::MessageLoop::current()->RunUntilIdle(); } TEST_F(SyncSchedulerTest, ServerConnectionChangeDuringBackoff) { UseMockDelayProvider(); EXPECT_CALL(*delay(), GetDelay(_)) .WillRepeatedly(Return(TimeDelta::FromMilliseconds(0))); StartSyncScheduler(SyncScheduler::NORMAL_MODE); connection()->SetServerNotReachable(); connection()->UpdateConnectionStatus(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateConnectionFailure), Return(true))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), Return(true))); scheduler()->ScheduleLocalNudge(zero(), ModelTypeSet(BOOKMARKS), FROM_HERE); PumpLoop(); // Run the nudge, that will fail and schedule a quick retry. ASSERT_TRUE(scheduler()->IsBackingOff()); // Before we run the scheduled canary, trigger a server connection change. scheduler()->OnConnectionStatusChange(); connection()->SetServerReachable(); connection()->UpdateConnectionStatus(); base::MessageLoop::current()->RunUntilIdle(); } // This was supposed to test the scenario where we receive a nudge while a // connection change canary is scheduled, but has not run yet. Since we've made // the connection change canary synchronous, this is no longer possible. TEST_F(SyncSchedulerTest, ConnectionChangeCanaryPreemptedByNudge) { UseMockDelayProvider(); EXPECT_CALL(*delay(), GetDelay(_)) .WillRepeatedly(Return(TimeDelta::FromMilliseconds(0))); StartSyncScheduler(SyncScheduler::NORMAL_MODE); connection()->SetServerNotReachable(); connection()->UpdateConnectionStatus(); EXPECT_CALL(*syncer(), SyncShare(_,_,_)) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateConnectionFailure), Return(true))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), Return(true))) .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess), QuitLoopNowAction())); scheduler()->ScheduleLocalNudge(zero(), ModelTypeSet(BOOKMARKS), FROM_HERE); PumpLoop(); // Run the nudge, that will fail and schedule a quick retry. ASSERT_TRUE(scheduler()->IsBackingOff()); // Before we run the scheduled canary, trigger a server connection change. scheduler()->OnConnectionStatusChange(); connection()->SetServerReachable(); connection()->UpdateConnectionStatus(); scheduler()->ScheduleLocalNudge(zero(), ModelTypeSet(BOOKMARKS), FROM_HERE); base::MessageLoop::current()->RunUntilIdle(); } // Tests that we don't crash trying to run two canaries at once if we receive // extra connection status change notifications. See crbug.com/190085. TEST_F(SyncSchedulerTest, DoubleCanaryInConfigure) { EXPECT_CALL(*syncer(), SyncShare(_, DOWNLOAD_UPDATES, APPLY_UPDATES)) .WillRepeatedly(DoAll( Invoke(sessions::test_util::SimulateConnectionFailure), Return(true))); StartSyncScheduler(SyncScheduler::CONFIGURATION_MODE); connection()->SetServerNotReachable(); connection()->UpdateConnectionStatus(); ModelTypeSet model_types(BOOKMARKS); CallbackCounter counter; ConfigurationParams params( GetUpdatesCallerInfo::RECONFIGURATION, model_types, TypesToRoutingInfo(model_types), base::Bind(&CallbackCounter::Callback, base::Unretained(&counter))); scheduler()->ScheduleConfiguration(params); scheduler()->OnConnectionStatusChange(); scheduler()->OnConnectionStatusChange(); PumpLoop(); // Run the nudge, that will fail and schedule a quick retry. } } // namespace syncer