1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/launcher/launcher_model.h"
#include <set>
#include <string>
#include "ash/launcher/launcher_model_observer.h"
#include "base/stringprintf.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ash {
namespace {
// LauncherModelObserver implementation that tracks what message are invoked.
class TestLauncherModelObserver : public LauncherModelObserver {
public:
TestLauncherModelObserver()
: added_count_(0),
removed_count_(0),
changed_count_(0),
moved_count_(0) {
}
// Returns a string description of the changes that have occurred since this
// was last invoked. Resets state to initial state.
std::string StateStringAndClear() {
std::string result;
AddToResult("added=%d", added_count_, &result);
AddToResult("removed=%d", removed_count_, &result);
AddToResult("changed=%d", changed_count_, &result);
AddToResult("moved=%d", moved_count_, &result);
added_count_ = removed_count_ = changed_count_ = moved_count_ = 0;
return result;
}
// LauncherModelObserver overrides:
virtual void LauncherItemAdded(int index) OVERRIDE {
added_count_++;
}
virtual void LauncherItemRemoved(int index, LauncherID id) OVERRIDE {
removed_count_++;
}
virtual void LauncherItemChanged(int index,
const LauncherItem& old_item) OVERRIDE {
changed_count_++;
}
virtual void LauncherItemMoved(int start_index, int target_index) OVERRIDE {
moved_count_++;
}
virtual void LauncherStatusChanged() OVERRIDE {
}
private:
void AddToResult(const std::string& format, int count, std::string* result) {
if (!count)
return;
if (!result->empty())
*result += " ";
*result += base::StringPrintf(format.c_str(), count);
}
int added_count_;
int removed_count_;
int changed_count_;
int moved_count_;
DISALLOW_COPY_AND_ASSIGN(TestLauncherModelObserver);
};
} // namespace
TEST(LauncherModel, BasicAssertions) {
TestLauncherModelObserver observer;
LauncherModel model;
// Model is initially populated with two items.
EXPECT_EQ(2, model.item_count());
// Two initial items should have different ids.
EXPECT_NE(model.items()[0].id, model.items()[1].id);
// Add an item.
model.AddObserver(&observer);
LauncherItem item;
int index = model.Add(item);
EXPECT_EQ(3, model.item_count());
EXPECT_EQ("added=1", observer.StateStringAndClear());
// Verifies all the items get unique ids.
std::set<LauncherID> ids;
for (int i = 0; i < model.item_count(); ++i)
ids.insert(model.items()[i].id);
EXPECT_EQ(model.item_count(), static_cast<int>(ids.size()));
// Change a tabbed image.
LauncherID original_id = model.items()[index].id;
model.Set(index, LauncherItem());
EXPECT_EQ(original_id, model.items()[index].id);
EXPECT_EQ("changed=1", observer.StateStringAndClear());
EXPECT_EQ(TYPE_TABBED, model.items()[index].type);
// Remove the item.
model.RemoveItemAt(index);
EXPECT_EQ(2, model.item_count());
EXPECT_EQ("removed=1", observer.StateStringAndClear());
// Add an app item.
item.type = TYPE_APP_SHORTCUT;
index = model.Add(item);
observer.StateStringAndClear();
// Change everything.
model.Set(index, item);
EXPECT_EQ("changed=1", observer.StateStringAndClear());
EXPECT_EQ(TYPE_APP_SHORTCUT, model.items()[index].type);
// Add another item.
item.type = TYPE_APP_SHORTCUT;
model.Add(item);
observer.StateStringAndClear();
// Move the third to the second.
model.Move(2, 1);
EXPECT_EQ("moved=1", observer.StateStringAndClear());
// And back.
model.Move(1, 2);
EXPECT_EQ("moved=1", observer.StateStringAndClear());
}
// Assertions around where items are added.
TEST(LauncherModel, AddIndices) {
TestLauncherModelObserver observer;
LauncherModel model;
// Model is initially populated with two items.
EXPECT_EQ(2, model.item_count());
// Two initial items should have different ids.
EXPECT_NE(model.items()[0].id, model.items()[1].id);
// Items come after the browser.
int browser = 0;
ASSERT_EQ(ash::TYPE_BROWSER_SHORTCUT, model.items()[browser].type);
// Tabbed items should be after shortcut.
LauncherItem item;
int tabbed_index1 = model.Add(item);
EXPECT_EQ(browser + 1, tabbed_index1);
// Add another tabbed item, it should follow first.
int tabbed_index2 = model.Add(item);
EXPECT_EQ(browser + 2, tabbed_index2);
// APP_SHORTCUT preceed browsers.
item.type = TYPE_APP_SHORTCUT;
int app_shortcut_index1 = model.Add(item);
EXPECT_EQ(browser + 1, app_shortcut_index1);
item.type = TYPE_APP_SHORTCUT;
int app_shortcut_index2 = model.Add(item);
EXPECT_EQ(browser + 2, app_shortcut_index2);
// Check that AddAt() figures out the correct indexes for app shortcuts.
item.type = TYPE_APP_SHORTCUT;
int app_shortcut_index3 = model.AddAt(0, item);
EXPECT_EQ(browser + 1, app_shortcut_index3);
item.type = TYPE_APP_SHORTCUT;
int app_shortcut_index4 = model.AddAt(5, item);
EXPECT_EQ(browser + 4, app_shortcut_index4);
item.type = TYPE_APP_SHORTCUT;
int app_shortcut_index5 = model.AddAt(2, item);
EXPECT_EQ(browser + 2, app_shortcut_index5);
// Before there are any panels, no icons should be right aligned.
EXPECT_EQ(model.item_count(), model.FirstPanelIndex());
// Check that AddAt() figures out the correct indexes for tabs and panels.
item.type = TYPE_TABBED;
int tabbed_index3 = model.AddAt(2, item);
EXPECT_EQ(browser + 6, tabbed_index3);
item.type = TYPE_APP_PANEL;
int app_panel_index1 = model.AddAt(2, item);
EXPECT_EQ(browser + 10, app_panel_index1);
item.type = TYPE_TABBED;
int tabbed_index4 = model.AddAt(11, item);
EXPECT_EQ(browser + 9, tabbed_index4);
item.type = TYPE_APP_PANEL;
int app_panel_index2 = model.AddAt(12, item);
EXPECT_EQ(browser + 12, app_panel_index2);
item.type = TYPE_TABBED;
int tabbed_index5 = model.AddAt(7, item);
EXPECT_EQ(browser + 7, tabbed_index5);
item.type = TYPE_APP_PANEL;
int app_panel_index3 = model.AddAt(13, item);
EXPECT_EQ(browser + 13, app_panel_index3);
// Right aligned index should be the first app panel index.
EXPECT_EQ(browser + 12, model.FirstPanelIndex());
// Browser shortcut and app list should still be first and second.
EXPECT_EQ(TYPE_BROWSER_SHORTCUT, model.items()[0].type);
EXPECT_EQ(TYPE_APP_LIST, model.items()[model.FirstPanelIndex() - 1].type);
}
// Assertions around id generation and usage.
TEST(LauncherModel, LauncherIDTests) {
TestLauncherModelObserver observer;
LauncherModel model;
EXPECT_EQ(2, model.item_count());
// Get the next to use ID counter.
LauncherID id = model.next_id();
// Calling this function multiple times does not change the returned ID.
EXPECT_EQ(model.next_id(), id);
// Check that when we reserve a value it will be the previously retrieved ID,
// but it will not change the item count and retrieving the next ID should
// produce something new.
EXPECT_EQ(model.reserve_external_id(), id);
EXPECT_EQ(2, model.item_count());
LauncherID id2 = model.next_id();
EXPECT_NE(id2, id);
// Adding another item to the list should also produce a new ID.
LauncherItem item;
item.type = TYPE_TABBED;
model.Add(item);
EXPECT_NE(model.next_id(), id2);
}
} // namespace ash
|
