1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "apps/shell_window_geometry_cache.h"
#include "chrome/browser/apps/app_browsertest_util.h"
#include "chrome/browser/extensions/extension_test_message_listener.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/extensions/application_launch.h"
#include "content/public/browser/notification_service.h"
#include "content/public/test/test_utils.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
using apps::ShellWindowGeometryCache;
// This helper class can be used to wait for changes in the shell window
// geometry cache registry for a specific window in a specific extension.
class GeometryCacheChangeHelper : ShellWindowGeometryCache::Observer {
public:
GeometryCacheChangeHelper(ShellWindowGeometryCache* cache,
const std::string& extension_id,
const std::string& window_id,
const gfx::Rect& bounds)
: cache_(cache),
extension_id_(extension_id),
window_id_(window_id),
bounds_(bounds),
satisfied_(false),
waiting_(false) {
cache_->AddObserver(this);
}
// This method will block until the shell window geometry cache registry will
// provide a bound for |window_id_| that is entirely different (as in x/y/w/h)
// from the initial |bounds_|.
void WaitForEntirelyChanged() {
if (satisfied_)
return;
waiting_ = true;
content::RunMessageLoop();
}
// Implements the content::NotificationObserver interface.
virtual void OnGeometryCacheChanged(const std::string& extension_id,
const std::string& window_id,
const gfx::Rect& bounds)
OVERRIDE {
if (extension_id != extension_id_ || window_id != window_id_)
return;
if (bounds_.x() != bounds.x() &&
bounds_.y() != bounds.y() &&
bounds_.width() != bounds.width() &&
bounds_.height() != bounds.height()) {
satisfied_ = true;
cache_->RemoveObserver(this);
if (waiting_)
base::MessageLoopForUI::current()->Quit();
}
}
private:
ShellWindowGeometryCache* cache_;
std::string extension_id_;
std::string window_id_;
gfx::Rect bounds_;
bool satisfied_;
bool waiting_;
};
// Helper class for tests related to the Apps Window API (chrome.app.window).
class AppWindowAPITest : public extensions::PlatformAppBrowserTest {
protected:
bool RunAppWindowAPITest(const char* testName) {
if (!BeginAppWindowAPITest(testName))
return false;
ResultCatcher catcher;
if (!catcher.GetNextResult()) {
message_ = catcher.message();
return false;
}
return true;
}
bool RunAppWindowAPITestAndWaitForRoundTrip(const char* testName) {
if (!BeginAppWindowAPITest(testName))
return false;
ExtensionTestMessageListener round_trip_listener("WaitForRoundTrip", true);
if (!round_trip_listener.WaitUntilSatisfied()) {
message_ = "Did not get the 'WaitForRoundTrip' message.";
return false;
}
round_trip_listener.Reply("");
ResultCatcher catcher;
if (!catcher.GetNextResult()) {
message_ = catcher.message();
return false;
}
return true;
}
private:
bool BeginAppWindowAPITest(const char* testName) {
ExtensionTestMessageListener launched_listener("Launched", true);
LoadAndLaunchPlatformApp("window_api");
if (!launched_listener.WaitUntilSatisfied()) {
message_ = "Did not get the 'Launched' message.";
return false;
}
launched_listener.Reply(testName);
return true;
}
};
// These tests are flaky after https://codereview.chromium.org/57433010/.
// See http://crbug.com/319613.
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, DISABLED_TestCreate) {
ASSERT_TRUE(RunAppWindowAPITest("testCreate")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, TestSingleton) {
ASSERT_TRUE(RunAppWindowAPITest("testSingleton")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, DISABLED_TestBounds) {
ASSERT_TRUE(RunAppWindowAPITest("testBounds")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, TestCloseEvent) {
ASSERT_TRUE(RunAppWindowAPITest("testCloseEvent")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, DISABLED_TestMaximize) {
ASSERT_TRUE(RunAppWindowAPITest("testMaximize")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, DISABLED_TestRestore) {
ASSERT_TRUE(RunAppWindowAPITest("testRestore")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, DISABLED_TestRestoreAfterClose) {
ASSERT_TRUE(RunAppWindowAPITest("testRestoreAfterClose")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, DISABLED_TestSizeConstraints) {
ASSERT_TRUE(RunAppWindowAPITest("testSizeConstraints")) << message_;
}
// Flaky failures on mac_rel and WinXP, see http://crbug.com/324915.
IN_PROC_BROWSER_TEST_F(AppWindowAPITest,
DISABLED_TestRestoreGeometryCacheChange) {
// This test is similar to the other AppWindowAPI tests except that at some
// point the app will send a 'ListenGeometryChange' message at which point the
// test will check if the geometry cache entry for the test window has
// changed. When the change happens, the test will let the app know so it can
// continue running.
ExtensionTestMessageListener launched_listener("Launched", true);
content::WindowedNotificationObserver app_loaded_observer(
content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
content::NotificationService::AllSources());
const extensions::Extension* extension = LoadExtension(
test_data_dir_.AppendASCII("platform_apps").AppendASCII("window_api"));
EXPECT_TRUE(extension);
OpenApplication(AppLaunchParams(browser()->profile(),
extension,
extensions::LAUNCH_CONTAINER_NONE,
NEW_WINDOW));
ExtensionTestMessageListener geometry_listener("ListenGeometryChange", true);
ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
launched_listener.Reply("testRestoreAfterGeometryCacheChange");
ASSERT_TRUE(geometry_listener.WaitUntilSatisfied());
GeometryCacheChangeHelper geo_change_helper_1(
ShellWindowGeometryCache::Get(browser()->profile()), extension->id(),
// The next line has information that has to stay in sync with the app.
"test-ra", gfx::Rect(200, 200, 200, 200));
GeometryCacheChangeHelper geo_change_helper_2(
ShellWindowGeometryCache::Get(browser()->profile()), extension->id(),
// The next line has information that has to stay in sync with the app.
"test-rb", gfx::Rect(200, 200, 200, 200));
// These calls will block until the shell window geometry cache will change.
geo_change_helper_1.WaitForEntirelyChanged();
geo_change_helper_2.WaitForEntirelyChanged();
ResultCatcher catcher;
geometry_listener.Reply("");
ASSERT_TRUE(catcher.GetNextResult());
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, TestBadging) {
ASSERT_TRUE(
RunAppWindowAPITestAndWaitForRoundTrip("testBadging")) << message_;
}
|
