1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
|
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/autocomplete/autocomplete_edit_view_mac.h"
#include "base/sys_string_conversions.h"
#include "chrome/browser/autocomplete/autocomplete_edit.h"
#include "chrome/browser/autocomplete/autocomplete_popup_model.h"
#include "chrome/browser/autocomplete/autocomplete_popup_view_mac.h"
#include "chrome/browser/tab_contents/tab_contents.h"
namespace {
// Store's the model and view state across tab switches.
struct AutocompleteEditViewMacState {
AutocompleteEditViewMacState(const AutocompleteEditModel::State model_state,
const bool has_focus, const NSRange& selection)
: model_state(model_state),
has_focus(has_focus),
selection(selection) {
}
const AutocompleteEditModel::State model_state;
const bool has_focus;
const NSRange selection;
};
// Returns a lazily initialized property bag accessor for saving our
// state in a TabContents.
PropertyAccessor<AutocompleteEditViewMacState>* GetStateAccessor() {
static PropertyAccessor<AutocompleteEditViewMacState> state;
return &state;
}
// Accessors for storing and getting the state from the tab.
void StoreStateToTab(TabContents* tab,
const AutocompleteEditViewMacState& state) {
GetStateAccessor()->SetProperty(tab->property_bag(), state);
}
const AutocompleteEditViewMacState* GetStateFromTab(const TabContents* tab) {
return GetStateAccessor()->GetProperty(tab->property_bag());
}
} // namespace
// Thin Obj-C bridge class that is the delegate of the omnibox field.
// It intercepts various control delegate methods and vectors them to
// the edit view.
@interface AutocompleteFieldDelegate : NSObject {
@private
AutocompleteEditViewMac* edit_view_; // weak, owns us.
}
- initWithEditView:(AutocompleteEditViewMac*)view;
@end
AutocompleteEditViewMac::AutocompleteEditViewMac(
AutocompleteEditController* controller,
ToolbarModel* toolbar_model,
Profile* profile,
CommandUpdater* command_updater,
NSTextField* field)
: model_(new AutocompleteEditModel(this, controller, profile)),
popup_view_(new AutocompletePopupViewMac(this, model_.get(), profile,
field)),
controller_(controller),
toolbar_model_(toolbar_model),
command_updater_(command_updater),
field_(field),
edit_helper_([[AutocompleteFieldDelegate alloc] initWithEditView:this]) {
DCHECK(controller);
DCHECK(toolbar_model);
DCHECK(profile);
DCHECK(command_updater);
DCHECK(field);
[field_ setDelegate:edit_helper_];
}
AutocompleteEditViewMac::~AutocompleteEditViewMac() {
// TODO(shess): Having to be aware of destructor ordering in this
// way seems brittle. There must be a better way.
// Destroy popup view before this object in case it tries to call us
// back in the destructor. Likewise for destroying the model before
// this object.
popup_view_.reset();
model_.reset();
// Disconnect field_ from edit_helper_ so that we don't get calls
// after destruction.
[field_ setDelegate:nil];
}
void AutocompleteEditViewMac::SaveStateToTab(TabContents* tab) {
DCHECK(tab);
NSRange range;
if (model_->has_focus()) {
range = GetSelectedRange();
} else {
// If we are not focussed, there is no selection. Manufacture
// something reasonable in case it starts to matter in the future.
range = NSMakeRange(0, [[field_ stringValue] length]);
}
AutocompleteEditViewMacState state(model_->GetStateForTabSwitch(),
model_->has_focus(), range);
StoreStateToTab(tab, state);
}
void AutocompleteEditViewMac::Update(
const TabContents* tab_for_state_restoring) {
// TODO(shess): It seems like if the tab is non-NULL, then this code
// shouldn't need to be called at all. When coded that way, I find
// that the field isn't always updated correctly. Figure out why
// this is. Maybe this method should be refactored into more
// specific cases.
const std::wstring text = toolbar_model_->GetText();
const bool user_visible = model_->UpdatePermanentText(text);
if (tab_for_state_restoring) {
RevertAll();
const AutocompleteEditViewMacState* state =
GetStateFromTab(tab_for_state_restoring);
if (state) {
// Should restore the user's text via SetUserText().
model_->RestoreState(state->model_state);
// Restore user's selection.
// TODO(shess): The model_ does not restore the focus state. If
// field_ was in focus when we switched away, I presume it
// should be in focus when we switch back. Figure out if model_
// not restoring focus is an oversight, or intentional for some
// subtle reason.
if (state->has_focus) {
FocusLocation();
DCHECK([field_ currentEditor]);
[[field_ currentEditor] setSelectedRange:state->selection];
}
}
} else if (user_visible) {
// Restore everything to the baseline look.
RevertAll();
// TODO(shess): Figure out how this case is used, to make sure
// we're getting the selection and popup right.
} else {
// TODO(shess): Figure out how this case is used, to make sure
// we're getting the selection and popup right.
// UpdateAndStyleText() approximates the inner part of Revertall()
// which under GTK is called EmphasizeURLComponents(), and is
// expected to change when I start feeding in the styling code.
UpdateAndStyleText(text, 0);
}
}
void AutocompleteEditViewMac::OpenURL(const GURL& url,
WindowOpenDisposition disposition,
PageTransition::Type transition,
const GURL& alternate_nav_url,
size_t selected_line,
const std::wstring& keyword) {
// TODO(shess): Why is the caller passing an invalid url in the
// first place? Make sure that case isn't being dropped on the
// floor.
if (!url.is_valid()) {
return;
}
model_->SendOpenNotification(selected_line, keyword);
if (disposition != NEW_BACKGROUND_TAB)
RevertAll(); // Revert the box to its unedited state.
controller_->OnAutocompleteAccept(url, disposition, transition,
alternate_nav_url);
}
std::wstring AutocompleteEditViewMac::GetText() const {
return base::SysNSStringToWide([field_ stringValue]);
}
void AutocompleteEditViewMac::SetUserText(const std::wstring& text,
const std::wstring& display_text,
bool update_popup) {
model_->SetUserText(text);
UpdateAndStyleText(display_text, display_text.size());
if (update_popup) {
UpdatePopup();
}
}
NSRange AutocompleteEditViewMac::GetSelectedRange() const {
DCHECK([field_ currentEditor]);
return [[field_ currentEditor] selectedRange];
}
void AutocompleteEditViewMac::SetWindowTextAndCaretPos(const std::wstring& text,
size_t caret_pos) {
UpdateAndStyleText(text, text.size());
}
void AutocompleteEditViewMac::SelectAll(bool reversed) {
// TODO(shess): Figure out what reversed implies. The gtk version
// has it imply inverting the selection front to back, but I don't
// even know if that makes sense for Mac.
UpdateAndStyleText(GetText(), 0);
}
void AutocompleteEditViewMac::RevertAll() {
ClosePopup();
model_->Revert();
std::wstring tt = GetText();
UpdateAndStyleText(tt, 0);
controller_->OnChanged();
}
void AutocompleteEditViewMac::UpdatePopup() {
model_->SetInputInProgress(true);
if (!model_->has_focus())
return;
// TODO(shess):
// Shouldn't inline autocomplete when the caret/selection isn't at
// the end of the text.
//
// One option would seem to be to check for a non-nil field
// editor, and check it's selected range against its length.
model_->StartAutocomplete(false);
}
void AutocompleteEditViewMac::ClosePopup() {
popup_view_->GetModel()->StopAutocomplete();
}
void AutocompleteEditViewMac::UpdateAndStyleText(
const std::wstring& display_text, size_t user_text_length) {
NSString* ss = base::SysWideToNSString(display_text);
NSMutableAttributedString* as =
[[[NSMutableAttributedString alloc] initWithString:ss] autorelease];
url_parse::Parsed parts;
AutocompleteInput::Parse(display_text, model_->GetDesiredTLD(),
&parts, NULL);
bool emphasize = model_->CurrentTextIsURL() && (parts.host.len > 0);
if (emphasize) {
// TODO(shess): Pull color out as a constant.
[as addAttribute:NSForegroundColorAttributeName
value:[NSColor greenColor]
range:NSMakeRange((NSInteger)parts.host.begin,
(NSInteger)parts.host.len)];
}
// TODO(shess): GTK has this as a member var, figure out why.
ToolbarModel::SecurityLevel scheme_security_level =
toolbar_model_->GetSchemeSecurityLevel();
// Emphasize the scheme for security UI display purposes (if necessary).
if (!model_->user_input_in_progress() && parts.scheme.is_nonempty() &&
(scheme_security_level != ToolbarModel::NORMAL)) {
// TODO(shess): Pull colors out as constants.
NSColor* color;
if (scheme_security_level == ToolbarModel::SECURE) {
color = [NSColor blueColor];
} else {
color = [NSColor blackColor];
}
[as addAttribute:NSForegroundColorAttributeName value:color
range:NSMakeRange((NSInteger)parts.scheme.begin,
(NSInteger)parts.scheme.len)];
}
// TODO(shess): Check that this updates the model's sense of focus
// correctly.
[field_ setObjectValue:as];
if (![field_ currentEditor]) {
[field_ becomeFirstResponder];
DCHECK_EQ([field_ currentEditor], [[field_ window] firstResponder]);
}
NSRange selected_range = NSMakeRange(user_text_length, [as length]);
// TODO(shess): What if it didn't get first responder, and there is
// no field editor? This will do nothing. Well, at least it won't
// crash. Think of something more productive to do, or prove that
// it cannot occur and DCHECK appropriately.
[[field_ currentEditor] setSelectedRange:selected_range];
}
void AutocompleteEditViewMac::OnTemporaryTextMaybeChanged(
const std::wstring& display_text, bool save_original_selection) {
// TODO(shess): I believe this is for when the user arrows around
// the popup, will be restored if they hit escape. Figure out if
// that is for certain it.
if (save_original_selection) {
saved_temporary_text_ = GetText();
}
UpdateAndStyleText(display_text, display_text.size());
}
bool AutocompleteEditViewMac::OnInlineAutocompleteTextMaybeChanged(
const std::wstring& display_text, size_t user_text_length) {
// TODO(shess): Make sure that this actually works. The round trip
// to native form and back may mean that it's the same but not the
// same.
if (display_text == GetText()) {
return false;
}
UpdateAndStyleText(display_text, user_text_length);
return true;
}
void AutocompleteEditViewMac::OnRevertTemporaryText() {
UpdateAndStyleText(saved_temporary_text_, saved_temporary_text_.size());
saved_temporary_text_.clear();
}
void AutocompleteEditViewMac::OnBeforePossibleChange() {
selection_before_change_ = GetSelectedRange();
text_before_change_ = GetText();
}
bool AutocompleteEditViewMac::OnAfterPossibleChange() {
NSRange new_selection(GetSelectedRange());
std::wstring new_text(GetText());
const size_t length = new_text.length();
bool selection_differs = !NSEqualRanges(new_selection,
selection_before_change_);
bool at_end_of_edit = (length == new_selection.location);
bool text_differs = (new_text != text_before_change_);
// When the user has deleted text, we don't allow inline
// autocomplete. This is assumed if the text has gotten shorter AND
// the selection has shifted towards the front of the text. During
// normal typing the text will almost always be shorter (as the new
// input replaces the autocomplete suggestion), but in that case the
// selection point will have moved towards the end of the text.
// TODO(shess): In our implementation, we can catch -deleteBackward:
// and other methods to provide positive knowledge that a delete
// occured, rather than intuiting it from context. Consider whether
// that would be a stronger approach.
bool just_deleted_text =
(length < text_before_change_.length() &&
new_selection.location <= selection_before_change_.location);
bool something_changed = model_->OnAfterPossibleChange(new_text,
selection_differs, text_differs, just_deleted_text, at_end_of_edit);
// TODO(shess): Restyle the text if something_changed. Not fixing
// now because styling is currently broken.
return something_changed;
}
void AutocompleteEditViewMac::OnUpOrDownKeyPressed(bool up, bool by_page) {
int count = by_page ? model_->result().size() : 1;
model_->OnUpOrDownKeyPressed(up ? -count : count);
}
void AutocompleteEditViewMac::OnEscapeKeyPressed() {
model_->OnEscapeKeyPressed();
}
void AutocompleteEditViewMac::OnSetFocus(bool f) {
model_->OnSetFocus(f);
}
void AutocompleteEditViewMac::OnKillFocus() {
model_->OnKillFocus();
}
void AutocompleteEditViewMac::AcceptInput(
WindowOpenDisposition disposition, bool for_drop) {
model_->AcceptInput(disposition, for_drop);
}
void AutocompleteEditViewMac::FocusLocation() {
// -makeFirstResponder: will select the entire field_. If we're
// already firstResponder, it's likely that we want to retain the
// current selection.
if (![field_ currentEditor]) {
[[field_ window] makeFirstResponder:field_];
}
}
@implementation AutocompleteFieldDelegate
- initWithEditView:(AutocompleteEditViewMac*)view {
self = [super init];
if (self) {
edit_view_ = view;
}
return self;
}
- (BOOL)control:(NSControl*)control
textView:(NSTextView*)textView doCommandBySelector:(SEL)cmd {
if (cmd == @selector(moveDown:)) {
edit_view_->OnUpOrDownKeyPressed(false, false);
return YES;
}
if (cmd == @selector(moveUp:)) {
edit_view_->OnUpOrDownKeyPressed(true, false);
return YES;
}
if (cmd == @selector(scrollPageDown:)) {
edit_view_->OnUpOrDownKeyPressed(false, true);
return YES;
}
if (cmd == @selector(scrollPageUp:)) {
edit_view_->OnUpOrDownKeyPressed(true, true);
return YES;
}
if (cmd == @selector(cancelOperation:)) {
edit_view_->OnEscapeKeyPressed();
return YES;
}
if (cmd == @selector(insertNewline:)) {
edit_view_->AcceptInput(CURRENT_TAB, false);
return YES;
}
// Capture the state before the operation changes the content.
// TODO(shess): Determine if this is always redundent WRT the call
// in -controlTextDidChange:.
edit_view_->OnBeforePossibleChange();
return NO;
}
- (void)controlTextDidBeginEditing:(NSNotification*)aNotification {
edit_view_->OnSetFocus(false);
// Capture the current state.
edit_view_->OnBeforePossibleChange();
}
- (void)controlTextDidChange:(NSNotification*)aNotification {
// Figure out what changed and notify the model_.
edit_view_->OnAfterPossibleChange();
// Then capture the new state.
edit_view_->OnBeforePossibleChange();
}
- (void)controlTextDidEndEditing:(NSNotification*)aNotification {
edit_view_->OnKillFocus();
// TODO(shess): Figure out where the selection belongs. On GTK,
// it's set to the start of the text.
}
@end
|