1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include <vector>
#include "base/message_loop/message_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/bookmarks/base_bookmark_model_observer.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_node_data.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/clipboard/clipboard.h"
#include "ui/base/clipboard/scoped_clipboard_writer.h"
using base::ASCIIToUTF16;
using std::string;
namespace bookmark_utils {
namespace {
class BookmarkUtilsTest : public testing::Test,
public BaseBookmarkModelObserver {
public:
BookmarkUtilsTest()
: grouped_changes_beginning_count_(0),
grouped_changes_ended_count_(0) {}
virtual ~BookmarkUtilsTest() {}
virtual void TearDown() OVERRIDE {
ui::Clipboard::DestroyClipboardForCurrentThread();
}
// Certain user actions require multiple changes to the bookmark model,
// however these modifications need to be atomic for the undo framework. The
// BaseBookmarkModelObserver is used to inform the boundaries of the user
// action. For example, when multiple bookmarks are cut to the clipboard we
// expect one call each to GroupedBookmarkChangesBeginning/Ended.
void ExpectGroupedChangeCount(int expected_beginning_count,
int expected_ended_count) {
// The undo framework is not used under Android. Thus the group change
// events will not be fired and so should not be tested for Android.
#if !defined(OS_ANDROID)
EXPECT_EQ(grouped_changes_beginning_count_, expected_beginning_count);
EXPECT_EQ(grouped_changes_ended_count_, expected_ended_count);
#endif
}
private:
// BaseBookmarkModelObserver:
virtual void BookmarkModelChanged() OVERRIDE {}
virtual void GroupedBookmarkChangesBeginning(BookmarkModel* model) OVERRIDE {
++grouped_changes_beginning_count_;
}
virtual void GroupedBookmarkChangesEnded(BookmarkModel* model) OVERRIDE {
++grouped_changes_ended_count_;
}
int grouped_changes_beginning_count_;
int grouped_changes_ended_count_;
// Clipboard requires a message loop.
base::MessageLoopForUI loop_;
DISALLOW_COPY_AND_ASSIGN(BookmarkUtilsTest);
};
TEST_F(BookmarkUtilsTest, GetBookmarksMatchingPropertiesWordPhraseQuery) {
BookmarkModel model(NULL);
const BookmarkNode* node1 = model.AddURL(model.other_node(),
0,
ASCIIToUTF16("foo bar"),
GURL("http://www.google.com"));
const BookmarkNode* node2 = model.AddURL(model.other_node(),
0,
ASCIIToUTF16("baz buz"),
GURL("http://www.cnn.com"));
const BookmarkNode* folder1 = model.AddFolder(model.other_node(),
0,
ASCIIToUTF16("foo"));
std::vector<const BookmarkNode*> nodes;
QueryFields query;
query.word_phrase_query.reset(new base::string16);
// No nodes are returned for empty string.
*query.word_phrase_query = ASCIIToUTF16("");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
EXPECT_TRUE(nodes.empty());
nodes.clear();
// No nodes are returned for space-only string.
*query.word_phrase_query = ASCIIToUTF16(" ");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
EXPECT_TRUE(nodes.empty());
nodes.clear();
// Node "foo bar" and folder "foo" are returned in search results.
*query.word_phrase_query = ASCIIToUTF16("foo");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(2U, nodes.size());
EXPECT_TRUE(nodes[0] == folder1);
EXPECT_TRUE(nodes[1] == node1);
nodes.clear();
// Ensure url matches return in search results.
*query.word_phrase_query = ASCIIToUTF16("cnn");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(1U, nodes.size());
EXPECT_TRUE(nodes[0] == node2);
nodes.clear();
// Ensure folder "foo" is not returned in more specific search.
*query.word_phrase_query = ASCIIToUTF16("foo bar");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(1U, nodes.size());
EXPECT_TRUE(nodes[0] == node1);
nodes.clear();
// Bookmark Bar and Other Bookmarks are not returned in search results.
*query.word_phrase_query = ASCIIToUTF16("Bookmark");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(0U, nodes.size());
nodes.clear();
}
// Check exact matching against a URL query.
TEST_F(BookmarkUtilsTest, GetBookmarksMatchingPropertiesUrl) {
BookmarkModel model(NULL);
const BookmarkNode* node1 = model.AddURL(model.other_node(),
0,
ASCIIToUTF16("Google"),
GURL("https://www.google.com/"));
model.AddURL(model.other_node(),
0,
ASCIIToUTF16("Google Calendar"),
GURL("https://www.google.com/calendar"));
model.AddFolder(model.other_node(), 0, ASCIIToUTF16("Folder"));
std::vector<const BookmarkNode*> nodes;
QueryFields query;
query.url.reset(new base::string16);
*query.url = ASCIIToUTF16("https://www.google.com/");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(1U, nodes.size());
EXPECT_TRUE(nodes[0] == node1);
nodes.clear();
*query.url = ASCIIToUTF16("calendar");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(0U, nodes.size());
nodes.clear();
// Empty URL should not match folders.
*query.url = ASCIIToUTF16("");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(0U, nodes.size());
nodes.clear();
}
// Check exact matching against a title query.
TEST_F(BookmarkUtilsTest, GetBookmarksMatchingPropertiesTitle) {
BookmarkModel model(NULL);
const BookmarkNode* node1 = model.AddURL(model.other_node(),
0,
ASCIIToUTF16("Google"),
GURL("https://www.google.com/"));
model.AddURL(model.other_node(),
0,
ASCIIToUTF16("Google Calendar"),
GURL("https://www.google.com/calendar"));
const BookmarkNode* folder1 =
model.AddFolder(model.other_node(), 0, ASCIIToUTF16("Folder"));
std::vector<const BookmarkNode*> nodes;
QueryFields query;
query.title.reset(new base::string16);
*query.title = ASCIIToUTF16("Google");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(1U, nodes.size());
EXPECT_TRUE(nodes[0] == node1);
nodes.clear();
*query.title = ASCIIToUTF16("Calendar");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(0U, nodes.size());
nodes.clear();
// Title should match folders.
*query.title = ASCIIToUTF16("Folder");
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(1U, nodes.size());
EXPECT_TRUE(nodes[0] == folder1);
nodes.clear();
}
// Check matching against a query with multiple predicates.
TEST_F(BookmarkUtilsTest, GetBookmarksMatchingPropertiesConjunction) {
BookmarkModel model(NULL);
const BookmarkNode* node1 = model.AddURL(model.other_node(),
0,
ASCIIToUTF16("Google"),
GURL("https://www.google.com/"));
model.AddURL(model.other_node(),
0,
ASCIIToUTF16("Google Calendar"),
GURL("https://www.google.com/calendar"));
model.AddFolder(model.other_node(), 0, ASCIIToUTF16("Folder"));
std::vector<const BookmarkNode*> nodes;
QueryFields query;
// Test all fields matching.
query.word_phrase_query.reset(new base::string16(ASCIIToUTF16("www")));
query.url.reset(new base::string16(ASCIIToUTF16("https://www.google.com/")));
query.title.reset(new base::string16(ASCIIToUTF16("Google")));
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(1U, nodes.size());
EXPECT_TRUE(nodes[0] == node1);
nodes.clear();
scoped_ptr<base::string16>* fields[] = {
&query.word_phrase_query, &query.url, &query.title };
// Test two fields matching.
for (size_t i = 0; i < arraysize(fields); i++) {
scoped_ptr<base::string16> original_value(fields[i]->release());
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(1U, nodes.size());
EXPECT_TRUE(nodes[0] == node1);
nodes.clear();
fields[i]->reset(original_value.release());
}
// Test two fields matching with one non-matching field.
for (size_t i = 0; i < arraysize(fields); i++) {
scoped_ptr<base::string16> original_value(fields[i]->release());
fields[i]->reset(new base::string16(ASCIIToUTF16("fjdkslafjkldsa")));
GetBookmarksMatchingProperties(&model, query, 100, string(), &nodes);
ASSERT_EQ(0U, nodes.size());
nodes.clear();
fields[i]->reset(original_value.release());
}
}
TEST_F(BookmarkUtilsTest, CopyPaste) {
BookmarkModel model(NULL);
const BookmarkNode* node = model.AddURL(model.other_node(),
0,
ASCIIToUTF16("foo bar"),
GURL("http://www.google.com"));
// Copy a node to the clipboard.
std::vector<const BookmarkNode*> nodes;
nodes.push_back(node);
CopyToClipboard(&model, nodes, false);
// And make sure we can paste a bookmark from the clipboard.
EXPECT_TRUE(CanPasteFromClipboard(model.bookmark_bar_node()));
// Write some text to the clipboard.
{
ui::ScopedClipboardWriter clipboard_writer(
ui::Clipboard::GetForCurrentThread(),
ui::CLIPBOARD_TYPE_COPY_PASTE);
clipboard_writer.WriteText(ASCIIToUTF16("foo"));
}
// Now we shouldn't be able to paste from the clipboard.
EXPECT_FALSE(CanPasteFromClipboard(model.bookmark_bar_node()));
}
TEST_F(BookmarkUtilsTest, CutToClipboard) {
BookmarkModel model(NULL);
model.AddObserver(this);
base::string16 title(ASCIIToUTF16("foo"));
GURL url("http://foo.com");
const BookmarkNode* n1 = model.AddURL(model.other_node(), 0, title, url);
const BookmarkNode* n2 = model.AddURL(model.other_node(), 1, title, url);
// Cut the nodes to the clipboard.
std::vector<const BookmarkNode*> nodes;
nodes.push_back(n1);
nodes.push_back(n2);
CopyToClipboard(&model, nodes, true);
// Make sure the nodes were removed.
EXPECT_EQ(0, model.other_node()->child_count());
// Make sure observers were notified the set of changes should be grouped.
ExpectGroupedChangeCount(1, 1);
// And make sure we can paste from the clipboard.
EXPECT_TRUE(CanPasteFromClipboard(model.other_node()));
}
TEST_F(BookmarkUtilsTest, GetParentForNewNodes) {
BookmarkModel model(NULL);
// This tests the case where selection contains one item and that item is a
// folder.
std::vector<const BookmarkNode*> nodes;
nodes.push_back(model.bookmark_bar_node());
int index = -1;
const BookmarkNode* real_parent = GetParentForNewNodes(
model.bookmark_bar_node(), nodes, &index);
EXPECT_EQ(real_parent, model.bookmark_bar_node());
EXPECT_EQ(0, index);
nodes.clear();
// This tests the case where selection contains one item and that item is an
// url.
const BookmarkNode* page1 = model.AddURL(model.bookmark_bar_node(),
0,
ASCIIToUTF16("Google"),
GURL("http://google.com"));
nodes.push_back(page1);
real_parent = GetParentForNewNodes(model.bookmark_bar_node(), nodes, &index);
EXPECT_EQ(real_parent, model.bookmark_bar_node());
EXPECT_EQ(1, index);
// This tests the case where selection has more than one item.
const BookmarkNode* folder1 = model.AddFolder(model.bookmark_bar_node(), 1,
ASCIIToUTF16("Folder 1"));
nodes.push_back(folder1);
real_parent = GetParentForNewNodes(model.bookmark_bar_node(), nodes, &index);
EXPECT_EQ(real_parent, model.bookmark_bar_node());
EXPECT_EQ(2, index);
// This tests the case where selection doesn't contain any items.
nodes.clear();
real_parent = GetParentForNewNodes(model.bookmark_bar_node(), nodes, &index);
EXPECT_EQ(real_parent, model.bookmark_bar_node());
EXPECT_EQ(2, index);
}
// Verifies that meta info is copied when nodes are cloned.
TEST_F(BookmarkUtilsTest, CloneMetaInfo) {
BookmarkModel model(NULL);
// Add a node containing meta info.
const BookmarkNode* node = model.AddURL(model.other_node(),
0,
ASCIIToUTF16("foo bar"),
GURL("http://www.google.com"));
model.SetNodeMetaInfo(node, "somekey", "somevalue");
model.SetNodeMetaInfo(node, "someotherkey", "someothervalue");
// Clone node to a different folder.
const BookmarkNode* folder = model.AddFolder(model.bookmark_bar_node(), 0,
ASCIIToUTF16("Folder"));
std::vector<BookmarkNodeData::Element> elements;
BookmarkNodeData::Element node_data(node);
elements.push_back(node_data);
EXPECT_EQ(0, folder->child_count());
CloneBookmarkNode(&model, elements, folder, 0, false);
ASSERT_EQ(1, folder->child_count());
// Verify that the cloned node contains the same meta info.
const BookmarkNode* clone = folder->GetChild(0);
ASSERT_TRUE(clone->GetMetaInfoMap());
EXPECT_EQ(2u, clone->GetMetaInfoMap()->size());
std::string value;
EXPECT_TRUE(clone->GetMetaInfo("somekey", &value));
EXPECT_EQ("somevalue", value);
EXPECT_TRUE(clone->GetMetaInfo("someotherkey", &value));
EXPECT_EQ("someothervalue", value);
}
} // namespace
} // namespace bookmark_utils
|