1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/file_path.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_init.h"
#include "chrome/browser/browser_list.h"
#include "chrome/browser/browser_window.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/test/in_process_browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
class BrowserInitTest : public InProcessBrowserTest {
};
class OpenURLsPopupObserver : public BrowserList::Observer {
public:
OpenURLsPopupObserver() : added_browser_(NULL) { }
virtual void OnBrowserAdded(const Browser* browser) {
added_browser_ = browser;
}
virtual void OnBrowserRemoved(const Browser* browser) { }
const Browser* added_browser_;
};
// Test that when there is a popup as the active browser any requests to
// BrowserInit::LaunchWithProfile::OpenURLsInBrowser don't crash because
// there's no explicit profile given.
IN_PROC_BROWSER_TEST_F(BrowserInitTest, OpenURLsPopup) {
std::vector<GURL> urls;
urls.push_back(GURL("http://localhost"));
// Note that in our testing we do not ever query the BrowserList for the "last
// active" browser. That's because the browsers are set as "active" by
// platform UI toolkit messages, and those messages are not sent during unit
// testing sessions.
OpenURLsPopupObserver observer;
BrowserList::AddObserver(&observer);
Browser* popup = Browser::CreateForType(Browser::TYPE_POPUP,
browser()->profile());
ASSERT_EQ(popup->type(), Browser::TYPE_POPUP);
ASSERT_EQ(popup, observer.added_browser_);
CommandLine dummy(CommandLine::NO_PROGRAM);
BrowserInit::LaunchWithProfile launch(FilePath(), dummy);
// This should create a new window, but re-use the profile from |popup|. If
// it used a NULL or invalid profile, it would crash.
launch.OpenURLsInBrowser(popup, false, urls);
ASSERT_NE(popup, observer.added_browser_);
BrowserList::RemoveObserver(&observer);
}
// Test that we prevent openning potentially dangerous schemes from the
// command line.
// TODO(jschuh): FLAKY because the process doesn't have sufficient time
// to start on most BuildBot runs and I don't want to add longer delays to
// the test. I'll circle back and make this work properly when i get a chance.
IN_PROC_BROWSER_TEST_F(BrowserInitTest, FLAKY_BlockBadURLs) {
const char* testurlstr = "http://localhost/";
const GURL testurl(testurlstr);
CommandLine cmdline(CommandLine::NO_PROGRAM);
cmdline.AppendArg(testurlstr);
cmdline.AppendArg("javascript:alert('boo')");
cmdline.AppendArg(testurlstr);
cmdline.AppendArg("view-source:http://localhost/");
// This will pick up the current browser instance.
BrowserInit::LaunchWithProfile launch(FilePath(), cmdline);
launch.Launch(browser()->profile(), false);
// TODO(jschuh): Give the browser a chance to start first.
PlatformThread::Sleep(50);
// Skip about:blank in the first tab
for (int i = 1; i < browser()->tab_count(); i++) {
const GURL &url = browser()->GetTabContentsAt(i)->GetURL();
ASSERT_EQ(url, testurl);
}
ASSERT_EQ(browser()->tab_count(), 3);
}
} // namespace
|
