1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
|
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/cocoa/bookmark_bar_bridge.h"
#include "chrome/browser/cocoa/bookmark_bar_controller.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
#include "chrome/browser/cocoa/cocoa_test_helper.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
// TODO(jrg): add OCMock to Chromium to save some typing.
namespace {
// Information needed to open a URL, as passed to the
// BookmarkBarController's delegate.
typedef std::pair<GURL,WindowOpenDisposition> OpenInfo;
} // The namespace must end here -- I need to use OpenInfo in
// FakeBookmarkBarController but can't place
// FakeBookmarkBarController itself in the namespace ("error:
// Objective-C declarations may only appear in global scope")
// Oddly, we are our own delegate.
@interface FakeBookmarkBarController : BookmarkBarController {
@public
scoped_nsobject<NSMutableArray> callbacks_;
std::vector<OpenInfo> opens_;
}
@end
@implementation FakeBookmarkBarController
- (id)initWithBrowser:(Browser*)browser {
if ((self = [super initWithBrowser:browser
initialWidth:100 // arbitrary
delegate:nil
resizeDelegate:nil])) {
callbacks_.reset([[NSMutableArray alloc] init]);
}
return self;
}
- (void)loaded:(BookmarkModel*)model {
[callbacks_ addObject:[NSNumber numberWithInt:0]];
}
- (void)beingDeleted:(BookmarkModel*)model {
[callbacks_ addObject:[NSNumber numberWithInt:1]];
}
- (void)nodeMoved:(BookmarkModel*)model
oldParent:(const BookmarkNode*)oldParent oldIndex:(int)oldIndex
newParent:(const BookmarkNode*)newParent newIndex:(int)newIndex {
[callbacks_ addObject:[NSNumber numberWithInt:2]];
}
- (void)nodeAdded:(BookmarkModel*)model
parent:(const BookmarkNode*)oldParent index:(int)index {
[callbacks_ addObject:[NSNumber numberWithInt:3]];
}
- (void)nodeChanged:(BookmarkModel*)model
node:(const BookmarkNode*)node {
[callbacks_ addObject:[NSNumber numberWithInt:4]];
}
- (void)nodeFavIconLoaded:(BookmarkModel*)model
node:(const BookmarkNode*)node {
[callbacks_ addObject:[NSNumber numberWithInt:5]];
}
- (void)nodeChildrenReordered:(BookmarkModel*)model
node:(const BookmarkNode*)node {
[callbacks_ addObject:[NSNumber numberWithInt:6]];
}
- (void)nodeRemoved:(BookmarkModel*)model
parent:(const BookmarkNode*)oldParent index:(int)index {
[callbacks_ addObject:[NSNumber numberWithInt:7]];
}
// Save the request.
- (void)openBookmarkURL:(const GURL&)url
disposition:(WindowOpenDisposition)disposition {
opens_.push_back(OpenInfo(url, disposition));
}
@end
class BookmarkBarBridgeTest : public CocoaTest {
public:
BrowserTestHelper browser_test_helper_;
};
// Call all the callbacks; make sure they are all redirected to the objc object.
TEST_F(BookmarkBarBridgeTest, TestRedirect) {
Browser* browser = browser_test_helper_.browser();
Profile* profile = browser_test_helper_.profile();
BookmarkModel* model = profile->GetBookmarkModel();
scoped_nsobject<NSView> parentView([[NSView alloc]
initWithFrame:NSMakeRect(0,0,100,100)]);
scoped_nsobject<NSView> webView([[NSView alloc]
initWithFrame:NSMakeRect(0,0,100,100)]);
scoped_nsobject<NSView> infoBarsView(
[[NSView alloc] initWithFrame:NSMakeRect(0,0,100,100)]);
scoped_nsobject<FakeBookmarkBarController>
controller([[FakeBookmarkBarController alloc] initWithBrowser:browser]);
EXPECT_TRUE(controller.get());
scoped_ptr<BookmarkBarBridge> bridge(new BookmarkBarBridge(controller.get(),
model));
EXPECT_TRUE(bridge.get());
bridge->Loaded(NULL);
bridge->BookmarkModelBeingDeleted(NULL);
bridge->BookmarkNodeMoved(NULL, NULL, 0, NULL, 0);
bridge->BookmarkNodeAdded(NULL, NULL, 0);
bridge->BookmarkNodeChanged(NULL, NULL);
bridge->BookmarkNodeFavIconLoaded(NULL, NULL);
bridge->BookmarkNodeChildrenReordered(NULL, NULL);
bridge->BookmarkNodeRemoved(NULL, NULL, 0, NULL);
// 8 calls above plus an initial Loaded() in init routine makes 9
EXPECT_TRUE([controller.get()->callbacks_ count] == 9);
for (int x = 1; x < 9; x++) {
NSNumber *num = [NSNumber numberWithInt:x-1];
EXPECT_TRUE([[controller.get()->callbacks_ objectAtIndex:x] isEqual:num]);
}
}
|
