1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
|
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Cocoa/Cocoa.h>
#include "base/basictypes.h"
#include "base/scoped_nsobject.h"
#include "base/sys_string_conversions.h"
#import "chrome/browser/cocoa/bookmark_bar_constants.h"
#import "chrome/browser/cocoa/bookmark_bar_controller.h"
#import "chrome/browser/cocoa/bookmark_bar_view.h"
#import "chrome/browser/cocoa/bookmark_button.h"
#import "chrome/browser/cocoa/bookmark_menu.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
#import "chrome/browser/cocoa/cocoa_test_helper.h"
#include "chrome/browser/cocoa/test_event_utils.h"
#import "chrome/browser/cocoa/view_resizer_pong.h"
#include "chrome/common/pref_names.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
// Just like a BookmarkBarController but openURL: is stubbed out.
@interface BookmarkBarControllerNoOpen : BookmarkBarController {
@public
std::vector<GURL> urls_;
std::vector<WindowOpenDisposition> dispositions_;
}
@end
@implementation BookmarkBarControllerNoOpen
- (void)openURL:(GURL)url disposition:(WindowOpenDisposition)disposition {
urls_.push_back(url);
dispositions_.push_back(disposition);
}
- (void)clear {
urls_.clear();
dispositions_.clear();
}
@end
// NSCell that is pre-provided with a desired size that becomes the
// return value for -(NSSize)cellSize:.
@interface CellWithDesiredSize : NSCell {
@private
NSSize cellSize_;
}
@property(readonly) NSSize cellSize;
@end
@implementation CellWithDesiredSize
@synthesize cellSize = cellSize_;
- (id)initTextCell:(NSString*)string desiredSize:(NSSize)size {
if ((self = [super initTextCell:string])) {
cellSize_ = size;
}
return self;
}
@end
// Remember the number of times we've gotten a frameDidChange notification.
@interface BookmarkBarControllerTogglePong : BookmarkBarControllerNoOpen {
@private
int toggles_;
}
@property (readonly) int toggles;
@end
@implementation BookmarkBarControllerTogglePong
@synthesize toggles = toggles_;
- (void)frameDidChange {
toggles_++;
}
@end
@interface FakeTheme : GTMTheme {
scoped_nsobject<NSColor> color_;
}
@end
@implementation FakeTheme
- (id)initWithColor:(NSColor*)color {
if ((self = [super init])) {
color_.reset([color retain]);
}
return self;
}
- (NSColor*)textColorForStyle:(GTMThemeStyle)style
state:(GTMThemeState)state {
return color_.get();
}
@end
namespace {
static const int kContentAreaHeight = 500;
static const int kInfoBarViewHeight = 30;
class BookmarkBarControllerTest : public CocoaTest {
public:
BookmarkBarControllerTest() {
resizeDelegate_.reset([[ViewResizerPong alloc] init]);
NSRect parent_frame = NSMakeRect(0, 0, 800, 50);
parent_view_.reset([[NSView alloc] initWithFrame:parent_frame]);
[parent_view_ setHidden:YES];
bar_.reset(
[[BookmarkBarControllerNoOpen alloc]
initWithBrowser:helper_.browser()
initialWidth:NSWidth(parent_frame)
delegate:nil
resizeDelegate:resizeDelegate_.get()]);
InstallAndToggleBar(bar_.get());
// Create a menu/item to act like a sender
menu_.reset([[BookmarkMenu alloc] initWithTitle:@"I_dont_care"]);
menu_item_.reset([[NSMenuItem alloc]
initWithTitle:@"still_dont_care"
action:NULL
keyEquivalent:@""]);
cell_.reset([[NSButtonCell alloc] init]);
[menu_item_ setMenu:menu_.get()];
[menu_ setDelegate:cell_.get()];
}
void InstallAndToggleBar(BookmarkBarController* bar) {
// Force loading of the nib.
[bar view];
// Awkwardness to look like we've been installed.
[parent_view_ addSubview:[bar view]];
NSRect frame = [[[bar view] superview] frame];
frame.origin.y = 100;
[[[bar view] superview] setFrame:frame];
// Make sure it's open so certain things aren't no-ops.
[bar updateAndShowNormalBar:YES
showDetachedBar:NO
withAnimation:NO];
}
// Return a menu item that points to the right URL.
NSMenuItem* ItemForBookmarkBarMenu(GURL& gurl) {
node_.reset(new BookmarkNode(gurl));
[menu_ setRepresentedObject:[NSValue valueWithPointer:node_.get()]];
return menu_item_;
}
// Does NOT take ownership of node.
NSMenuItem* ItemForBookmarkBarMenu(const BookmarkNode* node) {
[menu_ setRepresentedObject:[NSValue valueWithPointer:node]];
return menu_item_;
}
BrowserTestHelper helper_;
scoped_nsobject<NSView> parent_view_;
scoped_nsobject<ViewResizerPong> resizeDelegate_;
scoped_nsobject<BookmarkBarControllerNoOpen> bar_;
scoped_nsobject<BookmarkMenu> menu_;
scoped_nsobject<NSMenuItem> menu_item_;
scoped_nsobject<NSButtonCell> cell_;
scoped_ptr<BookmarkNode> node_;
};
TEST_F(BookmarkBarControllerTest, ShowWhenShowBookmarkBarTrue) {
[bar_ updateAndShowNormalBar:YES
showDetachedBar:NO
withAnimation:NO];
EXPECT_TRUE([bar_ isInState:bookmarks::kShowingState]);
EXPECT_FALSE([bar_ isInState:bookmarks::kDetachedState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
EXPECT_FALSE([[bar_ view] isHidden]);
EXPECT_GT([resizeDelegate_ height], 0);
EXPECT_GT([[bar_ view] frame].size.height, 0);
}
TEST_F(BookmarkBarControllerTest, HideWhenShowBookmarkBarFalse) {
[bar_ updateAndShowNormalBar:NO
showDetachedBar:NO
withAnimation:NO];
EXPECT_FALSE([bar_ isInState:bookmarks::kShowingState]);
EXPECT_FALSE([bar_ isInState:bookmarks::kDetachedState]);
EXPECT_FALSE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
EXPECT_TRUE([[bar_ view] isHidden]);
EXPECT_EQ(0, [resizeDelegate_ height]);
EXPECT_EQ(0, [[bar_ view] frame].size.height);
}
TEST_F(BookmarkBarControllerTest, HideWhenShowBookmarkBarTrueButDisabled) {
[bar_ setBookmarkBarEnabled:NO];
[bar_ updateAndShowNormalBar:YES
showDetachedBar:NO
withAnimation:NO];
EXPECT_TRUE([bar_ isInState:bookmarks::kShowingState]);
EXPECT_FALSE([bar_ isInState:bookmarks::kDetachedState]);
EXPECT_FALSE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
EXPECT_TRUE([[bar_ view] isHidden]);
EXPECT_EQ(0, [resizeDelegate_ height]);
EXPECT_EQ(0, [[bar_ view] frame].size.height);
}
TEST_F(BookmarkBarControllerTest, ShowOnNewTabPage) {
[bar_ updateAndShowNormalBar:NO
showDetachedBar:YES
withAnimation:NO];
EXPECT_FALSE([bar_ isInState:bookmarks::kShowingState]);
EXPECT_TRUE([bar_ isInState:bookmarks::kDetachedState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
EXPECT_FALSE([[bar_ view] isHidden]);
EXPECT_GT([resizeDelegate_ height], 0);
EXPECT_GT([[bar_ view] frame].size.height, 0);
// Make sure no buttons fall off the bar, either now or when resized
// bigger or smaller.
CGFloat sizes[] = { 300.0, -100.0, 200.0, -420.0 };
CGFloat previousX = 0.0;
for (unsigned x = 0; x < arraysize(sizes); x++) {
// Confirm the buttons moved from the last check (which may be
// init but that's fine).
CGFloat newX = [[bar_ offTheSideButton] frame].origin.x;
EXPECT_NE(previousX, newX);
previousX = newX;
// Confirm the buttons have a reasonable bounds. Recall that |-frame|
// returns rectangles in the superview's coordinates.
NSRect buttonViewFrame =
[[bar_ buttonView] convertRect:[[bar_ buttonView] frame]
fromView:[[bar_ buttonView] superview]];
EXPECT_EQ([bar_ buttonView], [[bar_ offTheSideButton] superview]);
EXPECT_TRUE(NSContainsRect(buttonViewFrame,
[[bar_ offTheSideButton] frame]));
EXPECT_EQ([bar_ buttonView], [[bar_ otherBookmarksButton] superview]);
EXPECT_TRUE(NSContainsRect(buttonViewFrame,
[[bar_ otherBookmarksButton] frame]));
// Now move them implicitly.
// We confirm FrameChangeNotification works in the next unit test;
// we simply assume it works here to resize or reposition the
// buttons above.
NSRect frame = [[bar_ view] frame];
frame.size.width += sizes[x];
[[bar_ view] setFrame:frame];
}
}
// Test whether |-updateAndShowNormalBar:...| sets states as we expect. Make
// sure things don't crash.
TEST_F(BookmarkBarControllerTest, StateChanges) {
// First, go in one-at-a-time cycle.
[bar_ updateAndShowNormalBar:NO
showDetachedBar:NO
withAnimation:NO];
EXPECT_EQ(bookmarks::kHiddenState, [bar_ visualState]);
EXPECT_FALSE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
[bar_ updateAndShowNormalBar:YES
showDetachedBar:NO
withAnimation:NO];
EXPECT_EQ(bookmarks::kShowingState, [bar_ visualState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
[bar_ updateAndShowNormalBar:YES
showDetachedBar:YES
withAnimation:NO];
EXPECT_EQ(bookmarks::kShowingState, [bar_ visualState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
[bar_ updateAndShowNormalBar:NO
showDetachedBar:YES
withAnimation:NO];
EXPECT_EQ(bookmarks::kDetachedState, [bar_ visualState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
// Now try some "jumps".
for (int i = 0; i < 2; i++) {
[bar_ updateAndShowNormalBar:NO
showDetachedBar:NO
withAnimation:NO];
EXPECT_EQ(bookmarks::kHiddenState, [bar_ visualState]);
EXPECT_FALSE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
[bar_ updateAndShowNormalBar:YES
showDetachedBar:YES
withAnimation:NO];
EXPECT_EQ(bookmarks::kShowingState, [bar_ visualState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
}
// Now try some "jumps".
for (int i = 0; i < 2; i++) {
[bar_ updateAndShowNormalBar:YES
showDetachedBar:NO
withAnimation:NO];
EXPECT_EQ(bookmarks::kShowingState, [bar_ visualState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
[bar_ updateAndShowNormalBar:NO
showDetachedBar:YES
withAnimation:NO];
EXPECT_EQ(bookmarks::kDetachedState, [bar_ visualState]);
EXPECT_TRUE([bar_ isVisible]);
EXPECT_FALSE([bar_ isAnimationRunning]);
}
}
// Make sure we're watching for frame change notifications.
TEST_F(BookmarkBarControllerTest, FrameChangeNotification) {
scoped_nsobject<BookmarkBarControllerTogglePong> bar;
bar.reset(
[[BookmarkBarControllerTogglePong alloc]
initWithBrowser:helper_.browser()
initialWidth:100 // arbitrary
delegate:nil
resizeDelegate:resizeDelegate_.get()]);
InstallAndToggleBar(bar.get());
// Send a frame did change notification for the pong's view.
[[NSNotificationCenter defaultCenter]
postNotificationName:NSViewFrameDidChangeNotification
object:[bar view]];
EXPECT_GT([bar toggles], 0);
}
// Confirm off the side button only enabled when reasonable.
TEST_F(BookmarkBarControllerTest, OffTheSideButtonHidden) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
[bar_ loaded:model];
EXPECT_TRUE([bar_ offTheSideButtonIsHidden]);
for (int i = 0; i < 2; i++) {
model->SetURLStarred(GURL("http://www.foo.com"), L"small", true);
EXPECT_TRUE([bar_ offTheSideButtonIsHidden]);
}
for (int i = 0; i < 20; i++) {
const BookmarkNode* parent = model->GetBookmarkBarNode();
model->AddURL(parent, parent->GetChildCount(),
L"super duper wide title",
GURL("http://superfriends.hall-of-justice.edu"));
}
EXPECT_FALSE([bar_ offTheSideButtonIsHidden]);
}
TEST_F(BookmarkBarControllerTest, TagMap) {
int64 ids[] = { 1, 3, 4, 40, 400, 4000, 800000000, 2, 123456789 };
std::vector<int32> tags;
// Generate some tags
for (unsigned int i = 0; i < arraysize(ids); i++) {
tags.push_back([bar_ menuTagFromNodeId:ids[i]]);
}
// Confirm reverse mapping.
for (unsigned int i = 0; i < arraysize(ids); i++) {
EXPECT_EQ(ids[i], [bar_ nodeIdFromMenuTag:tags[i]]);
}
// Confirm uniqueness.
std::sort(tags.begin(), tags.end());
for (unsigned int i=0; i<(tags.size()-1); i++) {
EXPECT_NE(tags[i], tags[i+1]);
}
}
TEST_F(BookmarkBarControllerTest, MenuForFolderNode) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
// First make sure something (e.g. "(empty)" string) is always present.
NSMenu* menu = [bar_ menuForFolderNode:model->GetBookmarkBarNode()];
EXPECT_GT([menu numberOfItems], 0);
// Test two bookmarks.
GURL gurl("http://www.foo.com");
model->SetURLStarred(gurl, L"small", true);
model->SetURLStarred(GURL("http://www.cnn.com"), L"bigger title", true);
menu = [bar_ menuForFolderNode:model->GetBookmarkBarNode()];
EXPECT_EQ([menu numberOfItems], 2);
NSMenuItem *item = [menu itemWithTitle:@"bigger title"];
EXPECT_TRUE(item);
item = [menu itemWithTitle:@"small"];
EXPECT_TRUE(item);
if (item) {
int64 tag = [bar_ nodeIdFromMenuTag:[item tag]];
const BookmarkNode* node = model->GetNodeByID(tag);
EXPECT_TRUE(node);
EXPECT_EQ(gurl, node->GetURL());
}
// Test with an actual folder as well
const BookmarkNode* parent = model->GetBookmarkBarNode();
const BookmarkNode* folder = model->AddGroup(parent,
parent->GetChildCount(),
L"group");
model->AddURL(folder, folder->GetChildCount(),
L"f1", GURL("http://framma-lamma.com"));
model->AddURL(folder, folder->GetChildCount(),
L"f2", GURL("http://framma-lamma-ding-dong.com"));
menu = [bar_ menuForFolderNode:model->GetBookmarkBarNode()];
EXPECT_EQ([menu numberOfItems], 3);
item = [menu itemWithTitle:@"group"];
EXPECT_TRUE(item);
EXPECT_TRUE([item hasSubmenu]);
NSMenu *submenu = [item submenu];
EXPECT_TRUE(submenu);
EXPECT_EQ(2, [submenu numberOfItems]);
EXPECT_TRUE([submenu itemWithTitle:@"f1"]);
EXPECT_TRUE([submenu itemWithTitle:@"f2"]);
}
// Confirm openBookmark: forwards the request to the controller's delegate
TEST_F(BookmarkBarControllerTest, OpenBookmark) {
GURL gurl("http://walla.walla.ding.dong.com");
scoped_ptr<BookmarkNode> node(new BookmarkNode(gurl));
scoped_nsobject<NSButtonCell> cell([[NSButtonCell alloc] init]);
scoped_nsobject<NSButton> button([[NSButton alloc] init]);
[button setCell:cell.get()];
[cell setRepresentedObject:[NSValue valueWithPointer:node.get()]];
[bar_ openBookmark:button];
EXPECT_EQ(bar_.get()->urls_[0], node->GetURL());
EXPECT_EQ(bar_.get()->dispositions_[0], CURRENT_TAB);
}
// Confirm opening of bookmarks works from the menus (different
// dispositions than clicking on the button).
TEST_F(BookmarkBarControllerTest, OpenBookmarkFromMenus) {
const char* urls[] = { "http://walla.walla.ding.dong.com",
"http://i_dont_know.com",
"http://cee.enn.enn.dot.com" };
SEL selectors[] = { @selector(openBookmarkInNewForegroundTab:),
@selector(openBookmarkInNewWindow:),
@selector(openBookmarkInIncognitoWindow:) };
WindowOpenDisposition dispositions[] = { NEW_FOREGROUND_TAB,
NEW_WINDOW,
OFF_THE_RECORD };
for (unsigned int i = 0;
i < sizeof(dispositions)/sizeof(dispositions[0]);
i++) {
GURL gurl(urls[i]);
[bar_ performSelector:selectors[i]
withObject:ItemForBookmarkBarMenu(gurl)];
EXPECT_EQ(bar_.get()->urls_[0], gurl);
EXPECT_EQ(bar_.get()->dispositions_[0], dispositions[i]);
[bar_ clear];
}
}
TEST_F(BookmarkBarControllerTest, TestAddRemoveAndClear) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
NSView* buttonView = [bar_ buttonView];
EXPECT_EQ(0U, [[bar_ buttons] count]);
unsigned int initial_subview_count = [[buttonView subviews] count];
// Make sure a redundant call doesn't choke
[bar_ clearBookmarkBar];
EXPECT_EQ(0U, [[bar_ buttons] count]);
EXPECT_EQ(initial_subview_count, [[buttonView subviews] count]);
GURL gurl1("http://superfriends.hall-of-justice.edu");
// Short titles increase the chances of this test succeeding if the view is
// narrow.
// TODO(viettrungluu): make the test independent of window/view size, font
// metrics, button size and spacing, and everything else.
std::wstring title1(L"x");
model->SetURLStarred(gurl1, title1, true);
EXPECT_EQ(1U, [[bar_ buttons] count]);
EXPECT_EQ(1+initial_subview_count, [[buttonView subviews] count]);
GURL gurl2("http://legion-of-doom.gov");
std::wstring title2(L"y");
model->SetURLStarred(gurl2, title2, true);
EXPECT_EQ(2U, [[bar_ buttons] count]);
EXPECT_EQ(2+initial_subview_count, [[buttonView subviews] count]);
for (int i = 0; i < 3; i++) {
// is_starred=false --> remove the bookmark
model->SetURLStarred(gurl2, title2, false);
EXPECT_EQ(1U, [[bar_ buttons] count]);
EXPECT_EQ(1+initial_subview_count, [[buttonView subviews] count]);
// and bring it back
model->SetURLStarred(gurl2, title2, true);
EXPECT_EQ(2U, [[bar_ buttons] count]);
EXPECT_EQ(2+initial_subview_count, [[buttonView subviews] count]);
}
[bar_ clearBookmarkBar];
EXPECT_EQ(0U, [[bar_ buttons] count]);
EXPECT_EQ(initial_subview_count, [[buttonView subviews] count]);
// Explicit test of loaded: since this is a convenient spot
[bar_ loaded:model];
EXPECT_EQ(2U, [[bar_ buttons] count]);
EXPECT_EQ(2+initial_subview_count, [[buttonView subviews] count]);
}
// Make sure that each button we add marches to the right and does not
// overlap with the previous one.
TEST_F(BookmarkBarControllerTest, TestButtonMarch) {
scoped_nsobject<NSMutableArray> cells([[NSMutableArray alloc] init]);
CGFloat widths[] = { 10, 10, 100, 10, 500, 500, 80000, 60000, 1, 345 };
for (unsigned int i = 0; i < arraysize(widths); i++) {
NSCell* cell = [[CellWithDesiredSize alloc]
initTextCell:@"foo"
desiredSize:NSMakeSize(widths[i], 30)];
[cells addObject:cell];
[cell release];
}
int x_offset = 0;
CGFloat x_end = x_offset; // end of the previous button
for (unsigned int i = 0; i < arraysize(widths); i++) {
NSRect r = [bar_ frameForBookmarkButtonFromCell:[cells objectAtIndex:i]
xOffset:&x_offset];
EXPECT_GE(r.origin.x, x_end);
x_end = NSMaxX(r);
}
}
TEST_F(BookmarkBarControllerTest, CheckForGrowth) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
GURL gurl1("http://www.google.com");
std::wstring title1(L"x");
model->SetURLStarred(gurl1, title1, true);
GURL gurl2("http://www.google.com/blah");
std::wstring title2(L"y");
model->SetURLStarred(gurl2, title2, true);
EXPECT_EQ(2U, [[bar_ buttons] count]);
CGFloat width_1 = [[[bar_ buttons] objectAtIndex:0] frame].size.width;
CGFloat x_2 = [[[bar_ buttons] objectAtIndex:1] frame].origin.x;
NSButton* first = [[bar_ buttons] objectAtIndex:0];
[[first cell] setTitle:@"This is a really big title; watch out mom!"];
[bar_ checkForBookmarkButtonGrowth:first];
// Make sure the 1st button is now wider, the 2nd one is moved over,
// and they don't overlap.
NSRect frame_1 = [[[bar_ buttons] objectAtIndex:0] frame];
NSRect frame_2 = [[[bar_ buttons] objectAtIndex:1] frame];
EXPECT_GT(frame_1.size.width, width_1);
EXPECT_GT(frame_2.origin.x, x_2);
EXPECT_GE(frame_2.origin.x, frame_1.origin.x + frame_1.size.width);
}
TEST_F(BookmarkBarControllerTest, DeleteBookmark) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
const char* urls[] = { "https://secret.url.com",
"http://super.duper.web.site.for.doodz.gov",
"http://www.foo-bar-baz.com/" };
const BookmarkNode* parent = model->GetBookmarkBarNode();
for (unsigned int i = 0; i < arraysize(urls); i++) {
model->AddURL(parent, parent->GetChildCount(),
L"title", GURL(urls[i]));
}
EXPECT_EQ(3, parent->GetChildCount());
const BookmarkNode* middle_node = parent->GetChild(1);
NSMenuItem* item = ItemForBookmarkBarMenu(middle_node);
[bar_ deleteBookmark:item];
EXPECT_EQ(2, parent->GetChildCount());
EXPECT_EQ(parent->GetChild(0)->GetURL(), GURL(urls[0]));
// node 2 moved into spot 1
EXPECT_EQ(parent->GetChild(1)->GetURL(), GURL(urls[2]));
}
TEST_F(BookmarkBarControllerTest, OpenAllBookmarks) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
const BookmarkNode* parent = model->GetBookmarkBarNode();
// { one, { two-one, two-two }, three }
model->AddURL(parent, parent->GetChildCount(),
L"title", GURL("http://one.com"));
const BookmarkNode* folder = model->AddGroup(parent,
parent->GetChildCount(),
L"group");
model->AddURL(folder, folder->GetChildCount(),
L"title", GURL("http://two-one.com"));
model->AddURL(folder, folder->GetChildCount(),
L"title", GURL("http://two-two.com"));
model->AddURL(parent, parent->GetChildCount(),
L"title", GURL("https://three.com"));
// Our first OpenAll... is from the bar itself.
[bar_ openAllBookmarks:ItemForBookmarkBarMenu(parent)];
EXPECT_EQ(bar_.get()->urls_.size(), 4U);
EXPECT_EQ(bar_.get()->dispositions_.size(), 4U);
// I can't use EXPECT_EQ() here since the macro can't expand
// properly (no way to print the value of an iterator).
std::vector<GURL>::iterator i;
std::vector<GURL>::iterator begin = bar_.get()->urls_.begin();
std::vector<GURL>::iterator end = bar_.get()->urls_.end();
i = find(begin, end, GURL("http://two-one.com"));
EXPECT_FALSE(i == end);
i = find(begin, end, GURL("https://three.com"));
EXPECT_FALSE(i == end);
i = find(begin, end, GURL("https://will-not-be-found.com"));
EXPECT_TRUE(i == end);
EXPECT_EQ(bar_.get()->dispositions_[3], NEW_BACKGROUND_TAB);
// Now try an OpenAll... from a folder node.
bar_.get()->urls_.clear();
bar_.get()->dispositions_.clear();
[bar_ openAllBookmarks:ItemForBookmarkBarMenu(folder)];
EXPECT_EQ(bar_.get()->urls_.size(), 2U);
EXPECT_EQ(bar_.get()->dispositions_.size(), 2U);
}
// TODO(jrg): write a test to confirm that nodeFavIconLoaded calls
// checkForBookmarkButtonGrowth:.
TEST_F(BookmarkBarControllerTest, Cell) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
[bar_ loaded:model];
const BookmarkNode* parent = model->GetBookmarkBarNode();
model->AddURL(parent, parent->GetChildCount(),
L"supertitle",
GURL("http://superfriends.hall-of-justice.edu"));
const BookmarkNode* node = parent->GetChild(0);
NSCell* cell = [bar_ cellForBookmarkNode:node];
EXPECT_TRUE(cell);
EXPECT_TRUE([[cell title] isEqual:@"supertitle"]);
EXPECT_EQ(node, [[cell representedObject] pointerValue]);
// cell is autoreleased; no need to release here
}
// Test drawing, mostly to ensure nothing leaks or crashes.
TEST_F(BookmarkBarControllerTest, Display) {
[[bar_ view] display];
}
// Test that middle clicking on a bookmark button results in an open action.
TEST_F(BookmarkBarControllerTest, MiddleClick) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
GURL gurl1("http://www.google.com/");
std::wstring title1(L"x");
model->SetURLStarred(gurl1, title1, true);
EXPECT_EQ(1U, [[bar_ buttons] count]);
NSButton* first = [[bar_ buttons] objectAtIndex:0];
EXPECT_TRUE(first);
[first otherMouseUp:test_event_utils::MakeMouseEvent(NSOtherMouseUp, 0)];
EXPECT_EQ(bar_.get()->urls_.size(), 1U);
}
TEST_F(BookmarkBarControllerTest, TestBuildOffTheSideMenu) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
NSMenu* menu = [bar_ offTheSideMenu];
ASSERT_TRUE(menu);
// The bookmark bar should start out with nothing.
EXPECT_EQ(0U, [[bar_ buttons] count]);
// Make sure things work when there's nothing. Note that there should always
// be a blank first menu item.
[bar_ buildOffTheSideMenu];
EXPECT_EQ(1, [menu numberOfItems]);
// We add lots of bookmarks. At first, we expect nothing to be added to the
// off-the-side menu. But once they start getting added, we expect the
// remaining ones to be added too. We expect a reasonably substantial number
// of items to be added by the end.
int num_off_the_side = 0;
for (int i = 0; i < 50; i++) {
const BookmarkNode* parent = model->GetBookmarkBarNode();
model->AddURL(parent, parent->GetChildCount(),
L"very wide title",
GURL("http://www.foobar.com/"));
[bar_ buildOffTheSideMenu];
if (num_off_the_side) {
num_off_the_side++;
EXPECT_EQ(1 + num_off_the_side, [menu numberOfItems]);
} else {
EXPECT_TRUE([menu numberOfItems] == 1 || [menu numberOfItems] == 2);
if ([menu numberOfItems] == 2)
num_off_the_side++;
}
}
EXPECT_GE(num_off_the_side, 20);
// Reset, and check that the built menu is "empty" again.
[bar_ clearBookmarkBar];
EXPECT_EQ(0U, [[bar_ buttons] count]);
[bar_ buildOffTheSideMenu];
EXPECT_EQ(1, [menu numberOfItems]);
}
TEST_F(BookmarkBarControllerTest, DisplaysHelpMessageOnEmpty) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
[bar_ loaded:model];
EXPECT_FALSE([[[bar_ buttonView] noItemTextfield] isHidden]);
}
TEST_F(BookmarkBarControllerTest, HidesHelpMessageWithBookmark) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
const BookmarkNode* parent = model->GetBookmarkBarNode();
model->AddURL(parent, parent->GetChildCount(),
L"title", GURL("http://one.com"));
[bar_ loaded:model];
EXPECT_TRUE([[[bar_ buttonView] noItemTextfield] isHidden]);
}
TEST_F(BookmarkBarControllerTest, BookmarkButtonSizing) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
const BookmarkNode* parent = model->GetBookmarkBarNode();
model->AddURL(parent, parent->GetChildCount(),
L"title", GURL("http://one.com"));
[bar_ loaded:model];
// Make sure the internal bookmark button also is the correct height.
NSArray* buttons = [bar_ buttons];
EXPECT_GT([buttons count], 0u);
for (NSButton* button in buttons) {
EXPECT_FLOAT_EQ(
bookmarks::kBookmarkBarHeight - 2 *
bookmarks::kBookmarkVerticalPadding,
[button frame].size.height);
}
}
TEST_F(BookmarkBarControllerTest, DropBookmarks) {
const char* urls[] = {
"http://qwantz.com",
"http://xkcd.com",
"javascript:alert('lolwut')"
};
std::wstring titles[] = {
std::wstring(L"Philosophoraptor"),
std::wstring(L"Can't draw"),
std::wstring(L"Inspiration")
};
EXPECT_EQ(arraysize(urls), arraysize(titles));
NSMutableArray* nsurls = [NSMutableArray arrayWithCapacity:0];
NSMutableArray* nstitles = [NSMutableArray arrayWithCapacity:0];
for (size_t i = 0; i < arraysize(urls); ++i) {
[nsurls addObject:base::SysUTF8ToNSString(urls[i])];
[nstitles addObject:base::SysWideToNSString(titles[i])];
}
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
const BookmarkNode* parent = model->GetBookmarkBarNode();
[bar_ addURLs:nsurls withTitles:nstitles at:NSZeroPoint];
EXPECT_EQ(3, parent->GetChildCount());
for (int i = 0; i < parent->GetChildCount(); ++i) {
EXPECT_EQ(parent->GetChild(i)->GetURL(), GURL(urls[i]));
EXPECT_EQ(parent->GetChild(i)->GetTitle(), titles[i]);
}
}
TEST_F(BookmarkBarControllerTest, TestButtonOrBar) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
GURL gurl1("http://www.google.com");
std::wstring title1(L"x");
model->SetURLStarred(gurl1, title1, true);
GURL gurl2("http://www.google.com/gurl_power");
std::wstring title2(L"gurl power");
model->SetURLStarred(gurl2, title2, true);
NSButton* first = [[bar_ buttons] objectAtIndex:0];
NSButton* second = [[bar_ buttons] objectAtIndex:1];
EXPECT_TRUE(first && second);
NSMenuItem* menuItem = [[[first cell] menu] itemAtIndex:0];
BookmarkNode* node = [bar_ nodeFromMenuItem:menuItem];
EXPECT_TRUE(node);
EXPECT_EQ(node, model->GetBookmarkBarNode()->GetChild(0));
menuItem = [[[second cell] menu] itemAtIndex:0];
node = [bar_ nodeFromMenuItem:menuItem];
EXPECT_TRUE(node);
EXPECT_EQ(node, model->GetBookmarkBarNode()->GetChild(1));
menuItem = [[[bar_ view] menu] itemAtIndex:0];
node = [bar_ nodeFromMenuItem:menuItem];
EXPECT_TRUE(node);
EXPECT_EQ(node, model->GetBookmarkBarNode());
}
TEST_F(BookmarkBarControllerTest, TestMenuNodeAndDisable) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
const BookmarkNode* parent = model->GetBookmarkBarNode();
const BookmarkNode* folder = model->AddGroup(parent,
parent->GetChildCount(),
L"group");
NSButton* button = [[bar_ buttons] objectAtIndex:0];
EXPECT_TRUE(button);
// Confirm the menu knows which node it is talking about
BookmarkMenu* menu = static_cast<BookmarkMenu*>([[button cell] menu]);
EXPECT_TRUE(menu);
EXPECT_TRUE([menu isKindOfClass:[BookmarkMenu class]]);
EXPECT_EQ(folder, [menu node]);
// Make sure "Open All" is disabled (nothing to open -- no children!)
// (Assumes "Open All" is the 1st item)
NSMenuItem* item = [menu itemAtIndex:0];
EXPECT_FALSE([bar_ validateUserInterfaceItem:item]);
// Now add a child and make sure the item would be enabled.
model->AddURL(folder, folder->GetChildCount(),
L"super duper wide title",
GURL("http://superfriends.hall-of-justice.edu"));
EXPECT_TRUE([bar_ validateUserInterfaceItem:item]);
}
TEST_F(BookmarkBarControllerTest, TestDragButton) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
GURL gurls[] = { GURL("http://www.google.com/a"),
GURL("http://www.google.com/b"),
GURL("http://www.google.com/c") };
std::wstring titles[] = { L"a", L"b", L"c" };
for (unsigned i = 0; i < arraysize(titles); i++) {
model->SetURLStarred(gurls[i], titles[i], true);
}
EXPECT_EQ([[bar_ buttons] count], arraysize(titles));
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:0] title] isEqual:@"a"]);
[bar_ dragButton:[[bar_ buttons] objectAtIndex:2] to:NSMakePoint(0, 0)];
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:0] title] isEqual:@"c"]);
[bar_ dragButton:[[bar_ buttons] objectAtIndex:1] to:NSMakePoint(1000, 0)];
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:0] title] isEqual:@"c"]);
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:1] title] isEqual:@"b"]);
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:2] title] isEqual:@"a"]);
// Finally, a drop of the 1st between the next 2
CGFloat x = NSMinX([[[bar_ buttons] objectAtIndex:2] frame]);
x += [[bar_ view] frame].origin.x;
[bar_ dragButton:[[bar_ buttons] objectAtIndex:0] to:NSMakePoint(x, 0)];
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:0] title] isEqual:@"b"]);
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:1] title] isEqual:@"c"]);
EXPECT_TRUE([[[[bar_ buttons] objectAtIndex:2] title] isEqual:@"a"]);
}
// Fake a theme with colored text. Apply it and make sure bookmark
// buttons have the same colored text. Repeat more than once.
TEST_F(BookmarkBarControllerTest, TestThemedButton) {
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
model->SetURLStarred(GURL("http://www.foo.com"), L"small", true);
BookmarkButton* button = [[bar_ buttons] objectAtIndex:0];
EXPECT_TRUE(button);
NSArray* colors = [NSArray arrayWithObjects:[NSColor redColor],
[NSColor blueColor],
nil];
for (NSColor* color in colors) {
scoped_nsobject<FakeTheme> theme([[FakeTheme alloc] initWithColor:color]);
[bar_ updateTheme:theme.get()];
NSAttributedString* astr = [button attributedTitle];
EXPECT_TRUE(astr);
EXPECT_TRUE([[astr string] isEqual:@"small"]);
// Pick a char in the middle to test (index 3)
NSDictionary* attributes = [astr attributesAtIndex:3 effectiveRange:NULL];
NSColor* newColor =
[attributes objectForKey:NSForegroundColorAttributeName];
EXPECT_TRUE([newColor isEqual:color]);
}
}
// Test that delegates and targets of buttons are cleared on dealloc.
TEST_F(BookmarkBarControllerTest, TestClearOnDealloc) {
// Make some bookmark buttons.
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
GURL gurls[] = { GURL("http://www.foo.com/"),
GURL("http://www.bar.com/"),
GURL("http://www.baz.com/") };
std::wstring titles[] = { L"foo", L"bar", L"baz" };
for (size_t i = 0; i < arraysize(titles); i++)
model->SetURLStarred(gurls[i], titles[i], true);
// Get and retain the buttons so we can examine them after dealloc.
scoped_nsobject<NSArray> buttons([[bar_ buttons] retain]);
EXPECT_EQ([buttons count], arraysize(titles));
// Make sure that everything is set.
for (BookmarkButton* button in buttons.get()) {
ASSERT_TRUE([button isKindOfClass:[BookmarkButton class]]);
EXPECT_TRUE([button delegate]);
EXPECT_TRUE([button target]);
EXPECT_TRUE([button action]);
}
// This will dealloc....
bar_.reset();
// Make sure that everything is cleared.
for (BookmarkButton* button in buttons.get()) {
EXPECT_FALSE([button delegate]);
EXPECT_FALSE([button target]);
EXPECT_FALSE([button action]);
}
}
// TODO(viettrungluu): figure out how to test animations.
} // namespace
|