1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
|
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Cocoa/Cocoa.h>
#import "base/scoped_nsobject.h"
#import "chrome/browser/cocoa/preferences_window_controller.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
#include "chrome/browser/cocoa/cocoa_test_helper.h"
#import "chrome/browser/cocoa/custom_home_pages_model.h"
#include "chrome/browser/options_window.h"
#include "chrome/common/pref_names.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
// Helper Objective-C object that sets a BOOL when we get a particular
// callback from the prefs window.
@interface PrefsClosedObserver : NSObject {
@public
BOOL gotNotification_;
}
- (void)prefsWindowClosed:(NSNotification*)notify;
@end
@implementation PrefsClosedObserver
- (void)prefsWindowClosed:(NSNotification*)notify {
gotNotification_ = YES;
}
@end
namespace {
class PrefsControllerTest : public CocoaTest {
public:
virtual void SetUp() {
CocoaTest::SetUp();
// The metrics reporting pref is registerd on the local state object in
// real builds, but we don't have one of those for unit tests. Register
// it on prefs so we'll find it when we go looking.
PrefService* prefs = browser_helper_.profile()->GetPrefs();
prefs->RegisterBooleanPref(prefs::kMetricsReportingEnabled, false);
pref_controller_ = [[PreferencesWindowController alloc]
initWithProfile:browser_helper_.profile()
initialPage:OPTIONS_PAGE_DEFAULT];
EXPECT_TRUE(pref_controller_);
}
virtual void TearDown() {
[pref_controller_ close];
CocoaTest::TearDown();
}
BrowserTestHelper browser_helper_;
PreferencesWindowController* pref_controller_;
};
// Test showing the preferences window and making sure it's visible, then
// making sure we get the notification when it's closed.
TEST_F(PrefsControllerTest, ShowAndClose) {
[pref_controller_ showPreferences:nil];
EXPECT_TRUE([[pref_controller_ window] isVisible]);
scoped_nsobject<PrefsClosedObserver> observer(
[[PrefsClosedObserver alloc] init]);
NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];
[defaultCenter addObserver:observer.get()
selector:@selector(prefsWindowClosed:)
name:NSWindowWillCloseNotification
object:[pref_controller_ window]];
[[pref_controller_ window] performClose:observer];
EXPECT_TRUE(observer.get()->gotNotification_);
[defaultCenter removeObserver:observer.get()];
// Prevent pref_controller_ from being closed again in TearDown()
pref_controller_ = nil;
}
TEST_F(PrefsControllerTest, ValidateCustomHomePagesTable) {
// First, insert two valid URLs into the CustomHomePagesModel.
GURL url1("http://www.google.com/");
GURL url2("http://maps.google.com/");
std::vector<GURL> urls;
urls.push_back(url1);
urls.push_back(url2);
[[pref_controller_ customPagesSource] setURLs:urls];
EXPECT_EQ(2U, [[pref_controller_ customPagesSource] countOfCustomHomePages]);
// Now insert a bad (empty) URL into the model.
[[pref_controller_ customPagesSource] setURLStringEmptyAt:1];
// Send a notification to simulate the end of editing on a cell in the table
// which should trigger validation.
[pref_controller_ controlTextDidEndEditing:[NSNotification
notificationWithName:NSControlTextDidEndEditingNotification
object:nil]];
EXPECT_EQ(1U, [[pref_controller_ customPagesSource] countOfCustomHomePages]);
}
TEST_F(PrefsControllerTest, NormalizePage) {
EXPECT_EQ(OPTIONS_PAGE_GENERAL,
[pref_controller_ normalizePage:OPTIONS_PAGE_GENERAL]);
EXPECT_EQ(OPTIONS_PAGE_CONTENT,
[pref_controller_ normalizePage:OPTIONS_PAGE_CONTENT]);
EXPECT_EQ(OPTIONS_PAGE_ADVANCED,
[pref_controller_ normalizePage:OPTIONS_PAGE_ADVANCED]);
[pref_controller_ lastSelectedPage]->SetValue(OPTIONS_PAGE_ADVANCED);
EXPECT_EQ(OPTIONS_PAGE_ADVANCED,
[pref_controller_ normalizePage:OPTIONS_PAGE_DEFAULT]);
[pref_controller_ lastSelectedPage]->SetValue(OPTIONS_PAGE_DEFAULT);
EXPECT_EQ(OPTIONS_PAGE_GENERAL,
[pref_controller_ normalizePage:OPTIONS_PAGE_DEFAULT]);
}
TEST_F(PrefsControllerTest, GetToolbarItemForPage) {
// Trigger awakeFromNib.
[pref_controller_ window];
NSArray* toolbarItems = [[pref_controller_ toolbar] items];
EXPECT_EQ([toolbarItems objectAtIndex:0],
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_GENERAL]);
EXPECT_EQ([toolbarItems objectAtIndex:1],
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_CONTENT]);
EXPECT_EQ([toolbarItems objectAtIndex:2],
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_ADVANCED]);
[pref_controller_ lastSelectedPage]->SetValue(OPTIONS_PAGE_ADVANCED);
EXPECT_EQ([toolbarItems objectAtIndex:2],
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_DEFAULT]);
// Out-of-range argument.
EXPECT_EQ([toolbarItems objectAtIndex:0],
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_COUNT]);
}
TEST_F(PrefsControllerTest, GetPageForToolbarItem) {
scoped_nsobject<NSToolbarItem> toolbarItem(
[[NSToolbarItem alloc] initWithItemIdentifier:@""]);
[toolbarItem setTag:0];
EXPECT_EQ(OPTIONS_PAGE_GENERAL,
[pref_controller_ getPageForToolbarItem:toolbarItem]);
[toolbarItem setTag:1];
EXPECT_EQ(OPTIONS_PAGE_CONTENT,
[pref_controller_ getPageForToolbarItem:toolbarItem]);
[toolbarItem setTag:2];
EXPECT_EQ(OPTIONS_PAGE_ADVANCED,
[pref_controller_ getPageForToolbarItem:toolbarItem]);
// Out-of-range argument.
[toolbarItem setTag:3];
EXPECT_EQ(OPTIONS_PAGE_GENERAL,
[pref_controller_ getPageForToolbarItem:toolbarItem]);
}
TEST_F(PrefsControllerTest, GetPrefsViewForPage) {
// Trigger awakeFromNib.
[pref_controller_ window];
EXPECT_EQ([pref_controller_ basicsView],
[pref_controller_ getPrefsViewForPage:OPTIONS_PAGE_GENERAL]);
EXPECT_EQ([pref_controller_ personalStuffView],
[pref_controller_ getPrefsViewForPage:OPTIONS_PAGE_CONTENT]);
EXPECT_EQ([pref_controller_ underTheHoodView],
[pref_controller_ getPrefsViewForPage:OPTIONS_PAGE_ADVANCED]);
[pref_controller_ lastSelectedPage]->SetValue(OPTIONS_PAGE_ADVANCED);
EXPECT_EQ([pref_controller_ underTheHoodView],
[pref_controller_ getPrefsViewForPage:OPTIONS_PAGE_DEFAULT]);
}
TEST_F(PrefsControllerTest, SwitchToPage) {
// Trigger awakeFromNib.
NSWindow* window = [pref_controller_ window];
NSView* contentView = [window contentView];
NSView* basicsView = [pref_controller_ basicsView];
NSView* personalStuffView = [pref_controller_ personalStuffView];
NSView* underTheHoodView = [pref_controller_ underTheHoodView];
NSToolbar* toolbar = [pref_controller_ toolbar];
NSToolbarItem* basicsToolbarItem =
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_GENERAL];
NSToolbarItem* personalStuffToolbarItem =
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_CONTENT];
NSToolbarItem* underTheHoodToolbarItem =
[pref_controller_ getToolbarItemForPage:OPTIONS_PAGE_ADVANCED];
NSString* basicsIdentifier = [basicsToolbarItem itemIdentifier];
NSString* personalStuffIdentifier = [personalStuffToolbarItem itemIdentifier];
NSString* underTheHoodIdentifier = [underTheHoodToolbarItem itemIdentifier];
IntegerPrefMember* lastSelectedPage = [pref_controller_ lastSelectedPage];
// Test without animation.
[pref_controller_ switchToPage:OPTIONS_PAGE_GENERAL animate:NO];
EXPECT_TRUE([basicsView isDescendantOf:contentView]);
EXPECT_FALSE([personalStuffView isDescendantOf:contentView]);
EXPECT_FALSE([underTheHoodView isDescendantOf:contentView]);
EXPECT_TRUE([[toolbar selectedItemIdentifier] isEqualTo:basicsIdentifier]);
EXPECT_EQ(OPTIONS_PAGE_GENERAL, lastSelectedPage->GetValue());
EXPECT_TRUE([[window title] isEqualTo:[basicsToolbarItem label]]);
[pref_controller_ switchToPage:OPTIONS_PAGE_CONTENT animate:NO];
EXPECT_FALSE([basicsView isDescendantOf:contentView]);
EXPECT_TRUE([personalStuffView isDescendantOf:contentView]);
EXPECT_FALSE([underTheHoodView isDescendantOf:contentView]);
EXPECT_TRUE([[toolbar selectedItemIdentifier]
isEqualTo:personalStuffIdentifier]);
EXPECT_EQ(OPTIONS_PAGE_CONTENT, lastSelectedPage->GetValue());
EXPECT_TRUE([[window title] isEqualTo:[personalStuffToolbarItem label]]);
[pref_controller_ switchToPage:OPTIONS_PAGE_ADVANCED animate:NO];
EXPECT_FALSE([basicsView isDescendantOf:contentView]);
EXPECT_FALSE([personalStuffView isDescendantOf:contentView]);
EXPECT_TRUE([underTheHoodView isDescendantOf:contentView]);
EXPECT_TRUE([[toolbar selectedItemIdentifier]
isEqualTo:underTheHoodIdentifier]);
EXPECT_EQ(OPTIONS_PAGE_ADVANCED, lastSelectedPage->GetValue());
EXPECT_TRUE([[window title] isEqualTo:[underTheHoodToolbarItem label]]);
// Test OPTIONS_PAGE_DEFAULT.
lastSelectedPage->SetValue(OPTIONS_PAGE_CONTENT);
[pref_controller_ switchToPage:OPTIONS_PAGE_DEFAULT animate:NO];
EXPECT_FALSE([basicsView isDescendantOf:contentView]);
EXPECT_TRUE([personalStuffView isDescendantOf:contentView]);
EXPECT_FALSE([underTheHoodView isDescendantOf:contentView]);
EXPECT_TRUE([[toolbar selectedItemIdentifier]
isEqualTo:personalStuffIdentifier]);
EXPECT_EQ(OPTIONS_PAGE_CONTENT, lastSelectedPage->GetValue());
EXPECT_TRUE([[window title] isEqualTo:[personalStuffToolbarItem label]]);
// TODO(akalin): Figure out how to test animation; we'll need everything
// to stick around until the animation finishes.
}
// TODO(akalin): Figure out how to test sync controls.
// TODO(akalin): Figure out how to test that sync controls are not shown
// when there isn't a sync service.
} // namespace
|
