1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
|
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Cocoa/Cocoa.h>
#import "base/scoped_nsobject.h"
#include "chrome/app/chrome_dll_resource.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
#import "chrome/browser/cocoa/cocoa_test_helper.h"
#import "chrome/browser/cocoa/toolbar_controller.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/pref_service.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
class ToolbarControllerTest : public testing::Test {
public:
// Indexes that match the ordering returned by the private ToolbarController
// |-toolbarViews| method.
enum {
kBackIndex, kForwardIndex, kReloadIndex, kHomeIndex, kStarIndex, kGoIndex,
kPageIndex, kWrenchIndex, kLocationIndex,
};
ToolbarControllerTest() {
Browser* browser = helper_.browser();
CommandUpdater* updater = browser->command_updater();
// The default state for the commands is true, set a couple to false to
// ensure they get picked up correct on initialization
updater->UpdateCommandEnabled(IDC_BACK, false);
updater->UpdateCommandEnabled(IDC_FORWARD, false);
bar_.reset(
[[ToolbarController alloc] initWithModel:browser->toolbar_model()
commands:browser->command_updater()
profile:helper_.profile()
webContentView:nil
infoBarsView:nil
bookmarkDelegate:nil]);
EXPECT_TRUE([bar_ view]);
NSView* parent = [cocoa_helper_.window() contentView];
[parent addSubview:[bar_ view]];
}
// Make sure the enabled state of the view is the same as the corresponding
// command in the updater. The views are in the declaration order of outlets.
void CompareState(CommandUpdater* updater, NSArray* views) {
EXPECT_EQ(updater->IsCommandEnabled(IDC_BACK),
[[views objectAtIndex:kBackIndex] isEnabled] ? true : false);
EXPECT_EQ(updater->IsCommandEnabled(IDC_FORWARD),
[[views objectAtIndex:kForwardIndex] isEnabled] ? true : false);
EXPECT_EQ(updater->IsCommandEnabled(IDC_RELOAD),
[[views objectAtIndex:kReloadIndex] isEnabled] ? true : false);
EXPECT_EQ(updater->IsCommandEnabled(IDC_HOME),
[[views objectAtIndex:kHomeIndex] isEnabled] ? true : false);
EXPECT_EQ(updater->IsCommandEnabled(IDC_STAR),
[[views objectAtIndex:kStarIndex] isEnabled] ? true : false);
}
CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc...
BrowserTestHelper helper_;
scoped_nsobject<ToolbarController> bar_;
};
// Test the initial state that everything is sync'd up
TEST_F(ToolbarControllerTest, InitialState) {
CommandUpdater* updater = helper_.browser()->command_updater();
CompareState(updater, [bar_ toolbarViews]);
}
// Make sure awakeFromNib created a bookmarkBarController
TEST_F(ToolbarControllerTest, AwakeFromNibCreatesBMBController) {
EXPECT_TRUE([bar_ bookmarkBarController]);
}
// Make sure a "titlebar only" toolbar works
TEST_F(ToolbarControllerTest, TitlebarOnly) {
NSView* view = [bar_ view];
EXPECT_TRUE([bar_ bookmarkBarController]);
[bar_ setHasToolbar:NO];
EXPECT_NE(view, [bar_ view]);
EXPECT_FALSE([bar_ bookmarkBarController]);
[bar_ setHasToolbar:YES];
EXPECT_EQ(view, [bar_ view]);
EXPECT_TRUE([bar_ bookmarkBarController]);
// Leave it off to make sure that's fine
[bar_ setHasToolbar:NO];
}
// Make some changes to the enabled state of a few of the buttons and ensure
// that we're still in sync.
TEST_F(ToolbarControllerTest, UpdateEnabledState) {
CommandUpdater* updater = helper_.browser()->command_updater();
EXPECT_FALSE(updater->IsCommandEnabled(IDC_BACK));
EXPECT_FALSE(updater->IsCommandEnabled(IDC_FORWARD));
updater->UpdateCommandEnabled(IDC_BACK, true);
updater->UpdateCommandEnabled(IDC_FORWARD, true);
CompareState(updater, [bar_ toolbarViews]);
}
TEST_F(ToolbarControllerTest, StarredState) {
// TODO(pinkerton): I'm not sure how to test this, as the only difference
// in internal state is in the image used. I tried using the name of the
// image on the button but it doesn't seem to stick to the NSImage, even
// when explicitly set.
}
// Focus the location bar and make sure that it's the first responder.
TEST_F(ToolbarControllerTest, FocusLocation) {
NSWindow* window = cocoa_helper_.window();
[window makeFirstResponder:[window contentView]];
EXPECT_EQ([window firstResponder], [window contentView]);
[bar_ focusLocationBar];
EXPECT_NE([window firstResponder], [window contentView]);
NSView* locationBar = [[bar_ toolbarViews] objectAtIndex:kLocationIndex];
EXPECT_EQ([window firstResponder], [(id)locationBar currentEditor]);
}
// Test drawing, mostly to ensure nothing leaks or crashes.
TEST_F(ToolbarControllerTest, Display) {
[[bar_ view] display];
}
TEST_F(ToolbarControllerTest, LoadingState) {
// TODO(pinkerton): Same problem testing this as the starred state above.
// In its initial state, the go button has a tag of IDC_GO. When loading,
// it should be IDC_STOP.
NSButton* go = [[bar_ toolbarViews] objectAtIndex:kGoIndex];
EXPECT_EQ([go tag], IDC_GO);
[bar_ setIsLoading:YES];
EXPECT_EQ([go tag], IDC_STOP);
[bar_ setIsLoading:NO];
EXPECT_EQ([go tag], IDC_GO);
}
// Check that toggling the state of the home button changes the visible
// state of the home button and moves the other buttons accordingly.
TEST_F(ToolbarControllerTest, ToggleHome) {
PrefService* prefs = helper_.profile()->GetPrefs();
bool showHome = prefs->GetBoolean(prefs::kShowHomeButton);
NSView* homeButton = [[bar_ toolbarViews] objectAtIndex:kHomeIndex];
EXPECT_EQ(showHome, ![homeButton isHidden]);
NSView* starButton = [[bar_ toolbarViews] objectAtIndex:kStarIndex];
NSView* locationBar = [[bar_ toolbarViews] objectAtIndex:kLocationIndex];
NSRect originalStarFrame = [starButton frame];
NSRect originalLocationBarFrame = [locationBar frame];
// Toggle the pref and make sure the button changed state and the other
// views moved.
prefs->SetBoolean(prefs::kShowHomeButton, !showHome);
EXPECT_EQ(showHome, [homeButton isHidden]);
EXPECT_NE(NSMinX(originalStarFrame), NSMinX([starButton frame]));
EXPECT_NE(NSMinX(originalLocationBarFrame), NSMinX([locationBar frame]));
EXPECT_NE(NSWidth(originalLocationBarFrame), NSWidth([locationBar frame]));
}
TEST_F(ToolbarControllerTest, TogglePageWrench) {
PrefService* prefs = helper_.profile()->GetPrefs();
bool showButtons = prefs->GetBoolean(prefs::kShowPageOptionsButtons);
NSView* pageButton = [[bar_ toolbarViews] objectAtIndex:kPageIndex];
NSView* wrenchButton = [[bar_ toolbarViews] objectAtIndex:kWrenchIndex];
EXPECT_EQ(showButtons, ![pageButton isHidden]);
EXPECT_EQ(showButtons, ![wrenchButton isHidden]);
NSView* goButton = [[bar_ toolbarViews] objectAtIndex:kGoIndex];
NSView* locationBar = [[bar_ toolbarViews] objectAtIndex:kLocationIndex];
NSRect originalGoFrame = [goButton frame];
NSRect originalLocationBarFrame = [locationBar frame];
// Toggle the pref and make sure the buttons changed state and the other
// views moved (or in the case of the location bar, it changed width).
prefs->SetBoolean(prefs::kShowPageOptionsButtons, !showButtons);
EXPECT_EQ(showButtons, [pageButton isHidden]);
EXPECT_EQ(showButtons, [wrenchButton isHidden]);
EXPECT_NE(NSMinX(originalGoFrame), NSMinX([goButton frame]));
EXPECT_NE(NSWidth(originalLocationBarFrame), NSWidth([locationBar frame]));
}
} // namespace
|
