1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
|
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string.h>
#include "base/command_line.h"
#include "base/thread_task_runner_handle.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/dom_distiller/content/browser/distillable_page_utils.h"
#include "components/dom_distiller/core/dom_distiller_switches.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gmock/include/gmock/gmock.h"
namespace dom_distiller {
using ::testing::_;
using namespace switches::reader_mode_heuristics;
namespace {
const char kSimpleArticlePath[] = "/dom_distiller/simple_article.html";
const char kSimpleArticleIFramePath[] =
"/dom_distiller/simple_article_iframe.html";
const char kArticlePath[] = "/dom_distiller/og_article.html";
const char kNonArticlePath[] = "/dom_distiller/non_og_article.html";
const char* kAllPaths[] = {
kSimpleArticlePath,
kSimpleArticleIFramePath,
kArticlePath,
kNonArticlePath
};
class Holder {
public:
virtual ~Holder() {}
virtual void OnResult(bool, bool) = 0;
};
class MockDelegate : public Holder {
public:
MOCK_METHOD2(OnResult, void(bool, bool));
base::Callback<void(bool, bool)> GetDelegate() {
return base::Bind(&MockDelegate::OnResult, base::Unretained(this));
}
};
} // namespace
template<const char Option[]>
class DistillablePageUtilsBrowserTestOption : public InProcessBrowserTest {
public:
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(switches::kEnableDomDistiller);
command_line->AppendSwitchASCII(switches::kReaderModeHeuristics,
Option);
}
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->Start());
web_contents_ =
browser()->tab_strip_model()->GetActiveWebContents();
setDelegate(web_contents_, holder_.GetDelegate());
}
void NavigateAndWait(const char* url) {
GURL article_url(url);
if (base::StartsWith(url, "/", base::CompareCase::SENSITIVE)) {
article_url = embedded_test_server()->GetURL(url);
}
// This blocks until the navigation has completely finished.
ui_test_utils::NavigateToURL(browser(), article_url);
content::WaitForLoadStop(web_contents_);
// Wait a bit for the message.
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),
base::TimeDelta::FromMilliseconds(100));
content::RunMessageLoop();
}
MockDelegate holder_;
content::WebContents* web_contents_;
};
using DistillablePageUtilsBrowserTestAlways =
DistillablePageUtilsBrowserTestOption<kAlwaysTrue>;
IN_PROC_BROWSER_TEST_F(DistillablePageUtilsBrowserTestAlways,
TestDelegate) {
// Run twice to make sure the delegate object is still alive.
for (int i = 0; i < 2; ++i) {
testing::InSequence dummy;
EXPECT_CALL(holder_, OnResult(true, true)).Times(1);
NavigateAndWait(kSimpleArticlePath);
}
for (unsigned i = 0; i < sizeof(kAllPaths) / sizeof(kAllPaths[0]); ++i) {
testing::InSequence dummy;
EXPECT_CALL(holder_, OnResult(true, true)).Times(1);
NavigateAndWait(kAllPaths[i]);
}
// Test pages that we don't care about its distillability.
{
testing::InSequence dummy;
EXPECT_CALL(holder_, OnResult(_, _)).Times(0);
NavigateAndWait("about:blank");
}
}
using DistillablePageUtilsBrowserTestNone =
DistillablePageUtilsBrowserTestOption<kNone>;
IN_PROC_BROWSER_TEST_F(DistillablePageUtilsBrowserTestNone,
TestDelegate) {
EXPECT_CALL(holder_, OnResult(_, _)).Times(0);
NavigateAndWait(kSimpleArticlePath);
}
using DistillablePageUtilsBrowserTestOG =
DistillablePageUtilsBrowserTestOption<kOGArticle>;
IN_PROC_BROWSER_TEST_F(DistillablePageUtilsBrowserTestOG,
TestDelegate) {
{
testing::InSequence dummy;
EXPECT_CALL(holder_, OnResult(true, true)).Times(1);
NavigateAndWait(kArticlePath);
}
{
testing::InSequence dummy;
EXPECT_CALL(holder_, OnResult(false, true)).Times(1);
NavigateAndWait(kNonArticlePath);
}
}
using DistillablePageUtilsBrowserTestAdaboost =
DistillablePageUtilsBrowserTestOption<kAdaBoost>;
IN_PROC_BROWSER_TEST_F(DistillablePageUtilsBrowserTestAdaboost,
TestDelegate) {
const char* paths[] = {kSimpleArticlePath, kSimpleArticleIFramePath};
for (unsigned i = 0; i < sizeof(paths)/sizeof(paths[0]); ++i) {
testing::InSequence dummy;
EXPECT_CALL(holder_, OnResult(true, false)).Times(1);
EXPECT_CALL(holder_, OnResult(true, true)).Times(1);
NavigateAndWait(paths[i]);
}
{
testing::InSequence dummy;
EXPECT_CALL(holder_, OnResult(false, false)).Times(1);
EXPECT_CALL(holder_, OnResult(false, true)).Times(1);
NavigateAndWait(kNonArticlePath);
}
}
} // namespace dom_distiller
|
