1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/browser_list.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/extensions/extension_dom_ui.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/ui_test_utils.h"
class ExtensionOverrideTest : public ExtensionApiTest {
protected:
bool CheckHistoryOverridesContainsNoDupes() {
// There should be no duplicate entries in the preferences.
const DictionaryValue* overrides =
browser()->profile()->GetPrefs()->GetDictionary(
ExtensionDOMUI::kExtensionURLOverrides);
ListValue* values = NULL;
if (!overrides->GetList("history", &values))
return false;
std::set<std::string> seen_overrides;
for (size_t i = 0; i < values->GetSize(); ++i) {
std::string value;
if (!values->GetString(i, &value))
return false;
if (seen_overrides.find(value) != seen_overrides.end())
return false;
seen_overrides.insert(value);
}
return true;
}
#if defined(TOUCH_UI)
// Navigate to the keyboard page, and ensure we have arrived at an
// extension URL.
void NavigateToKeyboard() {
ui_test_utils::NavigateToURL(browser(), GURL("chrome://keyboard/"));
TabContents* tab = browser()->GetSelectedTabContents();
ASSERT_TRUE(tab->controller().GetActiveEntry());
EXPECT_TRUE(tab->controller().GetActiveEntry()->url().
SchemeIs(chrome::kExtensionScheme));
}
#endif
};
IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, OverrideNewtab) {
ASSERT_TRUE(RunExtensionTest("override/newtab")) << message_;
{
ResultCatcher catcher;
// Navigate to the new tab page. The overridden new tab page
// will call chrome.test.notifyPass() .
ui_test_utils::NavigateToURL(browser(), GURL("chrome://newtab/"));
TabContents* tab = browser()->GetSelectedTabContents();
ASSERT_TRUE(tab->controller().GetActiveEntry());
EXPECT_TRUE(tab->controller().GetActiveEntry()->url().
SchemeIs(chrome::kExtensionScheme));
ASSERT_TRUE(catcher.GetNextResult());
}
// TODO(erikkay) Load a second extension with the same override.
// Verify behavior, then unload the first and verify behavior, etc.
}
IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, OverrideNewtabIncognito) {
ASSERT_TRUE(RunExtensionTest("override/newtab")) << message_;
// Navigate an incognito tab to the new tab page. We should get the actual
// new tab page because we can't load chrome-extension URLs in incognito.
ui_test_utils::OpenURLOffTheRecord(browser()->profile(),
GURL("chrome://newtab/"));
Browser* otr_browser = BrowserList::FindBrowserWithType(
browser()->profile()->GetOffTheRecordProfile(), Browser::TYPE_NORMAL,
false);
TabContents* tab = otr_browser->GetSelectedTabContents();
ASSERT_TRUE(tab->controller().GetActiveEntry());
EXPECT_FALSE(tab->controller().GetActiveEntry()->url().
SchemeIs(chrome::kExtensionScheme));
}
// Times out consistently on Win, http://crbug.com/45173.
#if defined(OS_WIN)
#define MAYBE_OverrideHistory DISABLED_OverrideHistory
#else
#define MAYBE_OverrideHistory OverrideHistory
#endif // defined(OS_WIN)
IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, MAYBE_OverrideHistory) {
ASSERT_TRUE(RunExtensionTest("override/history")) << message_;
{
ResultCatcher catcher;
// Navigate to the history page. The overridden history page
// will call chrome.test.notifyPass() .
ui_test_utils::NavigateToURL(browser(), GURL("chrome://history/"));
ASSERT_TRUE(catcher.GetNextResult());
}
}
// Regression test for http://crbug.com/41442.
IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, ShouldNotCreateDuplicateEntries) {
ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("override/history")));
// Simulate several LoadExtension() calls happening over the lifetime of
// a preferences file without corresponding UnloadExtension() calls.
for (size_t i = 0; i < 3; ++i) {
ExtensionDOMUI::RegisterChromeURLOverrides(
browser()->profile(),
browser()->profile()->GetExtensionService()->extensions()->back()->
GetChromeURLOverrides());
}
ASSERT_TRUE(CheckHistoryOverridesContainsNoDupes());
}
IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, ShouldCleanUpDuplicateEntries) {
// Simulate several LoadExtension() calls happening over the lifetime of
// a preferences file without corresponding UnloadExtension() calls. This is
// the same as the above test, except for that it is testing the case where
// the file already contains dupes when an extension is loaded.
ListValue* list = new ListValue();
for (size_t i = 0; i < 3; ++i)
list->Append(Value::CreateStringValue("http://www.google.com/"));
browser()->profile()->GetPrefs()->GetMutableDictionary(
ExtensionDOMUI::kExtensionURLOverrides)->Set("history", list);
ASSERT_FALSE(CheckHistoryOverridesContainsNoDupes());
ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("override/history")));
ASSERT_TRUE(CheckHistoryOverridesContainsNoDupes());
}
#if defined(TOUCH_UI)
IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, OverrideKeyboard) {
ASSERT_TRUE(RunExtensionTest("override/keyboard")) << message_;
{
ResultCatcher catcher;
NavigateToKeyboard();
ASSERT_TRUE(catcher.GetNextResult());
}
// Load the failing version. This should take precedence.
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("override").AppendASCII("keyboard_fails")));
{
ResultCatcher catcher;
NavigateToKeyboard();
ASSERT_FALSE(catcher.GetNextResult());
}
// Unload the failing version. We should be back to passing now.
const ExtensionList *extensions =
browser()->profile()->GetExtensionService()->extensions();
UnloadExtension((*extensions->rbegin())->id());
{
ResultCatcher catcher;
NavigateToKeyboard();
ASSERT_TRUE(catcher.GetNextResult());
}
}
#endif
|
