1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
|
// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <algorithm>
#include <vector>
#include "base/file_path.h"
#include "base/file_util.h"
#include "base/json_reader.h"
#include "base/message_loop.h"
#include "base/path_service.h"
#include "base/string_util.h"
#include "chrome/browser/extensions/extension.h"
#include "chrome/browser/extensions/extensions_service.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/json_value_serializer.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
namespace {
struct ExtensionsOrder {
bool operator()(const Extension* a, const Extension* b) {
return a->name() < b->name();
}
};
} // namespace
// A mock implementation of ExtensionsServiceFrontendInterface for testing the
// backend.
class ExtensionsServiceTestFrontend
: public ExtensionsServiceFrontendInterface {
public:
ExtensionsServiceTestFrontend() {
file_util::CreateNewTempDirectory(FILE_PATH_LITERAL("ext_test"),
&install_dir_);
}
~ExtensionsServiceTestFrontend() {
for (ExtensionList::iterator iter = extensions_.begin();
iter != extensions_.end(); ++iter) {
delete *iter;
}
}
std::vector<std::string>* errors() {
return &errors_;
}
ExtensionList* extensions() {
return &extensions_;
}
std::vector<FilePath>* installed() {
return &installed_;
}
FilePath install_dir() {
return install_dir_;
}
// ExtensionsServiceFrontendInterface
virtual MessageLoop* GetMessageLoop() {
return &message_loop_;
}
virtual void InstallExtension(const FilePath& extension_path) {
}
virtual void LoadExtension(const FilePath& extension_path) {
}
virtual void OnExtensionLoadError(const std::string& message) {
// In the development environment, we get errors when trying to load
// extensions out of the .svn directories.
if (message.find(".svn") != std::string::npos)
return;
errors_.push_back(message);
}
virtual void OnExtensionsLoadedFromDirectory(ExtensionList* new_extensions) {
extensions_.insert(extensions_.end(), new_extensions->begin(),
new_extensions->end());
delete new_extensions;
// In the tests we rely on extensions being in particular order,
// which is not always the case (and is not guaranteed by used APIs).
std::stable_sort(extensions_.begin(), extensions_.end(), ExtensionsOrder());
}
virtual void OnExtensionInstallError(const std::string& message) {
errors_.push_back(message);
}
virtual void OnExtensionInstalled(FilePath path) {
installed_.push_back(path);
}
void TestInstallExtension(const FilePath& path,
ExtensionsServiceBackend* backend,
bool should_succeed) {
ASSERT_TRUE(file_util::PathExists(path));
EXPECT_EQ(should_succeed,
backend->InstallExtension(path, install_dir_,
scoped_refptr<ExtensionsServiceFrontendInterface>(this)));
message_loop_.RunAllPending();
if (should_succeed) {
EXPECT_EQ(1u, installed_.size());
EXPECT_EQ(0u, errors_.size());
} else {
EXPECT_EQ(0u, installed_.size());
EXPECT_EQ(1u, errors_.size());
}
installed_.clear();
errors_.clear();
}
private:
MessageLoop message_loop_;
ExtensionList extensions_;
std::vector<std::string> errors_;
std::vector<FilePath> installed_;
FilePath install_dir_;
};
// make the test a PlatformTest to setup autorelease pools properly on mac
typedef PlatformTest ExtensionsServiceTest;
// Test loading good extensions from the profile directory.
TEST_F(ExtensionsServiceTest, LoadAllExtensionsFromDirectorySuccess) {
FilePath extensions_path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &extensions_path));
extensions_path = extensions_path.AppendASCII("extensions");
extensions_path = extensions_path.AppendASCII("good");
scoped_refptr<ExtensionsServiceBackend> backend(new ExtensionsServiceBackend);
scoped_refptr<ExtensionsServiceTestFrontend> frontend(
new ExtensionsServiceTestFrontend);
std::vector<Extension*> extensions;
EXPECT_TRUE(backend->LoadExtensionsFromDirectory(extensions_path,
scoped_refptr<ExtensionsServiceFrontendInterface>(frontend.get())));
frontend->GetMessageLoop()->RunAllPending();
ASSERT_EQ(3u, frontend->extensions()->size());
EXPECT_EQ(std::string("com.google.myextension1"),
frontend->extensions()->at(0)->id());
EXPECT_EQ(std::string("My extension 1"),
frontend->extensions()->at(0)->name());
EXPECT_EQ(std::string("The first extension that I made."),
frontend->extensions()->at(0)->description());
Extension* extension = frontend->extensions()->at(0);
const UserScriptList& scripts = extension->content_scripts();
ASSERT_EQ(2u, scripts.size());
EXPECT_EQ(2u, scripts[0].url_patterns().size());
EXPECT_EQ("http://*.google.com/*",
scripts[0].url_patterns()[0].GetAsString());
EXPECT_EQ("https://*.google.com/*",
scripts[0].url_patterns()[1].GetAsString());
EXPECT_EQ(extension->path().AppendASCII("script1.js").value(),
scripts[0].path().value());
EXPECT_EQ(1u, scripts[1].url_patterns().size());
EXPECT_EQ("http://*.yahoo.com/*", scripts[1].url_patterns()[0].GetAsString());
EXPECT_EQ(extension->path().AppendASCII("script2.js").value(),
scripts[1].path().value());
EXPECT_EQ(std::string("com.google.myextension2"),
frontend->extensions()->at(1)->id());
EXPECT_EQ(std::string("My extension 2"),
frontend->extensions()->at(1)->name());
EXPECT_EQ(std::string(""),
frontend->extensions()->at(1)->description());
ASSERT_EQ(0u, frontend->extensions()->at(1)->content_scripts().size());
EXPECT_EQ(std::string("com.google.myextension3"),
frontend->extensions()->at(2)->id());
EXPECT_EQ(std::string("My extension 3"),
frontend->extensions()->at(2)->name());
EXPECT_EQ(std::string(""),
frontend->extensions()->at(2)->description());
ASSERT_EQ(0u, frontend->extensions()->at(2)->content_scripts().size());
};
// Test loading bad extensions from the profile directory.
TEST_F(ExtensionsServiceTest, LoadAllExtensionsFromDirectoryFail) {
FilePath extensions_path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &extensions_path));
extensions_path = extensions_path.AppendASCII("extensions");
extensions_path = extensions_path.AppendASCII("bad");
scoped_refptr<ExtensionsServiceBackend> backend(new ExtensionsServiceBackend);
scoped_refptr<ExtensionsServiceTestFrontend> frontend(
new ExtensionsServiceTestFrontend);
std::vector<Extension*> extensions;
EXPECT_TRUE(backend->LoadExtensionsFromDirectory(extensions_path,
scoped_refptr<ExtensionsServiceFrontendInterface>(frontend.get())));
frontend->GetMessageLoop()->RunAllPending();
EXPECT_EQ(4u, frontend->errors()->size());
EXPECT_EQ(0u, frontend->extensions()->size());
EXPECT_TRUE(MatchPattern(frontend->errors()->at(0),
std::string("Could not load extension from '*'. * ") +
JSONReader::kBadRootElementType));
EXPECT_TRUE(MatchPattern(frontend->errors()->at(1),
std::string("Could not load extension from '*'. ") +
Extension::kInvalidJsListError));
EXPECT_TRUE(MatchPattern(frontend->errors()->at(2),
std::string("Could not load extension from '*'. ") +
Extension::kInvalidManifestError));
EXPECT_TRUE(MatchPattern(frontend->errors()->at(3),
"Could not load extension from '*'. Could not read '*' file."));
};
// Test installing extensions.
TEST_F(ExtensionsServiceTest, InstallExtension) {
FilePath extensions_path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &extensions_path));
extensions_path = extensions_path.AppendASCII("extensions");
scoped_refptr<ExtensionsServiceBackend> backend(new ExtensionsServiceBackend);
scoped_refptr<ExtensionsServiceTestFrontend> frontend(
new ExtensionsServiceTestFrontend);
FilePath path = extensions_path.AppendASCII("good.crx");
// A simple extension that should install without error.
frontend->TestInstallExtension(path, backend, true);
// TODO(erikkay): verify the contents of the installed extension.
// Installing the same extension twice should fail.
frontend->TestInstallExtension(path, backend, false);
// 0-length extension file.
path = extensions_path.AppendASCII("not_an_extension.crx");
frontend->TestInstallExtension(path, backend, false);
// Bad magic number.
path = extensions_path.AppendASCII("bad_magic.crx");
frontend->TestInstallExtension(path, backend, false);
// Poorly formed JSON.
path = extensions_path.AppendASCII("bad_json.crx");
frontend->TestInstallExtension(path, backend, false);
// Incorrect zip hash.
path = extensions_path.AppendASCII("bad_hash.crx");
frontend->TestInstallExtension(path, backend, false);
// TODO(erikkay): add more tests for many of the failure cases.
// TODO(erikkay): add tests for upgrade cases.
}
TEST_F(ExtensionsServiceTest, LoadExtension) {
FilePath extensions_path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &extensions_path));
extensions_path = extensions_path.AppendASCII("extensions");
scoped_refptr<ExtensionsServiceBackend> backend(new ExtensionsServiceBackend);
scoped_refptr<ExtensionsServiceTestFrontend> frontend(
new ExtensionsServiceTestFrontend);
FilePath ext1 = extensions_path.AppendASCII("good").AppendASCII("extension1")
.AppendASCII("1");
EXPECT_TRUE(backend->LoadSingleExtension(ext1,
scoped_refptr<ExtensionsServiceFrontendInterface>(frontend.get())));
frontend->GetMessageLoop()->RunAllPending();
EXPECT_EQ(0u, frontend->errors()->size());
ASSERT_EQ(1u, frontend->extensions()->size());
FilePath no_manifest = extensions_path.AppendASCII("bad")
.AppendASCII("no_manifest").AppendASCII("1");
EXPECT_FALSE(backend->LoadSingleExtension(no_manifest,
scoped_refptr<ExtensionsServiceFrontendInterface>(frontend.get())));
frontend->GetMessageLoop()->RunAllPending();
EXPECT_EQ(1u, frontend->errors()->size());
ASSERT_EQ(1u, frontend->extensions()->size());
}
|