1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/gtk/bookmark_editor_gtk.h"
#include <gtk/gtk.h>
#include "app/l10n_util.h"
#include "base/basictypes.h"
#include "base/logging.h"
#include "base/string_util.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/gtk/bookmark_tree_model.h"
#include "chrome/browser/gtk/bookmark_utils_gtk.h"
#include "chrome/browser/gtk/gtk_theme_provider.h"
#include "chrome/browser/gtk/gtk_util.h"
#include "chrome/browser/history/history.h"
#include "chrome/browser/net/url_fixer_upper.h"
#include "chrome/browser/profile.h"
#include "gfx/gtk_util.h"
#include "googleurl/src/gurl.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
namespace {
// Background color of text field when URL is invalid.
const GdkColor kErrorColor = GDK_COLOR_RGB(0xFF, 0xBC, 0xBC);
// Preferred initial dimensions, in pixels, of the folder tree.
static const int kTreeWidth = 300;
static const int kTreeHeight = 150;
} // namespace
// static
void BookmarkEditor::Show(gfx::NativeWindow parent_hwnd,
Profile* profile,
const BookmarkNode* parent,
const EditDetails& details,
Configuration configuration) {
DCHECK(profile);
BookmarkEditorGtk* editor =
new BookmarkEditorGtk(parent_hwnd, profile, parent, details,
configuration);
editor->Show();
}
BookmarkEditorGtk::BookmarkEditorGtk(
GtkWindow* window,
Profile* profile,
const BookmarkNode* parent,
const EditDetails& details,
BookmarkEditor::Configuration configuration)
: profile_(profile),
dialog_(NULL),
parent_(parent),
details_(details),
running_menu_for_root_(false),
show_tree_(configuration == SHOW_TREE) {
DCHECK(profile);
Init(window);
}
BookmarkEditorGtk::~BookmarkEditorGtk() {
// The tree model is deleted before the view. Reset the model otherwise the
// tree will reference a deleted model.
bb_model_->RemoveObserver(this);
}
void BookmarkEditorGtk::Init(GtkWindow* parent_window) {
bb_model_ = profile_->GetBookmarkModel();
DCHECK(bb_model_);
bb_model_->AddObserver(this);
dialog_ = gtk_dialog_new_with_buttons(
l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_TITLE).c_str(),
parent_window,
GTK_DIALOG_MODAL,
GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT,
GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,
NULL);
gtk_dialog_set_has_separator(GTK_DIALOG(dialog_), FALSE);
if (show_tree_) {
GtkWidget* action_area = GTK_DIALOG(dialog_)->action_area;
new_folder_button_ = gtk_button_new_with_label(
l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_NEW_FOLDER_BUTTON).c_str());
g_signal_connect(new_folder_button_, "clicked",
G_CALLBACK(OnNewFolderClickedThunk), this);
gtk_container_add(GTK_CONTAINER(action_area), new_folder_button_);
gtk_button_box_set_child_secondary(GTK_BUTTON_BOX(action_area),
new_folder_button_, TRUE);
}
gtk_dialog_set_default_response(GTK_DIALOG(dialog_), GTK_RESPONSE_ACCEPT);
// The GTK dialog content area layout (overview)
//
// +- GtkVBox |vbox| ----------------------------------------------+
// |+- GtkTable |table| ------------------------------------------+|
// ||+- GtkLabel ------+ +- GtkEntry |name_entry_| --------------+||
// ||| | | |||
// ||+-----------------+ +---------------------------------------+||
// ||+- GtkLabel ------+ +- GtkEntry |url_entry_| ---------------+|| *
// ||| | | |||
// ||+-----------------+ +---------------------------------------+||
// |+-------------------------------------------------------------+|
// |+- GtkScrollWindow |scroll_window| ---------------------------+|
// ||+- GtkTreeView |tree_view_| --------------------------------+||
// |||+- GtkTreeViewColumn |name_column| -----------------------+|||
// |||| ||||
// |||| ||||
// |||| ||||
// |||| ||||
// |||+---------------------------------------------------------+|||
// ||+-----------------------------------------------------------+||
// |+-------------------------------------------------------------+|
// +---------------------------------------------------------------+
//
// * The url and corresponding label are not shown if creating a new folder.
GtkWidget* content_area = GTK_DIALOG(dialog_)->vbox;
gtk_box_set_spacing(GTK_BOX(content_area), gtk_util::kContentAreaSpacing);
GtkWidget* vbox = gtk_vbox_new(FALSE, 12);
name_entry_ = gtk_entry_new();
std::string title;
if (details_.type == EditDetails::EXISTING_NODE) {
title = WideToUTF8(details_.existing_node->GetTitle());
} else if (details_.type == EditDetails::NEW_FOLDER) {
title = WideToUTF8(
l10n_util::GetString(IDS_BOOMARK_EDITOR_NEW_FOLDER_NAME));
}
gtk_entry_set_text(GTK_ENTRY(name_entry_), title.c_str());
g_signal_connect(name_entry_, "changed",
G_CALLBACK(OnEntryChangedThunk), this);
gtk_entry_set_activates_default(GTK_ENTRY(name_entry_), TRUE);
GtkWidget* table;
if (details_.type != EditDetails::NEW_FOLDER) {
url_entry_ = gtk_entry_new();
std::string url_spec;
if (details_.type == EditDetails::EXISTING_NODE)
url_spec = details_.existing_node->GetURL().spec();
gtk_entry_set_text(GTK_ENTRY(url_entry_), url_spec.c_str());
g_signal_connect(url_entry_, "changed",
G_CALLBACK(OnEntryChangedThunk), this);
gtk_entry_set_activates_default(GTK_ENTRY(url_entry_), TRUE);
table = gtk_util::CreateLabeledControlsGroup(NULL,
l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_NAME_LABEL).c_str(),
name_entry_,
l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_URL_LABEL).c_str(),
url_entry_,
NULL);
} else {
url_entry_ = NULL;
table = gtk_util::CreateLabeledControlsGroup(NULL,
l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_NAME_LABEL).c_str(),
name_entry_,
NULL);
}
gtk_box_pack_start(GTK_BOX(vbox), table, FALSE, FALSE, 0);
if (show_tree_) {
GtkTreeIter selected_iter;
int64 selected_id = 0;
if (details_.type == EditDetails::EXISTING_NODE)
selected_id = details_.existing_node->GetParent()->id();
else if (parent_)
selected_id = parent_->id();
tree_store_ = bookmark_utils::MakeFolderTreeStore();
bookmark_utils::AddToTreeStore(bb_model_, selected_id, tree_store_,
&selected_iter);
tree_view_ = bookmark_utils::MakeTreeViewForStore(tree_store_);
gtk_widget_set_size_request(tree_view_, kTreeWidth, kTreeHeight);
tree_selection_ = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree_view_));
GtkTreePath* path = NULL;
if (selected_id) {
path = gtk_tree_model_get_path(GTK_TREE_MODEL(tree_store_),
&selected_iter);
} else {
// We don't have a selected parent (Probably because we're making a new
// bookmark). Select the first item in the list.
path = gtk_tree_path_new_from_string("0");
}
gtk_tree_view_expand_to_path(GTK_TREE_VIEW(tree_view_), path);
gtk_tree_selection_select_path(tree_selection_, path);
gtk_tree_path_free(path);
GtkWidget* scroll_window = gtk_scrolled_window_new(NULL, NULL);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scroll_window),
GTK_POLICY_NEVER,
GTK_POLICY_AUTOMATIC);
gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(scroll_window),
GTK_SHADOW_ETCHED_IN);
gtk_container_add(GTK_CONTAINER(scroll_window), tree_view_);
gtk_box_pack_start(GTK_BOX(vbox), scroll_window, TRUE, TRUE, 0);
g_signal_connect(gtk_tree_view_get_selection(GTK_TREE_VIEW(tree_view_)),
"changed", G_CALLBACK(OnSelectionChangedThunk), this);
}
gtk_box_pack_start(GTK_BOX(content_area), vbox, TRUE, TRUE, 0);
g_signal_connect(dialog_, "response",
G_CALLBACK(OnResponseThunk), this);
g_signal_connect(dialog_, "delete-event",
G_CALLBACK(OnWindowDeleteEventThunk), this);
g_signal_connect(dialog_, "destroy",
G_CALLBACK(OnWindowDestroyThunk), this);
}
void BookmarkEditorGtk::Show() {
// Manually call our OnEntryChanged handler to set the initial state.
OnEntryChanged(NULL);
gtk_widget_show_all(dialog_);
}
void BookmarkEditorGtk::Close() {
// Under the model that we've inherited from Windows, dialogs can receive
// more than one Close() call inside the current message loop event.
if (dialog_) {
gtk_widget_destroy(dialog_);
dialog_ = NULL;
}
}
void BookmarkEditorGtk::BookmarkNodeMoved(BookmarkModel* model,
const BookmarkNode* old_parent,
int old_index,
const BookmarkNode* new_parent,
int new_index) {
Reset();
}
void BookmarkEditorGtk::BookmarkNodeAdded(BookmarkModel* model,
const BookmarkNode* parent,
int index) {
Reset();
}
void BookmarkEditorGtk::BookmarkNodeRemoved(BookmarkModel* model,
const BookmarkNode* parent,
int index,
const BookmarkNode* node) {
if ((details_.type == EditDetails::EXISTING_NODE &&
details_.existing_node->HasAncestor(node)) ||
(parent_ && parent_->HasAncestor(node))) {
// The node, or its parent was removed. Close the dialog.
Close();
} else {
Reset();
}
}
void BookmarkEditorGtk::BookmarkNodeChildrenReordered(
BookmarkModel* model, const BookmarkNode* node) {
Reset();
}
void BookmarkEditorGtk::Reset() {
// TODO(erg): The windows implementation tries to be smart. For now, just
// close the window.
Close();
}
GURL BookmarkEditorGtk::GetInputURL() const {
if (!url_entry_)
return GURL(); // Happens when we're editing a folder.
return GURL(URLFixerUpper::FixupURL(
gtk_entry_get_text(GTK_ENTRY(url_entry_)), ""));
}
std::wstring BookmarkEditorGtk::GetInputTitle() const {
return UTF8ToWide(gtk_entry_get_text(GTK_ENTRY(name_entry_)));
}
void BookmarkEditorGtk::ApplyEdits() {
DCHECK(bb_model_->IsLoaded());
GtkTreeIter currently_selected_iter;
if (show_tree_) {
if (!gtk_tree_selection_get_selected(tree_selection_, NULL,
¤tly_selected_iter)) {
ApplyEdits(NULL);
return;
}
}
ApplyEdits(¤tly_selected_iter);
}
void BookmarkEditorGtk::ApplyEdits(GtkTreeIter* selected_parent) {
// We're going to apply edits to the bookmark bar model, which will call us
// back. Normally when a structural edit occurs we reset the tree model.
// We don't want to do that here, so we remove ourselves as an observer.
bb_model_->RemoveObserver(this);
GURL new_url(GetInputURL());
std::wstring new_title(GetInputTitle());
if (!show_tree_ || !selected_parent) {
bookmark_utils::ApplyEditsWithNoGroupChange(
bb_model_, parent_, details_, new_title, new_url);
return;
}
// Create the new groups and update the titles.
const BookmarkNode* new_parent =
bookmark_utils::CommitTreeStoreDifferencesBetween(
bb_model_, tree_store_, selected_parent);
if (!new_parent) {
// Bookmarks must be parented.
NOTREACHED();
return;
}
bookmark_utils::ApplyEditsWithPossibleGroupChange(
bb_model_, new_parent, details_, new_title, new_url);
}
void BookmarkEditorGtk::AddNewGroup(GtkTreeIter* parent, GtkTreeIter* child) {
gtk_tree_store_append(tree_store_, child, parent);
gtk_tree_store_set(
tree_store_, child,
bookmark_utils::FOLDER_ICON, GtkThemeProvider::GetFolderIcon(true),
bookmark_utils::FOLDER_NAME,
l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_NEW_FOLDER_NAME).c_str(),
bookmark_utils::ITEM_ID, static_cast<int64>(0),
bookmark_utils::IS_EDITABLE, TRUE,
-1);
}
void BookmarkEditorGtk::OnSelectionChanged(GtkWidget* selection) {
if (!gtk_tree_selection_get_selected(tree_selection_, NULL, NULL))
gtk_widget_set_sensitive(new_folder_button_, FALSE);
else
gtk_widget_set_sensitive(new_folder_button_, TRUE);
}
void BookmarkEditorGtk::OnResponse(GtkWidget* dialog, int response_id) {
if (response_id == GTK_RESPONSE_ACCEPT)
ApplyEdits();
Close();
}
gboolean BookmarkEditorGtk::OnWindowDeleteEvent(GtkWidget* widget,
GdkEvent* event) {
Close();
// Return true to prevent the gtk dialog from being destroyed. Close will
// destroy it for us and the default gtk_dialog_delete_event_handler() will
// force the destruction without us being able to stop it.
return TRUE;
}
void BookmarkEditorGtk::OnWindowDestroy(GtkWidget* widget) {
MessageLoop::current()->DeleteSoon(FROM_HERE, this);
}
void BookmarkEditorGtk::OnEntryChanged(GtkWidget* entry) {
gboolean can_close = TRUE;
if (details_.type == EditDetails::NEW_FOLDER) {
if (GetInputTitle().empty()) {
gtk_widget_modify_base(name_entry_, GTK_STATE_NORMAL,
&kErrorColor);
can_close = FALSE;
} else {
gtk_widget_modify_base(name_entry_, GTK_STATE_NORMAL, NULL);
}
} else {
GURL url(GetInputURL());
if (!url.is_valid()) {
gtk_widget_modify_base(url_entry_, GTK_STATE_NORMAL,
&kErrorColor);
can_close = FALSE;
} else {
gtk_widget_modify_base(url_entry_, GTK_STATE_NORMAL, NULL);
}
}
gtk_dialog_set_response_sensitive(GTK_DIALOG(dialog_),
GTK_RESPONSE_ACCEPT, can_close);
}
void BookmarkEditorGtk::OnNewFolderClicked(GtkWidget* button) {
GtkTreeIter iter;
if (!gtk_tree_selection_get_selected(tree_selection_,
NULL,
&iter)) {
NOTREACHED() << "Something should always be selected if New Folder " <<
"is clicked";
return;
}
GtkTreeIter new_item_iter;
AddNewGroup(&iter, &new_item_iter);
GtkTreePath* path = gtk_tree_model_get_path(
GTK_TREE_MODEL(tree_store_), &new_item_iter);
gtk_tree_view_expand_to_path(GTK_TREE_VIEW(tree_view_), path);
// Make the folder name editable.
gtk_tree_view_set_cursor(GTK_TREE_VIEW(tree_view_), path,
gtk_tree_view_get_column(GTK_TREE_VIEW(tree_view_), 0),
TRUE);
gtk_tree_path_free(path);
}
|