1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
|
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/file_path.h"
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/scoped_temp_dir.h"
#include "base/string_util.h"
#include "chrome/browser/history/url_database.h"
#include "chrome/browser/history/visit_database.h"
#include "sql/connection.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
using base::Time;
using base::TimeDelta;
namespace history {
namespace {
bool IsVisitInfoEqual(const VisitRow& a,
const VisitRow& b) {
return a.visit_id == b.visit_id &&
a.url_id == b.url_id &&
a.visit_time == b.visit_time &&
a.referring_visit == b.referring_visit &&
a.transition == b.transition &&
a.is_indexed == b.is_indexed;
}
} // namespace
class VisitDatabaseTest : public PlatformTest,
public URLDatabase,
public VisitDatabase {
public:
VisitDatabaseTest() {
}
private:
// Test setup.
void SetUp() {
PlatformTest::SetUp();
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
FilePath db_file = temp_dir_.path().AppendASCII("VisitTest.db");
EXPECT_TRUE(db_.Open(db_file));
// Initialize the tables for this test.
CreateURLTable(false);
CreateMainURLIndex();
InitVisitTable();
}
void TearDown() {
db_.Close();
PlatformTest::TearDown();
}
// Provided for URL/VisitDatabase.
virtual sql::Connection& GetDB() {
return db_;
}
ScopedTempDir temp_dir_;
sql::Connection db_;
};
TEST_F(VisitDatabaseTest, Add) {
// Add one visit.
VisitRow visit_info1(1, Time::Now(), 0, content::PAGE_TRANSITION_LINK, 0);
EXPECT_TRUE(AddVisit(&visit_info1, SOURCE_BROWSED));
// Add second visit for the same page.
VisitRow visit_info2(visit_info1.url_id,
visit_info1.visit_time + TimeDelta::FromSeconds(1), 1,
content::PAGE_TRANSITION_TYPED, 0);
EXPECT_TRUE(AddVisit(&visit_info2, SOURCE_BROWSED));
// Add third visit for a different page.
VisitRow visit_info3(2,
visit_info1.visit_time + TimeDelta::FromSeconds(2), 0,
content::PAGE_TRANSITION_LINK, 0);
EXPECT_TRUE(AddVisit(&visit_info3, SOURCE_BROWSED));
// Query the first two.
std::vector<VisitRow> matches;
EXPECT_TRUE(GetVisitsForURL(visit_info1.url_id, &matches));
EXPECT_EQ(static_cast<size_t>(2), matches.size());
// Make sure we got both (order in result set is visit time).
EXPECT_TRUE(IsVisitInfoEqual(matches[0], visit_info1) &&
IsVisitInfoEqual(matches[1], visit_info2));
}
TEST_F(VisitDatabaseTest, Delete) {
// Add three visits that form a chain of navigation, and then delete the
// middle one. We should be left with the outer two visits, and the chain
// should link them.
static const int kTime1 = 1000;
VisitRow visit_info1(1, Time::FromInternalValue(kTime1), 0,
content::PAGE_TRANSITION_LINK, 0);
EXPECT_TRUE(AddVisit(&visit_info1, SOURCE_BROWSED));
static const int kTime2 = kTime1 + 1;
VisitRow visit_info2(1, Time::FromInternalValue(kTime2),
visit_info1.visit_id, content::PAGE_TRANSITION_LINK, 0);
EXPECT_TRUE(AddVisit(&visit_info2, SOURCE_BROWSED));
static const int kTime3 = kTime2 + 1;
VisitRow visit_info3(1, Time::FromInternalValue(kTime3),
visit_info2.visit_id, content::PAGE_TRANSITION_LINK, 0);
EXPECT_TRUE(AddVisit(&visit_info3, SOURCE_BROWSED));
// First make sure all the visits are there.
std::vector<VisitRow> matches;
EXPECT_TRUE(GetVisitsForURL(visit_info1.url_id, &matches));
EXPECT_EQ(static_cast<size_t>(3), matches.size());
EXPECT_TRUE(IsVisitInfoEqual(matches[0], visit_info1) &&
IsVisitInfoEqual(matches[1], visit_info2) &&
IsVisitInfoEqual(matches[2], visit_info3));
// Delete the middle one.
DeleteVisit(visit_info2);
// The outer two should be left, and the last one should have the first as
// the referrer.
visit_info3.referring_visit = visit_info1.visit_id;
matches.clear();
EXPECT_TRUE(GetVisitsForURL(visit_info1.url_id, &matches));
EXPECT_EQ(static_cast<size_t>(2), matches.size());
EXPECT_TRUE(IsVisitInfoEqual(matches[0], visit_info1) &&
IsVisitInfoEqual(matches[1], visit_info3));
}
TEST_F(VisitDatabaseTest, Update) {
// Make something in the database.
VisitRow original(1, Time::Now(), 23, content::PageTransitionFromInt(0), 19);
AddVisit(&original, SOURCE_BROWSED);
// Mutate that row.
VisitRow modification(original);
modification.url_id = 2;
modification.transition = content::PAGE_TRANSITION_TYPED;
modification.visit_time = Time::Now() + TimeDelta::FromDays(1);
modification.referring_visit = 9292;
modification.is_indexed = true;
UpdateVisitRow(modification);
// Check that the mutated version was written.
VisitRow final;
GetRowForVisit(original.visit_id, &final);
EXPECT_TRUE(IsVisitInfoEqual(modification, final));
}
// TODO(brettw) write test for GetMostRecentVisitForURL!
TEST_F(VisitDatabaseTest, GetVisibleVisitsInRange) {
// Add one visit.
VisitRow visit_info1(1, Time::Now(), 0,
static_cast<content::PageTransition>(
content::PAGE_TRANSITION_LINK |
content::PAGE_TRANSITION_CHAIN_START |
content::PAGE_TRANSITION_CHAIN_END),
0);
visit_info1.visit_id = 1;
EXPECT_TRUE(AddVisit(&visit_info1, SOURCE_BROWSED));
// Add second visit for the same page.
VisitRow visit_info2(visit_info1.url_id,
visit_info1.visit_time + TimeDelta::FromSeconds(1), 1,
static_cast<content::PageTransition>(
content::PAGE_TRANSITION_TYPED |
content::PAGE_TRANSITION_CHAIN_START |
content::PAGE_TRANSITION_CHAIN_END),
0);
visit_info2.visit_id = 2;
EXPECT_TRUE(AddVisit(&visit_info2, SOURCE_BROWSED));
// Add third visit for a different page.
VisitRow visit_info3(2,
visit_info1.visit_time + TimeDelta::FromSeconds(2), 0,
static_cast<content::PageTransition>(
content::PAGE_TRANSITION_LINK |
content::PAGE_TRANSITION_CHAIN_START),
0);
visit_info3.visit_id = 3;
EXPECT_TRUE(AddVisit(&visit_info3, SOURCE_BROWSED));
// Add a redirect visit from the last page.
VisitRow visit_info4(3,
visit_info1.visit_time + TimeDelta::FromSeconds(3), visit_info3.visit_id,
static_cast<content::PageTransition>(
content::PAGE_TRANSITION_SERVER_REDIRECT |
content::PAGE_TRANSITION_CHAIN_END),
0);
visit_info4.visit_id = 4;
EXPECT_TRUE(AddVisit(&visit_info4, SOURCE_BROWSED));
// Add a subframe visit.
VisitRow visit_info5(4,
visit_info1.visit_time + TimeDelta::FromSeconds(4), visit_info4.visit_id,
static_cast<content::PageTransition>(
content::PAGE_TRANSITION_AUTO_SUBFRAME |
content::PAGE_TRANSITION_CHAIN_START |
content::PAGE_TRANSITION_CHAIN_END),
0);
visit_info5.visit_id = 5;
EXPECT_TRUE(AddVisit(&visit_info5, SOURCE_BROWSED));
// Query the visits for all time, we should not get the first (duplicate of
// the second) or the redirect or subframe visits.
VisitVector results;
GetVisibleVisitsInRange(Time(), Time(), 0, &results);
ASSERT_EQ(static_cast<size_t>(2), results.size());
EXPECT_TRUE(IsVisitInfoEqual(results[0], visit_info4) &&
IsVisitInfoEqual(results[1], visit_info2));
// Query a time range and make sure beginning is inclusive and ending is
// exclusive.
GetVisibleVisitsInRange(visit_info2.visit_time, visit_info4.visit_time, 0,
&results);
ASSERT_EQ(static_cast<size_t>(1), results.size());
EXPECT_TRUE(IsVisitInfoEqual(results[0], visit_info2));
// Query for a max count and make sure we get only that number.
GetVisibleVisitsInRange(Time(), Time(), 1, &results);
ASSERT_EQ(static_cast<size_t>(1), results.size());
EXPECT_TRUE(IsVisitInfoEqual(results[0], visit_info4));
}
TEST_F(VisitDatabaseTest, VisitSource) {
// Add visits.
VisitRow visit_info1(111, Time::Now(), 0, content::PAGE_TRANSITION_LINK, 0);
ASSERT_TRUE(AddVisit(&visit_info1, SOURCE_BROWSED));
VisitRow visit_info2(112, Time::Now(), 1, content::PAGE_TRANSITION_TYPED, 0);
ASSERT_TRUE(AddVisit(&visit_info2, SOURCE_SYNCED));
VisitRow visit_info3(113, Time::Now(), 0, content::PAGE_TRANSITION_TYPED, 0);
ASSERT_TRUE(AddVisit(&visit_info3, SOURCE_EXTENSION));
// Query each visit.
std::vector<VisitRow> matches;
ASSERT_TRUE(GetVisitsForURL(111, &matches));
ASSERT_EQ(1U, matches.size());
VisitSourceMap sources;
GetVisitsSource(matches, &sources);
EXPECT_EQ(0U, sources.size());
ASSERT_TRUE(GetVisitsForURL(112, &matches));
ASSERT_EQ(1U, matches.size());
GetVisitsSource(matches, &sources);
ASSERT_EQ(1U, sources.size());
EXPECT_EQ(SOURCE_SYNCED, sources[matches[0].visit_id]);
ASSERT_TRUE(GetVisitsForURL(113, &matches));
ASSERT_EQ(1U, matches.size());
GetVisitsSource(matches, &sources);
ASSERT_EQ(1U, sources.size());
EXPECT_EQ(SOURCE_EXTENSION, sources[matches[0].visit_id]);
}
TEST_F(VisitDatabaseTest, GetIndexedVisits) {
// Add non-indexed visits.
int url_id = 111;
VisitRow visit_info1(
url_id, Time::Now(), 0, content::PAGE_TRANSITION_LINK, 0);
ASSERT_TRUE(AddVisit(&visit_info1, SOURCE_BROWSED));
VisitRow visit_info2(
url_id, Time::Now(), 0, content::PAGE_TRANSITION_TYPED, 0);
ASSERT_TRUE(AddVisit(&visit_info2, SOURCE_SYNCED));
std::vector<VisitRow> visits;
EXPECT_TRUE(GetVisitsForURL(url_id, &visits));
EXPECT_EQ(static_cast<size_t>(2), visits.size());
EXPECT_TRUE(GetIndexedVisitsForURL(url_id, &visits));
EXPECT_EQ(static_cast<size_t>(0), visits.size());
VisitRow visit_info3(
url_id, Time::Now(), 2, content::PAGE_TRANSITION_TYPED, 0);
visit_info3.is_indexed = true;
ASSERT_TRUE(AddVisit(&visit_info3, SOURCE_SYNCED));
EXPECT_TRUE(GetVisitsForURL(url_id, &visits));
EXPECT_EQ(static_cast<size_t>(3), visits.size());
EXPECT_TRUE(GetIndexedVisitsForURL(url_id, &visits));
EXPECT_EQ(static_cast<size_t>(1), visits.size());
}
} // namespace history
|