1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
|
// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/sync/engine/process_updates_command.h"
#include <vector>
#include "base/basictypes.h"
#include "chrome/browser/sync/engine/syncer.h"
#include "chrome/browser/sync/engine/syncer_proto_util.h"
#include "chrome/browser/sync/engine/syncer_util.h"
#include "chrome/browser/sync/engine/syncproto.h"
#include "chrome/browser/sync/sessions/sync_session.h"
#include "chrome/browser/sync/syncable/directory_manager.h"
#include "chrome/browser/sync/syncable/syncable.h"
using std::vector;
namespace browser_sync {
using sessions::SyncSession;
using sessions::StatusController;
ProcessUpdatesCommand::ProcessUpdatesCommand() {}
ProcessUpdatesCommand::~ProcessUpdatesCommand() {}
void ProcessUpdatesCommand::ModelChangingExecuteImpl(SyncSession* session) {
syncable::ScopedDirLookup dir(session->context()->directory_manager(),
session->context()->account_name());
if (!dir.good()) {
LOG(ERROR) << "Scoped dir lookup failed!";
return;
}
const GetUpdatesResponse& updates =
session->status_controller()->updates_response().get_updates();
const int update_count = updates.entries_size();
LOG(INFO) << "Get updates from ts " << dir->last_sync_timestamp() <<
" returned " << update_count << " updates.";
StatusController* status = session->status_controller();
if (updates.has_changes_remaining()) {
int64 changes_left = updates.changes_remaining();
LOG(INFO) << "Changes remaining:" << changes_left;
status->set_num_server_changes_remaining(changes_left);
}
int64 new_timestamp = 0;
if (updates.has_new_timestamp()) {
new_timestamp = updates.new_timestamp();
LOG(INFO) << "Get Updates got new timestamp: " << new_timestamp;
if (0 == update_count) {
if (new_timestamp > dir->last_sync_timestamp()) {
dir->set_last_sync_timestamp(new_timestamp);
status->set_got_new_timestamp();
}
return;
}
}
// If we have updates that are ALL supposed to be skipped, we don't want to
// get them again. In fact, the account's final updates are all supposed to
// be skipped and we DON'T step past them, we will sync forever.
int64 latest_skip_timestamp = 0;
bool any_non_skip_results = false;
const sessions::UpdateProgress& progress(status->update_progress());
vector<sessions::VerifiedUpdate>::const_iterator it;
for (it = progress.VerifiedUpdatesBegin();
it != progress.VerifiedUpdatesEnd();
++it) {
const sync_pb::SyncEntity& update = it->second;
any_non_skip_results = (it->first != VERIFY_SKIP);
if (!any_non_skip_results) {
// ALL updates were to be skipped, including this one.
if (update.sync_timestamp() > latest_skip_timestamp) {
latest_skip_timestamp = update.sync_timestamp();
}
} else {
latest_skip_timestamp = 0;
}
if (it->first != VERIFY_SUCCESS && it->first != VERIFY_UNDELETE)
continue;
switch (ProcessUpdate(dir, update)) {
case SUCCESS_PROCESSED:
case SUCCESS_STORED:
// We can update the timestamp because we store the update even if we
// can't apply it now.
if (update.sync_timestamp() > new_timestamp)
new_timestamp = update.sync_timestamp();
break;
default:
NOTREACHED();
break;
}
}
if (latest_skip_timestamp > new_timestamp)
new_timestamp = latest_skip_timestamp;
if (new_timestamp > dir->last_sync_timestamp()) {
dir->set_last_sync_timestamp(new_timestamp);
status->set_got_new_timestamp();
}
status->set_num_consecutive_errors(0);
// TODO(tim): Related to bug 30665, the Directory needs last sync timestamp
// per data type. Until then, use UNSPECIFIED.
status->set_current_sync_timestamp(syncable::UNSPECIFIED,
dir->last_sync_timestamp());
status->set_syncing(true);
return;
}
namespace {
// Returns true if the entry is still ok to process.
bool ReverifyEntry(syncable::WriteTransaction* trans, const SyncEntity& entry,
syncable::MutableEntry* same_id) {
const bool deleted = entry.has_deleted() && entry.deleted();
const bool is_directory = entry.IsFolder();
const syncable::ModelType model_type = entry.GetModelType();
return VERIFY_SUCCESS == SyncerUtil::VerifyUpdateConsistency(trans,
entry,
same_id,
deleted,
is_directory,
model_type);
}
} // namespace
// TODO(sync): Refactor this code.
// Process a single update. Will avoid touching global state.
ServerUpdateProcessingResult ProcessUpdatesCommand::ProcessUpdate(
const syncable::ScopedDirLookup& dir, const sync_pb::SyncEntity& pb_entry) {
const SyncEntity& entry = *static_cast<const SyncEntity*>(&pb_entry);
using namespace syncable;
syncable::Id id = entry.id();
const std::string name = SyncerProtoUtil::NameFromSyncEntity(entry);
WriteTransaction trans(dir, SYNCER, __FILE__, __LINE__);
SyncerUtil::CreateNewEntry(&trans, id);
// We take a two step approach. First we store the entries data in the
// server fields of a local entry and then move the data to the local fields
MutableEntry update_entry(&trans, GET_BY_ID, id);
// TODO(sync): do we need to run ALL these checks, or is a mere version check
// good enough?
if (!ReverifyEntry(&trans, entry, &update_entry)) {
return SUCCESS_PROCESSED; // the entry has become irrelevant
}
SyncerUtil::UpdateServerFieldsFromUpdate(&update_entry, entry, name);
if (update_entry.Get(SERVER_VERSION) == update_entry.Get(BASE_VERSION) &&
!update_entry.Get(IS_UNSYNCED)) {
// It's largely OK if data doesn't match exactly since a future update
// will just clobber the data. Conflict resolution will overwrite and
// take one side as the winner and does not try to merge, so strict
// equality isn't necessary.
LOG_IF(ERROR, !SyncerUtil::ServerAndLocalEntriesMatch(&update_entry))
<< update_entry;
}
return SUCCESS_PROCESSED;
}
} // namespace browser_sync
|
