1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/renderer_host/test/test_render_view_host.h"
#include "chrome/browser/renderer_host/mock_render_process_host.h"
#include "chrome/browser/translate/translate_infobars_delegates.h"
#include "chrome/browser/translate/translate_manager.h"
#include "chrome/common/ipc_test_sink.h"
#include "chrome/common/notification_registrar.h"
#include "chrome/common/notification_service.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/render_messages.h"
#include "chrome/test/testing_browser_process.h"
#include "third_party/cld/languages/public/languages.h"
class TestTranslateManager : public TranslateManager {
public:
TestTranslateManager() {}
};
class TranslateManagerTest : public RenderViewHostTestHarness,
public NotificationObserver {
public:
TranslateManagerTest() {}
// Simluates navigating to a page and getting the page contents and language
// for that navigation.
void SimulateNavigation(const GURL& url, int page_id,
const std::wstring& contents,
const std::string& lang) {
NavigateAndCommit(url);
SimulateOnPageContents(url, page_id, contents, lang);
}
void SimulateOnPageContents(const GURL& url, int page_id,
const std::wstring& contents,
const std::string& lang) {
rvh()->TestOnMessageReceived(ViewHostMsg_PageContents(0, url, page_id,
contents, lang));
}
bool GetTranslateMessage(int* page_id,
std::string* original_lang,
std::string* target_lang) {
const IPC::Message* message =
process()->sink().GetFirstMessageMatching(ViewMsg_TranslatePage::ID);
if (!message)
return false;
Tuple3<int, std::string, std::string> translate_param;
ViewMsg_TranslatePage::Read(message, &translate_param);
*page_id = translate_param.a;
*original_lang = translate_param.b;
*target_lang = translate_param.c;
return true;
}
// Returns the translate infobar if there is 1 infobar and it is a translate
// infobar.
TranslateInfoBarDelegate* GetTranslateInfoBar() {
if (contents()->infobar_delegate_count() != 1)
return NULL;
return contents()->GetInfoBarDelegateAt(0)->AsTranslateInfoBarDelegate();
}
// If there is 1 infobar and it is a translate infobar, closes it and returns
// true. Returns false otherwise.
bool CloseTranslateInfoBar() {
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
if (!infobar)
return false;
infobar->InfoBarDismissed(); // Simulates closing the infobar.
contents()->RemoveInfoBar(infobar);
return true;
}
// Checks whether |infobar| has been removed and clears the removed infobar
// list.
bool CheckInfoBarRemovedAndReset(InfoBarDelegate* infobar) {
bool found = std::find(removed_infobars_.begin(), removed_infobars_.end(),
infobar) != removed_infobars_.end();
removed_infobars_.clear();
return found;
}
// Returns true if at least one infobar was closed.
bool InfoBarRemoved() {
return !removed_infobars_.empty();
}
// If there is 1 infobar and it is a translate infobar, deny translation and
// returns true. Returns false otherwise.
bool DenyTranslation() {
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
if (!infobar)
return false;
infobar->TranslationDeclined();
contents()->RemoveInfoBar(infobar);
return true;
}
virtual void Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
DCHECK(type == NotificationType::TAB_CONTENTS_INFOBAR_REMOVED);
removed_infobars_.push_back(Details<InfoBarDelegate>(details).ptr());
}
protected:
virtual void SetUp() {
TranslateManager::set_test_enabled(true);
// This must be created after set_test_enabled() has been called to register
// notifications properly. Note that we do this before calling
// RenderViewHostTestHarness::SetUp() to match what's done in Chrome, where
// the TranslateManager is created before the TabContents. This matters for
// as they both register for similar events and we want the notifications
// to happen in the same sequence (TranslateManager first, TabContents
// second).
translate_manager_.reset(new TestTranslateManager());
RenderViewHostTestHarness::SetUp();
notification_registrar_.Add(
this,
NotificationType::TAB_CONTENTS_INFOBAR_REMOVED,
Source<TabContents>(contents()));
}
virtual void TearDown() {
notification_registrar_.Remove(
this,
NotificationType::TAB_CONTENTS_INFOBAR_REMOVED,
Source<TabContents>(contents()));
RenderViewHostTestHarness::TearDown();
TranslateManager::set_test_enabled(false);
}
private:
NotificationRegistrar notification_registrar_;
scoped_ptr<TestTranslateManager> translate_manager_;
// The list of infobars that have been removed.
// WARNING: the pointers points to deleted objects, use only for comparison.
std::vector<InfoBarDelegate*> removed_infobars_;
DISALLOW_COPY_AND_ASSIGN(TranslateManagerTest);
};
// An observer that keeps track of whether a navigation entry was committed.
class NavEntryCommittedObserver : public NotificationObserver {
public:
explicit NavEntryCommittedObserver(TabContents* tab_contents) {
registrar_.Add(this, NotificationType::NAV_ENTRY_COMMITTED,
Source<NavigationController>(&tab_contents->controller()));
}
virtual void Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
DCHECK(type == NotificationType::NAV_ENTRY_COMMITTED);
details_ =
*(Details<NavigationController::LoadCommittedDetails>(details).ptr());
}
const NavigationController::LoadCommittedDetails&
get_load_commited_details() const {
return details_;
}
private:
NavigationController::LoadCommittedDetails details_;
NotificationRegistrar registrar_;
DISALLOW_COPY_AND_ASSIGN(NavEntryCommittedObserver);
};
TEST_F(TranslateManagerTest, NormalTranslate) {
// Simulate navigating to a page.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// We should have an info-bar.
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
ASSERT_TRUE(infobar != NULL);
EXPECT_EQ(TranslateInfoBarDelegate::kBeforeTranslate, infobar->state());
// Simulate clicking translate.
process()->sink().ClearMessages();
infobar->Translate();
EXPECT_FALSE(InfoBarRemoved());
// Test that we sent the right message to the renderer.
int page_id = 0;
std::string original_lang, target_lang;
EXPECT_TRUE(GetTranslateMessage(&page_id, &original_lang, &target_lang));
EXPECT_EQ(0, page_id);
EXPECT_EQ("fr", original_lang);
EXPECT_EQ("en", target_lang);
// The infobar should still be there but in the translating state.
ASSERT_EQ(infobar, GetTranslateInfoBar()); // Same instance.
// TODO(jcampan): the state is not set if the button is not clicked.
// Refactor the infobar code so we can simulate the click.
// EXPECT_EQ(TranslateInfoBarDelegate::kTranslating, infobar->state());
// Simulate the render notifying the translation has been done.
rvh()->TestOnMessageReceived(ViewHostMsg_PageTranslated(0, 0, "fr", "en"));
// The infobar should have changed to the after state.
EXPECT_FALSE(InfoBarRemoved());
ASSERT_EQ(infobar, GetTranslateInfoBar());
// TODO(jcampan): the TranslateInfoBar is listening for the PAGE_TRANSLATED
// notification. Since in unit-test, no actual info-bar is
// created, it does not get the notification and does not
// update its state. Ideally the delegate (or rather model)
// would be the one listening for notifications and updating
// states. That would make this test work.
// EXPECT_EQ(TranslateInfoBarDelegate::kAfterTranslate, infobar->state());
// Simulate translating again from there but 2 different languages.
infobar->ModifyOriginalLanguage(0);
infobar->ModifyTargetLanguage(1);
std::string new_original_lang = infobar->original_lang_code();
std::string new_target_lang = infobar->target_lang_code();
process()->sink().ClearMessages();
infobar->Translate();
// Test that we sent the right message to the renderer.
EXPECT_TRUE(GetTranslateMessage(&page_id, &original_lang, &target_lang));
EXPECT_EQ(0, page_id);
EXPECT_EQ(new_original_lang, original_lang);
EXPECT_EQ(new_target_lang, target_lang);
}
// Tests that we show/don't show an info-bar for all languages the CLD can
// report.
TEST_F(TranslateManagerTest, TestAllLanguages) {
// The index in kExpectation are the Language enum (see languages.pb.h).
// true if we expect a translate infobar for that language.
// Note the supported languages are in translation_service.cc, see
// kSupportedLanguages.
bool kExpectations[] = {
// 0-9
false, true, true, true, true, true, true, true, true, true,
// 10-19
true, true, true, true, true, true, true, true, true, true,
// 20-29
true, true, true, true, true, false, false, true, true, true,
// 30-39
true, true, true, true, true, true, true, false, true, false,
// 40-49
true, false, true, false, false, true, false, true, false, false,
// 50-59
false, false, false, true, true, true, false, false, false, false,
// 60-69
false, false, true, true, false, true, true, false, true, true,
// 70-79
false, false, false, false, false, false, false, true, false, false,
// 80-89
false, false, false, false, false, false, false, false, false, false,
// 90-99
false, true, false, false, false, false, false, false, false, false,
// 100-109
false, true, false, false, false, false, false, false, false, false,
// 110-119
false, false, false, false, false, false, false, false, false, false,
// 120-129
false, false, false, false, false, false, false, false, false, false,
// 130-139
false, false, false, false, false, false, false, false, false, false,
// 140-149
false, false, false, false, false, false, false, false, false, false,
// 150-159
false, false, false, false, false, false, false, false, false, false,
// 160
false
};
GURL url("http://www.google.com");
for (size_t i = 0; i < arraysize(kExpectations); ++i) {
ASSERT_LT(i, static_cast<size_t>(NUM_LANGUAGES));
std::string lang = LanguageCodeWithDialects(static_cast<Language>(i));
SCOPED_TRACE(::testing::Message::Message() << "Iteration " << i <<
" language=" << lang);
// We should not have a translate infobar.
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
ASSERT_TRUE(infobar == NULL);
// Simulate navigating to a page.
NavigateAndCommit(url);
SimulateOnPageContents(url, i, L"", lang);
// Verify we have/don't have an info-bar as expected.
infobar = GetTranslateInfoBar();
EXPECT_EQ(kExpectations[i], infobar != NULL);
// Close the info-bar if applicable.
if (infobar != NULL)
EXPECT_TRUE(CloseTranslateInfoBar());
}
}
// Tests auto-translate on page.
TEST_F(TranslateManagerTest, AutoTranslateOnNavigate) {
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// Simulate the user translating.
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
ASSERT_TRUE(infobar != NULL);
infobar->Translate();
rvh()->TestOnMessageReceived(ViewHostMsg_PageTranslated(0, 0, "fr", "en"));
// Now navigate to a new page in the same language.
process()->sink().ClearMessages();
SimulateNavigation(GURL("http://news.google.fr"), 1, L"Les news", "fr");
// This should have automatically triggered a translation.
int page_id = 0;
std::string original_lang, target_lang;
EXPECT_TRUE(GetTranslateMessage(&page_id, &original_lang, &target_lang));
EXPECT_EQ(1, page_id);
EXPECT_EQ("fr", original_lang);
EXPECT_EQ("en", target_lang);
// Now navigate to a page in a different language.
process()->sink().ClearMessages();
SimulateNavigation(GURL("http://news.google.es"), 1, L"Las news", "es");
// This should not have triggered a translate.
EXPECT_FALSE(GetTranslateMessage(&page_id, &original_lang, &target_lang));
}
// Tests that multiple OnPageContents do not cause multiple infobars.
TEST_F(TranslateManagerTest, MultipleOnPageContents) {
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// Simulate clicking 'Nope' (don't translate).
EXPECT_TRUE(DenyTranslation());
EXPECT_EQ(0, contents()->infobar_delegate_count());
// Send a new PageContents, we should not show an infobar.
SimulateOnPageContents(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
EXPECT_EQ(0, contents()->infobar_delegate_count());
// Do the same steps but simulate closing the infobar this time.
SimulateNavigation(GURL("http://www.youtube.fr"), 1, L"Le YouTube", "fr");
EXPECT_TRUE(CloseTranslateInfoBar());
EXPECT_EQ(0, contents()->infobar_delegate_count());
SimulateOnPageContents(GURL("http://www.youtube.fr"), 1, L"Le YouTube", "fr");
EXPECT_EQ(0, contents()->infobar_delegate_count());
}
// Test that reloading the page brings back the infobar.
TEST_F(TranslateManagerTest, Reload) {
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// Close the infobar.
EXPECT_TRUE(CloseTranslateInfoBar());
// Reload should bring back the infobar.
NavEntryCommittedObserver nav_observer(contents());
Reload();
// Ensures it is really handled a reload.
const NavigationController::LoadCommittedDetails& nav_details =
nav_observer.get_load_commited_details();
EXPECT_TRUE(nav_details.entry != NULL); // There was a navigation.
EXPECT_EQ(NavigationType::EXISTING_PAGE, nav_details.type);
// The TranslateManager class processes the navigation entry committed
// notification in a posted task; process that task.
MessageLoop::current()->RunAllPending();
EXPECT_TRUE(GetTranslateInfoBar() != NULL);
}
// Test that reloading the page by way of typing again the URL in the
// location bar brings back the infobar.
TEST_F(TranslateManagerTest, ReloadFromLocationBar) {
GURL url("http://www.google.fr");
// Simulate navigating to a page and getting its language.
SimulateNavigation(url, 0, L"Le Google", "fr");
// Close the infobar.
EXPECT_TRUE(CloseTranslateInfoBar());
// Create a pending navigation and simulate a page load. That should be the
// equivalent of typing the URL again in the location bar.
NavEntryCommittedObserver nav_observer(contents());
contents()->controller().LoadURL(url, GURL(), PageTransition::TYPED);
rvh()->SendNavigate(0, url);
// Test that we are really getting a same page navigation, the test would be
// useless if it was not the case.
const NavigationController::LoadCommittedDetails& nav_details =
nav_observer.get_load_commited_details();
EXPECT_TRUE(nav_details.entry != NULL); // There was a navigation.
EXPECT_EQ(NavigationType::SAME_PAGE, nav_details.type);
// The TranslateManager class processes the navigation entry committed
// notification in a posted task; process that task.
MessageLoop::current()->RunAllPending();
EXPECT_TRUE(GetTranslateInfoBar() != NULL);
}
// Tests that a close translate infobar does not reappear when navigating
// in-page.
TEST_F(TranslateManagerTest, CloseInfoBarInPageNavigation) {
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// Close the infobar.
EXPECT_TRUE(CloseTranslateInfoBar());
// Navigate in page, no infobar should be shown.
SimulateNavigation(GURL("http://www.google.fr/#ref1"), 0, L"Le Google", "fr");
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
// Navigate out of page, a new infobar should show.
SimulateNavigation(GURL("http://www.google.fr/foot"), 0, L"Le Google", "fr");
EXPECT_TRUE(GetTranslateInfoBar() != NULL);
}
// Tests that denying translation is sticky when navigating in page.
TEST_F(TranslateManagerTest, DenyTranslateInPageNavigation) {
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// Simulate clicking 'Nope' (don't translate).
EXPECT_TRUE(DenyTranslation());
// Navigate in page, no infobar should be shown.
SimulateNavigation(GURL("http://www.google.fr/#ref1"), 0, L"Le Google", "fr");
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
// Navigate out of page, a new infobar should show.
SimulateNavigation(GURL("http://www.google.fr/foot"), 0, L"Le Google", "fr");
EXPECT_TRUE(GetTranslateInfoBar() != NULL);
}
// Tests that after translating and closing the infobar, the infobar does not
// return when navigating in page.
TEST_F(TranslateManagerTest, TranslateCloseInfoBarInPageNavigation) {
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// Simulate the user translating.
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
ASSERT_TRUE(infobar != NULL);
infobar->Translate();
rvh()->TestOnMessageReceived(ViewHostMsg_PageTranslated(0, 0, "fr", "en"));
// Close the infobar.
EXPECT_TRUE(CloseTranslateInfoBar());
// Navigate in page, no infobar should be shown.
SimulateNavigation(GURL("http://www.google.fr/#ref1"), 0, L"Le Google", "fr");
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
// Navigate out of page, a new infobar should show.
// Note that we navigate to a page in a different language so we don't trigger
// the auto-translate feature (it would translate the page automatically and
// the before translate inforbar would not be shown).
SimulateNavigation(GURL("http://www.google.de"), 0, L"Das Google", "de");
EXPECT_TRUE(GetTranslateInfoBar() != NULL);
}
// Tests that the after translate the infobar still shows when navigating
// in-page.
TEST_F(TranslateManagerTest, TranslateInPageNavigation) {
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// Simulate the user translating.
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
ASSERT_TRUE(infobar != NULL);
infobar->Translate();
rvh()->TestOnMessageReceived(ViewHostMsg_PageTranslated(0, 0, "fr", "en"));
// Navigate in page, the same infobar should still be shown.
SimulateNavigation(GURL("http://www.google.fr/#ref1"), 0, L"Le Google", "fr");
EXPECT_FALSE(InfoBarRemoved());
EXPECT_EQ(infobar, GetTranslateInfoBar());
// Navigate out of page, a new infobar should show.
// See note in TranslateCloseInfoBarInPageNavigation test on why it is
// important to navigate to a page in a different language for this test.
SimulateNavigation(GURL("http://www.google.de"), 0, L"Das Google", "de");
// The old infobar is gone.
EXPECT_TRUE(CheckInfoBarRemovedAndReset(infobar));
// And there is a new one.
EXPECT_TRUE(GetTranslateInfoBar() != NULL);
}
// Tests that no translate infobar is shown when navigating to a page in an
// unsupported language.
TEST_F(TranslateManagerTest, UnsupportedPageLanguage) {
// Simulate navigating to a page and getting an unsupported language.
SimulateNavigation(GURL("http://www.google.com"), 0, L"Google", "qbz");
// No info-bar should be shown.
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
}
// Tests that no translate infobar is shown when Chrome is in a language that
// the translate server does not support.
TEST_F(TranslateManagerTest, UnsupportedUILanguage) {
TestingBrowserProcess* browser_process =
static_cast<TestingBrowserProcess*>(g_browser_process);
std::string original_lang = browser_process->GetApplicationLocale();
browser_process->SetApplicationLocale("qbz");
// Simulate navigating to a page in a language supported by the translate
// server.
SimulateNavigation(GURL("http://www.google.com"), 0, L"Google", "en");
// No info-bar should be shown.
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
browser_process->SetApplicationLocale(original_lang);
}
// Tests that the translate preference is honored.
TEST_F(TranslateManagerTest, TranslatePref) {
// Make sure the pref allows translate.
PrefService* prefs = contents()->profile()->GetPrefs();
prefs->SetBoolean(prefs::kEnableTranslate, true);
// Simulate navigating to a page and getting its language.
SimulateNavigation(GURL("http://www.google.fr"), 0, L"Le Google", "fr");
// An infobar should be shown.
TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
EXPECT_TRUE(infobar != NULL);
// Disable translate.
prefs->SetBoolean(prefs::kEnableTranslate, false);
// Navigate to a new page, that should close the previous infobar.
GURL url("http://www.youtube.fr");
NavigateAndCommit(url);
infobar = GetTranslateInfoBar();
EXPECT_TRUE(infobar == NULL);
// Simulate getting the page contents and language, that should not trigger
// a translate infobar.
SimulateOnPageContents(url, 1, L"Le YouTube", "fr");
infobar = GetTranslateInfoBar();
EXPECT_TRUE(infobar == NULL);
}
|