1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
|
// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "app/test/data/resource.h"
#include "base/file_util.h"
#include "base/message_loop.h"
#include "base/path_service.h"
#include "chrome/browser/chrome_thread.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/json_value_serializer.h"
#include "chrome/common/notification_service.h"
#include "chrome/common/notification_type.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/pref_service.h"
#include "testing/gtest/include/gtest/gtest.h"
class PrefServiceTest : public testing::Test {
protected:
virtual void SetUp() {
// Name a subdirectory of the temp directory.
ASSERT_TRUE(PathService::Get(base::DIR_TEMP, &test_dir_));
test_dir_ = test_dir_.AppendASCII("PrefServiceTest");
// Create a fresh, empty copy of this directory.
file_util::Delete(test_dir_, true);
file_util::CreateDirectory(test_dir_);
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_dir_));
data_dir_ = data_dir_.AppendASCII("pref_service");
ASSERT_TRUE(file_util::PathExists(data_dir_));
}
virtual void TearDown() {
// Clean up test directory
ASSERT_TRUE(file_util::Delete(test_dir_, true));
ASSERT_FALSE(file_util::PathExists(test_dir_));
}
// the path to temporary directory used to contain the test operations
FilePath test_dir_;
// the path to the directory where the test data is stored
FilePath data_dir_;
};
class TestPrefObserver : public NotificationObserver {
public:
TestPrefObserver(const PrefService* prefs, const std::wstring& pref_name,
const std::wstring& new_pref_value)
: observer_fired_(false),
prefs_(prefs),
pref_name_(pref_name),
new_pref_value_(new_pref_value) {
}
virtual ~TestPrefObserver() {}
virtual void Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
EXPECT_EQ(type.value, NotificationType::PREF_CHANGED);
PrefService* prefs_in = Source<PrefService>(source).ptr();
EXPECT_EQ(prefs_in, prefs_);
std::wstring* pref_name_in = Details<std::wstring>(details).ptr();
EXPECT_EQ(*pref_name_in, pref_name_);
EXPECT_EQ(new_pref_value_, prefs_in->GetString(L"homepage"));
observer_fired_ = true;
}
bool observer_fired() { return observer_fired_; }
void Reset(const std::wstring& new_pref_value) {
observer_fired_ = false;
new_pref_value_ = new_pref_value;
}
private:
bool observer_fired_;
const PrefService* prefs_;
const std::wstring pref_name_;
std::wstring new_pref_value_;
};
TEST_F(PrefServiceTest, Basic) {
{
// Test that it fails on nonexistent file.
FilePath bogus_input_file = data_dir_.AppendASCII("read.txt");
PrefService prefs(bogus_input_file);
EXPECT_FALSE(prefs.ReloadPersistentPrefs());
}
ASSERT_TRUE(file_util::CopyFile(data_dir_.AppendASCII("read.json"),
test_dir_.AppendASCII("write.json")));
// Test that the persistent value can be loaded.
FilePath input_file = test_dir_.AppendASCII("write.json");
ASSERT_TRUE(file_util::PathExists(input_file));
PrefService prefs(input_file);
ASSERT_TRUE(prefs.ReloadPersistentPrefs());
// Register test prefs.
const wchar_t kNewWindowsInTabs[] = L"tabs.new_windows_in_tabs";
const wchar_t kMaxTabs[] = L"tabs.max_tabs";
const wchar_t kLongIntPref[] = L"long_int.pref";
prefs.RegisterStringPref(prefs::kHomePage, L"");
prefs.RegisterBooleanPref(kNewWindowsInTabs, false);
prefs.RegisterIntegerPref(kMaxTabs, 0);
prefs.RegisterStringPref(kLongIntPref, L"2147483648");
std::wstring microsoft(L"http://www.microsoft.com");
std::wstring cnn(L"http://www.cnn.com");
std::wstring homepage(L"http://www.example.com");
EXPECT_EQ(cnn, prefs.GetString(prefs::kHomePage));
const wchar_t kSomeDirectory[] = L"some_directory";
FilePath some_path(FILE_PATH_LITERAL("/usr/sbin/"));
prefs.RegisterFilePathPref(kSomeDirectory, FilePath());
// Now test that the transient value overrides the persistent value,
// without actually altering the persistent store.
EXPECT_TRUE(prefs.transient()->SetString(prefs::kHomePage, microsoft));
EXPECT_TRUE(prefs.transient()->GetString(prefs::kHomePage, &homepage));
EXPECT_EQ(microsoft, homepage);
EXPECT_EQ(microsoft, prefs.GetString(prefs::kHomePage));
// Test reading some other data types from sub-dictionaries, and
// writing to the persistent store.
EXPECT_TRUE(prefs.GetBoolean(kNewWindowsInTabs));
prefs.SetBoolean(kNewWindowsInTabs, false);
EXPECT_FALSE(prefs.GetBoolean(kNewWindowsInTabs));
EXPECT_EQ(20, prefs.GetInteger(kMaxTabs));
prefs.SetInteger(kMaxTabs, 10);
EXPECT_EQ(10, prefs.GetInteger(kMaxTabs));
EXPECT_EQ(2147483648LL, prefs.GetInt64(kLongIntPref));
prefs.SetInt64(kLongIntPref, 214748364842LL);
EXPECT_EQ(214748364842LL, prefs.GetInt64(kLongIntPref));
EXPECT_EQ(FilePath::StringType(FILE_PATH_LITERAL("/usr/local/")),
prefs.GetFilePath(kSomeDirectory).value());
prefs.SetFilePath(kSomeDirectory, some_path);
EXPECT_EQ(some_path.value(), prefs.GetFilePath(kSomeDirectory).value());
// Serialize and compare to expected output.
// SavePersistentPrefs uses ImportantFileWriter which needs a file thread.
MessageLoop message_loop;
ChromeThread file_thread(ChromeThread::FILE, &message_loop);
FilePath output_file = test_dir_.AppendASCII("write.json");
FilePath golden_output_file = data_dir_.AppendASCII("write.golden.json");
ASSERT_TRUE(file_util::PathExists(golden_output_file));
ASSERT_TRUE(prefs.SavePersistentPrefs());
MessageLoop::current()->RunAllPending();
EXPECT_TRUE(file_util::TextContentsEqual(golden_output_file, output_file));
ASSERT_TRUE(file_util::Delete(output_file, false));
}
TEST_F(PrefServiceTest, Overlay) {
const std::string transient =
"{\"bool\":true, \"int\":2, \"real\":2.0, \"string\":\"transient\","
"\"dictionary\":{\"value\":\"transient\"},"
"\"list\":[\"transient\"]}";
std::wstring persistent_string(L"persistent");
std::wstring transient_string(L"transient");
FilePath persistent_file = data_dir_.AppendASCII("overlay.json");
PrefService prefs(persistent_file);
EXPECT_TRUE(prefs.ReloadPersistentPrefs());
Value* transient_value;
{
JSONStringValueSerializer serializer(transient);
transient_value = serializer.Deserialize(NULL);
ASSERT_TRUE(transient_value);
}
prefs.transient()->Set(transient_string, transient_value);
Value* both_transient_value;
{
JSONStringValueSerializer serializer(transient);
both_transient_value = serializer.Deserialize(NULL);
ASSERT_TRUE(both_transient_value);
}
prefs.transient()->Set(L"both", both_transient_value);
// Register test prefs
static const std::wstring kTypes[] =
{ L"neither.", L"persistent.", L"transient.", L"both." };
for (size_t i = 0; i < arraysize(kTypes); ++i) {
prefs.RegisterBooleanPref((kTypes[i] + L"bool").c_str(), false);
prefs.RegisterIntegerPref((kTypes[i] + L"int").c_str(), 0);
prefs.RegisterRealPref((kTypes[i] + L"real").c_str(), 0.0);
prefs.RegisterStringPref((kTypes[i] + L"string").c_str(), L"");
prefs.RegisterListPref((kTypes[i] + L"list").c_str());
prefs.RegisterDictionaryPref((kTypes[i] + L"dictionary").c_str());
}
ASSERT_FALSE(prefs.GetBoolean(L"neither.bool"));
ASSERT_FALSE(prefs.GetBoolean(L"persistent.bool"));
ASSERT_TRUE(prefs.GetBoolean(L"transient.bool"));
ASSERT_TRUE(prefs.GetBoolean(L"both.bool"));
ASSERT_EQ(0, prefs.GetInteger(L"neither.int"));
ASSERT_EQ(1, prefs.GetInteger(L"persistent.int"));
ASSERT_EQ(2, prefs.GetInteger(L"transient.int"));
ASSERT_EQ(2, prefs.GetInteger(L"both.int"));
ASSERT_EQ(0.0, prefs.GetReal(L"neither.real"));
ASSERT_EQ(1.0, prefs.GetReal(L"persistent.real"));
ASSERT_EQ(2.0, prefs.GetReal(L"transient.real"));
ASSERT_EQ(2.0, prefs.GetReal(L"both.real"));
ASSERT_EQ(std::wstring(), prefs.GetString(L"neither.string"));
ASSERT_EQ(persistent_string, prefs.GetString(L"persistent.string"));
ASSERT_EQ(transient_string, prefs.GetString(L"transient.string"));
ASSERT_EQ(transient_string, prefs.GetString(L"both.string"));
{
const DictionaryValue* result_value =
prefs.GetDictionary(L"neither.dictionary");
ASSERT_FALSE(result_value);
}
{
const DictionaryValue* result_value =
prefs.GetDictionary(L"persistent.dictionary");
ASSERT_TRUE(result_value);
std::wstring result_string;
ASSERT_TRUE(result_value->GetString(L"value", &result_string));
ASSERT_EQ(persistent_string, result_string);
}
{
const DictionaryValue* result_value =
prefs.GetDictionary(L"transient.dictionary");
ASSERT_TRUE(result_value);
std::wstring result_string;
ASSERT_TRUE(result_value->GetString(L"value", &result_string));
ASSERT_EQ(transient_string, result_string);
}
{
const DictionaryValue* result_value =
prefs.GetDictionary(L"both.dictionary");
ASSERT_TRUE(result_value);
std::wstring result_string;
ASSERT_TRUE(result_value->GetString(L"value", &result_string));
ASSERT_EQ(transient_string, result_string);
}
{
const ListValue* result_value = prefs.GetList(L"neither.list");
ASSERT_FALSE(result_value);
}
{
const ListValue* result_value = prefs.GetList(L"persistent.list");
ASSERT_TRUE(result_value);
Value* member_value;
ASSERT_TRUE(result_value->Get(0, &member_value));
ASSERT_TRUE(member_value);
std::wstring result_string;
ASSERT_TRUE(member_value->GetAsString(&result_string));
ASSERT_EQ(persistent_string, result_string);
}
{
const ListValue* result_value = prefs.GetList(L"transient.list");
ASSERT_TRUE(result_value);
Value* member_value;
ASSERT_TRUE(result_value->Get(0, &member_value));
ASSERT_TRUE(member_value);
std::wstring result_string;
ASSERT_TRUE(member_value->GetAsString(&result_string));
ASSERT_EQ(transient_string, result_string);
}
{
const ListValue* result_value = prefs.GetList(L"both.list");
ASSERT_TRUE(result_value);
Value* member_value;
ASSERT_TRUE(result_value->Get(0, &member_value));
ASSERT_TRUE(member_value);
std::wstring result_string;
ASSERT_TRUE(member_value->GetAsString(&result_string));
ASSERT_EQ(transient_string, result_string);
}
}
TEST_F(PrefServiceTest, Observers) {
FilePath input_file = data_dir_.AppendASCII("read.json");
EXPECT_TRUE(file_util::PathExists(input_file));
PrefService prefs(input_file);
EXPECT_TRUE(prefs.ReloadPersistentPrefs());
const wchar_t pref_name[] = L"homepage";
prefs.RegisterStringPref(pref_name, L"");
EXPECT_EQ(std::wstring(L"http://www.cnn.com"), prefs.GetString(pref_name));
const std::wstring new_pref_value(L"http://www.google.com/");
TestPrefObserver obs(&prefs, pref_name, new_pref_value);
prefs.AddPrefObserver(pref_name, &obs);
// This should fire the checks in TestPrefObserver::Observe.
prefs.SetString(pref_name, new_pref_value);
// Make sure the tests were actually run.
EXPECT_TRUE(obs.observer_fired());
// Now try adding a second pref observer.
const std::wstring new_pref_value2(L"http://www.youtube.com/");
obs.Reset(new_pref_value2);
TestPrefObserver obs2(&prefs, pref_name, new_pref_value2);
prefs.AddPrefObserver(pref_name, &obs2);
// This should fire the checks in obs and obs2.
prefs.SetString(pref_name, new_pref_value2);
EXPECT_TRUE(obs.observer_fired());
EXPECT_TRUE(obs2.observer_fired());
// Make sure obs2 still works after removing obs.
prefs.RemovePrefObserver(pref_name, &obs);
obs.Reset(L"");
obs2.Reset(new_pref_value);
// This should only fire the observer in obs2.
prefs.SetString(pref_name, new_pref_value);
EXPECT_FALSE(obs.observer_fired());
EXPECT_TRUE(obs2.observer_fired());
// Ok, clean up.
prefs.RemovePrefObserver(pref_name, &obs2);
}
// TODO(port): port this test to POSIX.
#if defined(OS_WIN)
TEST_F(PrefServiceTest, LocalizedPrefs) {
PrefService prefs((FilePath()));
const wchar_t kBoolean[] = L"boolean";
const wchar_t kInteger[] = L"integer";
const wchar_t kString[] = L"string";
prefs.RegisterLocalizedBooleanPref(kBoolean, IDS_LOCALE_BOOL);
prefs.RegisterLocalizedIntegerPref(kInteger, IDS_LOCALE_INT);
prefs.RegisterLocalizedStringPref(kString, IDS_LOCALE_STRING);
// The locale default should take preference over the user default.
EXPECT_FALSE(prefs.GetBoolean(kBoolean));
EXPECT_EQ(1, prefs.GetInteger(kInteger));
EXPECT_EQ(L"hello", prefs.GetString(kString));
prefs.SetBoolean(kBoolean, true);
EXPECT_TRUE(prefs.GetBoolean(kBoolean));
prefs.SetInteger(kInteger, 5);
EXPECT_EQ(5, prefs.GetInteger(kInteger));
prefs.SetString(kString, L"foo");
EXPECT_EQ(L"foo", prefs.GetString(kString));
}
#endif
TEST_F(PrefServiceTest, NoObserverFire) {
PrefService prefs((FilePath()));
const wchar_t pref_name[] = L"homepage";
prefs.RegisterStringPref(pref_name, L"");
const std::wstring new_pref_value(L"http://www.google.com/");
TestPrefObserver obs(&prefs, pref_name, new_pref_value);
prefs.AddPrefObserver(pref_name, &obs);
// This should fire the checks in TestPrefObserver::Observe.
prefs.SetString(pref_name, new_pref_value);
// Make sure the observer was actually fired.
EXPECT_TRUE(obs.observer_fired());
// Setting the pref to the same value should not set the pref value a second
// time.
obs.Reset(new_pref_value);
prefs.SetString(pref_name, new_pref_value);
EXPECT_FALSE(obs.observer_fired());
// Clearing the pref should cause the pref to fire.
obs.Reset(L"");
prefs.ClearPref(pref_name);
EXPECT_TRUE(obs.observer_fired());
// Clearing the pref again should not cause the pref to fire.
obs.Reset(L"");
prefs.ClearPref(pref_name);
EXPECT_FALSE(obs.observer_fired());
// Ok, clean up.
prefs.RemovePrefObserver(pref_name, &obs);
}
TEST_F(PrefServiceTest, HasPrefPath) {
PrefService prefs((FilePath()));
const wchar_t path[] = L"fake.path";
// Shouldn't initially have a path.
EXPECT_FALSE(prefs.HasPrefPath(path));
// Register the path. This doesn't set a value, so the path still shouldn't
// exist.
prefs.RegisterStringPref(path, std::wstring());
EXPECT_FALSE(prefs.HasPrefPath(path));
// Set a value and make sure we have a path.
prefs.SetString(path, L"blah");
EXPECT_TRUE(prefs.HasPrefPath(path));
}
|