1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
|
// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "base/message_loop.h"
#include "base/string_util.h"
#include "chrome/views/table_view.h"
#include "chrome/views/window_win.h"
#include "chrome/views/window_delegate.h"
#include "testing/gtest/include/gtest/gtest.h"
using views::TableView;
// TestTableModel --------------------------------------------------------------
// Trivial TableModel implementation that is backed by a vector of vectors.
// Provides methods for adding/removing/changing the contents that notify the
// observer appropriately.
//
// Initial contents are:
// 0, 1
// 1, 1
// 2, 2
class TestTableModel : public views::TableModel {
public:
TestTableModel();
// Adds a new row at index |row| with values |c1_value| and |c2_value|.
void AddRow(int row, int c1_value, int c2_value);
// Removes the row at index |row|.
void RemoveRow(int row);
// Changes the values of the row at |row|.
void ChangeRow(int row, int c1_value, int c2_value);
// TableModel
virtual int RowCount();
virtual std::wstring GetText(int row, int column_id);
virtual void SetObserver(views::TableModelObserver* observer);
virtual int CompareValues(int row1, int row2, int column_id);
private:
views::TableModelObserver* observer_;
// The data.
std::vector<std::vector<int>> rows_;
DISALLOW_COPY_AND_ASSIGN(TestTableModel);
};
TestTableModel::TestTableModel() : observer_(NULL) {
AddRow(0, 0, 1);
AddRow(1, 1, 1);
AddRow(2, 2, 2);
}
void TestTableModel::AddRow(int row, int c1_value, int c2_value) {
DCHECK(row >= 0 && row <= static_cast<int>(rows_.size()));
std::vector<int> new_row;
new_row.push_back(c1_value);
new_row.push_back(c2_value);
rows_.insert(rows_.begin() + row, new_row);
if (observer_)
observer_->OnItemsAdded(row, 1);
}
void TestTableModel::RemoveRow(int row) {
DCHECK(row >= 0 && row <= static_cast<int>(rows_.size()));
rows_.erase(rows_.begin() + row);
if (observer_)
observer_->OnItemsRemoved(row, 1);
}
void TestTableModel::ChangeRow(int row, int c1_value, int c2_value) {
DCHECK(row >= 0 && row < static_cast<int>(rows_.size()));
rows_[row][0] = c1_value;
rows_[row][1] = c2_value;
if (observer_)
observer_->OnItemsChanged(row, 1);
}
int TestTableModel::RowCount() {
return static_cast<int>(rows_.size());
}
std::wstring TestTableModel::GetText(int row, int column_id) {
return IntToWString(rows_[row][column_id]);
}
void TestTableModel::SetObserver(views::TableModelObserver* observer) {
observer_ = observer;
}
int TestTableModel::CompareValues(int row1, int row2, int column_id) {
return rows_[row1][column_id] - rows_[row2][column_id];
}
// TableViewTest ---------------------------------------------------------------
class TableViewTest : public testing::Test, views::WindowDelegate {
public:
virtual void SetUp();
virtual void TearDown();
virtual views::View* GetContentsView() {
return table_;
}
protected:
// Creates the model.
TestTableModel* CreateModel();
// Verifies the view order matches that of the supplied arguments. The
// arguments are in terms of the model. For example, values of '1, 0' indicate
// the model index at row 0 is 1 and the model index at row 1 is 0.
void VeriyViewOrder(int first, ...);
// Verifies the selection matches the supplied arguments. The supplied
// arguments are in terms of this model. This uses the iterator returned by
// SelectionBegin.
void VerifySelectedRows(int first, ...);
// Configures the state for the various multi-selection tests.
// This selects model rows 0 and 1, and if |sort| is true the first column
// is sorted in descending order.
void SetUpMultiSelectTestState(bool sort);
scoped_ptr<TestTableModel> model_;
// The table. This is owned by the window.
TableView* table_;
private:
MessageLoopForUI message_loop_;
views::Window* window_;
};
void TableViewTest::SetUp() {
OleInitialize(NULL);
model_.reset(CreateModel());
std::vector<views::TableColumn> columns;
columns.resize(2);
columns[0].id = 0;
columns[1].id = 1;
table_ = new TableView(model_.get(), columns, views::ICON_AND_TEXT,
false, false, false);
window_ =
views::Window::CreateChromeWindow(NULL,
gfx::Rect(100, 100, 512, 512),
this);
}
void TableViewTest::TearDown() {
window_->Close();
// Temporary workaround to avoid leak of RootView::pending_paint_task_.
message_loop_.RunAllPending();
OleUninitialize();
}
void TableViewTest::VeriyViewOrder(int first, ...) {
va_list marker;
va_start(marker, first);
int value = first;
int index = 0;
for (int value = first, index = 0; value != -1; index++) {
ASSERT_EQ(value, table_->view_to_model(index));
value = va_arg(marker, int);
}
va_end(marker);
}
void TableViewTest::VerifySelectedRows(int first, ...) {
va_list marker;
va_start(marker, first);
int value = first;
int index = 0;
TableView::iterator selection_iterator = table_->SelectionBegin();
for (int value = first, index = 0; value != -1; index++) {
ASSERT_TRUE(selection_iterator != table_->SelectionEnd());
ASSERT_EQ(value, *selection_iterator);
value = va_arg(marker, int);
++selection_iterator;
}
ASSERT_TRUE(selection_iterator == table_->SelectionEnd());
va_end(marker);
}
void TableViewTest::SetUpMultiSelectTestState(bool sort) {
// Select two rows.
table_->SetSelectedState(0, true);
table_->SetSelectedState(1, true);
VerifySelectedRows(1, 0, -1);
if (!sort || HasFatalFailure())
return;
// Sort by first column descending.
TableView::SortDescriptors sd;
sd.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sd);
VeriyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Make sure the two rows are sorted.
// NOTE: the order changed because iteration happens over view indices.
VerifySelectedRows(0, 1, -1);
}
TestTableModel* TableViewTest::CreateModel() {
return new TestTableModel();
}
// NullModelTableViewTest ------------------------------------------------------
class NullModelTableViewTest : public TableViewTest {
protected:
// Creates the model.
TestTableModel* CreateModel() {
return NULL;
}
};
// Tests -----------------------------------------------------------------------
// Tests various sorting permutations.
TEST_F(TableViewTest, Sort) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VeriyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Sort by second column ascending, first column descending.
sort.clear();
sort.push_back(TableView::SortDescriptor(1, true));
sort.push_back(TableView::SortDescriptor(0, false));
sort[1].ascending = false;
table_->SetSortDescriptors(sort);
VeriyViewOrder(1, 0, 2, -1);
if (HasFatalFailure())
return;
// Clear the sort.
table_->SetSortDescriptors(TableView::SortDescriptors());
VeriyViewOrder(0, 1, 2, -1);
if (HasFatalFailure())
return;
}
// Tests changing the model while sorted.
TEST_F(TableViewTest, SortThenChange) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VeriyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
model_->ChangeRow(0, 3, 1);
VeriyViewOrder(0, 2, 1, -1);
}
// Tests adding to the model while sorted.
TEST_F(TableViewTest, AddToSorted) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VeriyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Add row so that it occurs first.
model_->AddRow(0, 5, -1);
VeriyViewOrder(0, 3, 2, 1, -1);
if (HasFatalFailure())
return;
// Add row so that it occurs last.
model_->AddRow(0, -1, -1);
VeriyViewOrder(1, 4, 3, 2, 0, -1);
}
// Tests selection on sort.
TEST_F(TableViewTest, PersistSelectionOnSort) {
// Select row 0.
table_->Select(0);
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VeriyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Make sure 0 is still selected.
EXPECT_EQ(0, table_->FirstSelectedRow());
}
// Tests selection iterator with sort.
TEST_F(TableViewTest, PersistMultiSelectionOnSort) {
SetUpMultiSelectTestState(true);
}
// Tests selection persists after a change when sorted with iterator.
TEST_F(TableViewTest, PersistMultiSelectionOnChangeWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
model_->ChangeRow(0, 3, 1);
VerifySelectedRows(1, 0, -1);
}
// Tests selection persists after a remove when sorted with iterator.
TEST_F(TableViewTest, PersistMultiSelectionOnRemoveWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
model_->RemoveRow(0);
VerifySelectedRows(0, -1);
}
// Tests selection persists after a add when sorted with iterator.
TEST_F(TableViewTest, PersistMultiSelectionOnAddWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
model_->AddRow(3, 4, 4);
VerifySelectedRows(0, 1, -1);
}
// Tests selection persists after a change with iterator.
TEST_F(TableViewTest, PersistMultiSelectionOnChange) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
model_->ChangeRow(0, 3, 1);
VerifySelectedRows(1, 0, -1);
}
// Tests selection persists after a remove with iterator.
TEST_F(TableViewTest, PersistMultiSelectionOnRemove) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
model_->RemoveRow(0);
VerifySelectedRows(0, -1);
}
// Tests selection persists after a add with iterator.
TEST_F(TableViewTest, PersistMultiSelectionOnAdd) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
model_->AddRow(3, 4, 4);
VerifySelectedRows(1, 0, -1);
}
TEST_F(NullModelTableViewTest, NullModel) {
// There's nothing explicit to test. If there is a bug in TableView relating
// to a NULL model we'll crash.
}
|