1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
|
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <cmath>
#include "base/memory/scoped_ptr.h"
#include "base/values.h"
#include "content/renderer/v8_value_converter.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
class V8ValueConverterTest : public testing::Test {
protected:
virtual void SetUp() {
v8::HandleScope handle_scope;
v8::Handle<v8::ObjectTemplate> global = v8::ObjectTemplate::New();
context_ = v8::Context::New(NULL, global);
}
virtual void TearDown() {
context_.Dispose();
}
std::string GetString(DictionaryValue* value, const std::string& key) {
std::string temp;
if (!value->GetString(key, &temp)) {
ADD_FAILURE();
return "";
}
return temp;
}
std::string GetString(v8::Handle<v8::Object> value, const std::string& key) {
v8::Handle<v8::String> temp =
value->Get(v8::String::New(key.c_str())).As<v8::String>();
if (temp.IsEmpty()) {
ADD_FAILURE();
return "";
}
v8::String::Utf8Value utf8(temp);
return std::string(*utf8, utf8.length());
}
std::string GetString(ListValue* value, uint32 index) {
std::string temp;
if (!value->GetString(static_cast<size_t>(index), &temp)) {
ADD_FAILURE();
return "";
}
return temp;
}
std::string GetString(v8::Handle<v8::Array> value, uint32 index) {
v8::Handle<v8::String> temp = value->Get(index).As<v8::String>();
if (temp.IsEmpty()) {
ADD_FAILURE();
return "";
}
v8::String::Utf8Value utf8(temp);
return std::string(*utf8, utf8.length());
}
bool IsNull(DictionaryValue* value, const std::string& key) {
Value* child = NULL;
if (!value->Get(key, &child)) {
ADD_FAILURE();
return false;
}
return child->GetType() == Value::TYPE_NULL;
}
bool IsNull(v8::Handle<v8::Object> value, const std::string& key) {
v8::Handle<v8::Value> child = value->Get(v8::String::New(key.c_str()));
if (child.IsEmpty()) {
ADD_FAILURE();
return false;
}
return child->IsNull();
}
bool IsNull(ListValue* value, uint32 index) {
Value* child = NULL;
if (!value->Get(static_cast<size_t>(index), &child)) {
ADD_FAILURE();
return false;
}
return child->GetType() == Value::TYPE_NULL;
}
bool IsNull(v8::Handle<v8::Array> value, uint32 index) {
v8::Handle<v8::Value> child = value->Get(index);
if (child.IsEmpty()) {
ADD_FAILURE();
return false;
}
return child->IsNull();
}
void TestWeirdType(const V8ValueConverter& converter,
v8::Handle<v8::Value> val,
base::Value::Type expected_type,
Value* expected_value) {
scoped_ptr<Value> raw(converter.FromV8Value(val, context_));
ASSERT_TRUE(raw.get());
EXPECT_EQ(expected_type, raw->GetType());
if (expected_value)
EXPECT_TRUE(expected_value->Equals(raw.get()));
v8::Handle<v8::Object> object(v8::Object::New());
object->Set(v8::String::New("test"), val);
scoped_ptr<DictionaryValue> dictionary(
static_cast<DictionaryValue*>(
converter.FromV8Value(object, context_)));
ASSERT_TRUE(dictionary.get());
Value* temp = NULL;
ASSERT_TRUE(dictionary->Get("test", &temp));
EXPECT_EQ(expected_type, temp->GetType());
if (expected_value)
EXPECT_TRUE(expected_value->Equals(temp));
v8::Handle<v8::Array> array(v8::Array::New());
array->Set(0, val);
scoped_ptr<ListValue> list(
static_cast<ListValue*>(
converter.FromV8Value(array, context_)));
ASSERT_TRUE(list.get());
ASSERT_TRUE(list->Get(0, &temp));
EXPECT_EQ(expected_type, temp->GetType());
if (expected_value)
EXPECT_TRUE(expected_value->Equals(temp));
}
// Context for the JavaScript in the test.
v8::Persistent<v8::Context> context_;
};
TEST_F(V8ValueConverterTest, BasicRoundTrip) {
DictionaryValue original_root;
original_root.Set("null", Value::CreateNullValue());
original_root.Set("true", Value::CreateBooleanValue(true));
original_root.Set("false", Value::CreateBooleanValue(false));
original_root.Set("positive-int", Value::CreateIntegerValue(42));
original_root.Set("negative-int", Value::CreateIntegerValue(-42));
original_root.Set("zero", Value::CreateIntegerValue(0));
original_root.Set("double", Value::CreateDoubleValue(88.8));
original_root.Set("big-integral-double",
Value::CreateDoubleValue(pow(2.0, 53)));
original_root.Set("string", Value::CreateStringValue("foobar"));
original_root.Set("empty-string", Value::CreateStringValue(""));
DictionaryValue* original_sub1 = new DictionaryValue();
original_sub1->Set("foo", Value::CreateStringValue("bar"));
original_sub1->Set("hot", Value::CreateStringValue("dog"));
original_root.Set("dictionary", original_sub1);
original_root.Set("empty-dictionary", new DictionaryValue());
ListValue* original_sub2 = new ListValue();
original_sub2->Append(Value::CreateStringValue("monkey"));
original_sub2->Append(Value::CreateStringValue("balls"));
original_root.Set("list", original_sub2);
original_root.Set("empty-list", new ListValue());
v8::Context::Scope context_scope(context_);
v8::HandleScope handle_scope;
V8ValueConverter converter;
v8::Handle<v8::Object> v8_object =
converter.ToV8Value(&original_root, context_).As<v8::Object>();
ASSERT_FALSE(v8_object.IsEmpty());
EXPECT_EQ(original_root.size(), v8_object->GetPropertyNames()->Length());
EXPECT_TRUE(v8_object->Get(v8::String::New("null"))->IsNull());
EXPECT_TRUE(v8_object->Get(v8::String::New("true"))->IsTrue());
EXPECT_TRUE(v8_object->Get(v8::String::New("false"))->IsFalse());
EXPECT_TRUE(v8_object->Get(v8::String::New("positive-int"))->IsInt32());
EXPECT_TRUE(v8_object->Get(v8::String::New("negative-int"))->IsInt32());
EXPECT_TRUE(v8_object->Get(v8::String::New("zero"))->IsInt32());
EXPECT_TRUE(v8_object->Get(v8::String::New("double"))->IsNumber());
EXPECT_TRUE(
v8_object->Get(v8::String::New("big-integral-double"))->IsNumber());
EXPECT_TRUE(v8_object->Get(v8::String::New("string"))->IsString());
EXPECT_TRUE(v8_object->Get(v8::String::New("empty-string"))->IsString());
EXPECT_TRUE(v8_object->Get(v8::String::New("dictionary"))->IsObject());
EXPECT_TRUE(v8_object->Get(v8::String::New("empty-dictionary"))->IsObject());
EXPECT_TRUE(v8_object->Get(v8::String::New("list"))->IsArray());
EXPECT_TRUE(v8_object->Get(v8::String::New("empty-list"))->IsArray());
scoped_ptr<Value> new_root(converter.FromV8Value(v8_object, context_));
EXPECT_NE(&original_root, new_root.get());
EXPECT_TRUE(original_root.Equals(new_root.get()));
}
TEST_F(V8ValueConverterTest, KeysWithDots) {
DictionaryValue original;
original.SetWithoutPathExpansion("foo.bar", Value::CreateStringValue("baz"));
v8::Context::Scope context_scope(context_);
v8::HandleScope handle_scope;
V8ValueConverter converter;
scoped_ptr<Value> copy(
converter.FromV8Value(
converter.ToV8Value(&original, context_), context_));
EXPECT_TRUE(original.Equals(copy.get()));
}
TEST_F(V8ValueConverterTest, ObjectExceptions) {
v8::Context::Scope context_scope(context_);
v8::HandleScope handle_scope;
// Set up objects to throw when reading or writing 'foo'.
const char* source =
"Object.prototype.__defineSetter__('foo', "
" function() { throw new Error('muah!'); });"
"Object.prototype.__defineGetter__('foo', "
" function() { throw new Error('muah!'); });";
v8::Handle<v8::Script> script(v8::Script::New(v8::String::New(source)));
script->Run();
v8::Handle<v8::Object> object(v8::Object::New());
object->Set(v8::String::New("bar"), v8::String::New("bar"));
// Converting from v8 value should replace the foo property with null.
V8ValueConverter converter;
scoped_ptr<DictionaryValue> converted(static_cast<DictionaryValue*>(
converter.FromV8Value(object, context_)));
EXPECT_TRUE(converted.get());
// http://code.google.com/p/v8/issues/detail?id=1342
// EXPECT_EQ(2u, converted->size());
// EXPECT_TRUE(IsNull(converted.get(), "foo"));
EXPECT_EQ(1u, converted->size());
EXPECT_EQ("bar", GetString(converted.get(), "bar"));
// Converting to v8 value should drop the foo property.
converted->SetString("foo", "foo");
v8::Handle<v8::Object> copy =
converter.ToV8Value(converted.get(), context_).As<v8::Object>();
EXPECT_FALSE(copy.IsEmpty());
EXPECT_EQ(2u, copy->GetPropertyNames()->Length());
EXPECT_EQ("bar", GetString(copy, "bar"));
}
TEST_F(V8ValueConverterTest, ArrayExceptions) {
v8::Context::Scope context_scope(context_);
v8::HandleScope handle_scope;
const char* source = "(function() {"
"var arr = [];"
"arr.__defineSetter__(0, "
" function() { throw new Error('muah!'); });"
"arr.__defineGetter__(0, "
" function() { throw new Error('muah!'); });"
"arr[1] = 'bar';"
"return arr;"
"})();";
v8::Handle<v8::Script> script(v8::Script::New(v8::String::New(source)));
v8::Handle<v8::Array> array = script->Run().As<v8::Array>();
ASSERT_FALSE(array.IsEmpty());
// Converting from v8 value should replace the first item with null.
V8ValueConverter converter;
scoped_ptr<ListValue> converted(static_cast<ListValue*>(
converter.FromV8Value(array, context_)));
ASSERT_TRUE(converted.get());
// http://code.google.com/p/v8/issues/detail?id=1342
EXPECT_EQ(2u, converted->GetSize());
EXPECT_TRUE(IsNull(converted.get(), 0));
// Converting to v8 value should drop the first item and leave a hole.
converted.reset(new ListValue());
converted->Append(Value::CreateStringValue("foo"));
converted->Append(Value::CreateStringValue("bar"));
v8::Handle<v8::Array> copy =
converter.ToV8Value(converted.get(), context_).As<v8::Array>();
ASSERT_FALSE(copy.IsEmpty());
EXPECT_EQ(2u, copy->Length());
EXPECT_EQ("bar", GetString(copy, 1));
}
TEST_F(V8ValueConverterTest, WeirdTypes) {
v8::Context::Scope context_scope(context_);
v8::HandleScope handle_scope;
v8::Handle<v8::RegExp> regex(
v8::RegExp::New(v8::String::New("."), v8::RegExp::kNone));
V8ValueConverter converter;
TestWeirdType(converter, v8::Undefined(), Value::TYPE_NULL, NULL);
TestWeirdType(converter, v8::Date::New(1000), Value::TYPE_DICTIONARY, NULL);
TestWeirdType(converter, regex, Value::TYPE_DICTIONARY, NULL);
converter.set_allow_undefined(true);
TestWeirdType(converter, v8::Undefined(), Value::TYPE_NULL, NULL);
converter.set_allow_date(true);
TestWeirdType(converter, v8::Date::New(1000), Value::TYPE_DOUBLE,
Value::CreateDoubleValue(1));
converter.set_allow_regexp(true);
TestWeirdType(converter, regex, Value::TYPE_STRING,
Value::CreateStringValue("/./"));
}
TEST_F(V8ValueConverterTest, Prototype) {
v8::Context::Scope context_scope(context_);
v8::HandleScope handle_scope;
const char* source = "(function() {"
"Object.prototype.foo = 'foo';"
"return {};"
"})();";
v8::Handle<v8::Script> script(v8::Script::New(v8::String::New(source)));
v8::Handle<v8::Object> object = script->Run().As<v8::Object>();
ASSERT_FALSE(object.IsEmpty());
V8ValueConverter converter;
scoped_ptr<DictionaryValue> result(
static_cast<DictionaryValue*>(converter.FromV8Value(object, context_)));
ASSERT_TRUE(result.get());
EXPECT_EQ(0u, result->size());
}
|