1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
|
// Copyright (c) 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <queue>
#include "base/bind.h"
#include "gpu/command_buffer/service/sync_point_manager.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace gpu {
class SyncPointManagerTest : public testing::Test {
public:
SyncPointManagerTest() {}
~SyncPointManagerTest() override {}
protected:
void SetUp() override {
sync_point_manager_.reset(new SyncPointManager(false));
}
void TearDown() override { sync_point_manager_.reset(); }
// Simple static function which can be used to test callbacks.
static void SetIntegerFunction(int* test, int value) { *test = value; }
scoped_ptr<SyncPointManager> sync_point_manager_;
};
struct SyncPointStream {
scoped_refptr<SyncPointOrderData> order_data;
scoped_ptr<SyncPointClient> client;
std::queue<uint32_t> order_numbers;
SyncPointStream(SyncPointManager* sync_point_manager,
CommandBufferNamespace namespace_id,
uint64_t command_buffer_id)
: order_data(SyncPointOrderData::Create()),
client(sync_point_manager->CreateSyncPointClient(order_data,
namespace_id,
command_buffer_id)) {}
~SyncPointStream() {
order_data->Destroy();
order_data = nullptr;
}
void AllocateOrderNum(SyncPointManager* sync_point_manager) {
order_numbers.push(
order_data->GenerateUnprocessedOrderNumber(sync_point_manager));
}
void BeginProcessing() {
ASSERT_FALSE(order_numbers.empty());
order_data->BeginProcessingOrderNumber(order_numbers.front());
}
void EndProcessing() {
ASSERT_FALSE(order_numbers.empty());
order_data->FinishProcessingOrderNumber(order_numbers.front());
order_numbers.pop();
}
};
TEST_F(SyncPointManagerTest, BasicSyncPointOrderDataTest) {
scoped_refptr<SyncPointOrderData> order_data = SyncPointOrderData::Create();
EXPECT_EQ(0u, order_data->current_order_num());
EXPECT_EQ(0u, order_data->processed_order_num());
EXPECT_EQ(0u, order_data->unprocessed_order_num());
const uint32_t order_num =
order_data->GenerateUnprocessedOrderNumber(sync_point_manager_.get());
EXPECT_EQ(1u, order_num);
EXPECT_EQ(0u, order_data->current_order_num());
EXPECT_EQ(0u, order_data->processed_order_num());
EXPECT_EQ(order_num, order_data->unprocessed_order_num());
order_data->BeginProcessingOrderNumber(order_num);
EXPECT_EQ(order_num, order_data->current_order_num());
EXPECT_EQ(0u, order_data->processed_order_num());
EXPECT_EQ(order_num, order_data->unprocessed_order_num());
order_data->FinishProcessingOrderNumber(order_num);
EXPECT_EQ(order_num, order_data->current_order_num());
EXPECT_EQ(order_num, order_data->processed_order_num());
EXPECT_EQ(order_num, order_data->unprocessed_order_num());
}
TEST_F(SyncPointManagerTest, SyncPointClientRegistration) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId = 0x123;
scoped_refptr<SyncPointClientState> empty_state =
sync_point_manager_->GetSyncPointClientState(kNamespaceId, kBufferId);
EXPECT_FALSE(empty_state);
scoped_refptr<SyncPointOrderData> order_data = SyncPointOrderData::Create();
scoped_ptr<SyncPointClient> client =
sync_point_manager_->CreateSyncPointClient(order_data, kNamespaceId,
kBufferId);
EXPECT_EQ(order_data, client->client_state()->order_data());
EXPECT_EQ(
client->client_state(),
sync_point_manager_->GetSyncPointClientState(kNamespaceId, kBufferId));
}
TEST_F(SyncPointManagerTest, BasicFenceSyncRelease) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId = 0x123;
scoped_refptr<SyncPointOrderData> order_data = SyncPointOrderData::Create();
scoped_ptr<SyncPointClient> client =
sync_point_manager_->CreateSyncPointClient(order_data, kNamespaceId,
kBufferId);
scoped_refptr<SyncPointClientState> client_state = client->client_state();
EXPECT_EQ(0u, client_state->fence_sync_release());
EXPECT_FALSE(client_state->IsFenceSyncReleased(1));
client->ReleaseFenceSync(1);
EXPECT_EQ(1u, client_state->fence_sync_release());
EXPECT_TRUE(client_state->IsFenceSyncReleased(1));
}
TEST_F(SyncPointManagerTest, MultipleClientsPerOrderData) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
scoped_refptr<SyncPointOrderData> order_data = SyncPointOrderData::Create();
scoped_ptr<SyncPointClient> client1 =
sync_point_manager_->CreateSyncPointClient(order_data, kNamespaceId,
kBufferId1);
scoped_ptr<SyncPointClient> client2 =
sync_point_manager_->CreateSyncPointClient(order_data, kNamespaceId,
kBufferId2);
scoped_refptr<SyncPointClientState> client_state1 = client1->client_state();
scoped_refptr<SyncPointClientState> client_state2 = client2->client_state();
client1->ReleaseFenceSync(1);
EXPECT_TRUE(client_state1->IsFenceSyncReleased(1));
EXPECT_FALSE(client_state2->IsFenceSyncReleased(1));
}
TEST_F(SyncPointManagerTest, BasicFenceSyncWaitRelease) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
release_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.BeginProcessing();
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
release_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
ASSERT_TRUE(valid_wait);
EXPECT_EQ(10, test_num);
release_stream.BeginProcessing();
release_stream.client->ReleaseFenceSync(1);
EXPECT_EQ(123, test_num);
}
TEST_F(SyncPointManagerTest, WaitOnSelfFails) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
// Generate wait order number first.
release_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.BeginProcessing();
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
wait_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
EXPECT_FALSE(valid_wait);
EXPECT_EQ(123, test_num);
}
TEST_F(SyncPointManagerTest, OutOfOrderRelease) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
// Generate wait order number first.
wait_stream.AllocateOrderNum(sync_point_manager_.get());
release_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.BeginProcessing();
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
release_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
EXPECT_FALSE(valid_wait);
EXPECT_EQ(123, test_num);
}
TEST_F(SyncPointManagerTest, HigherOrderNumberRelease) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
// Generate wait order number first.
wait_stream.AllocateOrderNum(sync_point_manager_.get());
release_stream.AllocateOrderNum(sync_point_manager_.get());
// Order number was higher but it was actually released.
release_stream.BeginProcessing();
release_stream.client->ReleaseFenceSync(1);
release_stream.EndProcessing();
wait_stream.BeginProcessing();
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
release_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
EXPECT_TRUE(valid_wait);
EXPECT_EQ(123, test_num);
}
TEST_F(SyncPointManagerTest, DestroyedClientRelease) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
release_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.BeginProcessing();
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
release_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
EXPECT_TRUE(valid_wait);
EXPECT_EQ(10, test_num);
// Destroying the client should release the wait.
release_stream.client.reset();
EXPECT_EQ(123, test_num);
}
TEST_F(SyncPointManagerTest, NonExistentRelease) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
// Assign release stream order [1] and wait stream order [2].
// This test simply tests that a wait stream of order [2] waiting on
// release stream of order [1] will still release the fence sync even
// though nothing was released.
release_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.BeginProcessing();
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
release_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
EXPECT_TRUE(valid_wait);
EXPECT_EQ(10, test_num);
// No release but finishing the order number should automatically release.
release_stream.BeginProcessing();
EXPECT_EQ(10, test_num);
release_stream.EndProcessing();
EXPECT_EQ(123, test_num);
}
TEST_F(SyncPointManagerTest, NonExistentRelease2) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
// Assign Release stream order [1] and assign Wait stream orders [2, 3].
// This test is similar to the NonExistentRelease case except
// we place an extra order number in between the release and wait.
// The wait stream [3] is waiting on release stream [1] even though
// order [2] was also generated. Although order [2] only exists on the
// wait stream so the release stream should only know about order [1].
release_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
// Have wait with order [3] to wait on release.
wait_stream.BeginProcessing();
ASSERT_EQ(2u, wait_stream.order_data->current_order_num());
wait_stream.EndProcessing();
wait_stream.BeginProcessing();
ASSERT_EQ(3u, wait_stream.order_data->current_order_num());
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
release_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
EXPECT_TRUE(valid_wait);
EXPECT_EQ(10, test_num);
// Even though release stream order [1] did not have a release, it
// should still release the fence when finish processing since the wait
// stream had expected on to exist there.
release_stream.BeginProcessing();
ASSERT_EQ(1u, release_stream.order_data->current_order_num());
release_stream.EndProcessing();
EXPECT_TRUE(release_stream.client->client_state()->IsFenceSyncReleased(1));
EXPECT_EQ(123, test_num);
}
TEST_F(SyncPointManagerTest, NonExistentOrderNumRelease) {
const CommandBufferNamespace kNamespaceId =
gpu::CommandBufferNamespace::GPU_IO;
const uint64_t kBufferId1 = 0x123;
const uint64_t kBufferId2 = 0x234;
SyncPointStream release_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId1);
SyncPointStream wait_stream(sync_point_manager_.get(), kNamespaceId,
kBufferId2);
// Assign Release stream orders [1, 4] and assign Wait stream orders [2, 3].
// Here we are testing that wait order [3] will wait on a fence sync
// in either order [1] or order [2]. Order [2] was not actually assigned
// to the release stream so it is essentially non-existent to the release
// stream's point of view. Once the release stream begins processing the next
// order [3], it should realize order [2] didn't exist and release the fence.
release_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
wait_stream.AllocateOrderNum(sync_point_manager_.get());
release_stream.AllocateOrderNum(sync_point_manager_.get());
// Have wait with order [3] to wait on release order [1] or [2].
wait_stream.BeginProcessing();
ASSERT_EQ(2u, wait_stream.order_data->current_order_num());
wait_stream.EndProcessing();
wait_stream.BeginProcessing();
ASSERT_EQ(3u, wait_stream.order_data->current_order_num());
int test_num = 10;
const bool valid_wait = wait_stream.client->Wait(
release_stream.client->client_state().get(), 1,
base::Bind(&SyncPointManagerTest::SetIntegerFunction, &test_num, 123));
EXPECT_TRUE(valid_wait);
EXPECT_EQ(10, test_num);
// Release stream should know it should release fence sync by order [3],
// so going through order [1] should not release it yet.
release_stream.BeginProcessing();
ASSERT_EQ(1u, release_stream.order_data->current_order_num());
release_stream.EndProcessing();
EXPECT_FALSE(release_stream.client->client_state()->IsFenceSyncReleased(1));
EXPECT_EQ(10, test_num);
// Beginning order [4] should immediately trigger the release.
release_stream.BeginProcessing();
ASSERT_EQ(4u, release_stream.order_data->current_order_num());
EXPECT_TRUE(release_stream.client->client_state()->IsFenceSyncReleased(1));
EXPECT_EQ(123, test_num);
}
} // namespace gpu
|