1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "sync/engine/sync_thread_sync_entity.h"
#include "base/memory/scoped_ptr.h"
#include "base/time/time.h"
#include "sync/internal_api/public/base/model_type.h"
#include "sync/syncable/syncable_util.h"
#include "sync/util/time.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace syncer {
// Some simple tests for the SyncThreadSyncEntity.
//
// The SyncThreadSyncEntity is an implementation detail of the
// NonBlockingTypeProcessorCore. As such, it doesn't make much sense to test
// it exhaustively, since it already gets a lot of test coverage from the
// NonBlockingTypeProcessorCore unit tests.
//
// These tests are intended as a basic sanity check. Anything more complicated
// would be redundant.
class SyncThreadSyncEntityTest : public ::testing::Test {
public:
SyncThreadSyncEntityTest()
: kServerId("ServerID"),
kClientTag("some.sample.tag"),
kClientTagHash(syncable::GenerateSyncableHash(PREFERENCES, kClientTag)),
kCtime(base::Time::UnixEpoch() + base::TimeDelta::FromDays(10)),
kMtime(base::Time::UnixEpoch() + base::TimeDelta::FromDays(20)) {
specifics.mutable_preference()->set_name(kClientTag);
specifics.mutable_preference()->set_value("pref.value");
}
virtual ~SyncThreadSyncEntityTest() {}
const std::string kServerId;
const std::string kClientTag;
const std::string kClientTagHash;
const base::Time kCtime;
const base::Time kMtime;
sync_pb::EntitySpecifics specifics;
};
// Construct a new entity from a server update. Then receive another update.
TEST_F(SyncThreadSyncEntityTest, FromServerUpdate) {
scoped_ptr<SyncThreadSyncEntity> entity(
SyncThreadSyncEntity::FromServerUpdate(kServerId, kClientTagHash, 10));
EXPECT_FALSE(entity->IsCommitPending());
entity->ReceiveUpdate(20);
EXPECT_FALSE(entity->IsCommitPending());
}
// Construct a new entity from a commit request. Then serialize it.
TEST_F(SyncThreadSyncEntityTest, FromCommitRequest) {
scoped_ptr<SyncThreadSyncEntity> entity(
SyncThreadSyncEntity::FromCommitRequest(kServerId,
kClientTagHash,
22,
33,
kCtime,
kMtime,
kClientTag,
false,
specifics));
ASSERT_TRUE(entity->IsCommitPending());
sync_pb::SyncEntity pb_entity;
int64 sequence_number = 0;
entity->PrepareCommitProto(&pb_entity, &sequence_number);
EXPECT_EQ(22, sequence_number);
EXPECT_EQ(kServerId, pb_entity.id_string());
EXPECT_EQ(kClientTagHash, pb_entity.client_defined_unique_tag());
EXPECT_EQ(33, pb_entity.version());
EXPECT_EQ(kCtime, ProtoTimeToTime(pb_entity.ctime()));
EXPECT_EQ(kMtime, ProtoTimeToTime(pb_entity.mtime()));
EXPECT_FALSE(pb_entity.deleted());
EXPECT_EQ(specifics.preference().name(),
pb_entity.specifics().preference().name());
EXPECT_EQ(specifics.preference().value(),
pb_entity.specifics().preference().value());
}
// Start with a server initiated entity. Commit over top of it.
TEST_F(SyncThreadSyncEntityTest, RequestCommit) {
scoped_ptr<SyncThreadSyncEntity> entity(
SyncThreadSyncEntity::FromServerUpdate(kServerId, kClientTagHash, 10));
entity->RequestCommit(kServerId,
kClientTagHash,
1,
10,
kCtime,
kMtime,
kClientTag,
false,
specifics);
EXPECT_TRUE(entity->IsCommitPending());
}
// Start with a server initiated entity. Fail to request a commit because of
// an out of date base version.
TEST_F(SyncThreadSyncEntityTest, RequestCommitFailure) {
scoped_ptr<SyncThreadSyncEntity> entity(
SyncThreadSyncEntity::FromServerUpdate(kServerId, kClientTagHash, 10));
EXPECT_FALSE(entity->IsCommitPending());
entity->RequestCommit(kServerId,
kClientTagHash,
23,
5, // Version 5 < 10
kCtime,
kMtime,
kClientTag,
false,
specifics);
EXPECT_FALSE(entity->IsCommitPending());
}
// Start with a pending commit. Clobber it with an incoming update.
TEST_F(SyncThreadSyncEntityTest, UpdateClobbersCommit) {
scoped_ptr<SyncThreadSyncEntity> entity(
SyncThreadSyncEntity::FromCommitRequest(kServerId,
kClientTagHash,
22,
33,
kCtime,
kMtime,
kClientTag,
false,
specifics));
EXPECT_TRUE(entity->IsCommitPending());
entity->ReceiveUpdate(400); // Version 400 > 33.
EXPECT_FALSE(entity->IsCommitPending());
}
// Start with a pending commit. Send it a reflected update that
// will not override the in-progress commit.
TEST_F(SyncThreadSyncEntityTest, ReflectedUpdateDoesntClobberCommit) {
scoped_ptr<SyncThreadSyncEntity> entity(
SyncThreadSyncEntity::FromCommitRequest(kServerId,
kClientTagHash,
22,
33,
kCtime,
kMtime,
kClientTag,
false,
specifics));
EXPECT_TRUE(entity->IsCommitPending());
entity->ReceiveUpdate(33); // Version 33 == 33.
EXPECT_TRUE(entity->IsCommitPending());
}
} // namespace syncer
|
