1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
|
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// A general interface for filtering and only acting on classes in Chromium C++
// code.
#include "ChromeClassTester.h"
#include <sys/param.h>
#include "clang/Basic/FileManager.h"
using namespace clang;
namespace {
bool starts_with(const std::string& one, const std::string& two) {
return one.compare(0, two.size(), two) == 0;
}
bool ends_with(const std::string& one, const std::string& two) {
if (two.size() > one.size())
return false;
return one.compare(one.size() - two.size(), two.size(), two) == 0;
}
} // namespace
ChromeClassTester::ChromeClassTester(CompilerInstance& instance)
: instance_(instance),
diagnostic_(instance.getDiagnostics()) {
BuildBannedLists();
}
void ChromeClassTester::BuildBannedLists() {
banned_namespaces_.push_back("std");
banned_namespaces_.push_back("__gnu_cxx");
banned_directories_.push_back("third_party/");
banned_directories_.push_back("native_client/");
banned_directories_.push_back("breakpad/");
banned_directories_.push_back("courgette/");
banned_directories_.push_back("ppapi/");
banned_directories_.push_back("usr/");
banned_directories_.push_back("testing/");
banned_directories_.push_back("googleurl/");
banned_directories_.push_back("v8/");
banned_directories_.push_back("sdch/");
// Don't check autogenerated headers.
banned_directories_.push_back("out/");
banned_directories_.push_back("llvm/");
banned_directories_.push_back("ninja/");
banned_directories_.push_back("xcodebuild/");
// You are standing in a mazy of twisty dependencies, all resolved by
// putting everything in the header.
banned_directories_.push_back("automation/");
// Don't check system headers.
banned_directories_.push_back("/Developer/");
// Used in really low level threading code that probably shouldn't be out of
// lined.
ignored_record_names_.insert("ThreadLocalBoolean");
// A complicated pickle derived struct that is all packed integers.
ignored_record_names_.insert("Header");
// Part of the GPU system that uses multiple included header
// weirdness. Never getting this right.
ignored_record_names_.insert("Validators");
// RAII class that's simple enough (media/base/callback.h).
ignored_record_names_.insert("AutoCallbackRunner");
// Has a UNIT_TEST only constructor. Isn't *terribly* complex...
ignored_record_names_.insert("AutocompleteController");
ignored_record_names_.insert("HistoryURLProvider");
// Because of chrome frame
ignored_record_names_.insert("ReliabilityTestSuite");
// Used over in the net unittests. A large enough bundle of integers with 1
// non-pod class member. Probably harmless.
ignored_record_names_.insert("MockTransaction");
// Used heavily in ui_unittests and once in views_unittests. Fixing this
// isn't worth the overhead of an additional library.
ignored_record_names_.insert("TestAnimationDelegate");
// Part of our public interface that nacl and friends use. (Arguably, this
// should mean that this is a higher priority but fixing this looks hard.)
ignored_record_names_.insert("PluginVersionInfo");
}
ChromeClassTester::~ChromeClassTester() {}
void ChromeClassTester::HandleTagDeclDefinition(TagDecl* tag) {
// We handle class types here where we have semantic information. We can only
// check structs/classes/enums here, but we get a bunch of nice semantic
// information instead of just parsing information.
if (CXXRecordDecl* record = dyn_cast<CXXRecordDecl>(tag)) {
// If this is a POD or a class template or a type dependent on a
// templated class, assume there's no ctor/dtor/virtual method
// optimization that we can do.
if (record->isPOD() ||
record->getDescribedClassTemplate() ||
record->getTemplateSpecializationKind() ||
record->isDependentType())
return;
if (InBannedNamespace(record))
return;
SourceLocation record_location = record->getInnerLocStart();
if (InBannedDirectory(record_location))
return;
// We sadly need to maintain a blacklist of types that violate these
// rules, but do so for good reason or due to limitations of this
// checker (i.e., we don't handle extern templates very well).
std::string base_name = record->getNameAsString();
if (IsIgnoredType(base_name))
return;
// We ignore all classes that end with "Matcher" because they're probably
// GMock artifacts.
if (ends_with(base_name, "Matcher"))
return;
CheckChromeClass(record_location, record);
}
}
void ChromeClassTester::emitWarning(SourceLocation loc, const char* raw_error) {
FullSourceLoc full(loc, instance().getSourceManager());
std::string err;
err = "[chromium-style] ";
err += raw_error;
Diagnostic::Level level =
diagnostic().getWarningsAsErrors() ?
Diagnostic::Error :
Diagnostic::Warning;
unsigned id = diagnostic().getCustomDiagID(level, err);
DiagnosticBuilder B = diagnostic().Report(full, id);
}
bool ChromeClassTester::InTestingNamespace(Decl* record) {
return GetNamespace(record).find("testing") != std::string::npos;
}
bool ChromeClassTester::InBannedNamespace(Decl* record) {
std::string n = GetNamespace(record);
if (n != "") {
return std::find(banned_namespaces_.begin(), banned_namespaces_.end(), n)
!= banned_namespaces_.end();
}
return false;
}
std::string ChromeClassTester::GetNamespace(Decl* record) {
return GetNamespaceImpl(record->getDeclContext(), "");
}
std::string ChromeClassTester::GetNamespaceImpl(const DeclContext* context,
std::string candidate) {
switch (context->getDeclKind()) {
case Decl::TranslationUnit: {
return candidate;
}
case Decl::Namespace: {
const NamespaceDecl* decl = dyn_cast<NamespaceDecl>(context);
std::string name_str;
llvm::raw_string_ostream OS(name_str);
if (decl->isAnonymousNamespace())
OS << "<anonymous namespace>";
else
OS << decl;
return GetNamespaceImpl(context->getParent(),
OS.str());
}
default: {
return GetNamespaceImpl(context->getParent(), candidate);
}
}
}
bool ChromeClassTester::InBannedDirectory(SourceLocation loc) {
const SourceManager &SM = instance_.getSourceManager();
SourceLocation spelling_location = SM.getSpellingLoc(loc);
PresumedLoc ploc = SM.getPresumedLoc(spelling_location);
std::string buffer_name;
if (ploc.isInvalid()) {
// If we're in an invalid location, we're looking at things that aren't
// actually stated in the source; treat this as a banned location instead
// of going through our full lookup process.
return true;
} else {
std::string b = ploc.getFilename();
// We need to special case scratch space; which is where clang does its
// macro expansion. We explicitly want to allow people to do otherwise bad
// things through macros that were defined due to third party libraries.
if (b == "<scratch space>")
return true;
// Don't complain about these things in implementation files.
if (ends_with(b, ".cc") || ends_with(b, ".cpp") || ends_with(b, ".mm")) {
return true;
}
// Don't complain about autogenerated protobuf files.
if (ends_with(b, ".pb.h")) {
return true;
}
// We need to munge the paths so that they are relative to the repository
// srcroot. We first resolve the symlinktastic relative path and then
// remove our known srcroot from it if needed.
char resolvedPath[MAXPATHLEN];
if (realpath(b.c_str(), resolvedPath)) {
b = resolvedPath;
}
for (std::vector<std::string>::const_iterator it =
banned_directories_.begin();
it != banned_directories_.end(); ++it) {
// If we can find any of the banned path components in this path, then
// this file is rejected.
size_t index = b.find(*it);
if (index != std::string::npos) {
bool matches_full_dir_name = index == 0 || b[index - 1] == '/';
if ((*it)[0] == '/')
matches_full_dir_name = true;
if (matches_full_dir_name)
return true;
}
}
}
return false;
}
bool ChromeClassTester::IsIgnoredType(const std::string& base_name) {
return ignored_record_names_.find(base_name) != ignored_record_names_.end();
}
|