blob: 1e532159972c56e65160f20e9a0bb353a06d2838 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef BASE_REFCOUNTED_H_
#define BASE_REFCOUNTED_H_
namespace base {
template <typename T>
class RefCounted {
public:
RefCounted() {}
~RefCounted() {}
};
template <typename T>
class RefCountedThreadSafe {
public:
RefCountedThreadSafe() {}
~RefCountedThreadSafe() {}
};
} // namespace base
// Ignore classes whose inheritance tree ends in WebKit's RefCounted base
// class. Though prone to error, this pattern is very prevalent in WebKit
// code, so do not issue any warnings.
namespace WebKit {
template <typename T>
class RefCounted {
public:
RefCounted() {}
~RefCounted() {}
};
} // namespace WebKit
// Unsafe; should error.
class PublicRefCountedDtorInHeader
: public base::RefCounted<PublicRefCountedDtorInHeader> {
public:
PublicRefCountedDtorInHeader() {}
~PublicRefCountedDtorInHeader() {}
private:
friend class base::RefCounted<PublicRefCountedDtorInHeader>;
};
// Unsafe; should error.
class PublicRefCountedThreadSafeDtorInHeader
: public base::RefCountedThreadSafe<
PublicRefCountedThreadSafeDtorInHeader> {
public:
PublicRefCountedThreadSafeDtorInHeader() {}
~PublicRefCountedThreadSafeDtorInHeader() {}
private:
friend class base::RefCountedThreadSafe<
PublicRefCountedThreadSafeDtorInHeader>;
};
// Safe; should not have errors.
class ProtectedRefCountedDtorInHeader
: public base::RefCounted<ProtectedRefCountedDtorInHeader> {
public:
ProtectedRefCountedDtorInHeader() {}
protected:
~ProtectedRefCountedDtorInHeader() {}
private:
friend class base::RefCounted<ProtectedRefCountedDtorInHeader>;
};
// Safe; should not have errors.
class PrivateRefCountedDtorInHeader
: public base::RefCounted<PrivateRefCountedDtorInHeader> {
public:
PrivateRefCountedDtorInHeader() {}
private:
~PrivateRefCountedDtorInHeader() {}
friend class base::RefCounted<PrivateRefCountedDtorInHeader>;
};
// Unsafe; A grandchild class ends up exposing their parent and grandparent's
// destructors.
class DerivedProtectedToPublicInHeader
: public ProtectedRefCountedDtorInHeader {
public:
DerivedProtectedToPublicInHeader() {}
~DerivedProtectedToPublicInHeader() {}
};
// Unsafe; A grandchild ends up implicitly exposing their parent and
// grantparent's destructors.
class ImplicitDerivedProtectedToPublicInHeader
: public ProtectedRefCountedDtorInHeader {
public:
ImplicitDerivedProtectedToPublicInHeader() {}
};
// Unsafe-but-ignored; should not have errors.
class WebKitPublicDtorInHeader
: public WebKit::RefCounted<WebKitPublicDtorInHeader> {
public:
WebKitPublicDtorInHeader() {}
~WebKitPublicDtorInHeader() {}
};
// Unsafe-but-ignored; should not have errors.
class WebKitDerivedPublicDtorInHeader
: public WebKitPublicDtorInHeader {
public:
WebKitDerivedPublicDtorInHeader() {}
~WebKitDerivedPublicDtorInHeader() {}
};
#endif // BASE_REFCOUNTED_H_
|
