1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
|
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "base/compiler_specific.h"
#include "base/message_loop.h"
#include "base/string_number_conversions.h"
#include "base/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/models/table_model.h"
#include "ui/base/models/table_model_observer.h"
#include "views/controls/table/table_view.h"
#include "views/controls/table/table_view2.h"
#include "views/window/window_delegate.h"
#if defined(OS_WIN)
#include "views/window/window_win.h"
#else
#include "views/window/window_gtk.h"
#endif
using ui::TableModel;
using ui::TableModelObserver; // TODO(beng): remove these
// Put the tests in the views namespace to make it easier to declare them as
// friend classes.
namespace views {
// TestTableModel --------------------------------------------------------------
// Trivial TableModel implementation that is backed by a vector of vectors.
// Provides methods for adding/removing/changing the contents that notify the
// observer appropriately.
//
// Initial contents are:
// 0, 1
// 1, 1
// 2, 2
class TestTableModel : public TableModel {
public:
TestTableModel();
// Adds a new row at index |row| with values |c1_value| and |c2_value|.
void AddRow(int row, int c1_value, int c2_value);
// Removes the row at index |row|.
void RemoveRow(int row);
// Changes the values of the row at |row|.
void ChangeRow(int row, int c1_value, int c2_value);
// TableModel
virtual int RowCount() OVERRIDE;
virtual string16 GetText(int row, int column_id) OVERRIDE;
virtual void SetObserver(TableModelObserver* observer) OVERRIDE;
virtual int CompareValues(int row1, int row2, int column_id) OVERRIDE;
private:
TableModelObserver* observer_;
// The data.
std::vector<std::vector<int> > rows_;
DISALLOW_COPY_AND_ASSIGN(TestTableModel);
};
// Same behavior as TestTableModel, except even items are in one group, while
// odd items are put in a different group.
class GroupTestTableModel : public TestTableModel {
virtual bool HasGroups() { return true; }
virtual Groups GetGroups() {
Groups groups;
Group group1, group2;
group1.title = ASCIIToUTF16("Group 1");
group1.id = 0;
group2.title = ASCIIToUTF16("Group 2");
group2.id = 0;
groups.push_back(group1);
groups.push_back(group2);
return groups;
}
// Return group = 0 if row is even, otherwise group = 1.
virtual int GetGroupID(int row) { return row % 2; }
};
TestTableModel::TestTableModel() : observer_(NULL) {
AddRow(0, 0, 1);
AddRow(1, 1, 1);
AddRow(2, 2, 2);
}
void TestTableModel::AddRow(int row, int c1_value, int c2_value) {
DCHECK(row >= 0 && row <= static_cast<int>(rows_.size()));
std::vector<int> new_row;
new_row.push_back(c1_value);
new_row.push_back(c2_value);
rows_.insert(rows_.begin() + row, new_row);
if (observer_)
observer_->OnItemsAdded(row, 1);
}
void TestTableModel::RemoveRow(int row) {
DCHECK(row >= 0 && row <= static_cast<int>(rows_.size()));
rows_.erase(rows_.begin() + row);
if (observer_)
observer_->OnItemsRemoved(row, 1);
}
void TestTableModel::ChangeRow(int row, int c1_value, int c2_value) {
DCHECK(row >= 0 && row < static_cast<int>(rows_.size()));
rows_[row][0] = c1_value;
rows_[row][1] = c2_value;
if (observer_)
observer_->OnItemsChanged(row, 1);
}
int TestTableModel::RowCount() {
return static_cast<int>(rows_.size());
}
string16 TestTableModel::GetText(int row, int column_id) {
return UTF8ToUTF16(base::IntToString(rows_[row][column_id]));
}
void TestTableModel::SetObserver(TableModelObserver* observer) {
observer_ = observer;
}
int TestTableModel::CompareValues(int row1, int row2, int column_id) {
return rows_[row1][column_id] - rows_[row2][column_id];
}
#if defined(OS_WIN)
// TableViewTest ---------------------------------------------------------------
class TableViewTest : public testing::Test, views::WindowDelegate {
public:
virtual void SetUp();
virtual void TearDown();
virtual views::View* GetContentsView() {
return table_;
}
protected:
// Creates the model.
virtual TestTableModel* CreateModel();
// Verifies the view order matches that of the supplied arguments. The
// arguments are in terms of the model. For example, values of '1, 0' indicate
// the model index at row 0 is 1 and the model index at row 1 is 0.
void VerifyViewOrder(int first, ...);
// Verifies the selection matches the supplied arguments. The supplied
// arguments are in terms of this model. This uses the iterator returned by
// SelectionBegin.
void VerifySelectedRows(int first, ...);
// Configures the state for the various multi-selection tests.
// This selects model rows 0 and 1, and if |sort| is true the first column
// is sorted in descending order.
void SetUpMultiSelectTestState(bool sort);
scoped_ptr<TestTableModel> model_;
// The table. This is owned by the window.
TableView* table_;
private:
MessageLoopForUI message_loop_;
views::Window* window_;
};
void TableViewTest::SetUp() {
OleInitialize(NULL);
model_.reset(CreateModel());
std::vector<TableColumn> columns;
columns.resize(2);
columns[0].id = 0;
columns[1].id = 1;
table_ = new TableView(model_.get(), columns, views::ICON_AND_TEXT,
false, false, false);
window_ =
views::Window::CreateChromeWindow(NULL, gfx::Rect(100, 100, 512, 512),
this);
}
void TableViewTest::TearDown() {
window_->CloseWindow();
// Temporary workaround to avoid leak of RootView::pending_paint_task_.
message_loop_.RunAllPending();
OleUninitialize();
}
void TableViewTest::VerifyViewOrder(int first, ...) {
va_list marker;
va_start(marker, first);
int value = first;
int index = 0;
for (int value = first, index = 0; value != -1; index++) {
ASSERT_EQ(value, table_->ViewToModel(index));
value = va_arg(marker, int);
}
va_end(marker);
}
void TableViewTest::VerifySelectedRows(int first, ...) {
va_list marker;
va_start(marker, first);
int value = first;
int index = 0;
TableView::iterator selection_iterator = table_->SelectionBegin();
for (int value = first, index = 0; value != -1; index++) {
ASSERT_TRUE(selection_iterator != table_->SelectionEnd());
ASSERT_EQ(value, *selection_iterator);
value = va_arg(marker, int);
++selection_iterator;
}
ASSERT_TRUE(selection_iterator == table_->SelectionEnd());
va_end(marker);
}
void TableViewTest::SetUpMultiSelectTestState(bool sort) {
// Select two rows.
table_->SetSelectedState(0, true);
table_->SetSelectedState(1, true);
VerifySelectedRows(1, 0, -1);
if (!sort || HasFatalFailure())
return;
// Sort by first column descending.
TableView::SortDescriptors sd;
sd.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sd);
VerifyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Make sure the two rows are sorted.
// NOTE: the order changed because iteration happens over view indices.
VerifySelectedRows(0, 1, -1);
}
TestTableModel* TableViewTest::CreateModel() {
return new TestTableModel();
}
// NullModelTableViewTest ------------------------------------------------------
class NullModelTableViewTest : public TableViewTest {
protected:
// Creates the model.
TestTableModel* CreateModel() {
return NULL;
}
};
// GroupModelTableViewTest -----------------------------------------------------
class GroupModelTableViewTest : public TableViewTest {
protected:
TestTableModel* CreateModel() {
return new GroupTestTableModel();
}
};
// Tests -----------------------------------------------------------------------
// Failing: http://crbug.com/45015
// Tests various sorting permutations.
TEST_F(TableViewTest, DISABLED_Sort) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VerifyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Sort by second column ascending, first column descending.
sort.clear();
sort.push_back(TableView::SortDescriptor(1, true));
sort.push_back(TableView::SortDescriptor(0, false));
sort[1].ascending = false;
table_->SetSortDescriptors(sort);
VerifyViewOrder(1, 0, 2, -1);
if (HasFatalFailure())
return;
// Clear the sort.
table_->SetSortDescriptors(TableView::SortDescriptors());
VerifyViewOrder(0, 1, 2, -1);
if (HasFatalFailure())
return;
}
// Failing: http://crbug.com/45015
// Tests changing the model while sorted.
TEST_F(TableViewTest, DISABLED_SortThenChange) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VerifyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
model_->ChangeRow(0, 3, 1);
VerifyViewOrder(0, 2, 1, -1);
}
// Failing: http://crbug.com/45015
// Tests adding to the model while sorted.
TEST_F(TableViewTest, DISABLED_AddToSorted) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VerifyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Add row so that it occurs first.
model_->AddRow(0, 5, -1);
VerifyViewOrder(0, 3, 2, 1, -1);
if (HasFatalFailure())
return;
// Add row so that it occurs last.
model_->AddRow(0, -1, -1);
VerifyViewOrder(1, 4, 3, 2, 0, -1);
}
// Failing: http://crbug.com/45015
// Tests selection on sort.
TEST_F(TableViewTest, DISABLED_PersistSelectionOnSort) {
// Select row 0.
table_->Select(0);
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
table_->SetSortDescriptors(sort);
VerifyViewOrder(2, 1, 0, -1);
if (HasFatalFailure())
return;
// Make sure 0 is still selected.
EXPECT_EQ(0, table_->FirstSelectedRow());
}
// Failing: http://crbug.com/45015
// Tests selection iterator with sort.
TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnSort) {
SetUpMultiSelectTestState(true);
}
// Failing: http://crbug.com/45015
// Tests selection persists after a change when sorted with iterator.
TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnChangeWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
model_->ChangeRow(0, 3, 1);
VerifySelectedRows(1, 0, -1);
}
// Failing: http://crbug.com/45015
// Tests selection persists after a remove when sorted with iterator.
TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnRemoveWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
model_->RemoveRow(0);
VerifySelectedRows(0, -1);
}
// Failing: http://crbug.com/45015
// Tests selection persists after a add when sorted with iterator.
TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnAddWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
model_->AddRow(3, 4, 4);
VerifySelectedRows(0, 1, -1);
}
// Failing: http://crbug.com/45015
// Tests selection persists after a change with iterator.
TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnChange) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
model_->ChangeRow(0, 3, 1);
VerifySelectedRows(1, 0, -1);
}
// Failing: http://crbug.com/45015
// Tests selection persists after a remove with iterator.
TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnRemove) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
model_->RemoveRow(0);
VerifySelectedRows(0, -1);
}
// Failing: http://crbug.com/45015
// Tests selection persists after a add with iterator.
TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnAdd) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
model_->AddRow(3, 4, 4);
VerifySelectedRows(1, 0, -1);
}
TEST_F(GroupModelTableViewTest, IndividualSelectAcrossGroups) {
table_->SetSelectedState(0, true);
table_->SetSelectedState(1, true);
table_->SetSelectedState(2, true);
VerifySelectedRows(2, 1, 0, -1);
}
TEST_F(GroupModelTableViewTest, ShiftSelectAcrossGroups) {
table_->SetSelectedState(0, true);
// Try to select across groups - this should fail.
ASSERT_FALSE(table_->SelectMultiple(1, 0));
VerifySelectedRows(0, -1);
}
TEST_F(GroupModelTableViewTest, ShiftSelectSameGroup) {
table_->SetSelectedState(0, true);
// Try to select in the same group - this should work but should only select
// items in the "even" group.
ASSERT_TRUE(table_->SelectMultiple(2, 0));
VerifySelectedRows(2, 0, -1);
}
// Crashing: http://crbug.com/45015
TEST_F(NullModelTableViewTest, DISABLED_NullModel) {
// There's nothing explicit to test. If there is a bug in TableView relating
// to a NULL model we'll crash.
}
#endif // OS_WIN
////////////////////////////////////////////////////////////////////////////////
// TableView2 Tests
class TableView2Test : public testing::Test, views::WindowDelegate {
public:
virtual void SetUp();
virtual void TearDown();
virtual views::View* GetContentsView() {
return table_;
}
// Returns the contents of a cell in the table.
std::wstring GetCellValue(int row, int column);
protected:
// Creates the model.
TestTableModel* CreateModel();
virtual views::TableTypes GetTableType() {
return views::TEXT_ONLY;
}
scoped_ptr<TestTableModel> model_;
// The table. This is owned by the window.
views::TableView2* table_;
private:
MessageLoopForUI message_loop_;
views::Window* window_;
};
void TableView2Test::SetUp() {
#if defined(OS_WIN)
OleInitialize(NULL);
#endif
model_.reset(CreateModel());
std::vector<TableColumn> columns;
columns.resize(2);
columns[0].id = 0;
columns[1].id = 1;
table_ = new views::TableView2(model_.get(), columns, GetTableType(),
views::TableView2::NONE);
window_ = views::Window::CreateChromeWindow(NULL,
gfx::Rect(100, 100, 512, 512),
this);
window_->Show();
}
void TableView2Test::TearDown() {
window_->CloseWindow();
// Temporary workaround to avoid leak of RootView::pending_paint_task_.
message_loop_.RunAllPending();
#if defined(OS_WIN)
OleUninitialize();
#endif
}
TestTableModel* TableView2Test::CreateModel() {
return new TestTableModel();
}
std::wstring TableView2Test::GetCellValue(int row, int column) {
#if defined(OS_WIN)
wchar_t str[128] = {0};
LVITEM item = {0};
item.mask = LVIF_TEXT;
item.iItem = row;
item.iSubItem = column;
item.pszText = str;
item.cchTextMax = 128;
BOOL r = ListView_GetItem(table_->GetTestingHandle(), &item);
DCHECK(r);
return std::wstring(str);
#else
GtkTreeModel* gtk_model =
gtk_tree_view_get_model(GTK_TREE_VIEW(table_->GetTestingHandle()));
DCHECK(gtk_model);
GtkTreeIter row_iter;
gboolean r = gtk_tree_model_iter_nth_child(gtk_model, &row_iter, NULL, row);
DCHECK(r);
gchar* text = NULL;
gtk_tree_model_get(gtk_model, &row_iter, column, &text, -1);
DCHECK(text);
std::wstring str(UTF8ToWide(text));
g_free(text);
return str;
#endif
}
// Tests that the table correctly reflects changes to the model.
TEST_F(TableView2Test, ModelChangesTest) {
ASSERT_EQ(3, table_->GetRowCount());
EXPECT_EQ(L"0", GetCellValue(0, 0));
EXPECT_EQ(L"1", GetCellValue(1, 0));
EXPECT_EQ(L"2", GetCellValue(2, 1));
// Test adding rows and that OnItemsAdded works.
model_->AddRow(3, 3, 3);
model_->AddRow(4, 4, 4);
table_->OnItemsAdded(3, 2);
ASSERT_EQ(5, table_->GetRowCount());
EXPECT_EQ(L"3", GetCellValue(3, 0));
EXPECT_EQ(L"4", GetCellValue(4, 1));
// Test removing rows and that OnItemsRemoved works.
model_->RemoveRow(1);
model_->RemoveRow(1);
table_->OnItemsRemoved(1, 2);
ASSERT_EQ(3, table_->GetRowCount());
EXPECT_EQ(L"0", GetCellValue(0, 0));
EXPECT_EQ(L"3", GetCellValue(1, 0));
EXPECT_EQ(L"4", GetCellValue(2, 1));
// Test changing rows and that OnItemsChanged works.
model_->ChangeRow(1, 1, 1);
model_->ChangeRow(2, 2, 2);
table_->OnItemsChanged(1, 2);
EXPECT_EQ(L"0", GetCellValue(0, 0));
EXPECT_EQ(L"1", GetCellValue(1, 0));
EXPECT_EQ(L"2", GetCellValue(2, 1));
// Test adding and removing rows and using OnModelChanged.
model_->RemoveRow(2);
model_->AddRow(2, 5, 5);
model_->AddRow(3, 6, 6);
table_->OnModelChanged();
ASSERT_EQ(4, table_->GetRowCount());
EXPECT_EQ(L"0", GetCellValue(0, 0));
EXPECT_EQ(L"1", GetCellValue(1, 0));
EXPECT_EQ(L"5", GetCellValue(2, 1));
EXPECT_EQ(L"6", GetCellValue(3, 1));
}
// Test the selection on a single-selection table.
TEST_F(TableView2Test, SingleSelectionTest) {
EXPECT_EQ(0, table_->SelectedRowCount());
EXPECT_EQ(-1, table_->GetFirstSelectedRow());
table_->SelectRow(0);
EXPECT_EQ(1, table_->SelectedRowCount());
EXPECT_EQ(0, table_->GetFirstSelectedRow());
table_->SelectRow(2);
EXPECT_EQ(1, table_->SelectedRowCount());
EXPECT_EQ(2, table_->GetFirstSelectedRow());
table_->ClearSelection();
EXPECT_EQ(0, table_->SelectedRowCount());
EXPECT_EQ(-1, table_->GetFirstSelectedRow());
}
// Row focusing are not supported on Linux yet.
#if defined(OS_WIN)
// Test the row focus on a single-selection table.
TEST_F(TableView2Test, RowFocusTest) {
EXPECT_EQ(-1, table_->GetFirstFocusedRow());
table_->FocusRow(0);
EXPECT_EQ(0, table_->GetFirstFocusedRow());
table_->FocusRow(2);
EXPECT_EQ(2, table_->GetFirstFocusedRow());
table_->ClearRowFocus();
EXPECT_EQ(-1, table_->GetFirstSelectedRow());
}
#endif
} // namespace views
|