From d9fc3d2a3f43d4295db24883223dbe71ff8dd5d4 Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Thu, 29 Jan 2015 17:22:14 +0900 Subject: xgettext: Support message syntax checks With this change, xgettext could report common syntactic problems in extracted strings. The current built-in checks are ellipsis-unicode, space-ellipsis, and quote-unicode. Those checks can be enabled with --check option of xgettext and disabled with special "xgettext:" comment in source files. Feature suggested by Philip Withnall in: https://savannah.gnu.org/bugs/?44098 * gettext-tools/src/message.h (enum syntax_check_type): New enum. (NSYNTAXCHECKS): New constant. (enum is_syntax_check): New enum. (struct message_ty): New field 'do_syntax_check'. (syntax_check_name): New variable declaration. * gettext-tools/src/message.c (syntax_check_name): New variable. * gettext-tools/src/msgl-cat.c (catenate_msgdomain_list): Propagate mp->do_syntax_check. * gettext-tools/src/msgmerge.c (message_merge): Propagate ref->do_syntax_check. * gettext-tools/src/msgl-check.h (syntax_check_message_list): New declaration. * gettext-tools/src/msgl-check.c (sentence_end): New function. (syntax_check_ellipsis_unicode): New function. (syntax_check_space_ellipsis): New function. (syntax_check_quote_unicode): New function. (syntax_check_message): New function. (syntax_check_message_list): New function. * gettext-tools/src/read-catalog-abstract.h (po_parse_comment_special): Adjust function declaration. * gettext-tools/src/read-catalog-abstract.c (po_parse_comment_special): Add new argument SCP for syntax checking; all callers changed. * gettext-tools/src/read-catalog.h (DEFAULT_CATALOG_READER_TY): New field 'do_syntax_check'. * gettext-tools/src/read-catalog.c (default_constructor): Initialize this->do_syntax_check. (default_copy_comment_state): Propagate this->do_syntax_check. * gettext-tools/src/xgettext.c (long_options): Add --check option. (main): Handle --check option. (usage): Document --check option. (remember_a_message): Propagate do_syntax_check value. * gettext-tools/tests/xgettext-14: New file. * gettext-tools/tests/sentence.c: New file. * gettext-tools/tests/Makefile.am (TESTS): Add new test. (noinst_PROGRAMS): Add 'sentence'. (sentence_SOURCES): New variable. (sentence_CPPFLAGS): New variable. (sentence_LDADD): New variable. * gettext-tools/doc/xgettext.texi: Document --check option. --- gettext-tools/src/ChangeLog | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) (limited to 'gettext-tools/src/ChangeLog') diff --git a/gettext-tools/src/ChangeLog b/gettext-tools/src/ChangeLog index 93a7dd0..f0e10fe 100644 --- a/gettext-tools/src/ChangeLog +++ b/gettext-tools/src/ChangeLog @@ -1,3 +1,44 @@ +2015-03-02 Daiki Ueno + + xgettext: Support message syntax checks + With this change, xgettext could report common syntactic problems + in extracted strings. The current built-in checks are + ellipsis-unicode, space-ellipsis, and quote-unicode. Those checks + can be enabled with --check option of xgettext and disabled with + special "xgettext:" comment in source files. + Feature suggested by Philip Withnall in: + https://savannah.gnu.org/bugs/?44098 + * message.h (enum syntax_check_type): New enum. + (NSYNTAXCHECKS): New constant. + (enum is_syntax_check): New enum. + (struct message_ty): New field 'do_syntax_check'. + (syntax_check_name): New variable declaration. + * message.c (syntax_check_name): New variable. + * msgl-cat.c (catenate_msgdomain_list): Propagate + mp->do_syntax_check. + * msgmerge.c (message_merge): Propagate ref->do_syntax_check. + * msgl-check.h (syntax_check_message_list): New declaration. + * msgl-check.c (syntax_check_ellipsis_unicode): New function. + (syntax_check_space_ellipsis): New function. + (syntax_check_quote_unicode): New function. + (syntax_check_message): New function. + (syntax_check_message_list): New function. + * read-catalog-abstract.h (po_parse_comment_special): Adjust + function declaration. + * read-catalog-abstract.c (po_parse_comment_special): Add new + argument SCP for syntax checking; all callers changed. + * read-catalog.h (DEFAULT_CATALOG_READER_TY): New field + 'do_syntax_check'. + * read-catalog.c (default_constructor): Initialize + this->do_syntax_check. + (default_copy_comment_state): Propagate this->do_syntax_check. + * sentence.h: New file. + * sentence.c: New file. + * xgettext.c (long_options): Add options --check and --sentence-end. + (main): Handle options --check and --sentence-end. + (usage): Document options --check and --sentence-end. + (remember_a_message): Propagate do_syntax_check value. + 2015-02-05 Alex Henrie (tiny change) xgettext: Wrap location comments to 79 characters -- cgit v1.1