aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* qmi-firmware-update: allow selecting multiple image files to downloadAleksander Morgado2017-01-163-16/+117
|
* qmi-firmware-update: new QfuUpdater with the core upgrade logicAleksander Morgado2017-01-167-23/+505
| | | | Initially, load sysfs path and setup state machine.
* qmi-firmware-update: new tool skeletonAleksander Morgado2017-01-165-1/+261
|
* utils,swi-update: fix build error when DEBUG not definedAleksander Morgado2017-01-161-2/+0
| | | | | | | swi-update.c: In function ‘download_image’: swi-update.c:838:8: error: ‘debug’ undeclared (first use in this function) if (!debug) ^~~~~
* utils/swi-update: avoid shadowing global variableAleksander Morgado2017-01-161-10/+10
| | | | | | | | | | swi-update.c: In function ‘parse_sdp_hello’: swi-update.c:506:7: error: declaration of ‘buf’ shadows a global declaration [-Werror=shadow] char buf[sizeof(*r) + sizeof(__u16)]; ^~~ swi-update.c:75:14: note: shadowed declaration is here static char *buf = NULL; ^~~
* utils,swi-update: include in buildAleksander Morgado2017-01-162-0/+2
|
* utils,swi-update: add license in header and use unix EOLAleksander Morgado2017-01-161-982/+997
|
* utils,swi-update: new tool to update QMI firmwareAleksander Morgado2017-01-161-0/+982
| | | | From: Bjørn Mork <bjorn@mork.no>
* libqmi-glib,device: fix segfault when cancellable already cancelledAleksander Morgado2017-01-151-0/+8
| | | | | | | | | | | | | | | | Thread 1 received signal SIGSEGV, Segmentation fault. 0x00007ffff79c9105 in transaction_cancelled (cancellable=0x7fffe4009420, ctx=0x669a30) at qmi-device.c:268 268 tr->cancellable_id = 0; The g_cancellable_connect() method will also call the given callback when the input cancellable is already cancelled. This means that the cancellation callback should also handle the case where the transaction hasn't been stored in the tracking table yet. Thanks to Benoît Donnette <benoit.donnette@21net.com> for the report and the suggested fix. https://bugs.freedesktop.org/show_bug.cgi?id=98283
* libqmi-glib,device: always create transactions tracking tableAleksander Morgado2017-01-151-4/+3
| | | | | Just easier; an empty GHashTable in the worst case where the device is not used at all shouldn't be an issue.
* libqmi-glib,device: fix releasing transaction on mbim errorAleksander Morgado2017-01-151-0/+1
| | | | | | | | | | If we don't release the transaction on the MBIM error, we will end up asserting on QmiDevice's finalize() when validating that there aren't pending transactions. [04 Jan 2017, 14:46:22] [Debug] [qfu-updater] error (ignored): couldn't close QMI device: Transaction timed out Qmi:ERROR:qmi-device.c:3262:finalize: assertion failed: (g_hash_table_size (self->priv->transactions) == 0) Aborted
* qmicli: use G_SOURCE_CONTINUE to reset the unix signal handlerAleksander Morgado2016-11-301-7/+6
|
* qmicli,helpers: fix uninitialized variablesAleksander Morgado2016-11-281-2/+2
|
* qmicli,helpers: more strict approach validating the unique id stringAleksander Morgado2016-11-281-4/+27
| | | | | | | | | We don't want e.g. an array that has some printable ASCII bytes, then NUL bytes and then some more printable ASCII bytes. We require a totally valid ASCII string, suffixed with NUL bytes if the string is shorter than 16 bytes. Plus, we avoid g_str_is_ascii(), which is only available in GLib 2.40.0.
* qmicli,dms: firmware image unique id seems to be ASCIIAleksander Morgado2016-11-283-6/+31
| | | | But just in case leave the raw-hex printable string fallback if it isn't.
* qmicli,dms: implement --dms-get-firmware-preferenceAleksander Morgado2016-11-281-0/+75
|
* qmicli,dms: error if missing fields in --dms-set-firmware-preferenceAleksander Morgado2016-11-281-0/+5
|
* qmicli,dms: improve output when setting firmware preferenceAleksander Morgado2016-11-281-28/+38
|
* qmicli,dms: plug memleaks when setting firmware preferenceAleksander Morgado2016-11-281-23/+44
| | | | Not a big deal, because qmicli exits after the operation, but anyway.
* build: require glib 2.36Aleksander Morgado2016-11-281-1/+1
| | | | | We want to start using new GLib features like e.g. GTask, available in GLib 2.36.
* qmicli: use g_clear_object() to cleanup cancellable after async operationAleksander Morgado2016-11-251-4/+2
|
* qmicli: use g_unix_signal_add() to setup signalsAleksander Morgado2016-11-251-15/+17
| | | | So that we can safely call GLib/GIO functions from within the signal handlers.
* qmicli: fix second ctrl+c handling in qmicliAleksander Morgado2016-11-251-1/+1
| | | | | A single ctrl+c cancels the GCancellable, and the second ctrl+c should have stopped the GMainLoop, but that was never happening.
* qmicli,pdc: print ongoing messages instead of debugAleksander Morgado2016-11-231-2/+2
|
* qmicli,pdc: use correct identifier to print gsizeAleksander Morgado2016-11-231-1/+1
| | | | | | qmicli-pdc.c: In function 'load_config_input_create_chunk': qmicli-pdc.c:1022:14: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'gsize {aka unsigned int}' [-Werror=format=] g_debug ("Uploaded %lu of %lu\n", config_file->offset, full_size);
* qmicli: avoid converting to dB invalid SINR valuesAleksander Morgado2016-11-171-16/+46
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=92106
* build: set qmi-pdc.h as nodistAleksander Morgado2016-10-311-0/+1
|
* libqmi-glib,device: make sure transaction ids are uniqueAleksander Morgado2016-10-281-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise, we may end up with transactions timing out and segfaulting as they aren't found in the tracking table (e.g. if the replacing transaction finishes before the timeout of the replaced transaction is fired off). ==573== Command: /usr/libexec/qmi-proxy --no-exit --verbose ==573== Parent PID: 567 ==573== ==573== Invalid write of size 8 ==573== at 0x4E9A07A: transaction_timed_out (qmi-device.c:248) ==573== by 0x5D24EB2: ??? (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x5D24439: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x5D247EF: ??? (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x5D24B11: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x40139D: main (qmi-proxy.c:220) ==573== Address 0x10 is not stack'd, malloc'd or (recently) free'd ==573== ==573== ==573== Process terminating with default action of signal 11 (SIGSEGV): dumping core ==573== Access not within mapped region at address 0x10 ==573== at 0x4E9A07A: transaction_timed_out (qmi-device.c:248) ==573== by 0x5D24EB2: ??? (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x5D24439: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x5D247EF: ??? (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x5D24B11: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5000.1) ==573== by 0x40139D: main (qmi-proxy.c:220) ==573== If you believe this happened as a result of a stack ==573== overflow in your program's main thread (unlikely but ==573== possible), you can try to increase the size of the ==573== main thread stack using the --main-stacksize= flag. ==573== The main thread stack size used in this run was 8388608.
* libqmi-glib,device: make sure transaction is removed from table on early errorsAleksander Morgado2016-10-271-16/+28
|
* libqmi-glib,proxy: fix segfault when trying to use already disposed clientsAleksander Morgado2016-10-271-79/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the client which originated the request exits (e.g. HUP received in its socket) before the actual response from the QmiDevice arrives, we'll end up trying to access the Client info (as kept in request->client) even if it has already been freed. Fix that, by making the Client a ref-counted object, and passing around full references of the Client where needed, e.g.: * In the async callbacks where Client is passed as data. * Inside each Request. Doing this we make sure each operation has a totally valid Client until the operation finishes, even if the client gets disconnected in between. ==311== Invalid read of size 8 ==311== at 0x4E9381C: track_cid (qmi-proxy.c:443) ==311== by 0x4E93A45: device_command_ready (qmi-proxy.c:492) ==311== by 0x52BEC18: g_simple_async_result_complete (gsimpleasyncresult.c:777) ==311== by 0x52BEC4E: complete_in_idle_cb (gsimpleasyncresult.c:789) ==311== by 0x583FA6D: g_idle_dispatch (gmain.c:5250) ==311== by 0x583D47A: g_main_dispatch (gmain.c:3065) ==311== by 0x583E237: g_main_context_dispatch (gmain.c:3641) ==311== by 0x583E463: g_main_context_iterate (gmain.c:3712) ==311== by 0x583E79C: g_main_loop_run (gmain.c:3906) ==311== by 0x401411: main (qmi-proxy.c:220) ==311== Address 0x87c7450 is 48 bytes inside a block of size 64 free'd ==311== at 0x4C2A0C0: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==311== by 0x584519E: g_free (gmem.c:197) ==311== by 0x585BBF6: g_slice_free1 (gslice.c:1124) ==311== by 0x4E92CC5: client_free (qmi-proxy.c:149) ==311== by 0x4E92DD4: connection_close (qmi-proxy.c:177) ==311== by 0x4E93CFF: connection_readable_cb (qmi-proxy.c:586) ==311== by 0x52C2A4D: socket_source_dispatch (gsocket.c:3264) ==311== by 0x583D47A: g_main_dispatch (gmain.c:3065) ==311== by 0x583E237: g_main_context_dispatch (gmain.c:3641) ==311== by 0x583E463: g_main_context_iterate (gmain.c:3712) ==311== by 0x583E79C: g_main_loop_run (gmain.c:3906) ==311== by 0x401411: main (qmi-proxy.c:220) ==311== Block was alloc'd at ==311== at 0x4C2B3D0: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==311== by 0x584502D: g_malloc (gmem.c:104) ==311== by 0x585B990: g_slice_alloc (gslice.c:1016) ==311== by 0x585B9D4: g_slice_alloc0 (gslice.c:1042) ==311== by 0x4E93FC5: incoming_cb (qmi-proxy.c:655) ==311== by 0x60F2A4B: ffi_call_unix64 (unix64.S:75) ==311== by 0x60F24B8: ffi_call (ffi64.c:492) ==311== by 0x55BB773: g_cclosure_marshal_generic (gclosure.c:1454) ==311== by 0x55BA093: g_closure_invoke (gclosure.c:777) ==311== by 0x55D1B45: signal_emit_unlocked_R (gsignal.c:3586) ==311== by 0x55D0F00: g_signal_emit_valist (gsignal.c:3340) ==311== by 0x55D1383: g_signal_emit (gsignal.c:3386) and: ==9308== Invalid read of size 8 ==9308== at 0x4E93641: device_new_ready (qmi-proxy.c:348) ==9308== by 0x52BEC18: g_simple_async_result_complete (gsimpleasyncresult.c:777) ==9308== by 0x52BEC4E: complete_in_idle_cb (gsimpleasyncresult.c:789) ==9308== by 0x583FA6D: g_idle_dispatch (gmain.c:5250) ==9308== by 0x583D47A: g_main_dispatch (gmain.c:3065) ==9308== by 0x583E237: g_main_context_dispatch (gmain.c:3641) ==9308== by 0x583E463: g_main_context_iterate (gmain.c:3712) ==9308== by 0x583E79C: g_main_loop_run (gmain.c:3906) ==9308== by 0x401411: main (qmi-proxy.c:220) ==9308== Address 0x8d04930 is 32 bytes inside a block of size 72 free'd ==9308== at 0x4C2A0C0: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9308== by 0x584519E: g_free (gmem.c:197) ==9308== by 0x585BBF6: g_slice_free1 (gslice.c:1124) ==9308== by 0x4E92EAB: client_free (qmi-proxy.c:159) ==9308== by 0x4E92FBA: connection_close (qmi-proxy.c:187) ==9308== by 0x4E93FC1: connection_readable_cb (qmi-proxy.c:626) ==9308== by 0x52C2A4D: socket_source_dispatch (gsocket.c:3264) ==9308== by 0x583D47A: g_main_dispatch (gmain.c:3065) ==9308== by 0x583E237: g_main_context_dispatch (gmain.c:3641) ==9308== by 0x583E463: g_main_context_iterate (gmain.c:3712) ==9308== by 0x583E79C: g_main_loop_run (gmain.c:3906) ==9308== by 0x401411: main (qmi-proxy.c:220) ==9308== Block was alloc'd at ==9308== at 0x4C2B3D0: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9308== by 0x584502D: g_malloc (gmem.c:104) ==9308== by 0x585B990: g_slice_alloc (gslice.c:1016) ==9308== by 0x585B9D4: g_slice_alloc0 (gslice.c:1042) ==9308== by 0x4E94287: incoming_cb (qmi-proxy.c:695) ==9308== by 0x60F2A4B: ffi_call_unix64 (unix64.S:75) ==9308== by 0x60F24B8: ffi_call (ffi64.c:492) ==9308== by 0x55BB773: g_cclosure_marshal_generic (gclosure.c:1454) ==9308== by 0x55BA093: g_closure_invoke (gclosure.c:777) ==9308== by 0x55D1B45: signal_emit_unlocked_R (gsignal.c:3586) ==9308== by 0x55D0F00: g_signal_emit_valist (gsignal.c:3340) ==9308== by 0x55D1383: g_signal_emit (gsignal.c:3386)
* libqmi-glib,proxy: plug memleak on command errorAleksander Morgado2016-10-271-0/+1
|
* libqmi-glib,proxy: print error message on response forwarding error, and ↵Aleksander Morgado2016-10-271-1/+4
| | | | plug memleak
* libqmi-glib,proxy: print error message on proxy open response error, and ↵Aleksander Morgado2016-10-271-0/+2
| | | | plug memleak
* libqmi-glib,proxy: print error message when indication cannot be forwardedAleksander Morgado2016-10-271-1/+1
|
* build: include PDC service enums in distAleksander Morgado2016-10-271-0/+2
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=98459
* pdc: minor fixes in qmicli loggingAliaksandr Barouski2016-10-261-6/+4
|
* pdc: use NOT_PROVISIONED to detect 'no configs'Aliaksandr Barouski2016-10-261-1/+2
| | | | | changed logic a bit to support situation when there is no config activated. In this case indication generated with error NOT_PROVISIONED.
* pdc: 2s of timeout to wait for configs listAleksander Morgado2016-10-261-0/+26
| | | | | | There won't be any indication if no configs are available. Based on a patch from Aliaksandr Barouski <alex.borovsky@gmail.com>.
* qmicli: minor fix in comment textAleksander Morgado2016-10-261-1/+1
|
* qmicli,pdc: refactor coding style and fix invalid freesAleksander Morgado2016-10-261-515/+423
| | | | | Mostly coding style fixes, although the patch also fixes several allocation issues when freeing GSlices.
* qmicli: remove unused helpersAleksander Morgado2016-10-262-50/+0
|
* qmicli: refactor qmicli_read_binary_array_from_string() helperAleksander Morgado2016-10-262-27/+77
| | | | | | The original implementation actually had some bugs when freeing the output array in error conditions. Also, use g_ascii_xdigit_value() instead of custom conversions.
* pdc: no need to CamelCase parameter namesAleksander Morgado2016-10-261-1/+1
|
* pdc: new PDC service implementationAliaksandr Barouski2016-10-2616-1/+2030
| | | | Added calls for configure hp4120 LTE modem
* dms: new 'Change Device Download Mode' commandAleksander Morgado2016-10-243-0/+93
| | | | | | Based on a patch from Aliaksandr Barouski <alex.borovsky@gmail.com> https://bugs.freedesktop.org/show_bug.cgi?id=96465
* qmicli/nas: add --nas-get-rf-band-infoDan Williams2016-10-111-0/+73
|
* wds: make WDS Extended Error Code TLV a common-refDan Williams2016-10-062-72/+20
|
* wds: add more TLVs and ModifyProfile/DeleteProfile requestsDan Williams2016-10-065-30/+297
|
* wds: add more Profile-related TLVsDan Williams2016-10-064-9/+155
|
* wds: move common Profile-related TLVs to common-refsDan Williams2016-10-062-404/+221
|
generated by cgit v1.1 at 2024-12-24 03:05:06 +0000