From 6b1a807ae81670fa26344fa0dc4ab394413d6157 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Fri, 10 Feb 2017 23:30:26 +0100 Subject: qmi-firmware-update: plug memleak ==14200== 308 (208 direct, 100 indirect) bytes in 1 blocks are definitely lost in loss record 1,163 of 1,191 ==14200== at 0x4C2AB8D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==14200== by 0x5D34B98: g_malloc (in /usr/lib/libglib-2.0.so.0.5000.2) ==14200== by 0x5D4D0D2: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5000.2) ==14200== by 0x5D4D6FD: g_slice_alloc0 (in /usr/lib/libglib-2.0.so.0.5000.2) ==14200== by 0x5AC62B3: g_type_create_instance (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5AA81FA: ??? (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5AA9C0C: g_object_newv (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5AAA3C3: g_object_new (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5789694: g_task_new (in /usr/lib/libgio-2.0.so.0.5000.2) ==14200== by 0x40D2E1: qfu_udev_helper_wait_for_device (qfu-udev-helpers.c:580) ==14200== by 0x40753D: qfu_device_selection_wait_for_tty (qfu-device-selection.c:211) ==14200== by 0x40A380: run_context_step_wait_for_tty (qfu-updater.c:798) ==14200== ==14200== 308 (208 direct, 100 indirect) bytes in 1 blocks are definitely lost in loss record 1,164 of 1,191 ==14200== at 0x4C2AB8D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==14200== by 0x5D34B98: g_malloc (in /usr/lib/libglib-2.0.so.0.5000.2) ==14200== by 0x5D4D0D2: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5000.2) ==14200== by 0x5D4D6FD: g_slice_alloc0 (in /usr/lib/libglib-2.0.so.0.5000.2) ==14200== by 0x5AC62B3: g_type_create_instance (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5AA81FA: ??? (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5AA9C0C: g_object_newv (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5AAA3C3: g_object_new (in /usr/lib/libgobject-2.0.so.0.5000.2) ==14200== by 0x5789694: g_task_new (in /usr/lib/libgio-2.0.so.0.5000.2) ==14200== by 0x40D2E1: qfu_udev_helper_wait_for_device (qfu-udev-helpers.c:580) ==14200== by 0x4074DD: qfu_device_selection_wait_for_cdc_wdm (qfu-device-selection.c:195) ==14200== by 0x409977: run_context_step_wait_for_cdc_wdm (qfu-updater.c:579) --- src/qmi-firmware-update/qfu-udev-helpers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qmi-firmware-update/qfu-udev-helpers.c b/src/qmi-firmware-update/qfu-udev-helpers.c index d1eb5df..89a80eb 100644 --- a/src/qmi-firmware-update/qfu-udev-helpers.c +++ b/src/qmi-firmware-update/qfu-udev-helpers.c @@ -507,6 +507,7 @@ handle_uevent (GUdevClient *client, ctx->timeout_id = 0; g_task_return_pointer (task, file, g_object_unref); + g_object_unref (task); } static gboolean -- cgit v1.1