summaryrefslogtreecommitdiffstats
path: root/lib/Transforms
diff options
context:
space:
mode:
authorKostya Serebryany <kcc@google.com>2013-02-11 14:36:01 +0000
committerKostya Serebryany <kcc@google.com>2013-02-11 14:36:01 +0000
commit117de489a0d5f4ff280fb173fe45bd5ce8514d93 (patch)
treedaa8f6c2be2b2c81e27db4e246dec936a37c8cdf /lib/Transforms
parent716d26b2ce310e852a78b25ec94db031378133bb (diff)
downloadexternal_llvm-117de489a0d5f4ff280fb173fe45bd5ce8514d93.zip
external_llvm-117de489a0d5f4ff280fb173fe45bd5ce8514d93.tar.gz
external_llvm-117de489a0d5f4ff280fb173fe45bd5ce8514d93.tar.bz2
[asan] added a flag -mllvm asan-short-64bit-mapping-offset=1 (0 by default)
This flag makes asan use a small (<2G) offset for 64-bit asan shadow mapping. On x86_64 this saves us a register, thus achieving ~2/3 of the zero-base-offset's benefits in both performance and code size. Thanks Jakub Jelinek for the idea. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@174886 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Transforms')
-rw-r--r--lib/Transforms/Instrumentation/AddressSanitizer.cpp10
1 files changed, 8 insertions, 2 deletions
diff --git a/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/lib/Transforms/Instrumentation/AddressSanitizer.cpp
index 0474eb5..c5f77ec 100644
--- a/lib/Transforms/Instrumentation/AddressSanitizer.cpp
+++ b/lib/Transforms/Instrumentation/AddressSanitizer.cpp
@@ -53,6 +53,7 @@ using namespace llvm;
static const uint64_t kDefaultShadowScale = 3;
static const uint64_t kDefaultShadowOffset32 = 1ULL << 29;
static const uint64_t kDefaultShadowOffset64 = 1ULL << 44;
+static const uint64_t kDefaultShort64bitShadowOffset = 0x7FFF8000; // < 2G.
static const uint64_t kPPC64_ShadowOffset64 = 1ULL << 41;
static const size_t kMaxStackMallocSize = 1 << 16; // 64K
@@ -133,6 +134,9 @@ static cl::opt<int> ClMappingScale("asan-mapping-scale",
cl::desc("scale of asan shadow mapping"), cl::Hidden, cl::init(0));
static cl::opt<int> ClMappingOffsetLog("asan-mapping-offset-log",
cl::desc("offset of asan shadow mapping"), cl::Hidden, cl::init(-1));
+static cl::opt<bool> ClShort64BitOffset("asan-short-64bit-mapping-offset",
+ cl::desc("Use short immediate constant as the mapping offset for 64bit"),
+ cl::Hidden, cl::init(false));
// Optimization flags. Not user visible, used mostly for testing
// and benchmarking the tool.
@@ -205,12 +209,14 @@ static ShadowMapping getShadowMapping(const Module &M, int LongSize,
// OR-ing shadow offset if more efficient (at least on x86),
// but on ppc64 we have to use add since the shadow offset is not neccesary
// 1/8-th of the address space.
- Mapping.OrShadowOffset = !IsPPC64;
+ Mapping.OrShadowOffset = !IsPPC64 && !ClShort64BitOffset;
Mapping.Offset = (IsAndroid || ZeroBaseShadow) ? 0 :
(LongSize == 32 ? kDefaultShadowOffset32 :
IsPPC64 ? kPPC64_ShadowOffset64 : kDefaultShadowOffset64);
- if (ClMappingOffsetLog >= 0) {
+ if (!ZeroBaseShadow && ClShort64BitOffset && LongSize == 64) {
+ Mapping.Offset = kDefaultShort64bitShadowOffset;
+ } if (!ZeroBaseShadow && ClMappingOffsetLog >= 0) {
// Zero offset log is the special case.
Mapping.Offset = (ClMappingOffsetLog == 0) ? 0 : 1ULL << ClMappingOffsetLog;
}