diff options
-rw-r--r-- | include/llvm/Analysis/ProfileInfoLoader.h | 2 | ||||
-rw-r--r-- | lib/Analysis/ProfileInfoLoader.cpp | 8 | ||||
-rw-r--r-- | lib/Analysis/ProfileInfoLoaderPass.cpp | 24 | ||||
-rw-r--r-- | lib/Transforms/Instrumentation/OptimalEdgeProfiling.cpp | 17 |
4 files changed, 33 insertions, 18 deletions
diff --git a/include/llvm/Analysis/ProfileInfoLoader.h b/include/llvm/Analysis/ProfileInfoLoader.h index e74ea3c..9e0c393 100644 --- a/include/llvm/Analysis/ProfileInfoLoader.h +++ b/include/llvm/Analysis/ProfileInfoLoader.h @@ -42,6 +42,8 @@ public: ProfileInfoLoader(const char *ToolName, const std::string &Filename, Module &M); + static const unsigned Uncounted; + unsigned getNumExecutions() const { return CommandLines.size(); } const std::string &getExecution(unsigned i) const { return CommandLines[i]; } diff --git a/lib/Analysis/ProfileInfoLoader.cpp b/lib/Analysis/ProfileInfoLoader.cpp index a6c55df..25481b2 100644 --- a/lib/Analysis/ProfileInfoLoader.cpp +++ b/lib/Analysis/ProfileInfoLoader.cpp @@ -34,8 +34,8 @@ static inline unsigned ByteSwap(unsigned Var, bool Really) { static unsigned AddCounts(unsigned A, unsigned B) { // If either value is undefined, use the other. - if (A == ~0U) return B; - if (B == ~0U) return A; + if (A == ProfileInfoLoader::Uncounted) return B; + if (B == ProfileInfoLoader::Uncounted) return A; return A + B; } @@ -64,7 +64,7 @@ static void ReadProfilingBlock(const char *ToolName, FILE *F, // Make sure we have enough space... The space is initialised to -1 to // facitiltate the loading of missing values for OptimalEdgeProfiling. if (Data.size() < NumEntries) - Data.resize(NumEntries, ~0U); + Data.resize(NumEntries, ProfileInfoLoader::Uncounted); // Accumulate the data we just read into the data. if (!ShouldByteSwap) { @@ -78,6 +78,8 @@ static void ReadProfilingBlock(const char *ToolName, FILE *F, } } +const unsigned ProfileInfoLoader::Uncounted = ~0U; + // ProfileInfoLoader ctor - Read the specified profiling data file, exiting the // program if the file is invalid or broken. // diff --git a/lib/Analysis/ProfileInfoLoaderPass.cpp b/lib/Analysis/ProfileInfoLoaderPass.cpp index 5f08612..89d90bc 100644 --- a/lib/Analysis/ProfileInfoLoaderPass.cpp +++ b/lib/Analysis/ProfileInfoLoaderPass.cpp @@ -160,8 +160,13 @@ void LoaderPass::readEdge(ProfileInfo::Edge e, std::vector<unsigned> &ECs) { if (ReadCount < ECs.size()) { double weight = ECs[ReadCount++]; - if (weight != ~0U) { - EdgeInformation[getFunction(e)][e] += weight; + if (weight != ProfileInfoLoader::Uncounted) { + // Here the data realm changes from the unsigned of the file to the + // double of the ProfileInfo. This conversion is save because we know + // that everything thats representable in unsinged is also representable + // in double. + EdgeInformation[getFunction(e)][e] += (double)weight; + DEBUG(errs() << "--Read Edge Counter for " << e << " (# "<< (ReadCount-1) << "): " << (unsigned)getEdgeWeight(e) << "\n"); @@ -185,9 +190,6 @@ bool LoaderPass::runOnModule(Module &M) { DEBUG(errs()<<"Working on "<<F->getNameStr()<<"\n"); readEdge(getEdge(0,&F->getEntryBlock()), Counters); for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) { - // Okay, we have to add a counter of each outgoing edge. If the - // outgoing edge is not critical don't split it, just insert the counter - // in the source or destination of the edge. TerminatorInst *TI = BB->getTerminator(); for (unsigned s = 0, e = TI->getNumSuccessors(); s != e; ++s) { readEdge(getEdge(BB,TI->getSuccessor(s)), Counters); @@ -258,7 +260,11 @@ bool LoaderPass::runOnModule(Module &M) { if (F->isDeclaration()) continue; for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) if (ReadCount < Counters.size()) - BlockInformation[F][BB] = Counters[ReadCount++]; + // Here the data realm changes from the unsigned of the file to the + // double of the ProfileInfo. This conversion is save because we know + // that everything thats representable in unsinged is also + // representable in double. + BlockInformation[F][BB] = (double)Counters[ReadCount++]; } if (ReadCount != Counters.size()) { errs() << "WARNING: profile information is inconsistent with " @@ -273,7 +279,11 @@ bool LoaderPass::runOnModule(Module &M) { for (Module::iterator F = M.begin(), E = M.end(); F != E; ++F) { if (F->isDeclaration()) continue; if (ReadCount < Counters.size()) - FunctionInformation[F] = Counters[ReadCount++]; + // Here the data realm changes from the unsigned of the file to the + // double of the ProfileInfo. This conversion is save because we know + // that everything thats representable in unsinged is also + // representable in double. + FunctionInformation[F] = (double)Counters[ReadCount++]; } if (ReadCount != Counters.size()) { errs() << "WARNING: profile information is inconsistent with " diff --git a/lib/Transforms/Instrumentation/OptimalEdgeProfiling.cpp b/lib/Transforms/Instrumentation/OptimalEdgeProfiling.cpp index cdaf5f1..b2e6747 100644 --- a/lib/Transforms/Instrumentation/OptimalEdgeProfiling.cpp +++ b/lib/Transforms/Instrumentation/OptimalEdgeProfiling.cpp @@ -18,6 +18,7 @@ #include "llvm/Pass.h" #include "llvm/Analysis/Passes.h" #include "llvm/Analysis/ProfileInfo.h" +#include "llvm/Analysis/ProfileInfoLoader.h" #include "llvm/Support/Compiler.h" #include "llvm/Support/raw_ostream.h" #include "llvm/Support/Debug.h" @@ -113,8 +114,8 @@ bool OptimalEdgeProfiler::runOnModule(Module &M) { NumEdgesInserted = 0; std::vector<Constant*> Initializer(NumEdges); - Constant* zeroc = ConstantInt::get(Int32, 0); - Constant* minusonec = ConstantInt::get(Int32, ProfileInfo::MissingValue); + Constant* Zero = ConstantInt::get(Int32, 0); + Constant* Uncounted = ConstantInt::get(Int32, ProfileInfoLoader::Uncounted); // Instrument all of the edges not in MST... unsigned i = 0; @@ -144,9 +145,9 @@ bool OptimalEdgeProfiler::runOnModule(Module &M) { if (!std::binary_search(MST.begin(), MST.end(), edge)) { printEdgeCounter(edge,entry,i); IncrementCounterInBlock(entry, i, Counters); NumEdgesInserted++; - Initializer[i++] = (zeroc); + Initializer[i++] = (Zero); } else{ - Initializer[i++] = (minusonec); + Initializer[i++] = (Uncounted); } // InsertedBlocks contains all blocks that were inserted for splitting an @@ -167,9 +168,9 @@ bool OptimalEdgeProfiler::runOnModule(Module &M) { if (!std::binary_search(MST.begin(), MST.end(), edge)) { printEdgeCounter(edge,BB,i); IncrementCounterInBlock(BB, i, Counters); NumEdgesInserted++; - Initializer[i++] = (zeroc); + Initializer[i++] = (Zero); } else{ - Initializer[i++] = (minusonec); + Initializer[i++] = (Uncounted); } } for (unsigned s = 0, e = TI->getNumSuccessors(); s != e; ++s) { @@ -195,9 +196,9 @@ bool OptimalEdgeProfiler::runOnModule(Module &M) { printEdgeCounter(edge,Succ,i); IncrementCounterInBlock(Succ, i, Counters); NumEdgesInserted++; } - Initializer[i++] = (zeroc); + Initializer[i++] = (Zero); } else { - Initializer[i++] = (minusonec); + Initializer[i++] = (Uncounted); } } } |