From 5a364c5561ec04e33a6f5d52c14f1bac6f247ea0 Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Fri, 15 Nov 2013 22:34:48 +0000 Subject: [weak vtables] Remove a bunch of weak vtables This patch removes most of the trivial cases of weak vtables by pinning them to a single object file. Differential Revision: http://llvm-reviews.chandlerc.com/D2068 Reviewed by Andy git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@194865 91177308-0d34-0410-b5e6-96231b3b80d8 --- unittests/ADT/IntrusiveRefCntPtrTest.cpp | 4 +++- unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp | 18 ++++++++++-------- .../ExecutionEngine/MCJIT/MCJITMultipleModuleTest.cpp | 8 +++++++- unittests/ExecutionEngine/MCJIT/MCJITTest.cpp | 8 +++++--- 4 files changed, 25 insertions(+), 13 deletions(-) (limited to 'unittests') diff --git a/unittests/ADT/IntrusiveRefCntPtrTest.cpp b/unittests/ADT/IntrusiveRefCntPtrTest.cpp index 0c8c4ca..2be5aaf 100644 --- a/unittests/ADT/IntrusiveRefCntPtrTest.cpp +++ b/unittests/ADT/IntrusiveRefCntPtrTest.cpp @@ -13,9 +13,11 @@ namespace llvm { struct VirtualRefCounted : public RefCountedBaseVPTR { - virtual void f() {} + virtual void f(); }; +void VirtualRefCounted::f() {} + // Run this test with valgrind to detect memory leaks. TEST(IntrusiveRefCntPtr, RefCountedBaseVPTRCopyDoesNotLeak) { VirtualRefCounted *V1 = new VirtualRefCounted; diff --git a/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp b/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp index e4197dd..e77fd36 100644 --- a/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp +++ b/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp @@ -83,14 +83,8 @@ protected: UnsupportedOSs.push_back(Triple::Cygwin); } - virtual void SetUp() { - didCallAllocateCodeSection = false; - Module = 0; - Function = 0; - Engine = 0; - Error = 0; - } - + virtual void SetUp(); + virtual void TearDown() { if (Engine) LLVMDisposeExecutionEngine(Engine); @@ -157,6 +151,14 @@ protected: char *Error; }; +void MCJITCAPITest::SetUp() { + didCallAllocateCodeSection = false; + Module = 0; + Function = 0; + Engine = 0; + Error = 0; +} + TEST_F(MCJITCAPITest, simple_function) { SKIP_UNSUPPORTED_PLATFORM; diff --git a/unittests/ExecutionEngine/MCJIT/MCJITMultipleModuleTest.cpp b/unittests/ExecutionEngine/MCJIT/MCJITMultipleModuleTest.cpp index 4d650e8..b01a854 100644 --- a/unittests/ExecutionEngine/MCJIT/MCJITMultipleModuleTest.cpp +++ b/unittests/ExecutionEngine/MCJIT/MCJITMultipleModuleTest.cpp @@ -18,7 +18,13 @@ using namespace llvm; -class MCJITMultipleModuleTest : public testing::Test, public MCJITTestBase {}; +class MCJITMultipleModuleTest : public testing::Test, + public MCJITTestBase { +public: + virtual ~MCJITMultipleModuleTest(); +}; + +MCJITMultipleModuleTest::~MCJITMultipleModuleTest() {} namespace { diff --git a/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp b/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp index 7ccd254..3a86eb5 100644 --- a/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp +++ b/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp @@ -21,11 +21,13 @@ using namespace llvm; class MCJITTest : public testing::Test, public MCJITTestBase { protected: - virtual void SetUp() { - M.reset(createEmptyModule("
")); - } + virtual void SetUp(); }; +void MCJITTest::SetUp() { + M.reset(createEmptyModule("
")); +} + namespace { // FIXME: Ensure creating an execution engine does not crash when constructed -- cgit v1.1