summaryrefslogtreecommitdiffstats
path: root/src/mesa/drivers/dri/radeon/radeon_common_context.c
diff options
context:
space:
mode:
authorEric Anholt <eric@anholt.net>2011-11-02 14:38:05 -0700
committerEric Anholt <eric@anholt.net>2011-11-03 09:13:46 -0700
commit9954a93ab77e64b01b95837f90a567df9e8c94df (patch)
tree5351930aa2d064abd1783a866367fb598a433ac6 /src/mesa/drivers/dri/radeon/radeon_common_context.c
parentca0f515f851f04a3849ac049868825e94382681d (diff)
downloadexternal_mesa3d-9954a93ab77e64b01b95837f90a567df9e8c94df.zip
external_mesa3d-9954a93ab77e64b01b95837f90a567df9e8c94df.tar.gz
external_mesa3d-9954a93ab77e64b01b95837f90a567df9e8c94df.tar.bz2
radeon: Check an error return instead of assigning it to a dead variable.
Fixes gcc set-but-unused-variable warning. Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Diffstat (limited to 'src/mesa/drivers/dri/radeon/radeon_common_context.c')
-rw-r--r--src/mesa/drivers/dri/radeon/radeon_common_context.c18
1 files changed, 13 insertions, 5 deletions
diff --git a/src/mesa/drivers/dri/radeon/radeon_common_context.c b/src/mesa/drivers/dri/radeon/radeon_common_context.c
index 2694daf..e6c7f94 100644
--- a/src/mesa/drivers/dri/radeon/radeon_common_context.c
+++ b/src/mesa/drivers/dri/radeon/radeon_common_context.c
@@ -551,11 +551,19 @@ radeon_update_renderbuffers(__DRIcontext *context, __DRIdrawable *drawable,
}
ret = radeon_bo_get_tiling(bo, &tiling_flags, &pitch);
- if (tiling_flags & RADEON_TILING_MACRO)
- bo->flags |= RADEON_BO_FLAGS_MACRO_TILE;
- if (tiling_flags & RADEON_TILING_MICRO)
- bo->flags |= RADEON_BO_FLAGS_MICRO_TILE;
-
+ if (ret) {
+ fprintf(stderr,
+ "failed to get tiling for %s %d\n",
+ regname, buffers[i].name);
+ radeon_bo_unref(bo);
+ bo = NULL;
+ continue;
+ } else {
+ if (tiling_flags & RADEON_TILING_MACRO)
+ bo->flags |= RADEON_BO_FLAGS_MACRO_TILE;
+ if (tiling_flags & RADEON_TILING_MICRO)
+ bo->flags |= RADEON_BO_FLAGS_MICRO_TILE;
+ }
}
if (buffers[i].attachment == __DRI_BUFFER_DEPTH) {