diff options
| author | Frédéric Boisnard <fredericx.boisnard@intel.com> | 2013-08-06 19:23:46 +0200 |
|---|---|---|
| committer | David Wagner <david.wagner@intel.com> | 2014-02-12 17:04:05 +0100 |
| commit | 11e31aedd3af9e95a860cfc1525badd4ffd7b56f (patch) | |
| tree | 3aace1005e1816aff829031c43fad319c4034a4e | |
| parent | 487ce850cc5f884f7689a2bfd55a7e1cf6eb3053 (diff) | |
| download | external_parameter-framework-11e31aedd3af9e95a860cfc1525badd4ffd7b56f.zip external_parameter-framework-11e31aedd3af9e95a860cfc1525badd4ffd7b56f.tar.gz external_parameter-framework-11e31aedd3af9e95a860cfc1525badd4ffd7b56f.tar.bz2 | |
PFW: Update CFLAGS to add Wall, Werror, Wextra everywhere
BZ: 129048
Some Makefiles of the PFW projects are missing the regular CFLAGS
-Wall, -Werror and -Wextra.
This patch aims to update the CLFAGS of these Makefiles. Some source
code had to be updated because warnings are now considered as errors.
Change-Id: Icc91f7bdc649118f822411d9b4693776a84037e9
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
Reviewed-on: http://android.intel.com:8080/123977
Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com>
Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com>
Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com>
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
| -rw-r--r-- | parameter/Android.mk | 10 | ||||
| -rw-r--r-- | remote-process/Android.mk | 9 | ||||
| -rw-r--r-- | remote-processor/Android.mk | 10 | ||||
| -rw-r--r-- | utility/Android.mk | 10 | ||||
| -rw-r--r-- | xmlserializer/Android.mk | 10 |
5 files changed, 49 insertions, 0 deletions
diff --git a/parameter/Android.mk b/parameter/Android.mk index c356c4d..e6e9891 100644 --- a/parameter/Android.mk +++ b/parameter/Android.mk @@ -101,6 +101,12 @@ common_src_files := \ common_module := libparameter common_module_tags := optional +common_cflags := \ + -Wall \ + -Werror \ + -Wextra \ + -Wno-unused-parameter + common_c_includes := \ $(LOCAL_PATH)/include/ \ $(LOCAL_PATH)/../utility/ \ @@ -119,6 +125,8 @@ LOCAL_COPY_HEADERS := $(common_copy_headers) LOCAL_MODULE_PATH := $(TARGET_OUT_SHARED_LIBRARIES) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module) @@ -142,6 +150,8 @@ include $(CLEAR_VARS) LOCAL_COPY_HEADERS_TO := $(common_copy_headers_to) LOCAL_COPY_HEADERS := $(common_copy_headers) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module)_host diff --git a/remote-process/Android.mk b/remote-process/Android.mk index cc842f2..7cf3ba7 100644 --- a/remote-process/Android.mk +++ b/remote-process/Android.mk @@ -9,6 +9,11 @@ common_src_files := \ common_module := remote-process common_module_tags := optional +common_cflags := \ + -Wall \ + -Werror \ + -Wextra \ + -Wno-unused-parameter common_c_includes := \ $(LOCAL_PATH)/../remote-processor/ @@ -25,6 +30,8 @@ LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module) LOCAL_MODULE_TAGS := $(common_module_tags) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_C_INCLUDES += \ $(common_c_includes) \ $(call include-path-for, stlport) \ @@ -45,6 +52,8 @@ LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module)_host LOCAL_MODULE_TAGS := $(common_module_tags) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_C_INCLUDES += \ $(common_c_includes) diff --git a/remote-processor/Android.mk b/remote-processor/Android.mk index d82d548..8facae7 100644 --- a/remote-processor/Android.mk +++ b/remote-processor/Android.mk @@ -16,6 +16,12 @@ common_src_files := \ common_module := libremote-processor common_module_tags := optional +common_cflags := \ + -Wall \ + -Werror \ + -Wextra \ + -Wno-unused-parameter + common_ldlibs := -lpthread ############################# # Target build @@ -27,6 +33,8 @@ LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module) LOCAL_MODULE_TAGS := $(common_module_tags) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_C_INCLUDES += \ $(call include-path-for, stlport) \ bionic/ @@ -44,6 +52,8 @@ include $(CLEAR_VARS) LOCAL_SRC_FILES := $(common_src_files) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_MODULE := $(common_module)_host LOCAL_MODULE_TAGS := $(common_module_tags) diff --git a/utility/Android.mk b/utility/Android.mk index a87df1c..5249a30 100644 --- a/utility/Android.mk +++ b/utility/Android.mk @@ -10,6 +10,12 @@ common_src_files := \ common_module := libutility common_module_tags := optional +common_cflags := \ + -Wall \ + -Werror \ + -Wextra \ + -Wno-unused-parameter + ############################# # Target build @@ -20,6 +26,8 @@ LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module) LOCAL_MODULE_TAGS := $(common_module_tags) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_C_INCLUDES += \ $(call include-path-for, stlport) \ bionic @@ -36,4 +44,6 @@ LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module)_host LOCAL_MODULE_TAGS := $(common_module_tags) +LOCAL_CFLAGS := $(common_cflags) + include $(BUILD_HOST_STATIC_LIBRARY) diff --git a/xmlserializer/Android.mk b/xmlserializer/Android.mk index 799bf1c..7fdaf71 100644 --- a/xmlserializer/Android.mk +++ b/xmlserializer/Android.mk @@ -19,6 +19,12 @@ common_module := libxmlserializer common_module_tags := optional +# Do not use the '-Werror' flag because of a compilation issue in libxml +common_cflags := \ + -Wall \ + -Wextra \ + -Wno-unused-parameter + common_c_includes := \ $(call include-path-for, libxml2) \ $(call include-path-for, webcore-icu) \ @@ -38,6 +44,8 @@ LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module) LOCAL_MODULE_TAGS := $(common_module_tags) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_C_INCLUDES += \ $(common_c_includes) \ $(call include-path-for, stlport) \ @@ -60,6 +68,8 @@ LOCAL_SRC_FILES := $(common_src_files) LOCAL_MODULE := $(common_module)_host LOCAL_MODULE_TAGS := $(common_module_tags) +LOCAL_CFLAGS := $(common_cflags) + LOCAL_C_INCLUDES += \ $(common_c_includes) |