Change blackboard write/readString prototype

Those functions are used in one place and let the caller transform a
std::string to a char * which makes the use of alloca necessary.
Moreover, the readString cannot know if the pointer given in input
points to a buffer with enough space, making it dangerous.

This patch reworks the API so that write/readString() get std::string
and lets the implementation play with char *. This also allows to get
rid of alloca() use which is quite dangerous.

Change-Id: I973e4987278289bb914c4e194b86e924a1c88a6d
Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/parameter/ParameterBlackboard.cpp b/parameter/ParameterBlackboard.cpp
index 3af9a1d..6001c77 100644
--- a/parameter/ParameterBlackboard.cpp
+++ b/parameter/ParameterBlackboard.cpp
@@ -99,14 +99,14 @@ void CParameterBlackboard::readInteger(void* pvDstData, uint32_t uiSize, uint32_
     }
 }
 
-void CParameterBlackboard::writeString(const char* pcSrcData, uint32_t uiOffset)
+void CParameterBlackboard::writeString(const std::string &input, uint32_t uiOffset)
 {
-    strcpy((char*)_pucData + uiOffset, pcSrcData);
+    strcpy((char*)_pucData + uiOffset, input.c_str());
 }
 
-void CParameterBlackboard::readString(char* pcDstData, uint32_t uiOffset) const
+void CParameterBlackboard::readString(std::string &output, uint32_t uiOffset) const
 {
-    strcpy(pcDstData, (const char*)_pucData + uiOffset);
+    output = std::string((const char*)_pucData + uiOffset);
 }
 
 // Access from/to subsystems